🇳🇱Netherlands @timohuisman

Somehow my colleague @adebruin couldn't create a MR, so I made one with the patch from #2

timohuisman → made their first commit to this issue’s fork.

I'm not sure why, but I get a 404 when I try to create a new branch for this issue.

Anyhow, Quickedit is no longer in core, see [#3259831]. So we could just use the existing view mode instead of overwriting it.

I've checked MR !23 against drupal/core 11 and drupal/views_infinite_scroll 2.0.2, found no errors. Back to RTBC.

timohuisman → changed the visibility of the branch 3412444-make-cacheablemetadataapplyto-merge to hidden.

It sounds like we can reopen this issue as a feature request? The patch in #5 contains the suggested merge. I think the merge would be the most logical solution, because the name applyTo doesn't suggest that it overwrites the existing data.

bbrala → credited timohuisman → .

https://github.com/palantirnet/drupal-rector/pull/304

timohuisman → created an issue.

Thanks for the patch. Can confirm that it works with paragraphs 1.16 with core 10.2.

Sounds good +1

Can confirm that #7 works.

timohuisman → made their first commit to this issue’s fork.

timohuisman → created an issue.

https://github.com/palantirnet/drupal-rector/pull/290

timohuisman → created an issue.

https://github.com/palantirnet/drupal-rector/pull/289

timohuisman → created an issue.

I've applied the suggested changes from #3 in https://github.com/palantirnet/drupal-rector/pull/287.

Resolved the feedback on the MR

See https://github.com/palantirnet/drupal-rector/pull/286

timohuisman → created an issue.

Thanks! Commited and tagged a new release.

timohuisman → created an issue.

The MR failure seems not to be related to this changes, but a mis-configuration in the Gitlab CI file, not sure though.

The patch is working fine against the 8.x-1.4.

Seems related to 🐛 CKEditor 5 toolbar items of multi-value field (typically Paragraphs) overflowing on narrow viewports and overlapping with node form's sidebar on wide viewports Active

We need this option as well. This patch provides a additional setting at the comment item form so you can enable the reply-link without enabling the threaded messages.

I think that the tests needs to be updated, but I'm not yet familiar with that proces. And the new setting is overruled by the default_mode setting, that should maybe be indicated in the ui?

Thanks for your contribution! I'll tag a release somewhere in the coming days.

Thanks!

I'm not sure that I understand the problem, is the issue summary up-to-date? I've just tested the url /paragraphs_edit/node/{{ nid }}/paragraphs/{{ id }}/delete and I was able to delete a existing paragraph. Could you provide more detailed steps to reproduce this issue?

I've committed the changes from #10, thanks for your contribution. I'll tag a release somewhere in the coming days.

As for #11, it seems related to the rules module? Could you open a new issue if you still face this issue?

Thanks for your contribution! I'll tag a release somewhere in the coming days.

I've rerolled that patch from #15 against the 1.0.0-alpha2 tag. The changes from 📌 Configure GitLab CI Fixed are not yet tagged, thats why the generated patch from MR11 doesn't apply.

Thanks for your contribution, sorry for the delay.

Thanks for contributing. I've committed the patch from #9. I've closed MR1 because it didn't contain any changes. I've also closed MR2, because it pulled changes from 2.0.x-dev into 8.x-1.x-dev.

Can confirm that this resolved the issue on Drupal 10.1.5.

Please ignore this patch, we're unfortunately still using the 8.x-1-x version. This patch adds partially support for Drupal 10.

This is a patch with the current state of the MR. Merge request urls are considered dangerous in combination with composer-patches, see https://github.com/cweagans/composer-patches/issues/347.

Indeed, not sure how I missed this by 3288114 yesterday

+1 RTBC. I've also replied in the #d10-readiness slack channel.

This is a patch against 6.x which simply checks if the quiz_result_feedback paragraph is available.

timohuisman → created an issue.

Re-roll #116 against 10.1.x and 11.x. The custom commands failure from #116 should have been fixed.

This time with a valid patch file extension...

This patch represents the current state of MR created in #170. We prefer patch files as long as the merge request urls are considered dangerous, see https://github.com/cweagans/composer-patches/issues/347.

Rerolled #2 and opened an MR. Added a patch for the current state of the MR, see https://github.com/cweagans/composer-patches/issues/347 for more information.

timohuisman → made their first commit to this issue’s fork.

Updated the MR with the latest changes from 6.x. Added a patch for the current state of the MR, see https://github.com/cweagans/composer-patches/issues/347 for more information.

I have manually tested MR #4 with drupal/core 10.1.2, everything seems to work fine. The patch applies, there are now errors when you switch the editor from ckeditor to ckeditor5 and I can still upload files after switching.

This issue appears to have been thoroughly tested and according to the comments on MR #4, any remaining feedback is being applied. I think we can now mark this as "RTBC".

Attached is a patch file with the current status of MR #4. We prefer patch files in our projects because we use composer patches and drupal.org merge request URLs are considered dangerous; see https://github.com/cweagans/composer-patches/issues/347.

Indeed, we need this as well.

This patch contains the current state of the merge request. See "Patches from drupal.org merge request URLs are dangerous?" for more information.

This patch contains the current state of the merge request. See "Patches from drupal.org merge request URLs are dangerous?" for more information.

The patch from #83 fails against 10.1.x and 11.x.

This should resolve the PHPCS errors from #124. The reroll is based on #94 against 9.5.x.

Indeed, I asked for it through Slack. It would be nice if we could have a new release, because the work for Drupal 10 has been done.

I've moved the issue to the Drupal.org project ownership queue, as #7 suggested.

This will probably fix the errors from #18. The patch is still a reroll from #16 against 8.x-1.0.

Rerolled #16 against 8.x-1.0. The latest release had a lot of changes, so I hope everything went well.

This is a duplicated of 📌 Automated Drupal Rector fixes RTBC , since that issue has a patch, I think it's better to close this one.

We've been using the patch from #9 for more than one year in production, everything is working fine in Drupal 9. It would be nice if this module could have a new release for D9, so that we can work on D10.

I've rerolled #26 against 10.1.x. The patch should also apply against 9.5.x.

However, I noticed that in the meantime #3284983: Views FilterPluginBase::groupForm double translates group item label strings → was created and committed. I think that the problem in this issue is now irrelevant, but because I had already rerolled the patch, I still chose to post it.