- 🇸🇪Sweden kevineinarsson
Rerolled #10 to apply cleanly to dev for people using this patch via Composer.
- Status changed to Needs review
over 1 year ago 4:24pm 14 March 2023 - Status changed to RTBC
9 months ago 9:45am 15 February 2024 +1 RTBC. I've been using patch #17 on a site successfully since March 2021.
- last update
9 months ago 4 pass - last update
9 months ago 4 pass - Status changed to Postponed: needs info
3 days ago 7:20pm 19 November 2024 - 🇫🇷France dqd London | N.Y.C | Paris | Hamburg | Berlin
This will have less chance to be committed until #16 💬 The Cropper library referenced in the README and in the libraries info is deprecated Needs work has been adressed or at least commented on. jQuery is partly moved out of core and should not mandatory if not required. Also please review if this issus is able to incooperate into the already committed issue with composer.libarary.json added.
I agree with #16. Now that Core is working to remove its dependencies on jQuery, that same sentiment should extend to contrib.
Is this the issue you're referring to?
✨ Create composer.libraries.json Active
The added library is still pointing to https://github.com/fengyuanchen/cropper, which isn't maintained anymore.
- 🇫🇷France dqd London | N.Y.C | Paris | Hamburg | Berlin
Thanks for coming back on this +1 - If we agree on #16 than this issue is not RTBC and needs work. It still points to https://github.com/fengyuanchen/jquery-cropper instead of https://github.com/fengyuanchen/cropperjs but the IS clearly states:
Instead let's upgrade to use just https://github.com/fengyuanchen/cropperjs in the first place. Not the jQuery wrapper, just Cropper.js.
Also we need to take the new composer file into account here now. Patch #17 needs reroll and jQuery needs to be removed. Also the README needs to be updated regarding library installation.