- Issue created by @abhinesh
- last update
over 1 year ago 4 pass - Status changed to RTBC
over 1 year ago 12:43pm 12 November 2023 - 🇫🇷France bakop Lille
Hello, tested on Drupal 10.2.0 and it works perfectly. RTBC+1
- 🇫🇷France dqd London | N.Y.C | Paris | Hamburg | Berlin
Thanks for all the efforts in here.
-
dqd →
committed b31cae33 on 8.x-2.x authored by
abhinesh →
Issue #3400111 by abhinesh: Add composer.libraries.json for fengyuanchen...
-
dqd →
committed b31cae33 on 8.x-2.x authored by
abhinesh →
- 🇨ðŸ‡Switzerland berdir Switzerland
The merge plugin is discouraged and should not be used, I don't think this should be included.
- 🇫🇷France dqd London | N.Y.C | Paris | Hamburg | Berlin
Major Follow up to update library: 💬 The Cropper library referenced in the README and in the libraries info is deprecated Needs work
Please join there to help so that this issue here incooperates nicely with the updated library version.
- 🇫🇷France dqd London | N.Y.C | Paris | Hamburg | Berlin
@berdir sorry that I missed your comment previously. That was work done on the road with a laptop on my lap as a co-driver front seat in the car at night with the display light dimmed. From my understanding the merge plugin issue is ✨ Support Composer merge for libraries Postponed: needs info ... this issue here is for adding composer library json file, which - at least what I thought - works without the merge plugin, no?
- 🇨ðŸ‡Switzerland berdir Switzerland
composer.libraries.yml is not a standard, it doesn't do anything on its own, only if you merge it into your main composer.json with the merge plugin. The only other thing is documentation, but then you'd need to explain what to do with it.
In dropzonejs, I removed composer merge plugin instructions from the README and instead just included explanations of what to put into composer.json: https://git.drupalcode.org/project/dropzonejs/-/blob/8.x-2.x/README.md?r..., https://git.drupalcode.org/project/dropzonejs/-/commit/164a0ce454db9bac9....
- 🇫🇷France dqd London | N.Y.C | Paris | Hamburg | Berlin
Hm, that makes sense! +1 and million thanks for coming back on this. I will start a new issue following dropzonejs on this. Seems the most reasonable road map for this scenario.
- 🇫🇷France dqd London | N.Y.C | Paris | Hamburg | Berlin
Follow up: 📌 The merge plugin is discouraged and should not be used Active
Automatically closed - issue fixed for 2 weeks with no activity.