🇫🇷France @bakop

RTBC + 1 -> Working on Drupal 10.3.1

bakop → changed the visibility of the branch filter-tooltips-3464033 to hidden.

bakop → created an issue.

bakop → created an issue.

Here is the patch to fix the phpcs error. I updated the merge request !

Fix placed in a merge request.
Everything looks good !

bakop → changed the visibility of the branch 3229922-cannot-be-uninstalled-d10-patch to hidden.

bakop → made their first commit to this issue’s fork.

I made the requested changes, you can review the MR.

Sorry, i didn't check the merge request.

Why you change the status ? Le problème est résolu et le README n'a rien à voir avec les erreurs de tests
If you have nothing to said about the code, can you pass the issue in need of revision or review by the community?
Thanks in advance

Issue with test dependencies seems to be resolved in https://www.drupal.org/project/field_states_ui/issues/3416385#comment-15... 🐛 YoutubeFieldTest::testYoutubeField Undefined array key "youtube" Active

Issue with test dependencies seems to be resolved in https://www.drupal.org/project/field_states_ui/issues/3416385#comment-15... 🐛 YoutubeFieldTest::testYoutubeField Undefined array key "youtube" Active

Add the composer.json solved this issue. You can review the MR!7

Hi, i will try to add the composer.json. The key is to know if the ci gonna take in count the file. If it's not the case, the maintainer will have to do a modification.

Here is the result after applying the patch.

bakop → created an issue.

Hello, you are both right. I modified and tested the code on versions 10.1.7 and 10.2.1

Hi, tested on Drupal 10.2.1 ! RTBC +1

Hello, tested on Drupal 10.2.0 and it works perfectly. RTBC+1

Patch sent as merge request (MR!9) !
It works only for version >=10.2.0 so a new release should be published.

bakop → changed the visibility of the branch 3410535-the-visual-of to active.

bakop → changed the visibility of the branch 3410535-the-visual-of to hidden.

bakop → created an issue.

Same here, the patch #7 resolved the issue for me.
I'm on a Drupal 10.1.6

Hi, there is indeed an issue with the version of the sdk to install the module on Drupal 10.
I did an email sending test (see attachment).

RTBC +1

Hello, the patch is not working correctly. The class is added but the class called in the code does not exist.

I can't modify the line in question because it no longer respects the 80 character rule.
I rebased the branch and removed the added class comment

Hi, i'm working on it !

There is a phpcs error on the constructor line. I did the modification.
@apaderno why do we need to change the class name and add the namespace into it ? Actually we have "Plugin implementation of the 'image_style_formatter' formatter." with the "FieldFormatter" annotation.

Errors reported by javascript tests seem related to a dependency problem like the Youtube module. This is not due to the fix, as i encounter the same problem without making any modifications. If anyone has an idea to fix this, please let me know.

bakop → created an issue.

Hi, have you cleared the site cache?

Hi ,I'm closing this ticket because the issue doesn't come from the module.

MR !26 updated to remove the duplicated foreach.

Hi, the patch still works but a duplicate foreach slipped in.

bakop → created an issue.

bakop → created an issue.

Finally, there seems to be an issue with loading test dependencies, such as the YouTube module for instance. This is not due to the fix, as I encounter the same problem without making any modifications. If anyone has an idea to fix this, please let me know.

This visually solves the issue, but it breaks the tests. I'll look into modifying my stack to accommodate JavaScript functional tests and see how to address this more properly.

bakop → created an issue.

Patch sent as MR (MR !6).

Hi, the patch is not applicable on my side, there is an error on composer.
I'm working on new version of this patch.

Patch sent as merge request.

Hi, maybe we need to replace the \Drupal::service('file_url_generator') service with dependency injection. Since it's already loaded in ImageFormatter, you might as well use it directly.

I push to fast. A little issue with my patch, i will fix it.

Hi, there has been no activity for a while, I take the liberty of modifying the original patch to update it. I didn't have time to set up the tests.

Patch done.

bakop → created an issue.

Hi, I still have the same error. Patch #3 does not check if the key exists.

Hi, I see that there is still the same problem. Patch #3 does not check if the key exists.

Hi, tested patch #17 on a Drupal 9.5.9 and it works.
RTBC +1

Hi, sorry that was me :) I forgot to change the status.

Looks like you've already fixed this problem. Please change the status if you are finished.

Patch sent as a merge request on the repository.

bakop → created an issue.

Hi, i got exactly the same errors and the Patch #4 works for me (Drupal 9).
RTBC + 1