- Issue created by @catapipper
- Assigned to bakop
- Issue was unassigned.
- 🇫🇷France bakop Lille
Looks like you've already fixed this problem. Please change the status if you are finished.
- Status changed to Needs review
over 1 year ago 2:40pm 20 April 2023 - Status changed to Active
over 1 year ago 5:43pm 18 May 2023 - 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
Status "Needs review" is for when there is a patch. A patch is still needed.
- last update
over 1 year ago Composer require failure - @damienmckenna opened merge request.
- Status changed to Needs review
over 1 year ago 5:51pm 18 May 2023 - 🇺🇸United States DamienMcKenna NH, USA
The step you forgot was to turn the issue fork into a merge request by clicking the "Open merge request" button.
- last update
over 1 year ago Composer require failure - 🇺🇸United States DamienMcKenna NH, USA
I don't think the change is correct:
- "drupal/captcha": "1.x-dev", + "drupal/captcha": "^1.0 || ^2.0.x-beta",
In order to use a beta version of a dependency you need to use the "@beta" suffix on the version string, and it needs to be tied to a release version, rather than a branch name. As such, it should be something more like this:
- "drupal/captcha": "1.x-dev", + "drupal/captcha": "^1.0 || ^2.0@beta",
Strictly speaking, it might even work without the @beta part:
- "drupal/captcha": "1.x-dev", + "drupal/captcha": "^1.0 || ^2.0",
Please try that, see if it works.
- last update
over 1 year ago Composer require failure - Status changed to Needs work
over 1 year ago 5:55pm 18 May 2023 - 🇺🇸United States DamienMcKenna NH, USA
Changing this to a "task" as it isn't really a "bug report".
- last update
over 1 year ago 533 pass - Status changed to Needs review
over 1 year ago 5:57pm 18 May 2023 - last update
over 1 year ago Composer require-dev failure - last update
over 1 year ago 533 pass - last update
over 1 year ago Composer require-dev failure - 🇺🇸United States DamienMcKenna NH, USA
Oh heck - Lingotek! The D10 issue is going to take some work: https://www.drupal.org/project/lingotek/issues/3288313 📌 Automated Drupal 10 compatibility fixes Fixed
It might be worth just running the tests against D9, for now, to at least make sure the syntax is correct and there aren't regressions?
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
Maybe this issue should focus on getting it to build, that is, fixing any require-related issues, even if it is still broken for other reasons.
- last update
over 1 year ago Composer require-dev failure - 🇺🇸United States DamienMcKenna NH, USA
Is that an agreement with my comment, or a different topic? Lingotek won't work as a test dependency for D10 for a while because its D10 compatibility fixes have a long way to go.
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
Your suggestion in #11 is a good one. I was suggesting that instead we could use this issue to get all the
require-dev
dependencies compatible with Drupal 10 so that at least it builds, even if the tests don't pass yet on Drupal 10. - 🇺🇸United States DamienMcKenna NH, USA
In that case we'll have to remove lingotek.
- last update
over 1 year ago 533 pass - last update
over 1 year ago Composer require-dev failure - last update
over 1 year ago 533 pass - last update
over 1 year ago 533 pass - last update
over 1 year ago 486 pass, 74 fail - last update
over 1 year ago 533 pass - last update
over 1 year ago 533 pass DamienMcKenna, thanks for pointing that out I'm still getting used to using the new tools instead of just adding patches. Glad work is progressing.
- First commit to issue fork.
- last update
over 1 year ago 533 pass -
jrockowitz →
committed e4a18f97 on 6.2.x authored by
DamienMcKenna →
Issue #3354719 by Liam Morland, catapipper: Update require-dev for...
-
jrockowitz →
committed e4a18f97 on 6.2.x authored by
DamienMcKenna →
- Status changed to Fixed
over 1 year ago 11:45am 25 May 2023 Automatically closed - issue fixed for 2 weeks with no activity.