🇺🇸United States @jrockowitz

The select_or_other.module is not working as expected.

jrockowitz → created an issue.

That makes sense because you can't nest a form within a form. You have to take a different approach, like opening the form in a modal dialog.

jrockowitz → created an issue.

jrockowitz → created an issue.

jrockowitz → changed the visibility of the branch 3460229-require-additional-type to active.

jrockowitz → changed the visibility of the branch 3460229-require-additional-type to hidden.

jrockowitz → created an issue.

jrockowitz → created an issue.

What is the reason for disabling the phone number validation? Is it not working as expected?

I am hesitant to add more features. A simpler approach would be to refactor the JavaScript so that you can override the validate method and even disable it via some custom JavaScript

The attached patch is a minor refactor which allows you to redefine the below function.

Drupal.webformTelephoneValidate = function ($telephone) {
  // Skip validation.
  return true;
}

jrockowitz → made their first commit to this issue’s fork.

Drupal core puts the prefix before the description in the form-element.html.twig.

https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/syste...
https://git.drupalcode.org/project/drupal/-/blob/11.x/core/themes/claro/...

I don't think Webform should override this decision. I am not seeing any issue similar issue reported via Drupal core.

I suspect there is a sequencing issue when the form builder/manager is reloaded via Ajax.

jrockowitz → created an issue.

I don't have time to start recording videos while the module is still in alpha releases. I am very open to improving the README.md files for each sub-module. We could add a 'Use case' for each module.

For example, the use case for the schemadotorg_entity_reference_override.module is to

Allow entity reference fields that relate a https://schema.org/Person to an https://schema.org/Organization to include a https://schema.org/Role with the entity reference using the Entity Reference _Override module.

A considerable contribution would be to define the use case for each sub-module.

The Schema.org JSON API module needs to be enabled before Schema.org content types are created.

You can delete and recreate your Schema.org mapping, which will trigger the creation of the JSON:API endpoints.

As note in the README.md features, it 'allows dedicated 'Role' fields to be created for a Schema.org type.'
https://git.drupalcode.org/project/schemadotorg/-/tree/1.0.x/modules/sch...

Right now, it is only configured for Podcasts.

The module may be deprecated and replaced with the schemadotorg_entity_reference_override.module which allows a Role value to be added to an entity reference.

@abhiyanshu That is a great explanation of the use case for the schemadotorg_inline_entity_form.module and the common use case for most sub-module.

@fishfree Feel free to suggest improvements to the README.md files.

Adding custom #states to a composite must be done using code.

@see https://git.drupalcode.org/project/webform/-/blob/6.2.x/modules/webform_...

The individual element titles in a data list are invisible via Drupal Core.

https://git.drupalcode.org/project/drupal/-/blob/11.x/core/lib/Drupal/Co...

Computed twig elements have performance limitations via Ajax. Any additional support should be handled via custom code or dedicated contributed module.

jrockowitz → made their first commit to this issue’s fork.

I don't think we should change this default expected behavior, but it can be changed using custom code.

We might want to tag one more stable release and then only support 10.2.x

Any additional features should be handled via custom code or a dedicated contributed module.

jrockowitz → created an issue.

Marking fixed to ensure people get commit credit but we cant make this change until we are only supporting Drupal 10.2.x

For #18, I do not see any reasonable fix because the submit callback is being triggered via a click event, which doesn't trigger validation.

@see https://git.drupalcode.org/project/webform/-/blob/6.2.x/src/Form/Webform...

The best workaround is to use https://www.drupal.org/project/clientside_validation →

Your code is nesting a webform inside a form, and it won't work as expected.

If you place the webform via a controller, it will work as expected.

All new features should be handled via custom code or a dedicated contributed module.

I am using "Drupal 10.2, Symfony mailer with SMPT" without any problems. Please update to the latest version of Symfony mailer and check you settings to make sure it is configured correctly.

The problem is that the http:// protocol included in the file URL in the email is causing our email security application to flag the emails as insecure and sometimes block them.

You need to ensure the file URL is secure via https.

Please reopen this ticket when you can provide more information

The issue seems to be related to 'element.allowed_tags' is missing from 'webform.settings'.

Please run `drush webform-repair`

jrockowitz → made their first commit to this issue’s fork.

jrockowitz → made their first commit to this issue’s fork.

You have to write custom code to support this. You might want to try using webform cards. @see https://www.youtube.com/watch?v=bDugc2gWQnw

Please post this support question to the appropriate channel.

I am finding the MRs very confusing. I created a new ticket to address the immediate deprecation. I will still give everyone commit credit on this ticket.

@see 📌 format_size() is deprecated and is replaced by ByteSizeMarkup Active

jrockowitz → created an issue.

Try running drush webform-repair with the ckeditor5 module enabled.

This was fixed via 🐛 When a Webform is loaded on a 404 page: [PHP 8.1] Deprecated function: preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated in webform_form_alter() Needs review

This should be fixed because via CLI \Drupal::routeMatch()->getRouteName() can be equal to NULL

I am not writing new features for the webform module. If someone contributes code with test coverage, it will most likely be committed.

Good catch. Besides attaching the CSS via the preprocess callback, we should fix the CSS.

Before

After

jrockowitz → made their first commit to this issue’s fork.

I am confused by using the 'unchecked' trigger for the 'addlabel_02' textfield.

    addlabel_02:
      '#type': textfield
      '#title': 'Your label'
    incorrect_label_02:
      '#type': message
      '#states':
        visible:
          ':input[name="addlabel_02"]':
            '!value': 'H*'
        invisible:
          ':input[name="addlabel_02"]':
            unchecked: true
      '#message_type': error
      '#message_message': '<strong>Wrong!</strong><br>until correctly labelled'

I managed to fix three of the four broken tests but I am stumped by the broken entity print private field handling test issue. I think it is related to https://www.drupal.org/node/3346038 →

jrockowitz → made their first commit to this issue’s fork.

Yes, we should add 'lifecycle: deprecated' to any module categorized as 'Webform [DEPRECATED]'

I am hesitant to make any UI/UX changes, but the field could be disabled via a form alter hook.

Let's add a warning.

We could also create a webform_deprecated project namespace and gradually move deprecated webform modules into that namespace.

The 'Set default value' button opens an instance of the input based on the currently entered settings and validation rules. For more complex elements, including composites, we need to rerender the entire element.

I am not sure we should make any changes to this behavior.

I am not able to replicate this issue using the attached webform.

What theme are you using?

I am for removing the reference.

I am not able to replicate this issue using the below example and the Claro theme. What theme are you using?

webform_custom_composite_basic:
  '#type': custom_composite
  '#title': webform_custom_composite_basic
  '#multiple__header': false
  '#element':
    first_name:
      '#type': textfield
      '#title': 'First name'
    last_name:
      '#type': textfield
      '#title': 'Last name'

You can make an RC, but I need to tag a stable one this week. We could skip the RC

I am unsure if the patch is getting to the root cause. It seems that the archive is being closed and needs to be reopened when zipping large files.

@see https://stackoverflow.com/questions/16121885/php-zip-archive-memory-ram-...

I would be more comfortable with a patch that checks if the archive is closed and then reopens it. The current patch is reopening the archive with every file.

What admin theme are you using?

The Gin Admin Theme always included the X/close link.

Via Claro, the close button is not displayed.

This seem safe to merge

jrockowitz → made their first commit to this issue’s fork.

There are already a lot of theme suggestions including webform handlers for email templates

@see https://git.drupalcode.org/project/webform/-/blob/6.2.x/includes/webform...
@see https://git.drupalcode.org/project/webform/-/blob/6.2.x/includes/webform...

If you need additional template suggestions, you should use custom code.

Yep, this can happen in the next day or so. I will review open tickets to see if anything else should go into the release

I am unsure that _webform_token_render_more() is the root cause because the performance issue only happens when Search API is enabled.

This feature type can be handled via a form alter hook in a dedicated module or custom code.

jrockowitz → created an issue.

jrockowitz → created an issue.