Brooklyn, NY
Account created on 25 September 2008, almost 17 years ago
#

Merge Requests

More

Recent comments

🇺🇸United States jrockowitz Brooklyn, NY

Test coverage for containsPlace support via Address is still required.

🇺🇸United States jrockowitz Brooklyn, NY

I agree, we can't support SVG by default. You could create an HTML editor for webforms that supports SVG.

🇺🇸United States jrockowitz Brooklyn, NY

I think if there are over 100+ webforms using an autocomplete is a better UI/UX. Perhaps we should address that decision in a new ticket.

🇺🇸United States jrockowitz Brooklyn, NY

Now I see the finally statement is to ensure the cleanup code is executed. It is probably okay to commit as-is and deal with exceptions later.

🇺🇸United States jrockowitz Brooklyn, NY

This is a really good solution.

Should we log the exception, maybe as a warning, so that developers can debug errors/issues with devel generate?

🇺🇸United States jrockowitz Brooklyn, NY

This regression is being caused by Use modal in add new field flow Active

We are most likely going to have to completely rewrite this module using the similar approach but targeting a completely different form/render array.

🇺🇸United States jrockowitz Brooklyn, NY

Attached is a very ugly workaround that (re)enables container rebuild for all modules as they are installed in Drupal 11.2+.

I don't think this is the best solution. Ideally, when a config rewrite is about to happen, the container could be rebuilt, but I couldn't figure out how to achieve this.

🇺🇸United States jrockowitz Brooklyn, NY

Also, I don't fully understand why we import the vocabularies and application profiles as CSV data (vs linked data/triples)?

It was simpler and more performant. Keep in mind the Schema.org data is all managed via the 'schemadotorg.installer' and 'schemadotorg.schema_type_manager' are services and could be reworked to not use CSV data.

The [Schema.org configuration tool (RDF UI)]( https://www.drupal.org/project/rdfui ) does use linked data/triples.
@see https://git.drupalcode.org/project/rdfui/-/blob/8.x-1.x/src/EasyRdfConve...

🇺🇸United States jrockowitz Brooklyn, NY

You can probably use the schemadotorg_jsonld_custom.module to extract the 'text' from the paragraph.

🇺🇸United States jrockowitz Brooklyn, NY

I don't know what type of Views integration is expected. This module creates entity types and fields that are exposed to views.

Maybe a Views display plugin could expose all the entities listed via JSON-LD.

🇺🇸United States jrockowitz Brooklyn, NY

Generally, most sites won't want or need Dynamic Yield for admin pages, and there should be a checkbox to enable/disable Dynamic Yield for admin pages. I am not sure we need to support custom exclude rules for the public-facing page.

🇺🇸United States jrockowitz Brooklyn, NY

I created an MR because I think we have to revert this change for now until only Drupal 11 is supported.

🇺🇸United States jrockowitz Brooklyn, NY

Technically, in the Drupal community, we are still supporting PHP 8.2 for Drupal 10.
@see https://www.drupal.org/docs/getting-started/system-requirements/php-requ...

I would be open to committing the patch, but I want to nudge you to update to PHP 8.3.

🇺🇸United States jrockowitz Brooklyn, NY

You can try the below patch and see if it fixes the issue.

🇺🇸United States jrockowitz Brooklyn, NY

The problem is PHP 8.2, and I am only testing (and supporting) PHP 8.3+.

Here is a similar issue 🐛 Php 8.2 const definition error Active

🇺🇸United States jrockowitz Brooklyn, NY

Can you please look at the code in question and compare what is on your website to the below code?

https://git.drupalcode.org/project/schemadotorg/-/blob/1.0.x/src/SchemaD...

Maybe you need to reinstall/recopy the module via composer if these lines don't match.

🇺🇸United States jrockowitz Brooklyn, NY

No one else has ran into this issue and there are no update hooks which delete configuration. You might have to revert to a back up to get the lost configuration and moving forward export your configuration before updating the module.

🇺🇸United States jrockowitz Brooklyn, NY

Do you still have the YAML configuration for `schemadotorg.schemadotorg_mappings.node.place.yml` exported? Can you share it here?

My best guess is that some update hooks were not triggered, and the updated configuration was not exported.

🇺🇸United States jrockowitz Brooklyn, NY

jrockowitz made their first commit to this issue’s fork.

🇺🇸United States jrockowitz Brooklyn, NY

Okay my mistake the issue is with the media_contextual_crop_iwc_adapter

🇺🇸United States jrockowitz Brooklyn, NY

jrockowitz created an issue.

Production build 0.71.5 2024