Brooklyn, NY
Account created on 25 September 2008, over 15 years ago
#

Merge Requests

More

Recent comments

πŸ‡ΊπŸ‡ΈUnited States jrockowitz Brooklyn, NY

I found a regression that seems to be related to the patch from #14

Clicking the description help toggle (?) for the Revision log message reloads the entire page.

  • Install Drupal 10.2.x, Gin Admin Theme, and the patch.
  • Set the Gin as the 'Administration theme' (/admin/appearance)
  • Enable 'Enable form description toggle' (/admin/appearance/settings/gin)
  • Go to the 'Add page' node form (/node/add/page)
  • Enter the 'Title'
  • Click the (?) next to 'Revision log message'
  • Confirm that the page is being submitted and loading the preview.

Note that the below error is being logged in the JS console with the patch. Withoug the patch, there are no JS errors and the (?) next to 'Revision log message' works as expected.

Uncaught TypeError: Cannot read properties of null (reading 'querySelectorAll')

πŸ‡ΊπŸ‡ΈUnited States jrockowitz Brooklyn, NY

jrockowitz β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States jrockowitz Brooklyn, NY

Thanks for the review, the target for MR needed to be 1.0.x.

πŸ‡ΊπŸ‡ΈUnited States jrockowitz Brooklyn, NY

This MR also fixes the update hook for πŸ› Invalid config schema Fixed

πŸ‡ΊπŸ‡ΈUnited States jrockowitz Brooklyn, NY

jrockowitz β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States jrockowitz Brooklyn, NY

jrockowitz β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States jrockowitz Brooklyn, NY

My immediate use case for a postsave hook is for a hook triggered after all insert or update hooks to an entity are executed. The immediate goal of this ticket is to simplify the entity API. My use case might be an edge case.

πŸ‡ΊπŸ‡ΈUnited States jrockowitz Brooklyn, NY

jrockowitz β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States jrockowitz Brooklyn, NY

The attached patch is a temp/POC solution.

πŸ‡ΊπŸ‡ΈUnited States jrockowitz Brooklyn, NY
πŸ‡ΊπŸ‡ΈUnited States jrockowitz Brooklyn, NY
πŸ‡ΊπŸ‡ΈUnited States jrockowitz Brooklyn, NY

jrockowitz β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States jrockowitz Brooklyn, NY

This is a good catch. Let's see if we can solve this in a backward-compatible way.

πŸ‡ΊπŸ‡ΈUnited States jrockowitz Brooklyn, NY

Tokens that I had previously used in Drupal 7 and Webform 7 were no longer functioning as before and failing to display a field label when using the syntax described in the new documentation i.e:

Webform 5.x+ is not 1-to-1 port of the Webform 4.x branch.

I am sorry that the token behavior has changed, but at this point, with stable releases, we can change how tokens work in the 5.x+ branch.

In custom code or dedicated control module, you can create webform submission tokens that include the element's label.

πŸ‡ΊπŸ‡ΈUnited States jrockowitz Brooklyn, NY

Please add test coverage for the validation changes.
@see \Drupal\Tests\webform\Functional\Element\WebformElementAddressTest

πŸ‡ΊπŸ‡ΈUnited States jrockowitz Brooklyn, NY

Can you please include a screen of the datapicker?

Are you using jQuery UI or a native browser date picker?

πŸ‡ΊπŸ‡ΈUnited States jrockowitz Brooklyn, NY

This is fixed in 6.2.x

πŸ‡ΊπŸ‡ΈUnited States jrockowitz Brooklyn, NY

I am stumped on how to do this via custom code.

I cannot find mercury_editor_menu_local_tasks_alter in the mercury_editor.module file.

If anyone can provide a code snippet, when you have a chance, I will owe you a Drupal beer.

πŸ‡ΊπŸ‡ΈUnited States jrockowitz Brooklyn, NY

The MR is a simple POC which can be refactored and improved. By design, the MR appends the new functionality to the 'type_tray.module'
and 'type_tray.libraries.yml' files so people can test and use the attached patch AS-IS.

πŸ‡ΊπŸ‡ΈUnited States jrockowitz Brooklyn, NY

New features should be handled in a dedicated contribute module or custom code.

πŸ‡ΊπŸ‡ΈUnited States jrockowitz Brooklyn, NY

jrockowitz β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States jrockowitz Brooklyn, NY
πŸ‡ΊπŸ‡ΈUnited States jrockowitz Brooklyn, NY
πŸ‡ΊπŸ‡ΈUnited States jrockowitz Brooklyn, NY
πŸ‡ΊπŸ‡ΈUnited States jrockowitz Brooklyn, NY

jrockowitz β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States jrockowitz Brooklyn, NY

Yep, this made it into Drupal core via πŸ“Œ Allow for deletion of a single value of a multiple value field Fixed

Based on the commit this feature made it into Drupal 10.2.1+

We could limit this module to Drupal < 10.2.1 so that people know to uninstall it when updating to Drupal 10.2.2.

πŸ‡ΊπŸ‡ΈUnited States jrockowitz Brooklyn, NY

Conditional logic for composite elements should be implemented in custom code. There are examples in webform_example_composite.module.

If we allow set #states for composite sub-elements via the UI, we must also sort out backend conditional validation.

πŸ‡ΊπŸ‡ΈUnited States jrockowitz Brooklyn, NY

Could we check that $element['#options'] is empty before calling $element_plugin->prepare($element);?

πŸ‡ΊπŸ‡ΈUnited States jrockowitz Brooklyn, NY

If someone needs to remove the shaking behavior, they can do it via custom code shared on Drupal β†’ or dedicated control module.

πŸ‡ΊπŸ‡ΈUnited States jrockowitz Brooklyn, NY

@NicholasS Adding GitPod support would be greatly appreciated.

How about creating a ticket for adding GitPod support? Once we have the ticket and starting point, I can add the GitPod button to the project page with a link to the ticket.

πŸ‡ΊπŸ‡ΈUnited States jrockowitz Brooklyn, NY

jrockowitz β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States jrockowitz Brooklyn, NY

jrockowitz β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States jrockowitz Brooklyn, NY

I understand people are trying to fix this issue, but the ticket summary should document the problem and resolution.

Right now, the MR seems to be removing file extension validation for all versions of Drupal, even though the problem is only occurring in 10.2.x

πŸ‡ΊπŸ‡ΈUnited States jrockowitz Brooklyn, NY

This issue should be addressed by the Webform Remote Fields module and not the Webform module

Production build https://api.contrib.social 0.61.6-2-g546bc20