jrockowitz → created an issue.
Test coverage for containsPlace support via Address is still required.
jrockowitz → created an issue.
jrockowitz → created an issue.
jrockowitz → created an issue.
I agree, we can't support SVG by default. You could create an HTML editor for webforms that supports SVG.
Looks good.
I think if there are over 100+ webforms using an autocomplete is a better UI/UX. Perhaps we should address that decision in a new ticket.
Now I see the finally statement is to ensure the cleanup code is executed. It is probably okay to commit as-is and deal with exceptions later.
This is a really good solution.
Should we log the exception, maybe as a warning, so that developers can debug errors/issues with devel generate?
This regression is being caused by ✨ Use modal in add new field flow Active
We are most likely going to have to completely rewrite this module using the similar approach but targeting a completely different form/render array.
Attached is a very ugly workaround that (re)enables container rebuild for all modules as they are installed in Drupal 11.2+.
I don't think this is the best solution. Ideally, when a config rewrite is about to happen, the container could be rebuilt, but I couldn't figure out how to achieve this.
jrockowitz → created an issue.
jrockowitz → created an issue.
jrockowitz → created an issue.
jrockowitz → created an issue.
jrockowitz → created an issue.
nod_ → credited jrockowitz → .
jrockowitz → created an issue.
Also, I don't fully understand why we import the vocabularies and application profiles as CSV data (vs linked data/triples)?
It was simpler and more performant. Keep in mind the Schema.org data is all managed via the 'schemadotorg.installer' and 'schemadotorg.schema_type_manager' are services and could be reworked to not use CSV data.
The [Schema.org configuration tool (RDF UI)](
https://www.drupal.org/project/rdfui →
) does use linked data/triples.
@see https://git.drupalcode.org/project/rdfui/-/blob/8.x-1.x/src/EasyRdfConve...
jrockowitz → created an issue.
jrockowitz → created an issue.
jrockowitz → created an issue.
You can probably use the schemadotorg_jsonld_custom.module to extract the 'text' from the paragraph.
jrockowitz → created an issue.
jrockowitz → created an issue.
jrockowitz → created an issue.
jrockowitz → created an issue.
jrockowitz → created an issue.
jrockowitz → created an issue.
jrockowitz → created an issue.
jrockowitz → created an issue.
I don't know what type of Views integration is expected. This module creates entity types and fields that are exposed to views.
Maybe a Views display plugin could expose all the entities listed via JSON-LD.
jrockowitz → created an issue.
nicxvan → credited jrockowitz → .
nicxvan → credited jrockowitz → .
nicxvan → credited jrockowitz → .
Generally, most sites won't want or need Dynamic Yield for admin pages, and there should be a checkbox to enable/disable Dynamic Yield for admin pages. I am not sure we need to support custom exclude rules for the public-facing page.
I created an MR because I think we have to revert this change for now until only Drupal 11 is supported.
Technically, in the Drupal community, we are still supporting PHP 8.2 for Drupal 10.
@see
https://www.drupal.org/docs/getting-started/system-requirements/php-requ... →
I would be open to committing the patch, but I want to nudge you to update to PHP 8.3.
You can try the below patch and see if it fixes the issue.
The problem is PHP 8.2, and I am only testing (and supporting) PHP 8.3+.
Here is a similar issue 🐛 Php 8.2 const definition error Active
Can you please look at the code in question and compare what is on your website to the below code?
https://git.drupalcode.org/project/schemadotorg/-/blob/1.0.x/src/SchemaD...
Maybe you need to reinstall/recopy the module via composer if these lines don't match.
apmsooner → credited jrockowitz → .
No one else has ran into this issue and there are no update hooks which delete configuration. You might have to revert to a back up to get the lost configuration and moving forward export your configuration before updating the module.
jrockowitz → created an issue.
Do you still have the YAML configuration for `schemadotorg.schemadotorg_mappings.node.place.yml` exported? Can you share it here?
My best guess is that some update hooks were not triggered, and the updated configuration was not exported.
jrockowitz → created an issue.
jrockowitz → created an issue.
jrockowitz → made their first commit to this issue’s fork.
Okay my mistake the issue is with the media_contextual_crop_iwc_adapter