I don’t know if test coverage was checking this issue. Should we reopen this ticket?
I am open this improvement but it must include test coverage or updates to broken tests.
jrockowitz → made their first commit to this issue’s fork.
This should be done via a dedicated contributed module that alters the submission data.
There might be contributed modules that are already out there that do this.
jrockowitz → made their first commit to this issue’s fork.
This feels like an edge case request that should be address in custom code that can be shared via the Webform Cookbook →
I reverted the commit. I am going to reopen this ticket but multiple people will need to confirm that this regression has been addressed before moving forward.
Tests are passing. I am going to commit this.
We should add additional test coverage to the WebformOptionsHelperTest
jrockowitz → made their first commit to this issue’s fork.
We must continue support trigger the $input.change(); to support events handling especially conditional logic
jrockowitz → made their first commit to this issue’s fork.
Change make perfect sense and aligns with existing validation logic
Change make perfect sense and aligns with existing validation logic
Users can disable these features.
/admin/structure/webform/config and unchecking 'Display collapse/expand all details link on all webforms'
/admin/structure/webform/config/advanced and unchecking 'Save details open/close state?'
We could add logic for the details toggle to only include it if the webform has a details element.
Saving the details' open/close state is a global behavior.
The most likely cause is the form is rendered twice. See if you can replicate the issue when switching to Oliverio theme. You will most likely have to review your form and element twig templates.
jrockowitz → made their first commit to this issue’s fork.
This is being fixed via 🐛 Tests are broken Active
jrockowitz → made their first commit to this issue’s fork.
jrockowitz → made their first commit to this issue’s fork.
I am going to revert the commit because of 📌 Revert deprecation in ContentEntityStorageBase::__get() Needs review
Since the module was now uninstallable, I merged the change AS-IS. We can create a new ticket to fix the tests and tag it to a new release.
We are probably okay keeping this change
I think the patch is fine but we need to fix the broken test before tagging a new release.
I am getting beta4, and I am on Drupal 10.4.
What version of Drupal are you on, because the Drupal dependency for the CER module change between beta3 (^9.5 || ^10) to beta4 (^10.3 || ^11)
https://www.drupal.org/project/cer/releases/5.0.0-beta3 →
https://www.drupal.org/project/cer/releases/5.0.0-beta4 →
I thought "drupal/cer": "^5.0", allowed beta releases to be installed.
This module is still in alpha, and it is possible/likely that some. config did not get updated or exported as expected.
One workaround is to back up and restore the schemadotorg.mapping.*.yml files, with a reinstall.
I'm sure it is one of the many, many schema modules.
At the same time, you can start disabling modules and see if it cause the issue.
With no error message or log, I won't be able to debug this issue.
Amongst other things, it re-thinks some Drupal UIs, specifically form actions, that are moved to the top right corner.
I am seeing this impact other contrib modules including custom_field.module, but we should look into if there is way to fix the problem via Gin or a contrib modules
I am very confused by your example, you are nesting a flexbox inside a container, creating an unexpected layout. If you remove the container, the flexbox layout starts being more predictable. Also, uou are also mixing inline labels with the default vertical label.
I think you either have to write a little CSS to get the layout your desire or simplify your layout.
Please provide an example webform which can be used to replicate this issue.
The MR looks good. I appreciate the specificity of the fix. Someone needs to do some manual review.
I don't want to implement this feature because it would require too much work to support it.
For example, the webform views module would most likely need to be updated and tokens will probably need to fixed.
Please reopen this ticket or create a new one if you can provide steps to replicate the issue.
Please reopen this ticket or create a new one if you can provide steps to replicate the issue.
Please reopen this ticket or create a new one if you can provide steps to replicate the issue.
Please reopen this ticket or create a new one if you can provide steps to replicate the issue.
Please reopen this ticket or create a new one if you can provide steps to replicate the issue.
I am closing this issue but I did see something similar with. Custom code that added a callback using $this inside a service or OOP hook.
The below code will cause the $this (i.e, a service) to serialized.
$form['actions']['save']['#submit'][] = [$this, 'formSubmit'];
The code had to be changed to
$form['actions']['save']['#submit'][] = [static::class, 'formSubmit'];
I first have to ask, do we try to fix this. The themes (in core) include a fix.
https://git.drupalcode.org/project/drupal/-/blob/11.x/core/themes/claro/...
https://git.drupalcode.org/project/drupal/-/blob/11.x/core/themes/oliver...
We need to be very careful with our solution because the fieldgroup css is most likely going to be removed.
https://git.drupalcode.org/project/drupal/-/blob/11.x/core/lib/Drupal/Co...
Tests are passing, and I'm confident that element access controls have sufficient test coverage.
Hmm I am almost would rather add the missing CSS to something like webform.form.css.
The webform add-ons service was removed. I think running update.php will resolve this issue.
The "Schema.org Blueprints JSON-LD Preview" provides the tab
I think this feature can be part of the schemadotorg_jsonld_preview.module.
We should add the 'Schema.org' tab to all supported content entity types.
- media
- taxonomy
- user
- block
- etc...
The routes and tasks would have become dynamically generated.
We do something similar to the devel.module.
- \Drupal\devel\Routing\RouteSubscriber
- \Drupal\devel\Plugin\Derivative\DevelLocalTask
You can modify or create your own CSV file and define it via Schema.org data file/URL. (/admin/config/schemadotorg/settings/general)
@see ✨ Bioschemas or other schemas support Needs review
It make sense to make sure the $element['#webform'] is not empty via
I updated the MR to use the below code.
// Make sure that the '#webform' property is defined before proceeding.
if (empty($element['#webform'])) {
return $element;
}
If all tests pass, this should be RTBC.
jrockowitz → made their first commit to this issue’s fork.
Wow, forgot about this ticket and the patch, and just ran into the same issue via 🐛 PHP 8.1 TypeError: Drupal\webform\WebformRequest::getUrl() Closed: cannot reproduce and my conclusion is the the main entity (node) should always be stored as the source entity. Yet the problem is that tokens are current accessing the paragraph and node.