- Merge request !138Issue #3257570: Ensure that submission are deleted when a webform is deleted โ (Open) created by jrockowitz
- ๐ช๐ธSpain eduardo morales alberti Spain, ๐ช๐บ
We should try to add the test coverage to it.
- Merge request !418Issue #3257570: Ensure that submission are deleted when a webform is deleted โ (Merged) created by eduardo morales alberti
- last update
over 1 year ago 535 pass, 2 fail - ๐ช๐ธSpain eduardo morales alberti Spain, ๐ช๐บ
If we want to delete all submissions of a form, why log it?
If there are a lot of submissions and has dblog enabled, it will add too many entries. - last update
over 1 year ago 535 pass, 2 fail - last update
over 1 year ago 537 pass, 2 fail - Status changed to Needs review
over 1 year ago 9:30am 14 March 2024 - ๐ช๐ธSpain eduardo morales alberti Spain, ๐ช๐บ
Added tests, and do not log the submission deletion on batch.
The failed test is because placekitten website does not respond, nothing related to the changes.
Ready to review. - ๐ช๐ธSpain eduardo morales alberti Spain, ๐ช๐บ
Can anyone review it?
- ๐บ๐ธUnited States jrockowitz Brooklyn, NY
Sorry for the slow response. This needs to be rerolled to 6.3.x
- ๐บ๐ธUnited States jrockowitz Brooklyn, NY
jrockowitz โ changed the visibility of the branch 3257570-delete-webform-improvements to hidden.
- ๐บ๐ธUnited States jrockowitz Brooklyn, NY
I managed to rebase the branch but this definitely needs review and work
- ๐ฎ๐ณIndia divyansh.gupta Jaipur
divyansh.gupta โ made their first commit to this issueโs fork.