🇪🇸Spain @eduardo morales alberti

Needs review

We will commit a validation to know if the URI is set.

Ready to review

As the \Drupal\content_translation\Plugin\views\field\TranslationLink extends from \Drupal\views\Plugin\views\field\EntityLink it should have the same schema.

eduardo morales alberti → created an issue.

Ready to review!!

After installing the module Config inspector we get the following message:

"'reduce' is not a supported key."

After review that verf view filter \Drupal\verf\Plugin\views\filter\EntityReference extends from \Drupal\views\Plugin\views\filter\InOperator, the schema also should be "views.filter.in_operator".

Also, the "show_unpublished" is defined on the filter and should be added to the schema.

@omarlopesino, we can confirm that the errors are gone and the view is still working.

Added schema user_scope to MR

Ready to review!

eduardo morales alberti → created an issue.

Added config schema to the processor.

After patch:

eduardo morales alberti → created an issue.

Sorry, we upload the wrong capture

RTBC!
Tested on Drupal 10.3 using Config inspector:
Before patch:

After apply the patch #2:

RTBC!

After running the entire behat suite, the tests are stable with the Gin version dev and the patch from the merge request, we recovered the step And I press the "Save" button that failed on version rc14, so from our side, the change seems stable.

We tested the edit node form and the entity modals and seem to work.
We will update the changes and wait for CI results.
Thank you!!

Hi,

We tested it on our Drupal 10.3, on any entity form we get the following error:

It fails on media library modal, and entity browser-

  }, Drupal.ginStickyFormActions = {
    init: function(context) {
      const newParent = document.querySelector(".gin-sticky-form-actions");
      newParent && (context.classList?.contains("gin--has-sticky-form-actions") && context.getAttribute("id") && this.updateFormId(newParent, form),

Thank you @jurgenhaas

We updated the tests using the following custom steps on Behat.

  /**
   * @Given I press the submit input
   */
  public function iPressTheButtonInput() {
    $session = $this->getSession();
    $driver = $session->getDriver();

    if ($driver instanceof \Behat\Mink\Driver\Selenium2Driver) {
      // JavaScript-enabled submission.
      $session->executeScript('document.querySelector("input#edit-submit").click();');
    } else {
      $session->getPage()->pressButton('edit-submit');
    }

  }

Adding related issue that maybe could help 🐛 Automatic entity label does not take into account the field constraints Needs review

Maybe the issue 🐛 Automatic entity label does not take into account the field constraints Needs review could help

Are there any updates on it?

Same here on version 10.3.9:

Symfony\Component\HttpKernel\Exception\BadRequestHttpException: Invalid filename. in Drupal\system\Controller\AssetControllerBase->getGroup() (line 236 of docroot/core/modules/system/src/Controller/AssetControllerBas
e.php)

We test it on a simpletestme https://master-cg4lcdtc1ja3gfni2izgajxkko4dkwxp.tugboatqa.com/

Steps to reproduce:

• We installed the drupal 10.3.9
• Installed the entity browser and created a reference field to content with this widget
• Installed media and media library
• Created a content with a media and saved the content
• Edit again the content and remove the media
• Review the logs

It is tested on a clean environment so RTBC

@berdir do you need more info?

@berdir as said in the comment #3247212-6: Ajax error on delete item →

We're seeing the same issue. It doesn't actually cause a problem unless PHP has the display_errors option switched on.

Here the problem is caused by having both an Entity Browser field and a core Media Library field on the same form. When trying to remove an item from the media widget, the Entity Browser code is getting confused because the button for core Media Library is also called remove_button

Attaching patch which checks the field name on the triggering element matches the expected one for this widget. This allows both the media library and entity browser to function correctly again here.

We are unsure how to cover it with tests, but the patch #3125117-11: Remove button in entity browser field widget doesn't work → works for us.

Ready to review

Fixed MR conflicts.

The version 18 requires country codes to be lowercase.

After testing version 18, we decided that it is not stable and does not work properly with the module.

eduardo morales alberti → created an issue.

eduardo morales alberti → created an issue.

@renatog, sorry because renderInIsolation comes from Drupal 10.3 https://www.drupal.org/node/3407994 →
Maybe we should add ^10.3 on the .info and composer.json as the 10.2.x is not supported.

But the check that you introduced is also valid.

Sorry, my bad.
Ready to review, working properly for our side.

Thank you for reviewing @renatog. Are there any pending issues?

eduardo morales alberti → created an issue.

Changes made

• Add the ability to alter the insight form.
• All insights are collapses
• Views can be excluded from the insights

Added dependency with issue 📌 Drop compatiblitiy with Drupal 9 version Active as some changes are not compatibles with drupal 9

eduardo morales alberti → created an issue.

Replaced renderPlain with renderInIsolation, remove 9.3 from .info module as Drupal 9 is not supported by Drupal and renderInIsolation is not compatible with drupal 9.
If we want to maintain drupal 9, then we should check if renderInIsolation exists, but supporting drupal 9 and 11 is not recommended.

eduardo morales alberti → created an issue.

We got some errors from the cache tags on some pages:

TypeError: array_merge(): Argument #1 must be of type array, null given in array_merge() (line 140 of /var/www/html/docroot/modules/contrib/modal_page/modal_page.module).

LogicException: A stray renderRoot() invocation is causing bubbling of attached assets to break. in Drupal\Core\Render\Renderer->renderRoot() (line 156 of /var/www/html/docroot/core/lib/Drupal/Core...

Warning: Undefined array key "tags" in modal_page_preprocess_html() (line 141 of /var/www/html/docroot/modules/contrib/modal_page/modal_page.module) #0 /var/www/html/docroot/core/includes/bootstrap...

Any news? we tested it, and works properly.

We created the fork to make some changes, but after reviewing and testing the patch, we validated it and is not needed.
Reviewed and tested.

eduardo morales alberti → made their first commit to this issue’s fork.

All tests fixed.

The remaining failed tests do not seem to be related to this change.

Any clue?

Failed PHPUnit:

There was 1 failure:
1)
Drupal\Tests\editor\Functional\EditorSecurityTest::testEditorXssFilterOverride
Behat\Mink\Exception\ExpectationException: The field "edit-body-0-value"
value is "Hello, Dumbo Octopus!alert(0)", but "Hello, Dumbo
Octopus!alert(0)" expected.
/builds/issue/drupal-3384789/vendor/behat/mink/src/WebAssert.php:888
/builds/issue/drupal-3384789/vendor/behat/mink/src/WebAssert.php:781
/builds/issue/drupal-3384789/core/tests/Drupal/Tests/WebAssert.php:991
/builds/issue/drupal-3384789/core/modules/editor/tests/src/Functional/EditorSecurityTest.php:454
FAILURES!
Tests: 3, Assertions: 131, Failures: 1.
---- Drupal\Tests\language\Functional\ConfigurableLanguageManagerTest ----

    Time: 00:39.668, Memory: 8.00 MB
    
    There was 1 failure:
    
    1)
    Drupal\Tests\responsive_image\FunctionalJavascript\ResponsiveImageFieldUiTest::testResponsiveImageFormatterUi
    Behat\Mink\Exception\ExpectationException: The string "Select a responsive
    image style." was not found anywhere in the HTML response of the current
    page.
    
    /builds/issue/drupal-3384789/vendor/behat/mink/src/WebAssert.php:888
    /builds/issue/drupal-3384789/vendor/behat/mink/src/WebAssert.php:363
    /builds/issue/drupal-3384789/core/tests/Drupal/Tests/WebAssert.php:558
    /builds/issue/drupal-3384789/core/modules/responsive_image/tests/src/FunctionalJavascript/ResponsiveImageFieldUiTest.php:94
    
    FAILURES!
    Tests: 1, Assertions: 11, Failures: 1.
---- Drupal\FunctionalJavascriptTests\Ajax\AjaxFormCacheTest ----

Failed Nightwatch:

  Error
    ✖ NightwatchAssertError
   Timed out while waiting for element <form.system-modules [name="modules[navigation][enable]"]:disabled> to be present for 10000 milliseconds. - expected "found" but got: "not found" (10495ms)
    Error location:
    /builds/issue/drupal-3384789/core/tests/Drupal/Nightwatch/Commands/drupalInstallModule.js:39
    –––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––
     37 |     // Wait for the checkbox for the module to be disabled as a sign that the
     38 |     // module has been enabled.
     39 |     this.waitForElementPresent( 
     40 |       `form.system-modules [name="modules[${module}][enable]"]:disabled`,
     41 |       10000,
    –––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––
 Wrote HTML report file to: /builds/issue/drupal-3384789/nightwatch_output/nightwatch-html-report/index.html

Thank you! We saw that custom profiles have their user.settings, we review it!

@smutgrave it is happening on all types of tests not only on migrations.
Seems related to the schema validation, but the schema seems to be right.

    /builds/issue/drupal-3384789/core/lib/Drupal/Core/Config/Development/ConfigSchemaChecker.php:98
    /builds/issue/drupal-3384789/vendor/symfony/event-dispatcher/EventDispatcher.php:206
    /builds/issue/drupal-3384789/vendor/symfony/event-dispatcher/EventDispatcher.php:56
    /builds/issue/drupal-3384789/core/lib/Drupal/Core/Config/Config.php:230
    /builds/issue/drupal-3384789/core/lib/Drupal/Core/Config/ConfigInstaller.php:396
    /builds/issue/drupal-3384789/core/lib/Drupal/Core/Config/ConfigInstaller.php:149
    /builds/issue/drupal-3384789/core/lib/Drupal/Core/ProxyClass/Config/ConfigInstaller.php:75
    /builds/issue/drupal-3384789/core/lib/Drupal/Core/Extension/ModuleInstaller.php:333
    /builds/issue/drupal-3384789/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
    /builds/issue/drupal-3384789/core/includes/install.core.inc:1916
    /builds/issue/drupal-3384789/core/includes/batch.inc:296
    /builds/issue/drupal-3384789/core/includes/form.inc:977
    /builds/issue/drupal-3384789/core/includes/install.core.inc:654
    /builds/issue/drupal-3384789/core/includes/install.core.inc:572
    /builds/issue/drupal-3384789/core/includes/install.core.inc:121
    /builds/issue/drupal-3384789/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:315
    /builds/issue/drupal-3384789/core/tests/Drupal/Tests/BrowserTestBase.php:546
    /builds/issue/drupal-3384789/core/tests/Drupal/Tests/BrowserTestBase.php:363
    /builds/issue/drupal-3384789/core/tests/Drupal/FunctionalJavascriptTests/PerformanceTestBase.php:28

Issue ✨ Allow user admins to choose the user cancellation method on the user deletion confirmation form (rather than having a single sitewide setting) Needs work could help to limit the options

eduardo morales alberti → created an issue.

@smustgrave What should we change on the MR?

The errors are:

Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for
    user.settings with the following errors: 0 [] 'cancel_method_options' is a
    required key.

But it is defined by the user.settings install config https://git.drupalcode.org/project/drupal/-/merge_requests/4684/diffs#1e...

cancel_method_options:
  user_cancel_block: true
  user_cancel_block_unpublish: true
  user_cancel_reassign: true
  user_cancel_delete: true

eduardo morales alberti → created an issue.

Thank you @lpeidro

We are not able to reproduce the PHPUnit errors on a Drupal 11.0-x-dev locally.

Errors on MR:
PHPUnit:

    PHPUnit Test failed to complete; Error: PHPUnit 10.5.35 by Sebastian
    Bergmann and contributors.
    
    Runtime:       PHP 8.3.12
    Configuration: /builds/issue/drupal-3384789/core/phpunit.xml.dist
    
    F                                                                   1 / 1
    (100%)
    
    Time: 00:03.085, Memory: 8.00 MB
    
    There was 1 failure:
    
    1)
    Drupal\Tests\config_translation\Kernel\Migrate\d6\MigrateUserConfigsTranslationTest::testUserMail
    Schema errors for user.settings with the following errors: 0 []
    'cancel_method_options' is a required key.
    (/builds/issue/drupal-3384789/core/lib/Drupal/Core/Config/Development/ConfigSchemaChecker.php:98)
    Failed asserting that two strings are equal.
    --- Expected
    +++ Actual
    @@ @@
    -'status'
    +'error'
    
    /builds/issue/drupal-3384789/core/modules/migrate/tests/src/Kernel/MigrateTestBase.php:203
    /builds/issue/drupal-3384789/core/modules/migrate/src/MigrateExecutable.php:515
    /builds/issue/drupal-3384789/core/modules/migrate/src/MigrateExecutable.php:273
    /builds/issue/drupal-3384789/core/modules/migrate/tests/src/Kernel/MigrateTestBase.php:179
    /builds/issue/drupal-3384789/core/modules/migrate/tests/src/Kernel/MigrateTestBase.php:192
    /builds/issue/drupal-3384789/core/modules/config_translation/tests/src/Kernel/Migrate/d6/MigrateUserConfigsTranslationTest.php:32

---- Drupal\Tests\standard\FunctionalJavascript\StandardJavascriptTest ----
Status    Group      Filename          Line Function                            
--------------------------------------------------------------------------------
Exception Other      phpunit-68.xml       0 Drupal\Tests\standard\FunctionalJav
    PHPUnit Test failed to complete; Error: PHPUnit 10.5.35 by Sebastian
    Bergmann and contributors.
    
    Runtime:       PHP 8.3.12
    Configuration: /builds/issue/drupal-3384789/core/phpunit.xml.dist
    
    E                                                                   1 / 1
    (100%)
    
    Time: 00:02.126, Memory: 8.00 MB
    
    There was 1 error:
    
    1)
    Drupal\Tests\standard\FunctionalJavascript\StandardJavascriptTest::testBigPipe
    Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for
    user.settings with the following errors: 0 [] 'cancel_method_options' is a
    required key.
    
    /builds/issue/drupal-3384789/core/lib/Drupal/Core/Config/Development/ConfigSchemaChecker.php:98
    /builds/issue/drupal-3384789/vendor/symfony/event-dispatcher/EventDispatcher.php:206
    /builds/issue/drupal-3384789/vendor/symfony/event-dispatcher/EventDispatcher.php:56
    /builds/issue/drupal-3384789/core/lib/Drupal/Core/Config/Config.php:230
    /builds/issue/drupal-3384789/core/lib/Drupal/Core/Config/ConfigInstaller.php:396
    /builds/issue/drupal-3384789/core/lib/Drupal/Core/Config/ConfigInstaller.php:149
    /builds/issue/drupal-3384789/core/lib/Drupal/Core/ProxyClass/Config/ConfigInstaller.php:75
    /builds/issue/drupal-3384789/core/lib/Drupal/Core/Extension/ModuleInstaller.php:333
    /builds/issue/drupal-3384789/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
    /builds/issue/drupal-3384789/core/includes/install.core.inc:1916
    /builds/issue/drupal-3384789/core/includes/batch.inc:296
    /builds/issue/drupal-3384789/core/includes/form.inc:977
    /builds/issue/drupal-3384789/core/includes/install.core.inc:654
    /builds/issue/drupal-3384789/core/includes/install.core.inc:572
    /builds/issue/drupal-3384789/core/includes/install.core.inc:121
    /builds/issue/drupal-3384789/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:315
    /builds/issue/drupal-3384789/core/tests/Drupal/Tests/BrowserTestBase.php:546
    /builds/issue/drupal-3384789/core/tests/Drupal/Tests/BrowserTestBase.php:363

--------------------------------------------------------------------------------
Exception Other      phpunit-53.xml       0 Drupal\Tests\content_translation\Fu
    PHPUnit Test failed to complete; Error: PHPUnit 10.5.35 by Sebastian
    Bergmann and contributors.
    
    Runtime:       PHP 8.3.12
    Configuration: /builds/issue/drupal-3384789/core/phpunit.xml.dist
    
    E                                                                   1 / 1
    (100%)
    
    Time: 00:02.117, Memory: 8.00 MB
    
    There was 1 error:
    
    1)
    Drupal\Tests\content_translation\FunctionalJavascript\ContentTranslationConfigUITest::testContentTranslationConfigUI
    Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for
    user.settings with the following errors: 0 [] 'cancel_method_options' is a
    required key.
    
    /builds/issue/drupal-3384789/core/lib/Drupal/Core/Config/Development/ConfigSchemaChecker.php:98
    /builds/issue/drupal-3384789/vendor/symfony/event-dispatcher/EventDispatcher.php:206
    /builds/issue/drupal-3384789/vendor/symfony/event-dispatcher/EventDispatcher.php:56
    /builds/issue/drupal-3384789/core/lib/Drupal/Core/Config/Config.php:230
    /builds/issue/drupal-3384789/core/lib/Drupal/Core/Config/ConfigInstaller.php:396
    /builds/issue/drupal-3384789/core/lib/Drupal/Core/Config/ConfigInstaller.php:149
    /builds/issue/drupal-3384789/core/lib/Drupal/Core/ProxyClass/Config/ConfigInstaller.php:75
    /builds/issue/drupal-3384789/core/lib/Drupal/Core/Extension/ModuleInstaller.php:333
    /builds/issue/drupal-3384789/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
    /builds/issue/drupal-3384789/core/includes/install.core.inc:1916
    /builds/issue/drupal-3384789/core/includes/batch.inc:296
    /builds/issue/drupal-3384789/core/includes/form.inc:977
    /builds/issue/drupal-3384789/core/includes/install.core.inc:654
    /builds/issue/drupal-3384789/core/includes/install.core.inc:572
    /builds/issue/drupal-3384789/core/includes/install.core.inc:121
    /builds/issue/drupal-3384789/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:315
    /builds/issue/drupal-3384789/core/tests/Drupal/Tests/BrowserTestBase.php:546
    /builds/issue/drupal-3384789/core/tests/Drupal/Tests/BrowserTestBase.php:363

---- Drupal\Tests\demo_umami\FunctionalJavascript\OpenTelemetryFrontPagePerformanceTest ----
Status    Group      Filename          Line Function                            
--------------------------------------------------------------------------------
Exception Other      phpunit-6.xml        0 Drupal\Tests\demo_umami\FunctionalJ
    PHPUnit Test failed to complete; Error: PHPUnit 10.5.35 by Sebastian
    Bergmann and contributors.
    
    Runtime:       PHP 8.3.12
    Configuration: /builds/issue/drupal-3384789/core/phpunit.xml.dist
    
    E                                                                   1 / 1
    (100%)
    
    Time: 00:01.718, Memory: 8.00 MB
    
    There was 1 error:
    
    1)
    Drupal\Tests\demo_umami\FunctionalJavascript\OpenTelemetryFrontPagePerformanceTest::testFrontPagePerformance
    Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for
    user.settings with the following errors: 0 [] 'cancel_method_options' is a
    required key.
    
    /builds/issue/drupal-3384789/core/lib/Drupal/Core/Config/Development/ConfigSchemaChecker.php:98
    /builds/issue/drupal-3384789/vendor/symfony/event-dispatcher/EventDispatcher.php:206
    /builds/issue/drupal-3384789/vendor/symfony/event-dispatcher/EventDispatcher.php:56
    /builds/issue/drupal-3384789/core/lib/Drupal/Core/Config/Config.php:230
    /builds/issue/drupal-3384789/core/lib/Drupal/Core/Config/ConfigInstaller.php:396
    /builds/issue/drupal-3384789/core/lib/Drupal/Core/Config/ConfigInstaller.php:149
    /builds/issue/drupal-3384789/core/lib/Drupal/Core/ProxyClass/Config/ConfigInstaller.php:75
    /builds/issue/drupal-3384789/core/lib/Drupal/Core/Extension/ModuleInstaller.php:333
    /builds/issue/drupal-3384789/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
    /builds/issue/drupal-3384789/core/includes/install.core.inc:1916
    /builds/issue/drupal-3384789/core/includes/batch.inc:296
    /builds/issue/drupal-3384789/core/includes/form.inc:977
    /builds/issue/drupal-3384789/core/includes/install.core.inc:654
    /builds/issue/drupal-3384789/core/includes/install.core.inc:572
    /builds/issue/drupal-3384789/core/includes/install.core.inc:121
    /builds/issue/drupal-3384789/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:315
    /builds/issue/drupal-3384789/core/tests/Drupal/Tests/BrowserTestBase.php:546
    /builds/issue/drupal-3384789/core/tests/Drupal/Tests/BrowserTestBase.php:363
    /builds/issue/drupal-3384789/core/tests/Drupal/FunctionalJavascriptTests/PerformanceTestBase.php:28

@lpeidro

1. Drupal 9.x is not supported by Drupal
2. If the function user_requirements is duplicated, the patch did not apply properly, take into account the MR is over Drupal 11.X not 10.3.x, here is the patch that we have applied on Drupal 10.3.x

Ready to review

@longwave Title updated.

Fixing merge request issues.

Do not process the revision if is not node.

It is unrelated to 3380623 because the question here is to check if the revision is a valid object, it fails on a different line.

We should check if the revision is a valid node before calling to get the translation method, because if the revision is null it gives the reported error.

In our case, we call to matchrequest to get the route and that produces the side effect, because the process inbound is launched twice.
First call method router matchRequest (Custom)

Second call method router matchRequest (Core):

eduardo morales alberti → created an issue.

eduardo morales alberti → created an issue.

eduardo morales alberti → created an issue.

Pending to review comments from @tunic

New release 2.0.0 compatible with Drupal 10.

Can anyone review it?

We can close this issue as Drupal 9 end of life was on November 2023 https://www.drupal.org/psa-2023-11-01 →

Merged

Same error on our project:

TypeError: OneTrust.OnConsentChanged is not a function
    at Drupal.youtubeCookiesOneTrust.onConsentChange (js_HHetFvoOZds01hjTV1yXGVp_mlhSzB51ARUMnfYybE0.js?scope=footer&delta=0&language=us&theme=radix&include=eJyNUltywyAMvJANt-gF2n9GYBmTyCgFkca3L3bssfPoTH9A7IplJQQnuBli6DBp2GMlQ2JrMTXZDYDJ9AGpMwLeZJkI9ecCf8zoF_jPGdtSE3Thppe0ZuIixaJxzOeAWXNESSXLM1F34mT5pleiXYl2IxrP7AlnC9rL-HgE_3xWczGbo4g_mVCk1viCmA4ECKa9VEfF6kOsHJcoqZppIEqwLHrdVc9pbBwFjJJDh-YKFKpe4GhO3wXTpN1V3SO1cvjf_NDj7ujNDb2GnPJT55HQienrT0qI3hBYpC0lD3zR87IBFOLZCN-JDnO9EjbuWl9kvazGgjv7VDvRNRkhucHAJRgowo7HS-0l6j_wR3cDzvP1Yqfqx3jAF6lNcS_6UcsTW6A3PziA6EOsIkPTUx2NeVFLycf5uKuNGEtLeEVqc30P37AjhPgL0D5Cig:266:16)
    at js_HHetFvoOZds01hjTV1yXGVp_mlhSzB51ARUMnfYybE0.js?scope=footer&delta=0&language=us&theme=radix&include=eJyNUltywyAMvJANt-gF2n9GYBmTyCgFkca3L3bssfPoTH9A7IplJQQnuBli6DBp2GMlQ2JrMTXZDYDJ9AGpMwLeZJkI9ecCf8zoF_jPGdtSE3Thppe0ZuIixaJxzOeAWXNESSXLM1F34mT5pleiXYl2IxrP7AlnC9rL-HgE_3xWczGbo4g_mVCk1viCmA4ECKa9VEfF6kOsHJcoqZppIEqwLHrdVc9pbBwFjJJDh-YKFKpe4GhO3wXTpN1V3SO1cvjf_NDj7ujNDb2GnPJT55HQienrT0qI3hBYpC0lD3zR87IBFOLZCN-JDnO9EjbuWl9kvazGgjv7VDvRNRkhucHAJRgowo7HS-0l6j_wR3cDzvP1Yqfqx3jAF6lNcS_6UcsTW6A3PziA6EOsIkPTUx2NeVFLycf5uKuNGEtLeEVqc30P37AjhPgL0D5Cig:300:39

As workaround we defined the style tag on another core plugin:

ckeditor5_removeFormat:
  ckeditor5:
    plugins: [removeFormat.RemoveFormat]
  drupal:
    label: Remove Format
    library: core/ckeditor5.removeFormat
    admin_library: ckeditor5/internal.admin.removeFormat
    toolbar_items:
      removeFormat:
        label: Remove Format
    elements:
     - <span>

The problem comes because the Style plugin that has the following styles defined does not define the span element and then gives an error message that the span should be defined by any plugin, but if there is no plugin, it can be defined on the source plugin, but it has the reported side effect.

span.text-primary|Color primary
span.text-beige|Color beige
span.text-yellow|Color yellow
span.text-white|Color white

Style plugin message:

The Style plugin needs another plugin to create <span>, for it to be able to create the following attributes: <span class="text-primary text-beige text-yellow text-white">. Enable a plugin that supports creating this tag. If none exists, you can configure the Source Editing plugin to support it.

The workaround is to define the span on a plugin from docroot/core/modules/ckeditor5/ckeditor5.ckeditor5.yml, clear the caches and remove the span from the source editing text area.

ckeditor5_removeFormat:
  ckeditor5:
    plugins: [removeFormat.RemoveFormat]
  drupal:
    label: Remove Format
    library: core/ckeditor5.removeFormat
    admin_library: ckeditor5/internal.admin.removeFormat
    toolbar_items:
      removeFormat:
        label: Remove Format
    elements:
     - <span>

If we add the span on the Style plugin we get the following error:

Definition:

ckeditor5_style:
  ckeditor5:
    plugins: [style.Style]
  drupal:
    label: Style
    library: core/ckeditor5.style
    admin_library: ckeditor5/internal.admin.style
    class: Drupal\ckeditor5\Plugin\CKEditor5Plugin\Style
    toolbar_items:
      style:
        label: Style
    # This plugin is able to add any configured class on any tag that can be
    # created by some other CKEditor 5 plugin. Hence it indicates it allows all
    # classes on all tags. Its subset then restricts this to a concrete set of
    # tags, and a concrete set of classes.
    # @todo Update in https://www.drupal.org/project/drupal/issues/3280124
    # @see \Drupal\ckeditor5\Plugin\CKEditor5Plugin\Style::getElementsSubset()
    # @see \Drupal\ckeditor5\Plugin\Validation\Constraint\StyleSensibleElementConstraintValidator
    elements:
      - <span>
      - <$any-html5-element class>

Error:

The website encountered an unexpected error. Try again later.

LogicException: The "ckeditor5_style" CKEditor 5 plugin implements ::getElementsSubset() and did return a subset ("<span class="text-primary text-beige text-yellow text-white">") but the following tags can no longer be created: "<span>". in Drupal\ckeditor5\Plugin\CKEditor5PluginManager->getProvidedElements() (line 416 of core/modules/ckeditor5/src/Plugin/CKEditor5PluginManager.php).Drupal\ckeditor5\Plugin\CKEditor5PluginManager->getEnabledDefinitions() (Line: 792)
Drupal\ckeditor5\Plugin\Editor\CKEditor5->getEventualEditorWithPrimedFilterFormat() (Line: 679)
Drupal\ckeditor5\Plugin\Editor\CKEditor5->validateConfigurationForm() (Line: 207)
editor_form_filter_admin_format_validate()
call_user_func_array() (Line: 82)
Drupal\Core\Form\FormValidator->executeValidateHandlers() (Line: 274)
Drupal\Core\Form\FormValidator->doValidateForm() (Line: 118)
Drupal\Core\Form\FormValidator->validateForm() (Line: 593)
Drupal\Core\Form\FormBuilder->processForm() (Line: 326)
Drupal\Core\Form\FormBuilder->buildForm() (Line: 73)
Drupal\Core\Controller\FormController->getContentResult()
call_user_func_array() (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 669)
Drupal\Core\Render\Renderer->executeInRenderContext() (Line: 121)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext() (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 181)
Symfony\Component\HttpKernel\HttpKernel->handleRaw() (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle() (Line: 53)
Drupal\Core\StackMiddleware\Session->handle() (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle() (Line: 28)
Drupal\Core\StackMiddleware\ContentLength->handle() (Line: 53)
Asm89\Stack\Cors->handle() (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle() (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle() (Line: 36)
Drupal\Core\StackMiddleware\AjaxPageState->handle() (Line: 55)
Drupal\http_headers_cleaner\Middleware\HttpHeadersCleanerMiddleware->handle() (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle() (Line: 741)
Drupal\Core\DrupalKernel->handle() (Line: 19) 

The final solution should be that the style plugin supports any element defined by itself, but we will apply the workaround.

We can close it as it is the expected behaviour, we added again the simplest folder to the .gitignore.
Thank you @quietone.

eduardo morales alberti → created an issue.

Thank you Alberto Paderno!!

Assigned to @tunic to review the changes before the new release.

Hi Alberto Paderno, any news of the module maintainer?

As work around it can be hidden by:

    $form['files_container'] = [
      '#type' => 'container',
      '#states' => [
        'visible' => [
          ':input[id="edit-subject"]' => [
            ['value' => $this->t('Question')],
            'or',
            ['value' => $this->t('Complaint')],
          ],
        ],
      ],
    ];

    $form['files_container']['images'] = [
      '#type' => 'managed_file',
      '#title' => $this->t('Choose an image (jpg/png)'),
      '#description' => $this->t('You may select up to 5 files.'),
      '#multiple' => TRUE,
      '#upload_validators' => [
        'file_validate_extensions' => ['png jpg jpeg'],
        'file_validate_size' => ['4194304'],
      ],
      '#cardinality' => 5,
    ];

After deploy the last version of Drupal 10.3.5 we got the following error:

Error: Class "Drupal\Core\EventSubscriber\RequestCloseSubscriber" not found in Drupal\Component\DependencyInjection\Container->createService() (line 259 of /mnt/www/html/drschar/docroot/core/lib/Drupal/Component/DependencyInjection/Container.php) #0 /mnt/www/html/drschar/docroot/core/lib/Drupal/Component/DependencyInjection/Container.php(177): Drupal\Component\DependencyInjection\Container->createService(Array, 'request_close_s...') #1 /mnt/www/html/drschar/docroot/core/lib/Drupal/Component/EventDispatcher/ContainerAwareEventDispatcher.php(105): Drupal\Component\DependencyInjection\Container->get('request_close_s...') #2 /mnt/www/html/drschar/vendor/symfony/http-kernel/HttpKernel.php(115): Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch(Object(Symfony\Component\HttpKernel\Event\TerminateEvent), 'kernel.terminat...') #3 /mnt/www/html/drschar/docroot/core/lib/Drupal/Core/StackMiddleware/StackedHttpKernel.php(63): Symfony\Component\HttpKernel\HttpKernel->terminate(Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\Render\HtmlResponse)) #4 /mnt/www/html/drschar/docroot/core/lib/Drupal/Core/DrupalKernel.php(688): Drupal\Core\StackMiddleware\StackedHttpKernel->terminate(Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\Render\HtmlResponse)) #5 /mnt/www/html/drschar/docroot/index.php(22): Drupal\Core\DrupalKernel->terminate(Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\Render\HtmlResponse)) #6 @main.

After a long time, one month, we did not receive any response from the maintainer, so we move the issue to the Drupal.org project ownership.