🇪🇸Spain @eduardo morales alberti

Any news? The last release was one year ago

Ready to review

Pending to separate on the settings form the external and internal links and the subcategories (iframe) and schemes (mailto, tel..) and then filter the targets by it.
Also, review the testing coverage.

eduardo morales alberti → created an issue.

Hi,

We already removed the module content_browser and replaced it with custom configuration based on the module on our projects, so we do not need to maintain it. Explanation on comment: https://www.drupal.org/project/content_browser/issues/3503979#comment-16... 📌 Drupla 11 compatibility Needs work

As a recommendation, it can be added a documentation to remove the dependency from the module and mark it as abandoned to be able to uninstall it without losing the functionality.

Or instead, if we want to keep the module maintained, use some kind of recipe to install the configuration to avoid the direct dependency.
The problem with the second option is that there is CSS and JavaScript.

eduardo morales alberti → created an issue.

Could you review the coding standard errors?

PHP CODE SNIFFER REPORT SUMMARY
----------------------------------------------------------------------
FILE                                                  ERRORS  WARNINGS
----------------------------------------------------------------------
entity_mesh.libraries.yml                             1       0
entity_mesh.permissions.yml                           1       0
entity_mesh.routing.yml                               1       0
src/DummyAccount.php                                  22      0
src/Repository.php                                    1       0
tests/src/Kernel/EntityMeshPermissionsTest.php        12      7
----------------------------------------------------------------------
A TOTAL OF 38 ERRORS AND 7 WARNINGS WERE FOUND IN 60 FILES
----------------------------------------------------------------------
PHPCBF CAN FIX 43 OF THESE SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
PHP CODE SNIFFER VIOLATION SOURCE SUMMARY
----------------------------------------------------------------------
    SOURCE                                                       COUNT
----------------------------------------------------------------------
[x] Drupal.Commenting.PostStatementComment.Found                 15
[x] Drupal.Commenting.InlineComment.InvalidEndChar               14
[x] Drupal.Classes.UnusedUseStatement.UnusedUse                  4
[x] Drupal.WhiteSpace.Comma.TooManySpaces                        4
[x] Drupal.Arrays.Array.CommaLastItem                            2
[x] Drupal.Files.EndFileNewline.TooMany                          2
[x] Drupal.Commenting.DocComment.TagGroupSpacing                 1
[ ] Drupal.Commenting.FunctionComment.MissingReturnComment       1
[x] Drupal.Files.EndFileNewline.NoneFound                        1
[ ] Drupal.Files.LineLength.TooLong                              1
----------------------------------------------------------------------
A TOTAL OF 45 SNIFF VIOLATIONS WERE FOUND IN 10 SOURCES
----------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SOURCES AUTOMATICALLY (43 VIOLATIONS IN TOTAL)
----------------------------------------------------------------------

Related issue https://www.drupal.org/project/drupal/issues/3384789 ✨ Allow user admins to choose the user cancellation method on the user deletion confirmation form (rather than having a single sitewide setting) Needs work

Ready to review!!

Reverting the latest commit and applying the schema again, as it had too many changes not related to the issue

All threads solved!! Ready to review

All threads solved but one, pending to review

Pending review PHPUnit test after applying suggestions

Ready to review, we removed the insight to avoid excessive loads on status page

We will remove the insight as it takes to much time to process on the status report

My comment was incomplete; we were trying to update the module from 11.1.8, and we were stuck on 2.2.6.

RTBC!! Thank you!!

Why the module is not compatible with 11.1.X on version 2.3.0?

Update MR

Solve MR conflict with Drupal 11

RTBC!!!
Before patch (shows modules only enabled on prod config split):

After the patch, it only shows the content install module (it is only installed once on a site setup to create default content and then uninstalled):

Fixed coding standard

Pending to solve the following errors:

FILE: modules/styleguide_static/src/StaticGenerator.php
------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AND 2 WARNINGS AFFECTING 6 LINES
------------------------------------------------------------------------------------------------------------------------
  53 | ERROR   | [x] Multi-line function declarations must have a trailing comma after the last parameter
     |         |     (Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma)
  57 | WARNING | [x] '@TODO: These should be cached.' should match the format '@todo Fix problem X here.'
     |         |     (Drupal.Commenting.TodoComment.TodoFormat)
  58 | WARNING | [x] '@TODO: Add hooks for extensibility.' should match the format '@todo Fix problem X here.'
     |         |     (Drupal.Commenting.TodoComment.TodoFormat)
 100 | ERROR   | [ ] Missing short description in doc comment (Drupal.Commenting.DocComment.MissingShort)
 101 | ERROR   | [ ] Description for the @return value is missing
     |         |     (Drupal.Commenting.FunctionComment.MissingReturnComment)
 139 | ERROR   | [x] Expected 1 space after FOR keyword; 0 found
     |         |     (Drupal.ControlStructures.ControlSignature.SpaceAfterKeyword)

Working on our side, ready to review

Updated branch with the last commits on 2.x and created a merge request

eduardo morales alberti → made their first commit to this issue’s fork.

We simplified the code and removed the table "xray_audit_insight", and we recalculated the external resources status on the xray audit and on the insights.

Could you provide steps to reproduce it?
We have logged the same error, but we were unable to reproduce it.

RTBC!! We tested it using the debug configuration, and now it only processes the saved translation once (not the default language). Take into account that the process entity is called from the node save, so it will take as reference the language of the saved node, not the default translation.

The current maintainer is not working with Drupal anymore, so it is possible that we will not get any response.

We uninstalled the module and replaced the configuration.

Steps to it:

• Create a new content display with the same configuration as content_browser display, we called it entity_browser.
• On views, replace content browser field, by a render field using the new entity_browser display.
• Replace any custom styling or twig from content_browser to entity_browser, example node--content-browser.html.twig => node--entity-browser.html.twig
• Once it is replaced, uninstall the module and check if any configuration needs to be recovered (it should not, as we removed all dependencies of content_browser from views and node display)

When the module is uninstalled it will remove the views with the content_browser field, and the entity_browsers with those views, so it is important to replace the field before uninstall it, also it will remove the content_browser display, that's why we created a new one with the same config.

@stefan.korn on Issue 🐛 Function file_validate_image_resolution is deprecated in drupal:10.2.0 and is removed from drupal:11.0.0. Active you have a more complete solution compatible with Drupal 10 and 11.

We created a new module to remove the EXIF information, but just because some images save geolocation about where it was taken and device information, but is optional and not related to exif_orientation, it is just to give an option to strip the information without losing the rotation.

There are more vulnerable packages https://www.drupal.org/project/gin/issues/3529722 🐛 Update Vulnerable npm Packages Active

+ ddev exec COLUMNS=200 cd web/themes/contrib/gin; npm audit

[31mFailed to execute command `COLUMNS=200 cd web/themes/contrib/gin; npm audit`: exit status 1[0m
# npm audit report

@babel/helpers  <7.26.10
Severity: moderate
Babel has inefficient RegExp complexity in generated code with .replace when transpiling named capturing groups - https://github.com/advisories/GHSA-968p-4wvh-cqc8
fix available via `npm audit fix`
node_modules/@babel/helpers

@babel/runtime  <7.26.10
Severity: moderate
Babel has inefficient RegExp complexity in generated code with .replace when transpiling named capturing groups - https://github.com/advisories/GHSA-968p-4wvh-cqc8
fix available via `npm audit fix`
node_modules/@babel/runtime

brace-expansion  2.0.1 - 4.0.0
brace-expansion Regular Expression Denial of Service vulnerability - https://github.com/advisories/GHSA-v6h2-p8h4-qcjw
fix available via `npm audit fix`
node_modules/svg-spritemap-webpack-plugin/node_modules/brace-expansion
  minimatch  5.0.0 - 9.0.5 || >=10.0.1
  Depends on vulnerable versions of brace-expansion
  node_modules/svg-spritemap-webpack-plugin/node_modules/minimatch
    glob  8.0.1 - 10.4.5
    Depends on vulnerable versions of minimatch
    node_modules/svg-spritemap-webpack-plugin/node_modules/glob
      svg-spritemap-webpack-plugin  >=4.4.1
      Depends on vulnerable versions of glob
      node_modules/svg-spritemap-webpack-plugin

cross-spawn  <6.0.6 || >=7.0.0 <7.0.5
Severity: high
Regular Expression Denial of Service (ReDoS) in cross-spawn - https://github.com/advisories/GHSA-3xgq-45jj-v275
Regular Expression Denial of Service (ReDoS) in cross-spawn - https://github.com/advisories/GHSA-3xgq-45jj-v275
fix available via `npm audit fix`
node_modules/cross-spawn
node_modules/webpack-cli/node_modules/cross-spawn

elliptic  <=6.6.0
Severity: critical
Valid ECDSA signatures erroneously rejected in Elliptic - https://github.com/advisories/GHSA-fc9h-whq2-v747
Elliptic's private key extraction in ECDSA upon signing a malformed input (e.g. a string) - https://github.com/advisories/GHSA-vjh7-7g9h-fjfh
fix available via `npm audit fix`
node_modules/elliptic

nanoid  <3.3.8
Severity: moderate
Predictable results in nanoid generation when given non-integer values - https://github.com/advisories/GHSA-mwcw-c2x4-8c55
fix available via `npm audit fix`
node_modules/nanoid

postcss  <=8.4.30
Severity: moderate
Regular Expression Denial of Service in postcss - https://github.com/advisories/GHSA-566m-qj78-rww5
PostCSS line return parsing error - https://github.com/advisories/GHSA-7fh5-64p2-3v2j
No fix available
node_modules/postcss-perfectionist/node_modules/postcss
node_modules/postcss-scss/node_modules/postcss
  postcss-perfectionist  *
  Depends on vulnerable versions of postcss
  Depends on vulnerable versions of postcss-scss
  node_modules/postcss-perfectionist
  postcss-scss  <=1.0.6
  Depends on vulnerable versions of postcss
  node_modules/postcss-scss

12 vulnerabilities (4 low, 6 moderate, 1 high, 1 critical)

To address issues that do not require attention, run:
  npm audit fix

Duplicated of https://www.drupal.org/project/gin/issues/3529723 🐛 Update Vulnerable npm Packages Active

eduardo morales alberti → created an issue.

eduardo morales alberti → created an issue.

Hi!
Any news on this issue?
We had the same problem on our Drupal with duplicated users

@sdhruvi5142 We are not sure if the test failed because the reCAPTCHA is for testing purposes on your video.

It is possible that is an error related to the static analysis from https://www.drupal.org/project/paragraphs/issues/3492718 🐛 Call to deprecated method loadRevision() of class Drupal\Core\Entity\EntityStorageInterface errors Active

eduardo morales alberti → created an issue.

eduardo morales alberti → created an issue.

Removed Drupal 9 support and added Drupal 11 to the .info

Added context, and once on recatcha validation.

@mahde could you confirm that it solves your issue?

eduardo morales alberti → created an issue.

We sent him an email, let's wait

tunic → credited eduardo morales alberti → .

Site structure

Menus: /en/admin/reports/xray-audit/site-structure/menu

We changed the view to show all menus on the same table to make it easy to download.

@lpeidro
We changed to tabs Entities Displays, as they were different operations, and to maintain the standard of one operation and a download button per page.

Example of report CSV download:

Added download button on almost all reports, except XrayAuditQueryTaskImageStylesPlugin as the current data structure was too difficult to adapt.

ZipArchiver does not works properly on Drupal 9.5, needs patch from issue https://www.drupal.org/project/drupal/issues/2850794 🐛 Unable to open Zip archive using ArchiverZip Fixed

smustgrave → credited eduardo morales alberti → .

eduardo morales alberti → created an issue.

We had the same problem with CloudFlare as it sorts the parameters and leads on the oembed items not loading.
The change solves it.
We added a hook update to clear the caches, because the hook post update only is launched if there is any update pending to be executed.

eduardo morales alberti → made their first commit to this issue’s fork.

Added target types configuration:

Ready to review

Remove internal links as already have a section on targets.
Move external links to targets.
Add schemas like mail, tel.. to targets => Other.
Add sections on targets:
Entities
Views
Others/Schema
...

eduardo morales alberti → created an issue.

Fixed!

Duplicated https://www.drupal.org/project/entity_mesh/issues/3518164 ✨ Allow choose the entity type and bundle from configuration Active

eduardo morales alberti → created an issue.

Added new configuration to choose which content will be processed

Ready to review

@himanshu_jhaloya The patch does not works because the validation is done before the method removeUtilityClassValue is called, so the form state already have required issues.

Also, cover removeUtility button.

Ready to review

eduardo morales alberti → created an issue.

The problems is solved by clicking on "Check manually", so the projects that have been uninstalled can be ignored.

https://www.drupal.org/project/drupal/issues/3270052#comment-14628951 🐛 Undefined array key in prepareUpdateData Active

Maybe the patch should also removed the uninstalled projects if were removed.

Same problem here https://www.drupal.org/project/drupal/issues/3270052#comment-16089374 🐛 Undefined array key in prepareUpdateData Active

In our case seems like the "locale.translation_status" has modules that were removed from the project but not from the key:

 
$status = \Drupal::keyValue('locale.translation_status')->getAll();
 
$module_handler = \Drupal::service('module_handler');
$module_handler->loadInclude('locale', 'inc', 'locale.compare');
$modules = \Drupal::service('extension.list.module')->getList();
$themes = \Drupal::service('extension.list.theme')->getList();
$project_list = array_merge($modules, $themes);
print_r(array_diff(array_keys($status), array_keys($project_list)));

Those modules were already removed from Drupal:

Array
(
    [0] => acquia_connector
    [1] => acquia_search
    [3] => addtoany
    [5] => advagg
    [9] => blazy
    [12] => colorbox
    [13] => colorbox_media_video
    [15] => config_filter
    [18] => config_update
    [19] => consumers
    [27] => email_registration
    [56] => jquery_ui_datepicker
    [58] => jsonapi_earlyrendering_workaround
    [59] => jsonapi_extras
    [64] => maillog
    [69] => memcache
    [74] => migrate_plus
    [107] => simple_oauth
    [115] => transliterate_filenames
)

We made some changes, including adding an OperationTimeCompressingHandler, to compress the logs, as they can be heavy on large sites.

We maintained the following list as the following attributes were not on the module:

spacing
spacing-y
spacing-x
headings
font-size
font-family

• text-align
  • left
  • right
  • center
• color
  • primary
  • secondary
• background-color
  • primary
  • secondary
• btn
  • primary
  • secondary
  • success
  • info
  • warning
  • danger
• btn-size
  • large
  • small

On the custom theme option we will keep only the following utilities as a base:

buttons
badge
text-align
text-color
bg-color
spacing
spacing-y
spacing-x
headings
font-size
font-family

Currently, the log entities are saved on a file archived_entity-YY-MM-DD.csv, but the date is when the file was created, and then, it does not match with the entity_logs, change the rotating file handler to use the entity logs dates.

Duplicated of https://www.drupal.org/project/log_entity_operations/issues/3520644 ✨ Add the hability to recover removed entity log operations Active

eduardo morales alberti → created an issue.

eduardo morales alberti → created an issue.

eduardo morales alberti → created an issue.

@luke.leber We are not sure how to contribute a test for it, as we are removing the attribute id, so we can not test that the id is duplicated, as it does not exist.

Do you refer to creating a test of the current code, testing the ID duplication?

Ready to review

eduardo morales alberti → created an issue.