- Issue created by @eduardo morales alberti
- πͺπΈSpain eduardo morales alberti Spain, πͺπΊ
Added new configuration to choose which content will be processed
- @eduardo-morales-alberti opened merge request.
- πͺπΈSpain eduardo morales alberti Spain, πͺπΊ
Remove internal links as already have a section on targets.
Move external links to targets.
Add schemas like mail, tel.. to targets => Other.
Add sections on targets:
Entities
Views
Others/Schema
... - πͺπΈSpain eduardo morales alberti Spain, πͺπΊ
Added target types configuration:
- πͺπΈSpain eduardo morales alberti Spain, πͺπΊ
Pending to separate on the settings form the external and internal links and the subcategories (iframe) and schemes (mailto, tel..) and then filter the targets by it.
Also, review the testing coverage. - πͺπΈSpain eduardo morales alberti Spain, πͺπΊ
Added to the settings form config entities with canonical like webforms.
- πͺπΈSpain lpeidro Madrid
I have reviewed the code, and it looks very good. I will now proceed with the QA.
One thing I noticed is that the batch processing does not take into account the configuration of the allowed bundles. Implementing this could help reduce the execution time of these processes.
For now, I donβt see it as a priority, but we could create a new task to address it in the future.
- πͺπΈSpain lpeidro Madrid
It is now working as expected. The hook_update has been corrected, as it was not setting default values for entities of type target and source. A check for enabled bundles in the module configuration has also been added during the batch process.
-
lpeidro β
committed 3936aabe on 1.x authored by
eduardo morales alberti β
Issue #3518164 by eduardo morales alberti: Allow choose the entity type...
-
lpeidro β
committed 3936aabe on 1.x authored by
eduardo morales alberti β
Automatically closed - issue fixed for 2 weeks with no activity.