- Issue created by @Juanjol
- Merge request !113Issue #3533141: Added config split detection on remove modules with basic unit tests β (Open) created by Juanjol
- πͺπΈSpain Juanjol Navarra
I've implemented a check for Config Split configurations before marking uninstalled modules for removal. The patch adds a new isModuleInConfigSplit() method that checks if a module exists in any Config Split configuration (both in complete_list and module arrays). If a module is found in a split, it's now marked for scanning instead of removal.
I've also added unit tests to ensure the functionality works correctly with and without Config Split installed.
This prevents the module from incorrectly suggesting to remove modules that are intentionally disabled in some environments but enabled in others via Config Split.
- πͺπΈSpain Juanjol Navarra
Added patch file version of the MR to allow add this in composer
- πͺπΈSpain Juanjol Navarra
I've fixed the MR by removing the logic that sends packages for scanning when they're installed via config split ignoring precious scan results. Updated MR and patch.
- ππΊHungary GΓ‘bor Hojtsy Hungary
Very complete suggestion, thanks! From my visual review, it looks fine, however I don't use config split :) Can you get anyone else review / try it? It looks like it would not have negative side effects at least, but would be good to have another set of eyes/hands on it.
- πͺπΈSpain eduardo morales alberti Spain, πͺπΊ
RTBC!!!
Before patch (shows modules only enabled on prod config split):
After the patch, it only shows the content install module (it is only installed once on a site setup to create default content and then uninstalled):