webform_submission and webform_submission_data schema don't match for sid

jrockowitz → changed the visibility of the branch 3462738-sid-schema to hidden.

Good catch!

My only concern is how the update hook handles changing the 'webform_submission_data.sid' schema when there are millions of records.

I am not seeing any warning about changing a field's schema via https://www.drupal.org/docs/drupal-apis/update-api/updating-database-sch... →

liam morland → made their first commit to this issue’s fork.

Is this really supposed to be signed? Or is it that it's an easier change to make one signed instead of making the other unsigned?

Is this really supposed to be signed? Or is it that it's an easier change to make one signed instead of making the other unsigned?

IDK, but I think the foreign sid in the webform_submission_data table should match the automatically defined sid in the webform_submission table.

Yes, they need to match for sure. Is it that Webform doesn't control the schema for table webform_submission?

Is it that Webform doesn't control the schema for table webform_submission?

As far as I understand, the webform_submission:sid column is created via the Entity API.

I think we want to use Webform SVG.

https://git.drupalcode.org/project/webform/-/blob/6.3.x/icons/000000/web...