- Issue created by @jrockowitz
- Merge request !577Issue #3493832: Allow custom data-options to added to elements JavaScript options β (Open) created by jrockowitz
- First commit to issue fork.
- π¨π¦Canada colan Toronto π¨π¦
Resolved merge conflict. Problem was that we're hacking on the file
modules/webform_toggles/js/webform_toggles.element.js
that's no longer there due to π Deprecate the use of drgullin/icheck Active . I simply removed the file. If folks are interested in making this change in Webform Deprecated β , they can dig it out of the commit. - π¨π¦Canada colan Toronto π¨π¦
Here's a Composer-friendly patch for 6.2.x, which assumes that #3452986-18: Update jquery.intl-tel-input to v23.0.10 and add option for i18n β has already been applied.
- πΊπΈUnited States jrockowitz Brooklyn, NY
People should weigh-in if this enhancement is useful.
- πΊπΈUnited States luke.leber Pennsylvania
I think the concept is useful, but sometimes the customization can't be hard-coded as data attributes, but rather rely on runtime information.
One example is for the international telephone element. See https://git.drupalcode.org/project/webform_intl_tel_national_mode/-/blob... for a somewhat heavy handed fix for how most UX problems were resolved.
Were there a client side event to tap into, it'd make things a lot easier to tweak. I would LOVE to take a holistic pass on the telephone input given how many quirks there are, and if there was more robust options handling, that'd be even easier.