Contrib.social

Delay discovery/init logic in WebformHelpManager

Open on Drupal.org →
Created on 17 November 2024, 9 months ago

Problem/Motivation

WebformHelpManager does a lot of stuff directly in __construct() (in methods called from __construct(). This is discouraged for services, as they might be initialized as dependencies to something without actually being used.

For example, this service is injected into a drush command, which are discovered very early.

Specifically, this is causing an error for us when doing a cache clear or updb going from from Drupal 10 to 11: "Route "webform.addons" does not exist.". A similar issue was also reported in #3465838-19: Drupal 11 compatibility fixes for webform → .

Steps to reproduce

Proposed resolution

Do the init when the information is requested.

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

Active

Version

6.3

Component

Code

Created by

🇨🇭Switzerland berdir Switzerland

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @berdir
  • First commit to issue fork.
  • Comment 9 months ago →
    🇺🇸United States jrockowitz Brooklyn, NY
  • Merge request !551Issue #3488049: Delay discovery/init logic in WebformHelpManager → (Merged) created by jrockowitz
  • Comment 9 months ago →
    🇨🇭Switzerland berdir Switzerland

    Looks good to me at first glance, didn't test yet, but will when I get back to D11 preparations for us.

  • Pipeline finished with Failed
    9 months ago
    Total: 2182s
    #347067
  • Pipeline finished with Success
    9 months ago
    Total: 408s
    #367928
  • Pipeline finished with Success
    8 months ago
    Total: 186s
    #372919
  • Pipeline finished with Canceled
    7 months ago
    Total: 91s
    #399188
  • Pipeline finished with Failed
    7 months ago
    Total: 183s
    #402192
  • Pipeline finished with Failed
    7 months ago
    Total: 806s
    #408405
  • Pipeline finished with Failed
    7 months ago
    Total: 439s
    #408815
  • Pipeline finished with Canceled
    7 months ago
    Total: 863s
    #408821
  • Pipeline finished with Success
    7 months ago
    Total: 862s
    #408827
  • Pipeline finished with Success
    7 months ago
    Total: 956s
    #409700
  • Pipeline finished with Success
    7 months ago
    Total: 1046s
    #409731
  • Pipeline finished with Success
    5 months ago
    Total: 210s
    #470391
  • Pipeline finished with Success
    5 months ago
    Total: 238s
    #470396
  • Pipeline finished with Success
    3 months ago
    Total: 738s
    #509649
  • Pipeline finished with Success
    3 months ago
    Total: 721s
    #509652
  • Pipeline finished with Skipped
    2 days ago
    #580035
  • Status changed to Needs review 2 days ago
  • Comment 2 days ago →
    🇺🇸United States jrockowitz Brooklyn, NY

    This feels very safe to commit AS-IS. Thanks

  • Comment 2 days ago →
    System Message
    • jrockowitz → committed 5c5f42db on 6.3.x 
      Issue #3488049 by jrockowitz, berdir: Delay discovery/init logic in...
  • Comment 1 day ago →
    🇺🇸United States jrockowitz Brooklyn, NY
  • Comment about 20 hours ago →
    System Message
    • jrockowitz → committed 5c5f42db on 6.x 
      Issue #3488049 by jrockowitz, berdir: Delay discovery/init logic in...
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024