Delay discovery/init logic in WebformHelpManager

Created on 17 November 2024, about 1 month ago

Problem/Motivation

WebformHelpManager does a lot of stuff directly in __construct() (in methods called from __construct(). This is discouraged for services, as they might be initialized as dependencies to something without actually being used.

For example, this service is injected into a drush command, which are discovered very early.

Specifically, this is causing an error for us when doing a cache clear or updb going from from Drupal 10 to 11: "Route "webform.addons" does not exist.". A similar issue was also reported in #3465838-19: Drupal 11 compatibility fixes for webform β†’ .

Steps to reproduce

Proposed resolution

Do the init when the information is requested.

Remaining tasks

User interface changes

API changes

Data model changes

πŸ“Œ Task
Status

Active

Version

6.3

Component

Code

Created by

πŸ‡¨πŸ‡­Switzerland berdir Switzerland

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.71.5 2024