- Issue created by @edmargomes
- Status changed to Needs review
about 1 year ago 2:16am 24 June 2024 - last update
about 1 year ago 536 pass - πΊπΈUnited States jrockowitz Brooklyn, NY
I am unsure that _webform_token_render_more() is the root cause because the performance issue only happens when Search API is enabled.
- π§π·Brazil edmargomes
I agree that it needs to be adjusted in the search api as well.
It's in both, as the core calls a render hook that triggers the hook in the search api, preventing the render from being called unnecessarily is important.
This render in the webform is called even if it's not on a webform page or in the webform admin. All it takes is for some module to invoke the tokens that arrive in this function.
However, in the search api, I agree that there needs to be a rule to prevent unnecessary processing. I'm still investigating how to patch it. - Merge request !696Issue #3456597: Cascading effect creates loss of performance β (Merged) created by jrockowitz
- πΊπΈUnited States jrockowitz Brooklyn, NY
I think we might want to address this issue because of the modules and custom code could trigger
webform_token_info()
and generally developers are not expectingwebform_token_info()
to render anything or trigger the theme layer.We are just adding a little defensive and optimization code.
-
jrockowitz β
committed afa51110 on 6.3.x
Issue #3456597: Cascading effect creates loss of performance
-
jrockowitz β
committed afa51110 on 6.3.x
-
jrockowitz β
committed afa51110 on 6.x
Issue #3456597: Cascading effect creates loss of performance
-
jrockowitz β
committed afa51110 on 6.x