Contrib.social

Cascading effect creates loss of performance

Open on Drupal.org →
Created on 24 June 2024, 6 days ago

Problem/Motivation

Pages, in the first cache, are taking 2 minutes to load

Steps to reproduce

Install:

  • Drupal 10
  • Metatag module
  • Tokens module
  • Webform
  • Search api

Have lots of data indexed by the search api.

Access a page without cache and that does not have the webform with the anonymous user.

When loading the page the Metatags module will invoke tokens, which will invoke the token info hook, which will call webform_token_info

This in turn calls _webform_token_render_more

which calls \Drupal::service('renderer')->renderPlain($build);
Then the Drupal renderer invokes the hook for render that triggers the search api, and since the search api is also uncached, processing takes a while.

Proposed resolution

My proposal is to put more checks here to see if the user has webform permissions, if not, enter the return ''

$theme_manager = \Drupal::service('webform.theme_manager');
  if (!$module_handler->isLoaded() || !$theme_manager->hasActiveTheme()) {
    return '';
  }

I would like the community's opinion on this solution.

🐛 Bug report
Status

Needs review

Version

6.2

Component

Code

Created by

🇧🇷Brazil edmargomes

Live updates comments and jobs are added and updated live.
  • Performance

    It affects performance. It is often combined with the Needs profiling tag.

Sign in to follow issues

Comments & Activities

  • Issue created by @edmargomes
  • Comment 6 days ago →
    🇧🇷Brazil edmargomes
  • Comment 6 days ago →
    🇧🇷Brazil edmargomes

    Proposed solution

  • Status changed to Needs review 6 days ago
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
    last update 6 days ago
    536 pass
  • Comment 6 days ago →
    🇧🇷Brazil edmargomes
  • Comment 6 days ago →
    🇺🇸United States jrockowitz Brooklyn, NY

    I am unsure that _webform_token_render_more() is the root cause because the performance issue only happens when Search API is enabled.

  • Comment 6 days ago →
    🇧🇷Brazil edmargomes

    I agree that it needs to be adjusted in the search api as well.

    It's in both, as the core calls a render hook that triggers the hook in the search api, preventing the render from being called unnecessarily is important.

    This render in the webform is called even if it's not on a webform page or in the webform admin. All it takes is for some module to invoke the tokens that arrive in this function.
    However, in the search api, I agree that there needs to be a rule to prevent unnecessary processing. I'm still investigating how to patch it.

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024