Contrib.social

Update remote_post Webform handler name & description

Open on Drupal.org →
Created on 25 April 2024, 12 months ago

Problem/Motivation

Knowing that the remote_post Webform handler exists, I wanted to do a GET request after submitting a Webform. I checked the list of Webform handlers for a similar remote_get handler, but it didn't seem to exist. I found it peculiar that this feature wasn't already available, so I decided to add it myself.

Big facepalm moment when looking at the code of the remote_post handler... It (obviously) has a configuration for the request method... 🤦.

Proposed resolution

As silly as it sounds, rename and/or update the description of the remote_post Webform handler to explicitly indicate that it supports all request methods.

📌 Task
Status

Needs review

Version

6.2

Component

Code

Created by

🇧🇪Belgium arno_vgh Antwerp

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @arno_vgh
  • Assigned to arno_vgh
  • Comment 12 months ago →
    🇧🇪Belgium arno_vgh Antwerp
  • Merge request !465Updated Remote post handler label and description → (Open) created by arno_vgh
  • Open on Drupal.org →
    Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
    last update 12 months ago
    Waiting for branch to pass
  • Status changed to Needs review 12 months ago
  • Comment 12 months ago →
    🇧🇪Belgium arno_vgh Antwerp
  • Pipeline finished with Success
    12 months ago
    Total: 2246s
    #156177
  • Comment 12 months ago →
    cilefen

    I feel “CRUD” is not safe to use as it will not be immediately understandable to a majority of users.

  • Status changed to Needs work 12 months ago
  • Comment 12 months ago →
    cilefen
  • Comment 12 months ago →
    cilefen

    Consider “remote HTTP operation” or similar.

  • Open on Drupal.org →
    Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
    last update 12 months ago
    Waiting for branch to pass
  • Comment 12 months ago →
    🇧🇪Belgium arno_vgh Antwerp

    Updated following your suggestion.
    For me the most important is to choose a name that goes beyond simply indicating a POST request.
    Better names or other toughts about this Webform handler always welcome, but let's keep this small 'issue' simple

  • Comment 12 months ago →
    🇧🇪Belgium arno_vgh Antwerp

    Updated following your suggestion.
    For me the most important is to choose a name that goes beyond simply indicating a POST request.
    Better names or other toughts about this Webform handler always welcome, but let's keep this small 'issue' simple

  • Status changed to Needs review 12 months ago
  • Comment 12 months ago →
    🇧🇪Belgium arno_vgh Antwerp
  • Pipeline finished with Success
    12 months ago
    Total: 1889s
    #156739
  • Pipeline finished with Success
    8 months ago
    Total: 196s
    #244937
  • Pipeline finished with Success
    8 months ago
    Total: 249s
    #244935
  • Pipeline finished with Success
    8 months ago
    Total: 208s
    #244955
  • Pipeline finished with Failed
    4 months ago
    Total: 7805s
    #365562
  • Pipeline finished with Failed
    4 months ago
    Total: 862s
    #365707
  • Pipeline finished with Success
    3 months ago
    Total: 832s
    #401750
  • Pipeline finished with Skipped
    3 months ago
    #401828
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024