Exception thrown when trying to submit element / wrapper attributes with invalid string

CS and Eslint violations are preexisting imho.
Asking for a (quick) review and about further tasks.

I also created a patch which can be applied on Webform 6.2.9; uploading it here if anyone is interested.

I have tested the patch and it fixes the problem for malformed YAML (e.g. "this: is: invalid: YAML").
This part is good.

When testing I've initially filled the field "Wrapper custom attributes (YAML)" with just a dummy string "BLABLABLA".
For this, the patch is not working. There is an error that is only visible in the browser's console:

TypeError: Unsupported operand types: array + string in Drupal\\webform\\Element\\WebformElementAttributes::validateWebformElementAttributes() (line 185 of modules/contrib/webform/src/Element/WebformElementAttributes.php). call_user_func_array(Array, Array) (Line: 281

Can we make this dummy proof and also display an error when a random string is filled in these fields?

Re #5,
Thank you for testing this! I also addressed the issue you found, and added it as a test case.

I'm asking for a second round review.

Created a patch on top of 6.2.x.

It works flawless! Code and tests are good.
I mark the issue as RTBC.

liam morland → made their first commit to this issue’s fork.

I appreciate all the work everyone has done to resolve this issue.

The codemirror element validates the YAML and sets an error on the attributes. Still, the problem was that the decoding in WebformElementAttributes was not checking if the attributes element had any validation errors.

Please review the new MR.

Committing my change which has test coverage and fixes the issue.

Automatically closed - issue fixed for 2 weeks with no activity.