Automated Drupal 10 compatibility fixes

The current 4.0.x branch has 7,543 errors, as reported by drupal-check.

With #17 we're down to 1,160. That's quite the improvement, but there's still a lot to go.

I ran the patch form #17 then fixed a few of the items found.
Now when running the test I am at - [ERROR] Found 1051 errors

Going to do a quick reroll of the last patch.

Rerolled.

With #22 on the current codebase we're down to 1,027 errors.

A major problem seems to be that the expects() method doesn't exist in LingotekConfigurationServiceInterface.

Making a few fixes.

More fixes.

#25 is down to 782 errors.

Fixed some more deprecated tests and module seems to be working from the surface. More tests need to be fixed

An interdiff for #28.

This is the same as #28 only it removes some lines that had been commented out instead of being removed.

With #30 we're at 737 errors.

Down to 713 errors.

The last submitted patch, 32: lingotek-n3288313-32.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

I think if we had working tests on the 4.0.x branch ( 📌 Fix test failures in 4.0.x (missing schema definition, etc) Needs work ) we'd have a better idea of what changes were actually needed to make this work.

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module → , even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.15.1, cannot fix all Drupal 10 compatibility problems.

Therefore this patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot → to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

This patch was created using these packages:

1. mglaman/phpstan-drupal: 1.1.35
2. palantirnet/drupal-rector: 0.15.1

Committing the yml file to support d10 in 4.0.x since the it doesn't get picked up by patches during automated testing

This is #32 by removing the yml file diffs since a different commit to it was made.

Updating the versions of webform and cohesion to be compatible with d10 in dev dependencies.

Adding cweagans/composer patches in extras to see if composer failures will go away.

Functional tests should hopefully now be in the clear.

The last submitted patch, 41: lingotek-n3288313-41.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

I am on D 10.1.2 with PHP 8.2 using Drupal Check. Mostly, I am seeing annotation problems, but there are also some underlying library refactoring that is having an impact. I'm attaching an update to #44 that has some of these changes. Am I heading in the right direction or have aI gone too far?

@murrow, This looks good. I am uploading the patch with some drupalCI fixes so we can run the test against drupal 10.

@npaudyal001, I've almost reached a stage where I need the tests to work in order to proceed with any confidence. That is blocked by 📌 Fix test failures in 4.0.x (missing schema definition, etc) Needs work , which seems a long way from reaching D10. Should I shift my attention to the tests in this branch and not wait on 📌 Fix test failures in 4.0.x (missing schema definition, etc) Needs work or do we continue with trying to sort out obvious issues here (underlying library changes, undefined parameters, annotations, etc) and hope that the test ticket catches up?

BTW, thanks for the drupalCI updates on cweagans. I could take a look at the PHP 8.2 build today to see what the problem is there.

@murrow, Most of the failures that you see on the recent patch was introduced by "Drupal\Core\Field\FieldStorageDefinitionListenerInterface" from the patch #46. As far as other errors, there were only 13 of them from the acquia/cohesion which I am having a hard time resolving but still working on it. I think we should focus on this issue as this is up to date and I will try and have some guys look at the test ticket to catch up.

Further updates. I'm still making my way through the code with Drupal Check.

More fixes to the unit tests suggested by drupal check. Includes rewriting tests without at() matcher and withconsecutive().

Thanks for this patch, @npaudyal001. I am almost there and should have a fresh patch coming over the next few days.

Further updates, with some Unit tests. 23 tests failing.

Removing whitespace

Thanks @murrow. I apologize for disappearing all these days. Had some health issues. Here is a patch with some more updates.

Fixing patch conflict

@murrow, I am seeing some things missing from these patches. For example, I am not seeing the class LingotekConfigurationTrait.php from patch #46 in the recent patches which seems to be causing errors. Looking more into it.

@npaudyal001 LingotekConfigurationTrait.php was a file I added and the discovered it was not needed for outside of a single file. I put the functions in the trait into that class as private functions. I'm not seeing it mentioned in the errors here:

Undoing bad "fixes". The Lingotek metadata entity doesn't use getters and setters, just raw objects. PHPStan complains about this, but you have to leave it as it is or refactor the entity itself. I tried using getters and it was a mistake. So, rolling back …

Thanks @murrow. Updating composer.json with new d10 supporting webform module. This should fix the composer failure.

@murrow, I am also seeing other changes in LingotekContentTranslationService.php and lingotek.module, where the fields are being set in a separate variable $content_metadata_entity and thus the original entity object remains unchanged. This is breaking functionalities. Were this changes made to handle PHPStan errors? We might need to roll that back too I suppose?

Reversing out $content_metadata_entity. (A conversation for another day: shouldn't the metadata entities behave like other Drupal entities – i.e., with fields instead of "entity" attributes?)

More updates...

@murrow Ignore this patch. I am testing one of the previous patches. There seems to be a lot of functionality breaking changes coming from phpstan fixes. Just trying to run the test with this patch and see whats the result.

Fixing the corrupt patch, #65. Same with this... ignore this patch

Further updates. Continuing from #64.

Further fixes on functionals.

Unit test fixes + additional updates

Further updates. Replaced some older diagnostic dumps with newer ones as drupal 10 required updated ones.

Fixing CI error

Ignoring the legacy tests that required database snapshot from older lingotek database structure.

Fixing changes related to group module and further updates

Added missing binary files and fixed some file renames.

Metatag fix

@npaudyal001, this is looking good. I will take a look into the coding standards errors now.

Further fixes...

Further coding standard fixes.. Also, if you are applying this patch please include binary option to pull the diagnostic dump file thats added for the update tests.

@npaudyal001 Do you need to update the project version control page to include the --binary option on git diff? https://www.drupal.org/project/lingotek/git-instructions →

Tablefield module is not yet compatible with php8.2, thats why its throwing errors. Other than that, with this patch we should be good. And @murrow, its probably a good idea to update that page.

@npaudyal001, I think only a maintainer has permission to update the project's version control page. Could I leave this to you, please?

@murrow, I don't see a way to update that page. It looks like thats a drupal default version control page for all modules.

There isn't any way to modify the git instructions page, you're limited to just adding a note to the project page.

I applied patch#84 and executed cache clear command. I am seeing this error,

The service "lingotek.config_subscriber" has a dependency on a non-existent service "Drupal\Core\Field\FieldStorageDefinitionListenerInterface".

Shouldn't we use, "@field_storage_definition.listener" instead of "Drupal\Core\Field\FieldStorageDefinitionListenerInterface" in lingotek.services.yml?

Fixed:
error: patch failed: tests/src/Functional/LingotekLongTextFieldImportTest.php:70
error: tests/src/Functional/LingotekLongTextFieldImportTest.php: patch does not apply

@sja112, thanks for pointing that out. Heres the updated patch.

Drupal core 9.5 still uses guzzle 6 which has deprecation issues with php 8 and >. Trying to include patches for that in composer.json file

Not very helpful! Trying to update the dependency through dupalCI custom commands.

This has been released on a new 4.1.x-dev branch and 4.1.0 official release branch. There are still drupal check errors associated with phpUnit 10 deprecations for which we will open a new issue. Thank you all!

Automatically closed - issue fixed for 2 weeks with no activity.