🇺🇸United States @galactus86

Any follow-up on this? I can't complete a D10 upgrade without this working.

Thanks!

galactus86 → created an issue.

I had some time to do some additional testing on my end. I was able to get the library to load by doing the following:

What seems to be missing is the dependency on wikimedia/composer-merge-plugin in the module's composer.json

This is my first crack at a patch to address issue.

galactus86 → created an issue.

galactus86 → created an issue.

galactus86 → made their first commit to this issue’s fork.

Agreed, I was surprised that language needed to be enabled. Having Language enabled creates a whole bunch of extra configuration files that have no other role than to be there for this module.

galactus86 → created an issue.

DamienMcKenna → credited galactus86 → .

I downloaded this MR as a patch and it works as expected! Thank you for this fix.

galactus86 → created an issue.

Hey there,

I'd be interested in stepping in to maintain this module. DamienMcKenna → pointed me to this as a good opportunity to contribute.

I also had a similar issue with the view no longer loading. But no flashing on our end.

Note to downgrade we used composer require drupal/viewsreference:2.0.0-beta4

galactus86 → created an issue.

I agree that solid label descriptions should suffice.

That said, I did open a slightly similar issue: https://www.drupal.org/project/layout_builder_styles/issues/3351372 ✨ Add custom radio button option with visual indicator Active

Perhaps there is an opportunity to collaborate on something here? I don't want to clutter the UI, but some visual indicators can be helpful.

Updated the toolbar_secondary.scss file instead so it compiles correctly and won't get over written in the future. I also removed the float as a best practice.

Patch attached for review.

While initial test works, when reviewing the code I see that the dist/.css file was changed NOT the .scss file. So next time anyone compiles the CSS this change will be lost.

I'm going to take a few minutes and update.

I had this on my list to tackle... nice work! Verified the patch works!

Following up on this... searching the issue queue I found this: https://www.drupal.org/project/layout_builder_styles/issues/3097952 ✨ Ability to add image previews for each style Postponed

These aren't necessarily the same feature request, but wanted to flag.

galactus86 → created an issue.

I ran the patch form #17 then fixed a few of the items found.
Now when running the test I am at - [ERROR] Found 1051 errors

Hello.

I just applied the patch from #17 and it seems to be working fine.

I am on Drupal core 9.5.3

galactus86 → created an issue.

Deciding on the right icon is not easy, I stuck with the pencil idea as it makes sense with the functionality. But here are some other ideas I thought I should share in case a different icons is preferred.

Attached is a patch that includes a new icon and style updates to apply.

Also a screenshot of the end result.

galactus86 → created an issue.

After further exploration of this issue, it's clear that the proposed changes should be handled in the Gin theme instead. So I am closing this one and creating a new issue over there! thanks

Hi there.

After digging into this issue some more, the issue seems to be unrelated to Quick Edit. It seems that the Edit link AND Local Tasks links displayed in the secondary toolbar are driven by Core and Admin Toolbar Extras.

So this issue title probably should be changed to reflect the issue being looked at.

Proposed changes:

• Update the icon (sprite) that Gin assigns to the Local Tasks link when it is available. To avoid confusion.

Two additional thoughts based on feedback I have received from multiple content editors:

1. Hide or change Edit text to more clearly reflect its function. I have heard some feedback from site users that the Edit link is confusing just because they expect to click it and edit the node. Since this link comes from Core and Admin_toolbar which is a very popular module we should be careful in how we handle.
2. Change the link text for Local Tasks to "Edit Page" to be more intuitive for editors. Local Tasks is not very meaningful for non-devs.

Assigning this to myself to work on.

Quick follow-up this patch is working great. So changing status to: Reviewed & Tested by Community.

Tested the patch from #7 and it works, currently on Core 9.5.2!!

I think it would be a bit overkill to add a setting just for that. Instead we can just check if the module is active and not render the link if not.

I agree it is likely overkill, plus it's not very intuitive to find that setting. But I wasn't sure how others would feel.