- Issue created by @texas_tater
- πΊπΈUnited States bkosborne New Jersey, USA
I agree, this is a bit confusing. I guess on one hand it could be useful to have it stay open like it does, but it's I think it's more likely that the user is adding just one block
- πΊπΈUnited States texas_tater Austin, TX
Agreed! Remaining open also impacts the perceived preview of visual layout by squishing things unnecessarily. It's already possible that the Preview might be slightly different from completely saving the layout, and this issue just adds another thing getting in the way.
- Merge request !7Close the Drupal off canvas dialog at the same time the LBIM modal is closed. β (Open) created by bkosborne
- Status changed to Needs review
over 1 year ago 6:04pm 15 June 2023 - πΊπΈUnited States bkosborne New Jersey, USA
Added a merge request with a 1 line fix. When the iframe modal is closed, the settings tray will also be closed. I think it's also reasonable to close the settings tray as soon as the iframe modal is opened, but that's more complicated I think. This also allows someone to close the iframe modal and make another selection from the settings tray if they want (like if they clicked the wrong thing).
I also first tried just configuring the module to have the iframe modal used for the remaining settings tray routes (choose block and choose section), but when I did that, things got a bit wacky after saving the block or section settings form. It reloaded the whole site inside the iframe.
- πΊπΈUnited States kevinquillen
I agree, after the user action is completed, the tray should close.
- πΊπΈUnited States kevinquillen
The proposed change in the MR addresses the problem.
- Status changed to RTBC
over 1 year ago 7:22pm 29 June 2023 - πΊπΈUnited States bkosborne New Jersey, USA
Setting to tested as per #7
- π¬π§United Kingdom Alina Basarabeanu
The changes from the merge request fixed the issue in Drupal Version 9.5.10 and layout_builder_iframe_modal 1.3.0.
Can this be merged into the next stable release?
Thank you - πΊπΈUnited States galactus86
I downloaded this MR as a patch and it works as expected! Thank you for this fix.
- First commit to issue fork.
- πΊπ¦Ukraine Taran2L Lviv
D10 settings tray has a different CSS ID, added it as well.
Attaching static patch file for composer patching.
-
svendecabooter β
committed 5ce5f299 on 1.0.x
Issue #3344334 by taran2l, bkosborne: Settings Tray does not close on...
-
svendecabooter β
committed 5ce5f299 on 1.0.x
- π§πͺBelgium svendecabooter Gent
Thanks for the MR & reviews. Committed now.