🇧🇪Belgium @svendecabooter

MR looks good to me.
Maybe we also need to add the 'hooks_converted' parameter for performance improvement: https://www.drupal.org/node/3490771 →

Seems like core is mostly putting all hooks together in a Hook\[MODULENAME]Hooks.php file, but I agree splitting up in logical chunks / files makes sense.

- Hook help still needs to be added as OOP hook
- All hooks need to be marked as converted, as per https://www.drupal.org/node/3490771 →

svendecabooter → created an issue.

Reverted, because module still contains a preprocess procedural hook.

svendecabooter → created an issue.

svendecabooter → created an issue.

Thanks for the MR and improvements!

svendecabooter → created an issue.

The "configuration" section of the readme should describe that the Range Input widget needs to be selected for a relevant facet, and the Range Input processor be selected, for this to work.

The help text in MR #5 does not correctly reflect this.

svendecabooter → changed the visibility of the branch 3337791-replace-readme.txt-to to hidden.

Thanks for the MR. Committed now.

Drupal 9 is no longer officially supported, and OOP hooks only work for 10.1+ anyway

I could work on this if I find some time. Currently just reporting this, without intent to immediately provide some code.

svendecabooter → created an issue.

borisson_ → credited svendecabooter → .

MR looks good.
Still to be added: Setting minimum Drupal version to 10.2

MR introduces PHPCS / PHPStan issues, which would ideally be resolved before merging.

Gave some feedback on the MR

I think it would be better to ignore the PHPStan error about the internal class usage, by ignoring it through a phpstan.neon file in the project, rather than copying over the whole PHP class from core...

Although just ignoring it might give a false sense of security, since we are overriding an internal class, that might suddenly break without BC warnings. But that should probably be covered by test scenario's.

svendecabooter → created an issue.

Thanks for the review.
Hopefully this can be merged in quickly, to unblock multilingual sites from using la_eu.

svendecabooter → made their first commit to this issue’s fork.

Thanks for the patch.
It doesn't look like UUID export will be committed to core anytime soon, but in the meantime we can already add support for people using this patches in the referenced issue.

D11 support is in the 3.x branch. Closing this issue.

Thanks for the report and fix.
We had encountered the same issue in one of our projects, and confirmed this as a solution.

svendecabooter → created an issue.

svendecabooter → created an issue.

svendecabooter → created an issue.

svendecabooter → created an issue.

Oops not relevant

svendecabooter → created an issue.

svendecabooter → created an issue.

svendecabooter → created an issue.

svendecabooter → created an issue.

svendecabooter → created an issue.

svendecabooter → created an issue.

svendecabooter → created an issue.

svendecabooter → created an issue.

svendecabooter → created an issue.

svendecabooter → created an issue.

svendecabooter → created an issue.

svendecabooter → created an issue.

svendecabooter → created an issue.

svendecabooter → created an issue.

svendecabooter → created an issue.

svendecabooter → created an issue.

svendecabooter → created an issue.

svendecabooter → created an issue.

svendecabooter → created an issue.

bramdriesen → credited svendecabooter → .

borisson_ → credited svendecabooter → .

svendecabooter → made their first commit to this issue’s fork.

Added MR + uploaded patch file for Composer-based workflows.

svendecabooter → created an issue.

bramdriesen → credited svendecabooter → .

I have added test coverage for this.
Not sure if this belongs in LoaderLanguageTest specifically, but it had all the setup logic already available, so seemed like the easiest place to add this test.

svendecabooter → created an issue.

svendecabooter → made their first commit to this issue’s fork.

bramdriesen → credited svendecabooter → .

Logic has evolved too much to fix the MR in this issue.
Closing this one in favor of 📌 Add Gitlab CI integration + fix coding standards issues Active , while giving credit to contributors in this issue.

svendecabooter → created an issue.

svendecabooter → created an issue.

svendecabooter → made their first commit to this issue’s fork.