🇧🇪Belgium @svendecabooter

borisson_ → credited svendecabooter → .

svendecabooter → made their first commit to this issue’s fork.

Added MR + uploaded patch file for Composer-based workflows.

svendecabooter → created an issue.

bramdriesen → credited svendecabooter → .

I have added test coverage for this.
Not sure if this belongs in LoaderLanguageTest specifically, but it had all the setup logic already available, so seemed like the easiest place to add this test.

svendecabooter → created an issue.

svendecabooter → made their first commit to this issue’s fork.

bramdriesen → credited svendecabooter → .

Logic has evolved too much to fix the MR in this issue.
Closing this one in favor of 📌 Add Gitlab CI integration + fix coding standards issues Active , while giving credit to contributors in this issue.

svendecabooter → created an issue.

svendecabooter → created an issue.

svendecabooter → made their first commit to this issue’s fork.

Did you update from a previous version?
If so, did you run update.php or "drush updb"?

Fixed in 📌 Drupal 11 support for 2.x Needs review

@aren33k: added 2 comments to MR review

Looks good to me.

Thanks for the followup, and sorry for the wrong permission logic.

svendecabooter → created an issue.

Class logic has been added now.

MR needs to be reworked on latest 3.0.x branch...

svendecabooter → created an issue.

svendecabooter → created an issue.

svendecabooter → created an issue.

Latest commits in 2.x have failing PHPCS jobs, so that still needs fixing.

Merge request has been updated, since the blocking issue is now resolved.
PHPCS pipeline is passing now.

svendecabooter → made their first commit to this issue’s fork.

svendecabooter → created an issue.

svendecabooter → created an issue.

bramdriesen → credited svendecabooter → .

svendecabooter → created an issue.

svendecabooter → created an issue.

Thanks for the MR. Manually updated the fix for the new OOP hook implementations

svendecabooter → created an issue.

Thanks - committed now.

This looks like a duplicate of 🐛 Modal Does not Close Automatically Active , caused by the absolute URL.
Can you report back in that ticket if the problem still persists on the latest version of this module?

Did the addition of a dialog class in ✨ Add a class to the dialog container RTBC help here in any way? Or would the patch by kpaxman still need to be applied to help resolve this issue?

This patch & MR no longer apply to the current 1.3.x state.
I have also tested on a multilingual site (with paths instead of domains configured though), and cannot reproduce the issue.
Can people who encountered this, retest with the latest version of this module, and report back if the problem still exists?

Can you check if this got resolved by the change in 🐛 Custom route to open in modal is restricted Needs review ?
That fix should also fix the issue with layout_builder_st

Thanks for the patch and rebase. Committed now.

Thanks for the patch. Committed now.

Thanks for the patch. Committed now.

Part of this is tackled in 🐛 Layout Builder translation issues Active - to fix the layout_builder_at issues currently in the project.

svendecabooter → created an issue.

Thanks for the MR & reviews.
Committed now.

I can confirm this issue, and the added patch fixes it. Committed now.

svendecabooter → created an issue.

Merge request contains all necessary fixes to satisfy PHPCS & PHPStan checks + a Gitlab pipeline to check those.
I have not changed the Javascript / CSS code, as I'm not familiar enough with it. I propose this can be tackled in a separate issue.

svendecabooter → created an issue.

g4mbini → credited svendecabooter → .

Looks good.
Can you address the deprecation issue as well, as mentioned in the PHPStan pipeline?
https://git.drupalcode.org/issue/iban_field-3509169/-/jobs/4487150

esmoves → credited svendecabooter → .

Patch file attached for composer-based workflows.

svendecabooter → created an issue.

Thanks, no worries. Hope you enjoyed your holidays :)

g4mbini → credited svendecabooter → .

Thanks for your work!
Looks good - merged now.

Merged and tagged new release.