- Issue created by @kensae
- 🇯🇴Jordan Rajab Natshah Jordan
This method will be nice, + no custom styling
It will be icon manipulation, not styling overrides.Thanks, Kenzie, I tested your method with other toolbar icons.
- 🇯🇴Jordan Rajab Natshah Jordan
Tested, it is working well.
Attached a static
navigation_extra_tools--2025-07-10--3532284--mr-28.patch
file, to this point of MR28.
To be used with Composer Patches and Drupal ~11.2.0 - 🇮🇪Ireland lostcarpark
Thank you both for working on this. I'll do some final checks and merge.
- 🇫🇷France Grimreaper France 🇫🇷
Hi,
Thanks for the MR and patch.
Confirm it works!
- 🇧🇪Belgium svendecabooter Gent
Tested patch as well, and works like a charm.
- 🇪🇸Spain plopesc Valladolid
Can confirm that it works like a charm for us as well! :)
Woul be great to have it merged and included in a future release of this useful module.
- 🇮🇪Ireland lostcarpark
I've been fixing up the tests as the classes have changed due to the new icon API way of doing things.
Unfortunately there seems to be a general issue with PHPUnit 11.5.29, affecting many projects (see 🐛 PHPUnit job hangs as of update to PHPUnit 11.5.29 Active ), causing PHPUnit to hang and eventually time out. I have temporarily set the maximum version to 11.5.28 in Dev dependencies, which allows tests to pass. I don't want to merge this, so will need to wait for a fix for that issue.
Also seeing an issue with PHPStan on previous major due to hook attributes. I'm sure this was passing before so looking into the cause.
Setting to needs work for the moment, till I figure out the PHPStan issue, but also blocked by the PHPUnit issue.
- 🇮🇪Ireland lostcarpark
PHPUnit now locked to 11.5.28 for GitLabCI.
Also, thanks to @jurgenhaas for showing me how to correct the PHPStan error. I added
@phpstan-ignore-next-line
to the comment above the attribute.Moving back to Needs Review. Would be greatful if someone could review my changes.
- 🇫🇷France Grimreaper France 🇫🇷
Hi,
I put 2 comments on changes related to project_browser.
-
lostcarpark →
committed 2b19835d on 1.3.x authored by
kensae →
Resolve #3532284 "Use icon api"
-
lostcarpark →
committed 2b19835d on 1.3.x authored by
kensae →
- 🇮🇪Ireland lostcarpark
Thanks for working on this, and thanks everyone for testing.
Merged into 1.3 branch. Will try to get a 1.3 release out later this week, but seeing what else can be included.
- Status changed to Fixed
6 days ago 12:04am 26 August 2025 Automatically closed - issue fixed for 2 weeks with no activity.