@pdureau, your opinion?
Trying to reorder attachments for readibility.
Here are screenshots of different combinations:
- Claro vs Bootstrap
- In Bootstrap, gap or no gap (because flex remove empty space at end)
- current vs em vs sup vs mark vs code
Thanks!
grimreaper → created an issue.
use code or sup
grimreaper → created an issue.
Hi,
Not tested but reviewed. Ok for me. Was about to RTBC when I put 2 nitpicks comments for description.
@pdureau your opinion?
MR rebased.
Hello,
I made some dichotomy to isolate the problematic configuration. by deleting all core.entity_view_display.* config and then reputting it one by one until failure during installation.
So when I list problematic config, it is when one of this config is present I have the bug.
With the following config:
- config/install/core.entity_view_display.block_content.accordion.default.yml
- config/install/core.entity_view_display.block_content.carousel.default.yml
- config/install/core.entity_view_display.block_content.list_group.default.yml
- config/install/core.entity_view_display.block_content.news_carousel.default.yml
- config/install/core.entity_view_display.block_content.progress_bar.default.yml
- config/install/core.entity_view_display.block_content.reference.default.yml
- config/install/core.entity_view_display.block_content.references.default.yml
- config/install/core.entity_view_display.block_content.references_media.default.yml
- config/install/core.entity_view_display.media.document.default.yml
- config/install/core.entity_view_display.media.link.default.yml
Failure after install_import_translations during install_configure_form:
[error] InvalidArgumentException: Field user_picture is unknown. in Drupal\Core\Entity\ContentEntityBase->getTranslatedField() (line 616 of /project/app/core/lib/Drupal/Core/Entity/ContentEntityBase.php).
With the following config:
- config/install/core.entity_view_display.block_content.blockquote.left.yml
Failure after install_profile_themes during install_install_profile:
The 'entity:block_content' context is required and not present.
With the following config:
- config/install/core.entity_view_display.node.blog_post.teaser.yml
- config/install/core.entity_view_display.node.job_offer.teaser.yml
- config/install/core.entity_view_display.node.page.teaser.yml
- config/install/core.entity_view_display.node.product.teaser.yml
Failure after install_profile_themes during install_install_profile:
[error] TypeError: Drupal\ui_patterns_field_formatters\Plugin\UiPatterns\Source\FieldFormatterSource::createInstanceFormatter(): Argument #2 ($field_definition) must be of type Drupal\Core\Field\FieldDefinitionInterface, null given, called in /project/app/modules/contrib/ui_patterns/modules/ui_patterns_field_formatters/src/Plugin/UiPatterns/Source/FieldFormatterSource.php on line 450 in Drupal\ui_patterns_field_formatters\Plugin\UiPatterns\Source\FieldFormatterSource->createInstanceFormatter() (line 328 of /project/app/modules/contrib/ui_patterns/modules/ui_patterns_field_formatters/src/Plugin/UiPatterns/Source/FieldFormatterSource.php) #0 /project/app/modules/contrib/ui_patterns/modules/ui_patterns_field_formatters/src/Plugin/UiPatterns/Source/FieldFormatterSource.php(450): Drupal\ui_patterns_field_formatters\Plugin\UiPatterns\Source\FieldFormatterSource->createInstanceFormatter('text_default', NULL)
#1 /project/app/core/lib/Drupal/Core/Plugin/PluginDependencyTrait.php(71): Drupal\ui_patterns_field_formatters\Plugin\UiPatterns\Source\FieldFormatterSource->calculateDependencies()
#2 /project/app/modules/contrib/ui_patterns/src/Plugin/UiPatterns/Source/DerivableContextSourceBase.php(472): Drupal\ui_patterns\SourcePluginBase->getPluginDependencies(Object(Drupal\ui_patterns_field_formatters\Plugin\UiPatterns\Source\FieldFormatterSource))
#3 /project/app/modules/contrib/ui_patterns/src/Element/ComponentElementBuilder.php(278): Drupal\ui_patterns\Plugin\UiPatterns\Source\DerivableContextSourceBase->calculateDependencies()
#4 /project/app/modules/contrib/ui_patterns/src/Element/ComponentElementBuilder.php(224): Drupal\ui_patterns\Element\ComponentElementBuilder->calculateComponentDependenciesSlots(Object(Drupal\Core\Plugin\Component), Array, Array)
#5 /project/app/modules/contrib/ui_patterns/src/Form/ComponentFormBuilderTrait.php(234): Drupal\ui_patterns\Element\ComponentElementBuilder->calculateComponentDependencies('ui_suite_bootst...', Array, Array)
#6 /project/app/modules/contrib/ui_patterns/modules/ui_patterns_blocks/src/Plugin/Block/ComponentBlock.php(91): Drupal\ui_patterns_blocks\Plugin\Block\ComponentBlock->calculateComponentDependencies('ui_suite_bootst...', Array)
#7 /project/app/core/lib/Drupal/Core/Plugin/PluginDependencyTrait.php(71): Drupal\ui_patterns_blocks\Plugin\Block\ComponentBlock->calculateDependencies()
#8 /project/app/core/lib/Drupal/Core/Plugin/PluginDependencyTrait.php(89): Drupal\Core\Config\Entity\ConfigEntityBase->getPluginDependencies(Object(Drupal\ui_patterns_blocks\Plugin\Block\EntityComponentBlock))
#9 /project/app/core/modules/layout_builder/src/Entity/LayoutBuilderEntityViewDisplay.php(380): Drupal\Core\Config\Entity\ConfigEntityBase->calculatePluginDependencies(Object(Drupal\ui_patterns_blocks\Plugin\Block\EntityComponentBlock))
#10 /project/app/core/lib/Drupal/Core/Config/Entity/ConfigEntityBase.php(328): Drupal\layout_builder\Entity\LayoutBuilderEntityViewDisplay->calculateDependencies()
#11 /project/app/core/lib/Drupal/Core/Entity/EntityDisplayBase.php(272): Drupal\Core\Config\Entity\ConfigEntityBase->preSave(Object(Drupal\layout_builder\Entity\LayoutBuilderEntityViewDisplayStorage))
#12 /project/app/core/modules/layout_builder/src/Entity/LayoutBuilderEntityViewDisplay.php(140): Drupal\Core\Entity\EntityDisplayBase->preSave(Object(Drupal\layout_builder\Entity\LayoutBuilderEntityViewDisplayStorage))
#13 /project/app/core/lib/Drupal/Core/Entity/EntityStorageBase.php(528): Drupal\layout_builder\Entity\LayoutBuilderEntityViewDisplay->preSave(Object(Drupal\layout_builder\Entity\LayoutBuilderEntityViewDisplayStorage))
#14 /project/app/core/lib/Drupal/Core/Entity/EntityStorageBase.php(483): Drupal\Core\Entity\EntityStorageBase->doPreSave(Object(Drupal\layout_builder\Entity\LayoutBuilderEntityViewDisplay))
#15 /project/app/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php(257): Drupal\Core\Entity\EntityStorageBase->save(Object(Drupal\layout_builder\Entity\LayoutBuilderEntityViewDisplay))
#16 /project/app/core/lib/Drupal/Core/Entity/EntityBase.php(354): Drupal\Core\Config\Entity\ConfigEntityStorage->save(Object(Drupal\layout_builder\Entity\LayoutBuilderEntityViewDisplay))
#17 /project/app/core/lib/Drupal/Core/Config/Entity/ConfigEntityBase.php(617): Drupal\Core\Entity\EntityBase->save()
#18 /project/app/core/modules/layout_builder/src/Entity/LayoutBuilderEntityViewDisplay.php(166): Drupal\Core\Config\Entity\ConfigEntityBase->save()
#19 /project/app/core/lib/Drupal/Core/Config/ConfigInstaller.php(389): Drupal\layout_builder\Entity\LayoutBuilderEntityViewDisplay->save()
#20 /project/app/core/lib/Drupal/Core/Config/ConfigInstaller.php(149): Drupal\Core\Config\ConfigInstaller->createConfiguration('', Array)
#21 /project/app/core/lib/Drupal/Core/ProxyClass/Config/ConfigInstaller.php(75): Drupal\Core\Config\ConfigInstaller->installDefaultConfig('module', 'sobki_profile_b...')
#22 /project/app/core/lib/Drupal/Core/Extension/ModuleInstaller.php(326): Drupal\Core\ProxyClass\Config\ConfigInstaller->installDefaultConfig('module', 'sobki_profile_b...')
#23 /project/app/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php(83): Drupal\Core\Extension\ModuleInstaller->install(Array, false)
#24 /project/app/core/includes/install.core.inc(1677): Drupal\Core\ProxyClass\Extension\ModuleInstaller->install(Array, false)
#25 /project/app/core/includes/install.core.inc(695): install_install_profile(Array)
#26 /project/app/core/includes/install.core.inc(572): install_run_task(Array, Array)
#27 /project/app/core/includes/install.core.inc(121): install_run_tasks(Array, Array)
#28 /project/vendor/drush/drush/includes/drush.inc(69): install_drupal(Object(Composer\Autoload\ClassLoader), Array, Array)
#29 /project/vendor/drush/drush/includes/drush.inc(53): drush_call_user_func_array('install_drupal', Array)
#30 /project/vendor/drush/drush/src/Commands/core/SiteInstallCommands.php(170): drush_op('install_drupal', Object(Composer\Autoload\ClassLoader), Array, Array)
#31 [internal function]: Drush\Commands\core\SiteInstallCommands->install('sobki_profile_b...', Array)
#32 /project/vendor/consolidation/annotated-command/src/CommandProcessor.php(276): call_user_func_array(Array, Array)
#33 /project/vendor/consolidation/annotated-command/src/CommandProcessor.php(212): Consolidation\AnnotatedCommand\CommandProcessor->runCommandCallback(Array, Object(Consolidation\AnnotatedCommand\CommandData))
#34 /project/vendor/consolidation/annotated-command/src/CommandProcessor.php(175): Consolidation\AnnotatedCommand\CommandProcessor->validateRunAndAlter(Array, Array, Object(Consolidation\AnnotatedCommand\CommandData))
#35 /project/vendor/consolidation/annotated-command/src/AnnotatedCommand.php(387): Consolidation\AnnotatedCommand\CommandProcessor->process(Object(Symfony\Component\Console\Output\ConsoleOutput), Array, Array, Object(Consolidation\AnnotatedCommand\CommandData))
#36 /project/vendor/symfony/console/Command/Command.php(326): Consolidation\AnnotatedCommand\AnnotatedCommand->execute(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#37 /project/vendor/symfony/console/Application.php(1096): Symfony\Component\Console\Command\Command->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#38 /project/vendor/symfony/console/Application.php(324): Symfony\Component\Console\Application->doRunCommand(Object(Consolidation\AnnotatedCommand\AnnotatedCommand), Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#39 /project/vendor/symfony/console/Application.php(175): Symfony\Component\Console\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#40 /project/vendor/drush/drush/src/Runtime/Runtime.php(110): Symfony\Component\Console\Application->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#41 /project/vendor/drush/drush/src/Runtime/Runtime.php(40): Drush\Runtime\Runtime->doRun(Array, Object(Symfony\Component\Console\Output\ConsoleOutput))
#42 /project/vendor/drush/drush/drush.php(140): Drush\Runtime\Runtime->run(Array)
#43 /project/vendor/bin/drush.php(119): include('/project/vendor...')
#44 {main}.
Without all those problematic config, during installation even if installation is successful I have the following warnings:
...
[notice] Performed install task: install_profile_themes
[warning] The "field_block:block_content:text_media:body" block plugin was not found
[warning] The "field_block:block_content:text_media:field_media" block plugin was not found
[warning] The "field_block:block_content:text_media:body" block plugin was not found
[warning] The "field_block:block_content:text_media:field_media" block plugin was not found
[warning] The "field_block:block_content:key_number:field_number" block plugin was not found
[warning] The "field_block:block_content:key_number:field_suffix" block plugin was not found
[warning] The "field_block:block_content:key_number:body" block plugin was not found
[warning] The "field_block:block_content:key_number:field_number" block plugin was not found
[warning] The "field_block:block_content:key_number:field_suffix" block plugin was not found
[warning] The "field_block:block_content:key_number:body" block plugin was not found
[warning] The "field_block:block_content:featuring:field_media" block plugin was not found
[warning] The "field_block:block_content:featuring:field_heading" block plugin was not found
[warning] The "field_block:block_content:featuring:body" block plugin was not found
[warning] The "field_block:block_content:featuring:field_cta" block plugin was not found
[warning] The "field_block:block_content:featuring:field_media" block plugin was not found
[warning] The "field_block:block_content:featuring:field_heading" block plugin was not found
[warning] The "field_block:block_content:featuring:body" block plugin was not found
[warning] The "field_block:block_content:featuring:field_cta" block plugin was not found
[warning] The "block_content:d7b0e3ca-31a5-4697-84bc-95600bb2067a" block plugin was not found
[warning] The "field_block:taxonomy_term:tags:name" block plugin was not found
[warning] The "field_block:taxonomy_term:tags:name" block plugin was not found
[warning] The "field_block:paragraph:progress_bar:field_title" block plugin was not found
[warning] The "field_block:paragraph:progress_bar:field_title" block plugin was not found
[warning] The "field_block:paragraph:list_group_item:field_content" block plugin was not found
[warning] The "field_block:paragraph:list_group_item:field_content" block plugin was not found
[warning] The "field_block:paragraph:carousel_item:field_media" block plugin was not found
[warning] The "field_block:paragraph:carousel_item:field_caption" block plugin was not found
[warning] The "field_block:paragraph:carousel_item:field_media" block plugin was not found
[warning] The "field_block:paragraph:carousel_item:field_caption" block plugin was not found
[warning] The "field_block:paragraph:accordion_item:field_title" block plugin was not found
[warning] The "field_block:paragraph:accordion_item:field_text" block plugin was not found
[warning] The "field_block:paragraph:accordion_item:field_title" block plugin was not found
[warning] The "field_block:paragraph:accordion_item:field_text" block plugin was not found
[warning] The "field_block:block_content:blockquote:field_media" block plugin was not found
[warning] The "field_block:block_content:blockquote:field_quote" block plugin was not found
[warning] The "field_block:block_content:blockquote:field_footer" block plugin was not found
[warning] The "field_block:block_content:blockquote:field_media" block plugin was not found
[warning] The "field_block:block_content:blockquote:field_quote" block plugin was not found
[warning] The "field_block:block_content:blockquote:field_footer" block plugin was not found
[warning] The "field_block:block_content:alert:field_heading" block plugin was not found
[warning] The "field_block:block_content:alert:field_message" block plugin was not found
[warning] The "field_block:block_content:alert:field_heading" block plugin was not found
[warning] The "field_block:block_content:alert:field_message" block plugin was not found
[warning] The "field_block:node:product:title" block plugin was not found
[warning] The "field_block:node:product:body" block plugin was not found
[warning] The "field_block:node:product:field_media" block plugin was not found
[warning] The "field_block:node:product:field_featurings" block plugin was not found
[warning] The "field_block:node:product:field_related_content" block plugin was not found
[warning] The "field_block:node:product:title" block plugin was not found
[warning] The "field_block:node:product:body" block plugin was not found
[warning] The "field_block:node:product:field_media" block plugin was not found
[warning] The "field_block:node:product:field_featurings" block plugin was not found
[warning] The "field_block:node:product:field_related_content" block plugin was not found
[warning] The "field_block:node:news:field_teaser_media" block plugin was not found
[warning] The "field_block:node:news:title" block plugin was not found
[warning] The "field_block:node:news:field_teaser_text" block plugin was not found
[warning] The "field_block:node:news:created" block plugin was not found
[warning] The "field_block:node:news:field_teaser_media" block plugin was not found
[warning] The "field_block:node:news:title" block plugin was not found
[warning] The "field_block:node:news:field_teaser_text" block plugin was not found
[warning] The "field_block:node:news:created" block plugin was not found
[warning] The "field_block:node:job_offer:field_teaser_media" block plugin was not found
[warning] The "field_block:node:job_offer:title" block plugin was not found
[warning] The "field_block:node:job_offer:field_teaser_text" block plugin was not found
[warning] The "field_block:node:job_offer:created" block plugin was not found
[warning] The "field_block:node:job_offer:field_teaser_media" block plugin was not found
[warning] The "field_block:node:job_offer:title" block plugin was not found
[warning] The "field_block:node:job_offer:field_teaser_text" block plugin was not found
[warning] The "field_block:node:job_offer:created" block plugin was not found
[warning] The "field_block:node:blog_post:field_teaser_media" block plugin was not found
[warning] The "field_block:node:blog_post:title" block plugin was not found
[warning] The "field_block:node:blog_post:field_teaser_text" block plugin was not found
[warning] The "field_block:node:blog_post:field_tags" block plugin was not found
[warning] The "field_block:node:blog_post:created" block plugin was not found
[warning] The "field_block:node:blog_post:field_teaser_media" block plugin was not found
[warning] The "field_block:node:blog_post:title" block plugin was not found
[warning] The "field_block:node:blog_post:field_teaser_text" block plugin was not found
[warning] The "field_block:node:blog_post:field_tags" block plugin was not found
[warning] The "field_block:node:blog_post:created" block plugin was not found
[notice] Performed install task: install_install_profile
...
Also before encountering config bugs, I had to edit app/core/modules/image/src/Plugin/Field/FieldType/ImageItem.php:
public static function generateSampleValue(FieldDefinitionInterface $field_definition) {
return [];
Otherwise there was a fatal with the array_rand in this method.
I hope that all those elements will help the debugging.
Maybe we can figure out common points with those configs.
Waiting feedbacks before converting stylesManager::alterForm tests to the Form element tests.
Will be fixed in 📌 Evaluate if better to provide a form element Active .
Will be fixed in 📌 Evaluate if better to provide a form element Active .
Commit message.
Issue #3490142 by grimreaper, pdureau: Move styles manager form alter logic to a form element.
- do not save empty config entries
- Rework ui_styles_attributes source regarding last changes in UIP2
- Allow ui_styles_attributes source to set other attributes
- Fix ui_styles_ui_patterns config schema
@todo Create tests on the form element.
@pdureau I ask you some macro questions in MR.
MR updated.
2 remaining review points.
grimreaper → created an issue.
I tried with latest dev version of 1.0.x.
Still got the problem.
In manage display, no problem.
But when configuring a link with icon field formatter in Layout Builder, the config is corrupted.
Merged what was independent from UI Skins.
First MR rebased, so it is clearer what needs to be made generic.
Postponing until UI Skins issue is done.
So the problem is that with Daidy UI the styleheet generation ui_styles/stylesheet.css?prefix=.ui-styles-source-select-plugin takes 6 sec.
Checking mine with Bootstrap, it takes 50ms. And Bootstrap has more styles than Daisy UI.
So it highly depends on how those classes are used, how the CSS is organized.
It also made me realize that the controller response is not cached in the browser, and the payload is not optimized (removing empty lines, white space).
So, we need to:
- make the controller response cacheable (even if it should already be the case), if not possible, save the generated file in public stream wrapper.
- optimize the payload.
UI Skins issue created ✨ Theme definition: link to utility classes Active .
I will isolate generic stuff unrelated to theme selection in another MR to merge it right now.
grimreaper → created an issue.
Strange because, I quickly checked the daisyUI styles and there is like 800 lines. While UI Suite Bootstrap has like 1500 lines and I don't have slowness problem with Bootstrap with CSS aggregation disabled, and cache disabled.
Would it be the CSS file generated on the fly for preview with UI Styles widget/source?
Hi,
Thanks for your feedback.
So this happens in 2 areas, Structure > Block Layout and in blocks in Layout Builder?
Does it happens in other places with UI Styles? section config form in Layout Builder, Theme regions with ui_styles_page, etc.
In structure block layout, if you uninstall ui_styles_block, there is no more slow down?
A content entity type (node, block content, etc.):
- has a media entity reference field
- create (directly in media_library) or edit (with media_library_edit) a media
- the media has a link field with link icon widget.
The icon position "field" is not displayed.
Maybe no more needed when ✨ [2.1.x] Add views pager plugin Active will be done.
Hi,
As discussed,the problem is that then visitors will have to download a 1.1Mo file for a few icons on a page. Even if the download is only on first page, I would like to avoid that so perf tools like lighthouse will not say anything.
Perfect. Thanks!
Now 🐛 Components: check attributes props default value Active is working!
Pushed a trim to remove left space.
grimreaper → made their first commit to this issue’s fork.
So, happening not only with Metatag, but with other computed fields like path, menu_link, default_revision and customer_profiles (commerce).
Not sure if this is the proper fix, if there is a better place to act, or better to change the foreach loop directly. But at least, I don't have warnings anymore.
And for the warnings to happen, I had to use a component as a layout in my display and trigger this display. The component can be left empty of slots/props.
Closing.
Currently changed to direct buttons or select in UIP2.
We can reopen later if needed.
On my fresh install website I don't pass in app/core/lib/Drupal/Component/Plugin/Discovery/DerivativeDiscoveryDecorator.php for field property derivative.
Nope.
I have deleted my config. Resaved /admin/config/regional/content-language, so it had been recreated for simple_mega_menu and user (not for shortcut like on my other fresh install website).
Recreated with "field_type: metatag_computed" for both user and simple_mega_menu but now the warning is in the previous foreach.
foreach ($entity_type_fields_data["field_storages"] as $field_name => $field_storage_data) {
...
$base_plugin_derivative = array_merge($base_plugin_definition, [
'label' => $field_storage_data["label"],
I think I found it.
On my fresh install I had been able to get a core.base_field_override.user.user.metatag
uuid: efad82a6-6b28-4c79-9766-25a1dffadff7
langcode: en
status: true
dependencies:
module:
- metatag
- user
id: user.user.metatag
field_name: metatag
entity_type: user
bundle: user
label: 'Metatags (Hidden field for JSON support)'
description: 'The computed meta tags for the entity.'
required: false
translatable: true
default_value: { }
default_value_callback: ''
settings: { }
field_type: metatag_computed
Whereas on Sobki it looks like:
uuid: fdac8baf-39e4-4353-8669-814967182c14
langcode: en
status: true
dependencies:
module:
- user
_core:
default_config_hash: BggQQmc05YzF3dnZzbHBRHsnGQotgHAkAPzNLtewF3I
id: user.user.metatag
field_name: metatag
entity_type: user
bundle: user
label: 'Metatags (Hidden field for JSON support)'
description: 'The meta tags for the entity.'
required: false
translatable: false
default_value: { }
default_value_callback: ''
settings: { }
field_type: map
The field type is not the same.
So I guess it is a Metatag update that had not been correctly applied or a missing update in the Metatag module.
Got a clue.
It is for some specific entity_type.
Related to:
- core.base_field_override.shortcut.default.metatag
- core.base_field_override.simple_mega_menu.default.metatag
- core.base_field_override.user.user.metatag
These 3 config twice at each cache clear.
I tried to reproduce on a fresh install. See screenshot of /admin/config/regional/content-language.
But I don't know why on my fresh install, the config is saved, but when I export the config, there is no core.base_field_override.shortcut.default.metatag file.
I will try to go deeper tomorrow.
But then maybe it is legacy Metatag stuff in Sobki's config.
Hi,
Thanks for the update.
I confirm that it still fixes the issue.
Marking as RTBC.
I let you merge.
Good for me.
Thanks a lot!
RTBC.
I let you merge if you want.
Thanks!
I confirm the fix. RTBC.
I let you merge if you want.
Hello,
I confirm the fix. RTBC.
I let you merge if you want.
Thanks a lot for the feature request and the MR.
I will give a look and test.
More efficient on parsing the file and loading the icons for the backend?
Or more efficient for the visitor browsing the website?
Hi,
I put a review comment.
I have the warnings on the MR of ✨ [10.1.x] Upgrade to UIP2 Active .
But currently the installation is blocked by 🐛 Context error during installation Active , so I will try to reproduce on a standard install.
It is on the sobki_profile_bootstrap that there is a problem.
And more precisely on the MR on ✨ [10.1.x] Upgrade to UIP2 Active .
Hello :),
If you think this needs tests. Yep go for it please. You will be able to write it way faster than me :)
Thanks!
About comment 15, I found the problem in the custom code on my project.
So working on content menu links.
The first problem had been fixed by 🐛 Settings in the formater icon are not saved Active .
But the second one with icon_linkit_formatter remains.
Patch for Composer usage.
function menu_manipulator_menu_link_content_form_entity_builder($entity_type, EntityInterface $menu_link, &$form, FormStateInterface $form_state) {
// Attach extra options to Menu Link Content entity.
$menu_link_options = $menu_link->link->first()->options ?: [];
$menu_link_options['icon'] = $form_state->getValue('menu_link_icon');
This prevent saving the icon with other module like ui_icons.
Thanks!
Hi,
Drupal 7 is no more supported and Drupal 7 branches on projects had been automatically marked as unsupported and not available to download anymore.
So closing the issue.
Hi,
Drupal 7 is no more supported and Drupal 7 branches on projects had been automatically marked as unsupported and not available to download anymore.
So closing the issue.
Hi,
Drupal 7 is no more supported and Drupal 7 branches on projects had been automatically marked as unsupported and not available to download anymore.
So closing the issue.
Hi,
Drupal 7 is no more supported and Drupal 7 branches on projects had been automatically marked as unsupported and not available to download anymore.
So closing the issue.
Hi,
Drupal 7 is no more supported and Drupal 7 branches on projects had been automatically marked as unsupported and not available to download anymore.
So closing the issue.
Hi,
Drupal 7 is no more supported and Drupal 7 branches on projects had been automatically marked as unsupported and not available to download anymore.
So closing the issue.
grimreaper → created an issue.
Hi,
Replying to comment 24.
It may look like:
destination:
field:
field: ''
custom:
custom: ''
custom: ''
See https://git.drupalcode.org/project/sobki_profile_bootstrap/-/blob/10.0.x...
grimreaper → made their first commit to this issue’s fork.
grimreaper → created an issue.
grimreaper → created an issue.
Breaking change to notify.
I should also re-add default classes if Fences is not present in the preprocess_field.
Ok you fixed variant ID by the time I made my tests. :)
Pipeline is red.
I made some review comments. In some comments, I said I need to check, so they are on my side.
I have tested with ✨ [10.1.x] Upgrade to UIP2 Active . Almost there! Thanks!
2 remaining points that I got multiple times:
This one is due to my custom field formatter in Sobki, on my side then:
This one is due to my source plugin in ui_styles_ui_patterns, on my side then: