🇫🇷France @Grimreaper

grimreaper → created an issue.

Hi,

Thanks for the issue and the MR, I have the same warning when saving a commerce product with a metatag field.

MR fixed the warning.

Hi,

Encountered the same issue after updating to Commerce 3.x.

Thanks for the MR, I applied the patch from it and no more fatal error.

I got the same error.

So it seems related to 🐛 1.x brnach incompatible with commerce v3 since the Login Pane constructor is different Active

Thanks for the new release.

grimreaper → created an issue.

Postponed until testing with Display Builder.

Is it validated that we test this solution?

grimreaper → created an issue.

date - tag - article title

Hi,

I confirm the fix and RTBC on an environment without AVIF support, no more fatal error when displaying a form with an image field like /media/add/image

Thanks!

Hi,

I am encountering the same fatal error on an env without AVIF support.

On status report page, there is a warning about the missing AVIF support but this does not prevent the fatal error.

Hi,

Uploading patch from MR https://git.drupalcode.org/project/drupal/-/merge_requests/11205 for Composer usage.

Thanks everyone for the work done here.

Hi @smovs,

The problem occurs for example when using the table component with the views table presenter template.

If you are using a component "manually" or with site building it is ok.

But with a presenter template, like written in the issue summary, you can get an empty string as slot value and in this case the problem occurs.

So, to test you can create a view using the table display (not component display using the table component).

grimreaper → created an issue.

pdureau → credited grimreaper → .

grimreaper → created an issue.

Not possible until #3446080: [PP-2] Recipe Browsing UI → is done, otherwise it will be restricted to scripts only.

Also found problem during evaluation:

- ✨ Recipe Composer plugin: support wikimedia/composer-merge-plugin Active
- 💬 Unpack composer plugin impact Active

grimreaper → created an issue.

Hi,

Thanks for the quick feedbacks.

Webform also provides a composer.libraries.json: https://git.drupalcode.org/project/webform/-/blob/6.3.x/composer.librari... which I suggested in #2974114: Composer merge plugin support → long time ago to ease updates.

So for projects providing additional libraries, it can be/is useful.

the merge plugin is super complex

I agree that it can have side effects depending on your configuration and what is merged.

Why are you using it? Hopefully it is just a legacy of what Drupal used to do.

Unfortunately no ^^. It is by default in my project stack: https://gitlab.com/florenttorregrosa-drupal/docker-drupal-project/-/blob...

- to merge custom modules/profiles/themes composer.json: 1) in case I want to split dependencies into the module using it, mainly for documentation purpose in case a custom modules is extracted from the project. 2) when developing install profiles like https://www.drupal.org/project/sobki_profile_bootstrap → .
- and like mentioned above for modules with external libraries

Hi,

Sorry for the inconvenience but it working as expected.

In this case, some documentation or hook_form_alter needs to be done to avoid exposing options without effect.

It is by design because like with the block "page title" or the region "navigation collapsible" the wrapper printing attributes had been removed.

UI Suite Bootstrap templates:
- Page title block: https://git.drupalcode.org/project/ui_suite_bootstrap/-/blob/5.1.x/templ...
- Branding block: https://git.drupalcode.org/project/ui_suite_bootstrap/-/blob/5.1.x/templ...
- Navigation collapsible region: https://git.drupalcode.org/project/ui_suite_bootstrap/-/blob/5.1.x/templ...

For the region it was to be able to have flex CSS effect properly acting on the blocks in this region.

For the blocks, it was because Core itself does not provide those wrappers by default:
- Branding block: https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/syste...
- Page title: https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/syste...

Hopefully with https://www.drupal.org/project/display_builder → we will be able to have a page.html.twig completely site buildable, so no more need of region special cases, and also even less special cases of blocks.

Hi,

I have created a child issue ✨ Recipe Composer plugin: support wikimedia/composer-merge-plugin Active because the new Composer plugin is not usable on projects using wikimedia/composer-merge-plugin.

Needing feedback on what a long term solution would be.

grimreaper → created an issue.

grimreaper → created an issue.

grimreaper → created an issue.

grimreaper → created an issue.

Hi,

I am still interested in helping finishing this issue.

Any feedback please?

PHPMD fixed.

I don't think this should be done after casting the value.

I think other sources have cacheable metadata management problems.

Not sure if it is the correct solution as why cache dependency had been tried to be added on entity type and URL initially.

At least providing MR to start discussion.

grimreaper → created an issue.

I am not sure this is still needed, now that 🐛 Single Directory Components templates are not auto reloaded after change Active is merged in Core.

Hi,

Can a redirect processor implements prepareImportableEntityData method and execute it before DefaultDataProcessor so it can store needed data for a later stage execution?

g4mbini → credited grimreaper → .

Like for Bootstrap, recipes, display_builder will be done in other issues.

grimreaper → created an issue.

grimreaper → created an issue.

MR rebased and updated regarding comment 7.

MR updated.

MR updated regarding MR in UIP

For "JSON:API clients" yes, it is with basic_auth module.

But for "non JSON:API clients" we need another, persistent, authentication.

The "non JSON:API clients" are used for physical files, for public files it is ok with the URL (as they are public), but for private file system, we need to make a request being authenticated.

And the URL for the URI private://my/file.jpg will not authenticate you with basic_auth if I am not mistaken. Or if Ok with basic_auth, we need a dedicated method for other authentication plugins.

Changing to needs work, Tests in tests/src/Kernel/Source/MenuSourceTest.php should be completed I think.

Good for me.

Just wondering why existing tests are not failing on Core 11.1 without this MR.

grimreaper → created an issue.

Hi,

I wonder where it is written that SASS code would be compiled into the browser?

If you have created your subtheme you are responsible to provide the tools to compile your SASS, or you can also have a subtheme not using SASS.

I wonder if the oauth plugin should not be extracted into its own module project to have its own lifecycle.

Adding related issue 💬 Can't get oauth2 to work Active .

From memory it was needed because of the redirect of the login form submission.

Since then ✨ Use user.login.http instead of user.login Active , could be done to improve that.

grimreaper → created an issue.

Thanks @larowlan!

Indeed much simpler.

I haved test it with 📌 Define form elements from SDC Active and ✨ Add ui_patterns_field_widgets sub-module Active , POCs on those issues are still working.

So +1 for me.

No, the MR to look for for this issue is https://git.drupalcode.org/project/drupal/-/merge_requests/11866 which is green.

MR https://git.drupalcode.org/project/drupal/-/merge_requests/11345 was to test this issue and 📌 Define form elements from SDC Active as it has overlapping changes and to ensure changes in this issue will not be incompatible with the other.

Needs examples of how it should look like.

Other MR https://git.drupalcode.org/project/drupal/-/merge_requests/11345 rebased and updated.

It still works!

Hi,

Requested changes addressed.

I got a random failure on a CKE5 JS test, after retriggering the job it is ok.

I will test changes against https://git.drupalcode.org/project/drupal/-/merge_requests/11345, to check for 📌 Define form elements from SDC Active .

You can re-review in the meantime if you want.

Hi,

Thanks everyone for the reviews and feedback.

Looking at it to update MR.

Thanks :)

Thanks!

Hello,

Thanks for the merge.

Even if reported the bug and updated the MR. The original fix is from @tocab. Could it be possible to credit him please?