🇫🇷France @Grimreaper

smustgrave → credited grimreaper → .

Still some problem outside of offcanvas.

grimreaper → created an issue.

Not possible to do, because at some point it will be blocked by ckeditor5-stylesheets which can't be conditionally altered.

So changing only default colors to be Sobki ones.

grimreaper → created an issue.

grimreaper → created an issue.

Hi,

Review points addressed.

grimreaper → created an issue.

grimreaper → changed the visibility of the branch 3503645-contextual-links-use to hidden.

Thanks for the review.

Hi @vinodhini.e,

Please create a separated issue indicating in which conditions you get issues.

Also I don't see why the proposed changes in https://git.drupalcode.org/issue/ui_suite_bootstrap-3531053/-/commit/cf8... about core_version_requirement are needed.

Discussed with @nicoloye,

Sobki Bootstrap sub theme will have to declare their option in the theme settings so by choosing it, Sobki Bootstrap library alteration will not happen and sub theme will have to duplicate this logic.

grimreaper → made their first commit to this issue’s fork.

Thanks.

Results are better now, but the "input group" is not working.

grimreaper → created an issue.

Hi,

After updating to 1.1.0-beta5, I have the autocomplete results display broken in UI Suite Bootstrap.

See attached screenshots.

It is UI Icons Menu which removes the required on the link, issue created in the module issue queue.

grimreaper → created an issue.

grimreaper → made their first commit to this issue’s fork.

I forgot about empty option.

grimreaper → created an issue.

Hi,

I am not in favor to adding such logic into Entity Share.

I think Entity Share is already enough complicated and should remain only a JSON:API consumer, and alter it as less as possible.

If it needs to alter JSON:API, it should be by relying on Core API or contrib modules like JSON:API Extras.

I would prefer that such access check changes should be proposed into the different contrib modules or with a core issue/ another contrib modules for Core provided content entity types.

Hi,

What's the point of providing a SASS starterkit not supporting compilation and at the same time provide it without compiled CSS files?

The goal is to provide example of how to include the different Bootstrap's SASS files in the correct order to provide customizations. And also how to override the libraries in the info.yml

So why not provide a set of compiled CSS files based on the SCSS ones or at least provide a CSS based starterkit?

Because those compiled CSS would be for a specific Bootstrap version and would need to be recompiled and commited at each Bootstrap release.

Now in the 5.2.x branch, CDN and Bootswatch support are present, so it will drastically ease the setup for demo and evaluation.

Also, I'd suggest to give the starterkit a version to make it easier to track future updates/changes.

The starterkit version will correspond to the ui_suite_bootstrap version when packaged by drupal.org and when generating a starterkit from the Core's command, it will note from which version of the starterkit it had been generated. (or does it has changed since the last time I tried this command?)

I find UI Suite Bootstrap being the most interesting

Thanks!

Also feel free to propose improvements into the starterkits with merge request!

Hi,

I made an addition in getLayoutSettings to avoid it to fail if the layout plugin does not exist.

This is helpful in case of update like for UI Patterns 1 to UI Patterns 2 upgrade.

Attaching patch for Composer usage.

grimreaper → made their first commit to this issue’s fork.

Regarding 📌 [1.0.0-alpha2] Play nice with layout builder Active , Layout Builder is using features introduced in the conversion of hooks into OOP code like https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/layou...

#[Hook('entity_view_alter', order: Order::Last)]

So I am not sure it will be feasible with Core 10.x

With proposed changes, Display Builder override Layout Builder.

Now we need to check if Layout Builder is present to call it too or not. Because not possible to enable Layout Builder on a view display anymore.

Would it be possible to keep display_builder_devel? I think it can become quite useful to debug display builder in a buggy state, and/or prevent deadlock.

grimreaper → created an issue.

Patch for Composer usage.

Same problem When closing a media modal in Layout Builder.

For example when a block content type has a media entity reference field.

The focus it set to the top of the page.

grimreaper → made their first commit to this issue’s fork.

Patch for Composer usage for 10.5.x.

Hi,

Agreed with comment 16.

I have not dug why there is an eventListener on a CSS event but a side effect of JS listening to transitionend event is as soon as any CSS transition happens, like on Olivero put mouse hover shortcut icon or the main menu folding/unfolding when going on top of the page, it scrolls again.

I have tried to put the scroll logic into:

window.addEventListener('dialog:afterclose', (e) => {
    const $element = $(e.target);
    if (Drupal.offCanvas.isOffCanvas($element)) {

But at this moment const $target = $('.is-layout-builder-highlighted'); finds no results while there is still the highlighted block.

I will create a branch which removes the scroll.

Also another side effect of JS listening to transitionend event is as soon as any CSS transition happens, like on Olivero put mouse hover shortcut icon or the main menu folding/unfolding when going on top of the page, it scrolls again.

Hi,

Replied to review comments.

Hi,

I think it is related to 🐛 Using the Insert Media button causes the window to scroll to the bottom of the page Active .

"drupal/display_builder": "1.0.x-dev",

Inspired by https://www.drupal.org/project/entity_vdts →

To add form element on the entity view display form when Layout Builder is enabled is OK.

But we have not found yet how to take the hand on the rendering and provide a link to the Display Builder on the entity view display form.

grimreaper → made their first commit to this issue’s fork.

Tested OK.

Fixed properties order for Stylelint.

Check why the field_formatter module is still present.

I think you can change to the issue status to RTBC then ;)

grimreaper → created an issue.

It was that!

Hi,

Thanks for the reply, unfortunately I still got the fatal error.

I don't think the problem is at the root level of the file, the error message says:

This constraint can only operate on the root object being validated

Ok, I think I found the problem while writing this comment and reading multiple times the error message.

layout_builder_restrictions/config/schema/layout_builder_restrictions.schema.yml:

core.entity_view_display.*.*.*.third_party.layout_builder_restrictions:
  type: sequence
  label: 'Layout Builder Restrictions plugin configuration'
  sequence:
    type: layout_builder_restrictions.[%key]

So it is searching in layout_builder_restrictions_by_role/config/schema/layout_builder_restrictions_by_role.schema.yml:

layout_builder_restrictions.entity_view_mode_restriction_per_role:
  type: config_object

It should be a type mapping.

grimreaper → created an issue.

Uploading screenshot for before/after comparation.

Hi,

Thanks, I also encountered this issue. MR fixes it.

We encountered:

Drupal\Core\Render\Component\Exception\InvalidComponentException: [props.properties.variant.enum] There must be a minimum of 1 items in the array, 0 found in Drupal\Core\Theme\Component\ComponentValidator->validateDefinition() (line 144 of core/lib/Drupal/Core/Theme/Component/ComponentValidator.php).

In vendor/justinrainbow/json-schema/src/JsonSchema/SchemaStorage.php:

    public function resolveRef(string $ref, $resolveStack = [])
    {
        ...
        // get & process the schema
        $refSchema = $this->getSchema($fileName);
        foreach ($jsonPointer->getPropertyPaths() as $path) {

$jsonPointer->getPropertyPaths() is empty and $refSchema = $this->getSchema($fileName); get empty enum.

Removing special $ref for variant fixes the problem. Somehow no problem with other special $ref of UI Patterns 2.

Hi,

@penyakisto review comments addressed. We are available to discuss before tonight commit.

grimreaper → made their first commit to this issue’s fork.