🇫🇷France @Grimreaper

Waiting for standard CI to switch to Drupal 10.3

Grimreaper → created an issue.

No worries,

As written in the issue summary, there is something that should not work which actually work and the MR "fix" how the "mark" theme key should be used.

Fixing tests in another issue then rebasing this one.

Good catch. Thanks!

Hello,

In a file field it is possible to allow the json extension and to upload a JSON path, so I guess it is possible to extract JSON files.

The result will depend on the chosen extraction method and I don't know how performant its are to extract JSON.

Hi,

I think you should configure the menu links to be hidden for admins and on the module settings form:
- check "Administrator role bypass access check in admin context"
- uncheck "Administrator role bypass access check in front"
- uncheck "Administrator bypass"

So admins will have access check in front but not in backoffice.

I found a solution with xpath.

Also another one was:

$this->assertStringContainsString(\Drupal::VERSION, $this->getSession()->getPage()->getContent());

Gathering the tests fixes from 🐛 PHP < 8.0 compatibility RTBC

Hi,

Thanks for the bug report and workaround MR.

I don't think it is a long term solution.

I think an approach like in the https://www.drupal.org/project/field_formatter_range → module should be made/tried.

Altering image related formatters to allow to enable/disable the Gif handling and then update the current hooks to listen to an introduced property. Also, need to ensure that these altering will be available in Views fields.

if yes, an update path should also be made.

Thanks @drumm

I have tested on a Core 10.2.7 with the following patch: #2942975-255: [PP-1] Expose Layout Builder data to REST and JSON:API →

Enabling the field enhancer on both client and server sites. And enabling the "Layout builder" processor in the config import.

It is working well.

Now that a MR had been created, code review and rebase will be easier.

- Creating MR
- testing patches since the last time I did it
- updating patch

@smustgrave, no problem. I have not uploaded before because there was no difference:

Before patch:

After patch:

For the record, example in UI Suite Bootstrap starter kit: https://git.drupalcode.org/project/ui_suite_bootstrap/-/blob/5.0.x/start...

Current display is almost the same as Bootstrap 3.

Only difference, when there is help text in the field configuration and a file is uploaded. This help text is no more displayed in BS3.

Grimreaper → created an issue.

Grimreaper → created an issue.

Grimreaper → created an issue.

Styling provided in 5.0.0-alpha5, broken in 5.0.0-alpha13

Hi,

Not sure if this is the correct issue to post that.

I think it would be nice to have a mechanism which allows a module or theme to add stories to an existing component without having to redeclare the component.

Discussed with @pdureau,

The mechanism depends on region_attributes, created by template_preprocess_layout in layout_discovery module.

However, this region_attributes variable is not used in component templates. (and it does not exist if the component is not used as a layout.)

The solution would be to enforce every UI patterns component to use one attributes object by slot. But it will not possible when slots are printed without wrappers.

<div{{ attributes }}>
  <div{{ foo_attributes.addClass('foo')}}>
    {{ foo }}
  </div>
  {{ bar }}
 </div>

Also, it would not be possible to use the prop drilling from UI Styles because we do not have access to the content of the slots to inject the wrapper. (it is removed when rendering and blocks are rendered twice)

Grimreaper → created an issue.