France 🇫🇷
Account created on 18 November 2012, over 12 years ago
#

Merge Requests

More

Recent comments

🇫🇷France Grimreaper France 🇫🇷

Hi,

Thanks both of you for your replies.

Then in case I will adapt my code to only manipulate the body.

🇫🇷France Grimreaper France 🇫🇷

Thanks a lot for the followup.

I put one review comment.

🇫🇷France Grimreaper France 🇫🇷

Hi,

Changing of project as this is not UI Suite Bootstrap related.

Currently, you can define a block content type with an image field or a media field and then use it. But that's not necessarily the best way. Or use the "data from a field".

It depends on your site structure. And not sure that it is the best experience for editors to access component directly. I think it is better to prepare block types (that will use the components with fields) and so the editors only can place blocks.

🇫🇷France Grimreaper France 🇫🇷

grimreaper created an issue.

🇫🇷France Grimreaper France 🇫🇷

grimreaper created an issue.

🇫🇷France Grimreaper France 🇫🇷

grimreaper created an issue.

🇫🇷France Grimreaper France 🇫🇷

Also need to be able to handle background image on block contents by adding a media field on the block type and so view displays could use it with tokens.

🇫🇷France Grimreaper France 🇫🇷

TODO:
- refactor display processing
- Form to control which media bundle is available and with which field.
- UI Patterns attributes plugin source

🇫🇷France Grimreaper France 🇫🇷

grimreaper made their first commit to this issue’s fork.

🇫🇷France Grimreaper France 🇫🇷

MR rebased.

Here is a new patch from MR to add for projects.

Marking as postponed until Allow changing the layout of an existing section in Layout Builder UI Needs work is fixed.

🇫🇷France Grimreaper France 🇫🇷

Also remove array_pop and array_push regarding 🐛 Do not use array_pop or array_push Needs review

🇫🇷France Grimreaper France 🇫🇷

Ok, the problem is that "layout-builder__section" key does not have a weight. So if putting weight on links it appears after the section.

Allow changing the layout of an existing section in Layout Builder UI Needs work is also proposing to put links into a dedicated container so that no side effect on other stuff.

I would prefer to not act on the links so themers can alter LB element to do their own reordering. Especially if a lot of other patches on core and other contrib modules are present.

This is very side effect prone.

🇫🇷France Grimreaper France 🇫🇷

Hello,

I will reupdate this MR after finishing some cleanup on the 1.0.x branch and then creating and targeting a 2.0.x branch.

🇫🇷France Grimreaper France 🇫🇷

grimreaper created an issue.

🇫🇷France Grimreaper France 🇫🇷

Hello,

As currently the reorder links are wrapped into a container:

$sections[$key]['rearrange'] = [
            '#type' => 'container',
          ];

The hook has currently no impact so it can be removed.

I think to open another branch to get rid of this container wrapper.

If the reorder links needs to appear last (which I agree is better), then setting a weight on it will do it properly.

🇫🇷France Grimreaper France 🇫🇷
🇫🇷France Grimreaper France 🇫🇷

grimreaper created an issue.

🇫🇷France Grimreaper France 🇫🇷
🇫🇷France Grimreaper France 🇫🇷

The Section Library module JS is sensitive to the DOM structure and expected a list with ul > li > a.

🇫🇷France Grimreaper France 🇫🇷

waiting for a new USB release.

🇫🇷France Grimreaper France 🇫🇷

grimreaper made their first commit to this issue’s fork.

🇫🇷France Grimreaper France 🇫🇷

Thanks.

It is merged :)

🇫🇷France Grimreaper France 🇫🇷

Change reverted and marking as postponed until Core issue is resolved.

🇫🇷France Grimreaper France 🇫🇷

It breaks the contextual links in admin theme.

🇫🇷France Grimreaper France 🇫🇷

Hello,

Thank you, it fixed the fatal error for me!

🇫🇷France Grimreaper France 🇫🇷

grimreaper created an issue.

🇫🇷France Grimreaper France 🇫🇷

Currently the only case I see is for attributes props.

So a new source for attributes which would allow to instanciate as many other attributes sources as desired.

As there is no external dependency, I think it can be provided by UI Patterns directly.

🇫🇷France Grimreaper France 🇫🇷

I created another MR to have Support for color widget Active and Prop source to get background URL Active appliable as patch.

🇫🇷France Grimreaper France 🇫🇷

I forgot transform relative when using an image stye.

🇫🇷France Grimreaper France 🇫🇷

Hello,

Thanks @avpaderno.

As per your previous comment, here is the comment after 14 days, to remind that I am still interested and I have not received any news from the maintainer.

🇫🇷France Grimreaper France 🇫🇷

Thanks for the merge :)

🇫🇷France Grimreaper France 🇫🇷

I propose to handle everything in Support for color widget Active .

🇫🇷France Grimreaper France 🇫🇷

I have added a note on the project page.

🇫🇷France Grimreaper France 🇫🇷

Hello,

I think this is due to the dependency on ui_icons.

Which is now in beta, so minimum stability beta should be ok.

Could you please retry with minimum stability beta?

🇫🇷France Grimreaper France 🇫🇷

A wrapper is removed by a module on my test environment.

🇫🇷France Grimreaper France 🇫🇷

Uploading patch for Composer usage.

🇫🇷France Grimreaper France 🇫🇷

grimreaper made their first commit to this issue’s fork.

Production build 0.71.5 2024