🇫🇷France @Grimreaper

grimreaper → created an issue.

grimreaper → created an issue.

MR updated

Just made a quick call with @pdureau,

Let's add a normalize in StringPropType to handle those cases then call this normalize in LinksPropType.

Also use the occasion to potentially get rid of the normalizeAttributes method in LinksPropType to use directly the normalize of AttributesPropType.

MR rebased. Thanks for the CI changes. Nice to see a green pipeline.

I understand that you have your development habits.

I don't think development habits should be reflected in a repository. For example on another level, I don't put a gitignore with IDE related stuff in my repositories, I have a global .gitignore.

But that's personal.

I would say 2 things :)
- let the maintainers decide :p
- I also need a composer.json in ✨ Linkit with attributes with icon Active ;) (for the require-dev)

Can I create a minimal "recovery mode" formElement to use in this case so for the moment a minimal version can be used?

And then later it can be improved.

To avoid to have a medium size MR which will rot and then rebasing will be time consuming.

Merged.

Follow up issue for the buttons not updated 🐛 Modal buttons not updated Active .

grimreaper → created an issue.

I made a small change that fix my use case.

At least it can be used to open discussion.

Unrelated test failures.

grimreaper → created an issue.

grimreaper → created an issue.

Hi,

If there is no specific requirements that can't be done with the .info.yml file of the main module, then a composer.json file is not needed as there is one automatically generated or at least metadata are exposed by the drupal.org composer facade https://www.drupal.org/project/project_composer →

And re-reading the description, it seems that sub-modules requirements are also detected automatically.

grimreaper → created an issue.

I have created a POC, one question, then writting tests.

grimreaper → created an issue.

I have tested some cases from comment 16 and comment #3255606-9: Support Layout Builder → .

Works perfectly.

Thanks!

Here is a patch from the new MR which cumulates changes from this issue and ✨ Support Layout Builder Active .

I tried to squash the commit because not possible to apply the patch after the one from #3415791-17: Allow "Clone display" to current bundle view mode (overwrite) → .

So I will also add layout builder support on the other issue.

Hello,

I have rebased the MR and generate a patch for Composer usage.

grimreaper → made their first commit to this issue’s fork.

Hello,

I have rebased the MR and generate a patch file for Composer from latest version.

CI jobs in failure are not related to the changes in the MR.

Back to needs review.

accordion: ok
accordion_item:
- accordion-header attributes
- (button_attributes)
- (content attributes)
- accordion-body attributes
alert:
- prop heading level?
- heading attributes
badge: ok
blockquote:
- blockquote attributes?
- blockquote footer attributes?
breadcrumb: ok
button: ok
button_group: ok
button_toolbar: ok
card:
- card header: https://getbootstrap.com/docs/5.3/components/card/#mixins-utilities
- card footer: https://getbootstrap.com/docs/5.3/components/card/#mixins-utilities
- image_col_classes to convert
- content_col_classes to convert
- for horizontal variant: row attributes
card_body:
- card subtitles attributes: https://getbootstrap.com/docs/5.3/components/card/#titles-text-and-links
- card title
- card text
card_group: ok
card_overlay: same as card_body
carousel: ok
carousel_item:
- carousel caption: https://getbootstrap.com/docs/5.3/components/carousel/#captions
- image attributes?
close_button: ok
dropdown:
- dropdown-menu attributes? out of scope https://getbootstrap.com/docs/5.3/components/dropdowns/#text ?
figure:
- image attributes?
list: ok
list_group: ok
list_group_item: ok
modal:
- modal title: https://getbootstrap.com/docs/5.3/components/modal/#live-demo
- modal header?
- modal body?
- modal footer?
nav: ok
navbar: ok
navbar_nav: ok
offcanvas:
- offcanvas body: https://getbootstrap.com/docs/5.3/components/offcanvas/#placement
- offcanvas title
- offcanvas header?
pagination: ok
progress:
- rework height prop with an attributes prop?
progress_stacked: ok
spinner: ok
table: ok
table_cell: ok
table_row: ok
toast:
- toast header?
- toast body?
toast_container: ok

Hello,

I mentioned the issue in the issue summary. I had checked during a meet with Pierre.

It has been merged.

https://git.drupalcode.org/project/ui_suite_bootstrap/-/blob/5.1.x/compo...

grimreaper → created an issue.

Issue #3449390 by grimreaper, pdureau: [5.1.0] Create components for grid management.
- Implements containers, columns and gutters of Bootstrap documentation.
- Add container wrapper with attributes.
- Fix is sequence

Almost forgot to try the breakout from DSFR.

Still a sub module? or as it should be only a plugin, put it in the main module?

grimreaper → created an issue.

grimreaper → created an issue.

grimreaper → created an issue.

grimreaper → created an issue.

grimreaper → created an issue.

grimreaper → created an issue.

Thanks a lot Pierre for pushing this forward.

I have not reviewed or tested.

But before continuing in UI Styles, I would like to discuss the strategy for non-layout components.

grimreaper → created an issue.

grimreaper → created an issue.

MR updated.

Please tell me if this method to get thumbnail is ok. I didn't find a way to get it simpler.

I left 2 todos to open discussion.

When feedbacks will be ok I will update tests.

Good point

Ok for me.

Code review we made together addressed.

Ready for review.

Waiting for 📌 [2.0.0-beta5] Add new EnumSetPropType Active to test in site building before merging.

MR ready for discussion.

Impossible to fix otherwise. To avoid the escape from the renderer service, I need to use a formattable (or markup) markup object, and it is not doable in Twig.

Thanks a lot, the previous version of the MR had too few changes in my opinion, with your last push I am way more confident.

No problem for the minimum version update. I am too in favor of "once it is no more supported, it should not require a new major version".

I will merge and if new problems are found it can be fixed in follow up issues.

Workaround solution like putting the variables into a render array with markup does not work because some tags are escaped and it is not possible to list manually every possible tags:

       {
          '#markup': column_content,
        }

When printing in the presenter template the column_content variable there is no problem.

If I setup a column_content variable with {% set column_content = '<p>foo</p>' %}, no problem when passed into the component. When using the "set" on an "area" in twig, then we obtain a Twig/Markup object and not directly the generated HTML.

The problem is in app/core/lib/Drupal/Core/Render/Renderer.php::ensureMarkupIsSafe:

if (isset($elements['#plain_text'])) {
      $elements['#markup'] = Markup::create(Html::escape($elements['#plain_text']));
    }

This is where the escape comes from. But in SDC, the only place where plain_text is used is in app/core/lib/Drupal/Core/Render/Element/ComponentElement.php::generateComponentTemplate:

if (\is_scalar($slot_value)) {
        $slot_value = [
          "#plain_text" => (string) $slot_value,
        ];
      }

But when I put a breakpoint in this if statement, it is not triggered. So I wonder where the plain_text comes.

Let's merge like it.

Then when ✨ Provide the Drush command as bin Active will be done, we can refactor to use the bin directly.

To be fixed in ✨ Create patterns/components for grid management Active

To be fixed in ✨ Create patterns/components for grid management Active

I started pocing ✨ Bootstrap 5 : Layout > Columns Active and ✨ Bootstrap 5 : Layout > Gutters Active with grid_row_1.

grimreaper → created an issue.

Fixed in ✨ Create patterns/components for grid management Active

Back to active.

Find transversal way of handling breakpoints later in 🌱 Generic mechanism to handle breakpoints Active , maybe it will be for UI Suite Bootstrap 5.2.x.

Back to active.

Find transversal way of handling breakpoints later in 🌱 Generic mechanism to handle breakpoints Active , maybe it will be for UI Suite Bootstrap 5.2.x.

Back to active.

Find transversal way of handling breakpoints later in 🌱 Generic mechanism to handle breakpoints Active , maybe it will be for UI Suite Bootstrap 5.2.x.

grimreaper → created an issue.

Only one call remaining and not worth to remove because logic of merging attributes, url options, etc. would had to be duplicated otherwise.

grimreaper → created an issue.