France 🇫🇷
Account created on 18 November 2012, about 12 years ago
#

Merge Requests

More

Recent comments

🇫🇷France Grimreaper France 🇫🇷

I also have tested Layout Builder Browser.

Unfortunately instead of providing a #theme links, it wrap manually all its links into a container.

So I will handle that in another time.

🇫🇷France Grimreaper France 🇫🇷

Because in the sizes setting of the responsive image styles I used ',' and not ', '.

Maybe change separator to , and add a trim.

🇫🇷France Grimreaper France 🇫🇷

Hi,

Thanks both of you for the work done here and sorry that I not had the time to work on it.

🇫🇷France Grimreaper France 🇫🇷

Patch if projects want to get rid of deprecated options before 5.2.x.

🇫🇷France Grimreaper France 🇫🇷

Hi,

In Stylize Layout Builder Active , I would like to put some default styling for Section Library but that is not possible without the fix. Also without the fix, the styling I put for stuff not related to Section Library are broken.

🇫🇷France Grimreaper France 🇫🇷

Thanks!

I confirm that now it is ok.

🇫🇷France Grimreaper France 🇫🇷

Showed and reviewed with @pdureau.

🇫🇷France Grimreaper France 🇫🇷

Seen with @pdureau,

We found a way to adapt the icon pack template to use automatically the viewbox.

🇫🇷France Grimreaper France 🇫🇷

In UIP 2: Need to alter the LinksPropType normalization to add an HTML attribute to the links based on in_active_trail.

In USB: Change the active-link.js file to use this attribute too.
In Sobki (until extracted to a generic module): change the event subscriber to use this attribute too.

🇫🇷France Grimreaper France 🇫🇷

Patch for Composer usage.

🇫🇷France Grimreaper France 🇫🇷

Hi,

I have checked and the issue persist even with the fix of the other issue.

The fix in the other issue was on form submission.

This one is when the form is displayed.

🇫🇷France Grimreaper France 🇫🇷

Hi,

Thanks I confirm the bug fix.

🇫🇷France Grimreaper France 🇫🇷

https://git.drupalcode.org/project/sobki_profile_bootstrap/-/blob/10.0.x...

I understand for different view modes. But the problem is even for the same view mode, if changing the icon change the ratio it can't be handled.

🇫🇷France Grimreaper France 🇫🇷

As discussed with @jonathan1055, the issue and MR can be closed and re-open if needed.

🇫🇷France Grimreaper France 🇫🇷

Thanks for the details.

Ok, on Firefox I too see the errors.

These errors comes from the attributes props with the "HTML classes" source, it is the "pattern" on the textfield input.

What is strange is that with other components which all have at least the standard attributes prop there is no error. Only with card.

🇫🇷France Grimreaper France 🇫🇷

Thanks!

I know see the prop source select and token source.

So I guess I will be able to get field values, etc.
Is it normal that the "data from a field" source is not present?

🇫🇷France Grimreaper France 🇫🇷

Hi,

I have the same error when menu link content entities.

An AJAX HTTP error occurred.
HTTP Result Code: 500
Debugging information follows.
Path: /admin/structure/menu/item/25/edit?element_parents=link/widget/0/icon&destination=/admin/structure/menu/manage/footer-social-links&ajax_form=1
StatusText: error
ResponseText: 
...
The website encountered an unexpected error. Try again later.Exception: Serialization of 'Closure' is not allowed in serialize() (line 14 of core/lib/Drupal/Component/Serialization/PhpSerialize.php). Drupal\Component\Serialization\PhpSerialize::encode(Array) (Line: 129)
🇫🇷France Grimreaper France 🇫🇷

But now it show that when there is a refresh of the icon selector. The icon position is not redisplayed properly.

I guess the field name has changed due to Ajax.

Maybe it would be simpler to not put states API on the icon position.

🇫🇷France Grimreaper France 🇫🇷

I quickly check and I don't have the problem on Sobki.

With this change it till works on Sobki.

I don't know why I have this problem on my other project.

Here is a patch for the MR for Composer to unlock me on my other project.

Needs tests.

🇫🇷France Grimreaper France 🇫🇷

It is ok.

False positive.

Looks like an AJAX refresh on th elist of allowed HTML tags, did not happen correctly.

🇫🇷France Grimreaper France 🇫🇷

Hi,

Thanks for the bug report.

I tried to reproduce the bug with Layout Builder and manage display. I was not able to reproduce the bug.

Is it possible to get some screenshots or a short recording to show the error please?

Which UI Patterns version are you using?

🇫🇷France Grimreaper France 🇫🇷

Hi,

Thanks for the bug report.

I confirm that I can reproduce and that it is not related to UI Suite Bootstrap.

🇫🇷France Grimreaper France 🇫🇷

Hi,

Props properties titles and descriptions implemented as a component in UI Suite DaisyUI (e.g. /ui_suite_daisyui/components/button/button.component.yml:87) can not be translated via the User interface translation page

For me it is the same subject as #3481491-7: [2.0.0-rc1] Make components metadata translatable .

At the same time category, label, and description names in DaisyUI classes are translatable.

Because it is from UI Styles: https://git.drupalcode.org/project/ui_styles/-/blob/8.x-1.x/src/StylePlu...

🇫🇷France Grimreaper France 🇫🇷

Hum, I don't think I can access the tmp of this job as it is not in the actifact.

But thanks to you, I tried to search and I had not figured out before that Yarn console output was collapsed, so opening it I think I found why...:

command not found: npm

So I will debug my CI docker image...

Sorry for the wrong bug.

🇫🇷France Grimreaper France 🇫🇷

Hi,

In [5.1.x] Use icons Active , we would like to add a conditional dependency:

- if Core < 11.1: add ui_icons:ui_icons_backport
- else: no dependency.

So having hook_requirements in themes would have greatly helped.

And like for comment 35, having update hooks in themes in case of newly provided config would also be helpful.

I don't know if others would be ok to re-open this issue.

🇫🇷France Grimreaper France 🇫🇷

Hi,

Thanks @avpaderno !

🇫🇷France Grimreaper France 🇫🇷

Will check the todos later.

🇫🇷France Grimreaper France 🇫🇷

I put 4 questions in the MR to discuss.

🇫🇷France Grimreaper France 🇫🇷

In _cqri_build_source_attributes the $breakpoint argument is not used.

Can it be removed or is it something to implement that has been forgotten?

🇫🇷France Grimreaper France 🇫🇷

We does not check if the current theme is the front theme as it is triggered only for anonymous users so with the front theme.

🇫🇷France Grimreaper France 🇫🇷

In core app/core/modules/system/system.module:

  // Handle setting the "active" class on links by:
  // - loading the active-link library if the current user is authenticated;
  // - applying a response filter if the current user is anonymous.
  // @see \Drupal\Core\Link
  // @see \Drupal\Core\Utility\LinkGenerator::generate()
  // @see template_preprocess_links()
  // @see \Drupal\Core\EventSubscriber\ActiveLinkResponseFilter
  $page['#cache']['contexts'][] = 'user.roles:authenticated';
  if (\Drupal::currentUser()->isAuthenticated()) {
    $page['#attached']['library'][] = 'core/drupal.active-link';
  }

Not possible to override this behavior in ui_suite_bootstrap as themes can't have services. So will override in Sobki.

Production build 0.71.5 2024