🇫🇷France @Grimreaper

MR updated.

Code quality done, Tests improved.

Review comments addressed.

Unrelated nightwatch failure, I retriggered the job.

Hi,

How is configured the "password_protected" entity view display of your content type and of your product type?

If in this view mode the other fields of your content entity are shown, it is normal.

https://www.drupal.org/docs/contributed-modules/entity-access-password/p... →

Hi,

2 points.

- Git: you can edit the default commit message in Gitlab UI, When checking the "Combine (squash) commits", there is a "Edit commit message" checkbox. Mentioning that because even if I was the commit author, I am not in the commit message, that's a detail.

- I think this may had been committed too soon, maybe we should have documented the core issue and the need to apply a patch.

Dashboard:
- admin theme => ok
- dashboard module => ok
- redirection to the dashboard (via ECA)? => already handled by dashboard module
- Welcome block with the shortcuts
- https://www.drupal.org/project/dashboard →

list job offer https://www.drupal.org/files/issues/2025-05-15/article%20liste.png: →
- add taxonomy vocabulary places
- add taxonomy vocabulary job type: CDI, CDD
- add taxonomy vocabulary job type: remote, on place, hybrid
- add field on job offer
- block with 3 latest job offers
- add filter on job list page
- compact list:
- CDI - places
- title
- list:
- title
- date
- CDI
- places
- candidate link
- job offer: add text highlights and display media into card horizontal.
- layout builder browser:
- list job offer
- list blog post

Blocks:
(- padding: 2 if needed)

UI Patterns Library
- hide component structure into accordion
- display stories on the components list

block accordion:
- prepare other view mode for accordion items to have a background color
- primary:
- button has text-bg-primary
- content: text primary, bg primary subtle
- secondary:
- button has text-bg-secondary
- content: text secondary, bg secondary subtle
- allow to select on accordion level

Block alert:
- default: light
- primary:
- secondary:
- all variants
- dismissible

Test ui_patterns_field and ui_patterns_ui

Block CTA:
- remove from Layout Builder Browser

Block button:
- create from block CTA
- without icon
- plugged directly on button component

Top bar:
- layout link as Edit: app/core/modules/navigation/src/Plugin/TopBarItem/PageActions.php, columns icon
- Layout builder button on top bar
- save layout
- discard changes
- dropdown for other

Block carousel:
- carousel caption: add background color, text-bg-primary, transparency 50%, padding 2, round 2
- add link field to display as a button: button secondary
- view mode
- primary
- secondary
- View mode selector

I don't see any commit related to this issue on 1.0.x.

Has it been merged?

MR created on 🐛 Drupal\layout_builder\Entity\LayoutBuilderEntityViewDisplay class does not correspond to an entity type. Needs work

Encountered the same problem in 📌 [1.0.0-alpha2] Play nice with layout builder Active

Will create a MR from last patch. and use entity type manager service.

grimreaper → made their first commit to this issue’s fork.

  $displays = \Drupal::entityTypeManager()->getStorage('entity_view_display')->loadMultiple();

fixes the issue

I will search for an existing core issue and/or create a new one if needed.

The problem is from

function layout_builder_install(): void {
  $display_changed = FALSE;

  $displays = LayoutBuilderEntityViewDisplay::loadMultiple();

It is trying to load from the class but at this moment entity_view_display class had already been overridden by display_builder_entity_view and so EntityTypeRepository does not find "entity_view_display" from the class LayoutBuilderEntityViewDisplay.

I will try to see if changing core a little bit will help.

I also have the error, I will try to debug after a meeting.

grimreaper → created an issue.

Ok, I think this issue can be closed in favor of https://www.drupal.org/project/rift_cq →

Strange because I have added layout_builder as a dependency.

I will try to reinstall with MR applied before install.

grimreaper → created an issue.

grimreaper → created an issue.

At module activation, all blocks are automatically put in the page layout root slot

This is not what I obtain currently.

When enable display_builder_page_layout I obtain a white screen with the message "This Display builder is empty, you can edit this layout here to add content."

I would say, this will open the door to side effects and be big maintenance burden.

I would vote for no support. We want to gain performance by no more have all those preprocesses.

display_builder_entity_view_module_implements_alter preserved as it will be deleted in 📌 [1.0.0-alpha2] Play nice with layout builder Active

Hi,

I see that this issue has a commit associated.

So, is it fixed or still needs work?

Hi,

Any feedback please?

MR ready for test and discussions.

override per content was not handled or I missed that?

POC working \o/

As discussed, currently for a first compatibility, let's assume layout_builder is present and add it as a dependency so we can extend it to fallback to its behavior.

For hooks as PHP class.

Which approach do we take?

1. One class file for all hooks per module
2. One file per hook
3. One file per related hooks/logic if possible

I am for the one file per hook.

Hi,

I never used EntityWithPluginCollectionInterface before, so if it works for you, ok.

Need answer and/or discussion to finish.

I think this issue will be blocked by 🐛 Layout builder cannot recover on missing layout Needs work

Hi @smovs,

In Twig template, when we check {% if caption %} is always true because in this case, we pass a non-empty array.

Yes, and that's the purpose of this issue, we should be able to keep a simple if statement in Twig and having check as expected. We don't want an empty caption to appear.

we create a non-empty array.

That's what needs to be challenged.

Note: I can't reassign the issue to you.

Ok, thanks for the info.

Also composer.json was completed on the fly by drupal.org composer facade from the .info.yml file.

But for documentation/sync purpose that's nice!

I have created a bunch of issues to discuss some missing features.

- ✨ Remove dependency on crop modules Active
- ✨ Make image_style_quality dependency optional Active
- 💬 SVG support Active
- ✨ Support container query Active

Review and assignation to review crossed maybe :)

grimreaper → created an issue.

grimreaper → created an issue.

grimreaper → created an issue.

grimreaper → created an issue.

grimreaper → created an issue.

Found missing spots.

JS:
- assets/js/text/text.js
- assets/js/misc/tabledrag.js

Some btn-outline-dark, so I think the theme class should be made available in a drupalSettings.

src/Utility/Element.php:

// Find a class based on the value of "value", "title" or "button_type".
    if (!$class) {
      $themeClass = Bootstrap::getThemeMapping();
      $value = $this->getProperty('value', $this->getProperty('title', ''));
      /** @var string $button_type */
      $button_type = $this->getProperty('button_type', 'outline-' . $themeClass);
      $class = "{$prefix}-" . Bootstrap::cssClassFromString($value, $button ? $button_type : 'outline-' . $themeClass);
    }

src/HookHandler/PreprocessMenuLocalAction.php:

$class = Bootstrap::cssClassFromString($link['title'], 'outline-dark');

On PHP side, maybe for both, but at least for PreprocessMenuLocalAction, the problem is that it is the opposite that needs to be gathered. When in dark mode, we need outline-light.

So, more complex than a simple mode/class pair only.

And as discussed, let's see if we can handle some browser feature to indicate to the browser that this page is light or dark to leverage Browser feature.

And on styles level, think if needed to be able to indicate that some style options are related to light or dark.

grimreaper → created an issue.

To be fixed in 🐛 Front-end theme styles can bleed into Navigation Active

Hi,

I have added a font-family: inherit

Coming from https://drupal.slack.com/archives/C7AB68LJV/p1750418950750889

grimreaper → made their first commit to this issue’s fork.

grimreaper → created an issue.

Hi,

I have retested installation on Sobki with and without the proposed change, I confirm it fixes the bug.

Thanks!

Thanks for the reply.

Then in this case what is missing is an update hook for existing config and layout overrides.

Without this update, not possible to fix those config (except by editing config files or from admin) and not possible to fix layout overrides due to fatal error.

I can share some code for looping on layout overrides if needed.

https://github.com/twbs/bootstrap/issues/38024

Test done, it does not work.

https://drupal.slack.com/archives/C1BMUQ9U6/p1751445615235749

Currently there is no API in Core to handle that automatically.

So either in a first time do workarounds in ui_suite_bootstrap, or start directly with a Core issue to add support.

It was due to a missing check when there is no image in the layout builder browser block.

Hello,

I am updating on 2.0.5 on Sobki and I got the following error:

Drupal\Component\Plugin\Exception\PluginNotFoundException: The "ui_patterns:sobki_theme_bootstrap:grid_row_2" plugin does not exist. Valid plugin IDs for Drupal\Core\Layout\LayoutPluginManager are: layout_twocol_section, layout_threecol_section, layout_fourcol_section, layout_onecol, layout_twocol, layout_twocol_bricks, layout_threecol_25_50_25, layout_threecol_33_34_33, navigation_layout, layout_builder_blank, ui_patterns:ui_suite_bootstrap:accordion_item, ui_patterns:ui_suite_bootstrap:accordion, ui_patterns:ui_suite_bootstrap:button, ui_patterns:ui_suite_bootstrap:button_group, ui_patterns:ui_suite_bootstrap:button_toolbar, ui_patterns:ui_suite_bootstrap:close_button, ui_patterns:ui_suite_bootstrap:card_body, ui_patterns:ui_suite_bootstrap:card, ui_patterns:ui_suite_bootstrap:card_group, ui_patterns:ui_suite_bootstrap:card_overlay, ui_patterns:ui_suite_bootstrap:carousel_item, ui_patterns:ui_suite_bootstrap:carousel, ui_patterns:ui_suite_bootstrap:modal, ui_patterns:ui_suite_bootstrap:offcanvas, ui_patterns:ui_suite_bootstrap:dropdown, ui_patterns:sobki_theme_bootstrap:grid_row_2_33_67, ui_patterns:sobki_theme_bootstrap:grid_row_2_25_75, ui_patterns:sobki_theme_bootstrap:grid_row_2_67_33, ui_patterns:sobki_theme_bootstrap:grid_row_2_75_25, ui_patterns:sobki_theme_bootstrap:grid_row_3_50_25_25, ui_patterns:sobki_theme_bootstrap:grid_row_3_25_50_25, ui_patterns:sobki_theme_bootstrap:grid_row_3_25_25_50, ui_patterns:ui_suite_bootstrap:grid_row, ui_patterns:ui_suite_bootstrap:grid_row_1, ui_patterns:ui_suite_bootstrap:grid_row_2, ui_patterns:ui_suite_bootstrap:grid_row_3, ui_patterns:ui_suite_bootstrap:grid_row_4, ui_patterns:ui_suite_bootstrap:list_group_item, ui_patterns:ui_suite_bootstrap:list_group, ui_patterns:ui_suite_bootstrap:navbar_nav, ui_patterns:ui_suite_bootstrap:navbar, ui_patterns:ui_suite_bootstrap:breadcrumb, ui_patterns:ui_suite_bootstrap:pagination, ui_patterns:ui_suite_bootstrap:nav, ui_patterns:ui_suite_bootstrap:alert, ui_patterns:ui_suite_bootstrap:badge, ui_patterns:navigation:badge, ui_patterns:ui_suite_bootstrap:figure, ui_patterns:ui_suite_bootstrap:spinner, ui_patterns:navigation:title, ui_patterns:navigation:toolbar_button, ui_patterns:ui_suite_bootstrap:progress, ui_patterns:ui_suite_bootstrap:progress_stacked, ui_patterns:sobki_theme_bootstrap:animated_number, ui_patterns:sobki_theme_bootstrap:container, ui_patterns:sobki_theme_bootstrap:dropdown_megamenu, ui_patterns:ui_suite_bootstrap:table_cell, ui_patterns:ui_suite_bootstrap:table_row, ui_patterns:ui_suite_bootstrap:table, ui_patterns:ui_suite_bootstrap:toast, ui_patterns:ui_suite_bootstrap:toast_container, ui_patterns:ui_suite_bootstrap:blockquote, ui_patterns:ui_suite_bootstrap:list in Drupal\Core\Plugin\DefaultPluginManager->doGetDefinition() (line 53 of core/lib/Drupal/Component/Plugin/Discovery/DiscoveryTrait.php).

It seems that now components with a "replaces" key does not appear anymore in the available plugins.

Also I saw in the commit a change in the library template, should a change record be made?

grimreaper → created an issue.

MR created.

Patch for Composer usage.

Hi,

I am encountering the same error on 🐛 Unexpected error on "Manage display" page for block "Text + CTA" Active .

Core 11.2.0
PHP 8.3

Hi,

If I don't miss any, all review comments had been addressed.

So back to RTBC?

grimreaper → created an issue.

smustgrave → credited grimreaper → .

Still some problem outside of offcanvas.

grimreaper → created an issue.

Not possible to do, because at some point it will be blocked by ckeditor5-stylesheets which can't be conditionally altered.

So changing only default colors to be Sobki ones.

grimreaper → created an issue.