Dashboard icon missing from Navigation

@penyaskito, I cannot reproduce this error. I can see the dashboard icon on the Drupal CMS installation, and the dashboard module version is 2.0.0.

Attaching screenshot for reference :

I can confirm this behavior.

The issue lies with the missing data-icon-text attribute. The other menu entries use this attribute to offer a fallback, when no icon is available. Without this attribute there is not 'content' property and thus the before element is not rendered.

The toolbar-button sdc was indeed not used. I propose that it should be used.
The alternative would be to add the earlier mentioned attribute.

Sorry I didn't review this yet. I actually had a fix locally that never uploaded. Will review ASAP.

To note: even if we still want to support this for 11.1 and below, 📌 Navigation leverage icon core API Needs work landed.

Our goal should be:

- Support the (now old) toolbar.
- Support the navigation as is (11.0, 11.1), mainly because of Drupal CMS.
- Support HEAD/11.2, May/June 2025. We should use the new Icon API.

In case of conflict, we would drop support from top to bottom of that list.

PS: Just to be clear, I don't expect to add Icon API support here.

no worries. I'm good with the patch for now.

I didn't use icon api here, just the navigation sdc component.

I think the issue might be because I installed cms -> uninstalled announcement -> this automatically removed the dashboard :( -> create new dashboard with same machine name

That's definitely a critical. Created 🐛 Uninstalling a module deletes dashboards that have a block provided by that module Active to discuss if that's the right UX.

Facing the same issue After Drupal CMS 1.1.0 was released
🐛 No icon for the Dashboard link in the Navigation menu Active
Hoping for a release.

As mentioned in #7, this is a moving target.
In 📌 Navigation leverage icon core API Needs work , the plan is to a) use icon API, b) find a way to define overrides/extend navigation icon library, while still allowing themes to override it.
In the meantime I think the safest is just fake a menu and use whatever navigation menus are using. Dirty, but works, and less change to break suddenly.

It looks good!

Will probably need to be updated along the way depending on progress in other fronts.

It's great to have the icon back!

Thanks!