🇩🇪Germany @woldtwerk

woldtwerk → created an issue.

woldtwerk → changed the visibility of the branch 3479031-update-js-component to hidden.

I refactored the js component, but need to do some extra work in the service.

I'll continue this after my 8d vacation.

woldtwerk → created an issue.

Thx,
I'll try to have a look this week.
I was kinda busy recently.

woldtwerk → created an issue.

Sure we can do it.
I had some minor issues I would change beforehand.
Also I would refactor a little to be more drupal compliant.

What's the best approach to go further?
Do I create an issue in the main module to be able to create an issue fork or will you give me push access to a branch?

Also why does the regex not allow stream wrappers? It's explicitly excluded with the negative lookahead

Do you have any hints on how to run specific Tests and update the fixture data?

woldtwerk → created an issue.

I think we have 2 Issues here:
1: group key is overwritten by LibraryDiscoveryParser (commit)
2: we can't disable grouping. CssCollectionGrouper only checks for preprocess key. Thus you can't use preprocess, but opt out of grouping. (commit)

For 2 it's debatable if 0 or -1 would be preferred.
Let me know what you think

fork

woldtwerk → made their first commit to this issue’s fork.

Thanks Seth,
I'll rebase my current progress for using core/sortable on this.

The patches are not correct. It needs to be changed in 3 Files:
src/Form/MenuSettingsForm.php
src/Form/SettingsForm.php
src/Form/SkipFormSettingsForm.php

There already was an issue fork. No need for patches

woldtwerk → created an issue.

I thought I start with this one.

Makes 3392717 🌱 Replace dragula with SortableJS Active and removal of jquery easier :)

woldtwerk → created an issue.

all right. thanks

is airbnb config still the preferred config?
I always found it quite cumbersome. Had much more joy without airbnb and prettier and instead using antfu's config which includes eslint stylistic.

Hey there,
I made a little refactoring to use core/sortable. Seems to work just fine.

I'm a little confused about the es6.js stuff. how do you transpile that? There is no {composer|package}.json command.
Is it even wanted anymore? Core removed the es6.js files and just puts the es6 stuff in normal .js files.

Would appreciate some guidance for a proper merge request.
thanks.

woldtwerk → created an issue.

Thank you :)

woldtwerk → created an issue.

woldtwerk → created an issue.

woldtwerk → created an issue.

thanks for your test and quick reply. Drupal and Browser Caches have been cleared.
Maybe it was just a hiccup.

woldtwerk → created an issue.

Thank you for the patch.
I made a 1.0.2 release.

I would still be interested in the results of your investigation.
Did it work well with nuxt content?

A check wouldn't hurt, but you shouldn't use this formatter for svg's.

Mixing svg and pixel based formats in the same field is not a good idea.
Does core's responsive image support this?

Same issue.
I have one d10 install in which it works and one in which it does not work.
Couldn't figure out the difference :|

How do you want to handle the merge?
Replace your current js implementation or add mine as a separate formatter?

Hi Eric,
Thank you.
yeah we can combine them. It might as well be part of the main module for ease of use :)

There's an small issue with transparent images, I'd like to fix before that.

got the same error. plugin definitions is always an empty array.

woldtwerk → created an issue.

What do I need to do to write my own enhancer in a custom module? Specifically how do I register them?

Drupal Docs at it's finest again. You need to use $config to override it in settings.php

```php
$config['environment_indicator.indicator']['bg_color'] = '#3db5ff';
$config['environment_indicator.indicator']['fg_color'] = '#ffffff';
$config['environment_indicator.indicator']['name'] = 'Localhost';
```