- Issue created by @woldtwerk
- Status changed to Needs review
4 months ago 6:11am 14 August 2024 - 🇮🇳India sarwan_verma
Hi,
I have fixed this issue "TypedConfigManagerInterface" and also attached patch,
please review and verify,
Thanks!. - Status changed to Needs work
4 months ago 6:22am 14 August 2024 - 🇮🇳India abhiyanshu
The suggested resolution is that the $typedConfigManager variable needs to be typed. However, in the attached patch #3, I see that the TypedConfigManagerInterface class is being removed, along with the entire $typedConfigManager variable. Instead of removing it, I think we should simply add:
protected TypedConfigManagerInterface $typedConfigManager;
This way, we maintain the necessary typing without removing the functionality.
- Status changed to Needs review
4 months ago 6:51am 14 August 2024 - 🇮🇳India abhiyanshu
I have:
- Added the TypedConfigManagerInterface import.
- Added the TypedConfigManagerInterface type hint to the $typedConfigManager property.
- Updated the create method to use the service ID 'config.typed_config_manager
Thanks.
- 🇩🇪Germany woldtwerk Stralibu
The patches are not correct. It needs to be changed in 3 Files:
src/Form/MenuSettingsForm.php
src/Form/SettingsForm.php
src/Form/SkipFormSettingsForm.phpThere already was an issue fork. No need for patches