abhiyanshu → created an issue.
abhiyanshu → created an issue.
abhiyanshu → created an issue.
abhiyanshu → created an issue.
abhiyanshu → created an issue.
abhiyanshu → created an issue.
abhiyanshu → created an issue.
abhiyanshu → created an issue.
abhiyanshu → created an issue.
abhiyanshu → created an issue.
abhiyanshu → created an issue.
Fixed the all PHPCS error. Please take a look and merge.
Thank you!
abhiyanshu → created an issue.
abhiyanshu → created an issue.
Fixed the PHPCS error. Please take a look and merge.
Thank you!
abhiyanshu → created an issue. See original summary → .
abhiyanshu → created an issue.
abhiyanshu → created an issue.
This update looks correct. Thank you.
To maintain backward compatibility with both Commerce Kickstart 3.x and 4.x, this ensures compatibility across versions.
Moving this to RTBC.
abhiyanshu → created an issue.
abhiyanshu → created an issue.
abhiyanshu → created an issue.
abhiyanshu → created an issue.
abhiyanshu → created an issue.
abhiyanshu → made their first commit to this issue’s fork.
Hey alex,
Applied the patch successfully and created the merge request !10 for the same. Thank you!
abhiyanshu → made their first commit to this issue’s fork.
abhiyanshu → made their first commit to this issue’s fork.
abhiyanshu → made their first commit to this issue’s fork.
abhiyanshu → made their first commit to this issue’s fork.
abhiyanshu → created an issue.
abhiyanshu → created an issue.
abhiyanshu → created an issue.
abhiyanshu → created an issue.
abhiyanshu → created an issue.
abhiyanshu → created an issue.
Fixed all the PHPCS issues except for one warning.
I'll leave this for your decision, or please let me know how you'd like to proceed. Thanks you.
FILE: /var/www/web/themes/contrib/radix/includes/form.theme
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------
77 | WARNING | Doc comment indicates hook_form_alter() but function signature is "radix_form_alter" instead of "form_form_alter". Did you
| | mean hook_form_FORM_ID_alter()?
abhiyanshu → created an issue.
abhiyanshu → created an issue.
abhiyanshu → created an issue.
abhiyanshu → created an issue.
abhiyanshu → created an issue.
abhiyanshu → created an issue.
Fixed the coding standards issues. Kindly review.
Please refer to the attached screenshot for more clarity. Thank you.
Note : The current README.md file does not follow the standard template defined by Drupal.
https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... →
We can create a separate issue for the README.md file.
Let me know how you'd like to proceed. I'm happy to contribute.
Thank you.
abhiyanshu → created an issue.
@nidhish, You can ignore the info file.
abhiyanshu → created an issue.
abhiyanshu → created an issue.
Fixed the coding standards issues. Kindly review.
Please refer to the attached screenshot for more clarity. Thank you.
abhiyanshu → created an issue.
abhiyanshu → made their first commit to this issue’s fork.
Fixed the remaining coding standard issues.
Please refer to the attached screenshot for more clarity. Thank you.
abhiyanshu → made their first commit to this issue’s fork.
abhiyanshu → created an issue.
Yes, agreed. The issues reported above are from version 2.0.0-beta14, which was released on January 3, 2025.
Could you please take a look at the two files below? I think there is room for improvement in both files.
JsEventsConfigForm.php
CssClassField.php
https://git.drupalcode.org/project/toolshed/-/blob/2.0.x/src/Element/Css...
https://git.drupalcode.org/project/toolshed/-/blob/2.0.x/src/Form/JsEven...
abhiyanshu → created an issue.
abhiyanshu → created an issue.
abhiyanshu → created an issue.
abhiyanshu → created an issue.
abhiyanshu → created an issue.
abhiyanshu → created an issue.
abhiyanshu → created an issue.
abhiyanshu → created an issue.
abhiyanshu → created an issue.
abhiyanshu → created an issue.
Hello there, Apologies for the delay. I wasn’t able to complete this task earlier,
but I’ve now added the new release:
1.1.6 →
Repo : https://git.drupalcode.org/project/revolt/
Please let me know if there's anything else I can assist with.
I have:
- Added the TypedConfigManagerInterface import.
- Added the TypedConfigManagerInterface type hint to the $typedConfigManager property.
- Updated the create method to use the service ID 'config.typed_config_manager
Thanks.
The suggested resolution is that the $typedConfigManager variable needs to be typed. However, in the attached patch #3, I see that the TypedConfigManagerInterface class is being removed, along with the entire $typedConfigManager variable. Instead of removing it, I think we should simply add:
protected TypedConfigManagerInterface $typedConfigManager;
This way, we maintain the necessary typing without removing the functionality.
@fjgarlin The changes appear to be correctly managed now, as the test-only job is working as expected, as seen in the pipeline checks (https://git.drupalcode.org/issue/drupal-3467080/-/pipelines/248717).
Moving it to RTBC. Thanks.
Sure @mabho,
I somehow missed the notification and just got the message after the MR.
I will continue addressing any remaining issues in the new alpha9 version. Thank you for your patience and understanding.
Since you want to export specific webforms,
Access your database with a tool like phpMyAdmin or a CLI, and run SQL queries to export the webform data.
SELECT * INTO OUTFILE '/path/to/export/webform_812.sql'
FROM webform
WHERE nid = 812;SELECT * INTO OUTFILE '/path/to/export/webform_813.sql'
FROM webform
WHERE nid = 813;This will generate SQL files containing the webform data.
@TR I would suggest to update the cspell Dictionary and add specific terms to ignoreWords if they are valid in your context.
Simply Update/add TforValue to ignoreWords in .cspell.json, save it, and run cspell again to check if it stops flagging TforValue.
{
"version": "0.1",
"ignoreWords": [
"TforValue"
]
}Resolved all the issues reported by PHPCS. There are just a few remaining warnings, primarily related to lines exceeding 80 characters and the min.js file.
@cleavinjosh, I have reviewed and can confirm that the patch provided in #8 is still not working as expected. Moving it to "Needs Work" for further refinement. Thanks for your efforts!
Please refer to the attached screenshot for more clarity.
I think we should try adding timeout parameters to the connect and pconnect methods to see if increasing the timeout resolves the issue.
$client->connect($host, $port, 10);
I have reviewed MR !1, but there are still some PHPCS issues remaining.
Fix few of them, Below are the list of issues remaining. Thanks!
I have raised a separate MR as I encountered some issues on the 1.0.x branch. I have also updated the pipeline for MR !2 (Branch name -> 3372544-fix-the-issues)
FILE: /home/developer/projects/orgissues/modules/contrib/opencollective/opencollective.routing.yml
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------
7 | WARNING | The administration page callback should probably use "administer site configuration" - which implies the user can
| | change something - rather than "access administration pages" which is about viewing but not changing configurations.
-------------------------------------------------------------------------------------------------------------------------------------
FILE: /home/developer/projects/orgissues/modules/contrib/opencollective/README.md
---------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
---------------------------------------------------------------------------------
7 | WARNING | Line exceeds 80 characters; contains 152 characters
21 | WARNING | Line exceeds 80 characters; contains 81 characters
39 | WARNING | Line exceeds 80 characters; contains 92 characters
---------------------------------------------------------------------------------
FILE: ...eveloper/projects/orgissues/modules/contrib/opencollective/modules/opencollective_webhooks/src/Entity/WebhookEventInterface.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------
8 | ERROR | Doc comment is empty
-------------------------------------------------------------------------------------------------------------------------------------
FILE: /home/developer/projects/orgissues/modules/contrib/opencollective/modules/opencollective_webhooks/src/Form/TestForm.php
-----------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------
27 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-----------------------------------------------------------------------------------------------------------------------------
FILE: ...developer/projects/orgissues/modules/contrib/opencollective/modules/opencollective_webhooks/src/Service/PollingTokenManager.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------
30 | ERROR | Doc comment is empty
-------------------------------------------------------------------------------------------------------------------------------------
FILE: /home/developer/projects/orgissues/modules/contrib/opencollective/modules/opencollective_api/css/api-events.css
---------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------
1 | ERROR | Class definition is empty
---------------------------------------------------------------------------------------------------------------------
FILE: /home/developer/projects/orgissues/modules/contrib/opencollective/modules/opencollective_api/README.md
------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------
10 | WARNING | Line exceeds 80 characters; contains 93 characters
------------------------------------------------------------------------------------------------------------
FILE: /home/developer/projects/orgissues/modules/contrib/opencollective/modules/opencollective_api/src/ApiQueryPluginBase.php
-----------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------
23 | WARNING | Possible useless method overriding detected
-----------------------------------------------------------------------------------------------------------------------------
FILE: /home/developer/projects/orgissues/modules/contrib/opencollective/modules/opencollective_api/src/Service/ApiClientFactory.php
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------
10 | ERROR | Doc comment is empty
-----------------------------------------------------------------------------------------------------------------------------------
FILE: ...es/contrib/opencollective/modules/opencollective_commerce/src/Plugin/Commerce/PaymentGateway/ContributionFlowPaymentGateway.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
-------------------------------------------------------------------------------------------------------------------------------------
37 | ERROR | Missing short description in doc comment
38 | ERROR | Missing parameter comment
40 | ERROR | Description for the @return value is missing
-------------------------------------------------------------------------------------------------------------------------------------
FILE: ...me/developer/projects/orgissues/modules/contrib/opencollective/modules/opencollective_commerce/src/Service/EventSyncManager.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AND 2 WARNINGS AFFECTING 8 LINES
-------------------------------------------------------------------------------------------------------------------------------------
16 | ERROR | Doc comment is empty
76 | ERROR | Missing short description in doc comment
77 | ERROR | Description for the @return value is missing
164 | ERROR | Missing short description in doc comment
165 | ERROR | Missing parameter comment
167 | ERROR | Description for the @return value is missing
200 | WARNING | Unused variable $slug.
216 | WARNING | Unused variable $slug.
-------------------------------------------------------------------------------------------------------------------------------------
abhiyanshu → made their first commit to this issue’s fork.
@chandu7929 While scanning this module via Upgrade Status, I initially found 54 problems. After addressing many of them, only 40 warnings remain.
I can confirm that apart from these warnings, the module is compatible with Drupal 11.
However, most of the warnings appearing are related to the same issue mentioned below.
i.e..,
Twig template modules/contrib/commerce/modules/payment/templates/commerce-payment-total-summary.html.twig contains a syntax error and cannot be parsed.
The 'commerce_cart/admin' library is not defined because the defining extension is not installed. Cannot decide if it is deprecated or not.
Support from all Views contextual filter settings for the default_argument_skip_url setting is removed from drupal:11.0.0. No replacement is provided. See https://www.drupal.org/node/3382316.
For additional clarity, please refer to the attached screenshot. Thanks!
@lostcarpark, I locally scanned the module and found only one PHPCS issue. Please refer to the attached patch.
Additionally attaching the Screenshot for more clarity. Thanks!
Now able to create a view successfully without any warnings.
I followed the same steps to reproduce the issue, but instead, I encountered another error that appears as soon as we enable this module.
Fatal error: Declaration of Drupal\doc_serialization\Encoder\Doc::encode($data, $format, array $context = []) must be compatible with Symfony\Component\Serializer\Encoder\EncoderInterface::encode(mixed $data, string $format, array $context = []): string in /var/www/html/modules/contrib/doc_serialization/src/Encoder/Doc.php on line 44
The above error is encountering due to a mismatch between the method signature in your class and the method signature defined in the EncoderInterface from Symfony. I have updated encode method to match the interface's signature.
I tried to reproduce the issue again, and the view is now creating successfully without any warnings. Kindly review. Thanks.