@pfrenssen , Done this on the 2.x.
Please review. Thanks.
abhiyanshu โ made their first commit to this issueโs fork.
@tim-diels,
I have set the requirement in the module for the file. Please refer to the screenshot for more clarity. Thanks.
abhiyanshu โ made their first commit to this issueโs fork.
Hi @Prashant Mishra Sir,
I have reviewed the README file and made changes to align it with the Drupal standards as suggested in the README template(
https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... โ
). It now meets the recommended standards. Thanks.
abhiyanshu โ made their first commit to this issueโs fork.
Sure, I revisited Merge Request !42
and created a patch for it.
Included some missing code, Hope it works. Thanks.
Absolutely correct @tr,
Since getMockForAbstractClass() has been removed without a direct replacement method within PHPUnit itself, the recommended approach now is to use the getMockBuilder() method directly to create a mock object for an abstract class.
i.e..,
use PHPUnit\Framework\TestCase;
abstract class AbstractClass {
abstract public function method1();
abstract public function method2();
}
class MyTest extends TestCase {
public function testSomething() {
$mock = $this->getMockBuilder(AbstractClass::class)
->getMock();
// Define mock behavior or expectations
$mock->expects($this->any())
->method('method1')
->willReturn('foo');
// Assertions or test logic with $mock
$this->assertEquals('foo', $mock->method1());
}
}
I can verify that #9 no longer produces any PHPCS warnings in the README.md file.
I have also reviewed the template, and it aligns with the standards suggested in #4 by @ressa. Everything looks good to me.
Moving this to RTBC. Thanks.
Created patch for the same. Thanks.
Hi @Tim,
I have resolved the issue with the deprecated code by using ::renderInIsolation()
. Thanks.
Below are the files in which the issues have been resolved:
tests/src/Kernel/EntityViewTest.php
src/Logger/RulesDebugLog.php
abhiyanshu_rawat โ made their first commit to this issueโs fork.
Hi @greggles,
I installed the theme locally and didn't find any comments related to polyfill.io.
However, polyfill-io
is present only in the .js.map
file, and the changes related to it are not in the base file of the map file.
Please refer to the attached screenshot for more clarity.
I believe we can ignore it or If you have any suggestions, please let us know so that we can proceed accordingly. Thanks.
abhiyanshu_rawat โ made their first commit to this issueโs fork.
Since it's only one change, but to avoid accidentally using the wrong CDN for the files, I have updated the CDN library to use polyfill-fastly.io. Thanks.
abhiyanshu_rawat โ made their first commit to this issueโs fork.
I have updated all the comments with polyfill-fastly.io to avoid accidentally using the wrong CDN for the files. Thanks.
I have updated all the comments with polyfill-fastly.io to avoid accidentally using the wrong CDN for the files. Thanks.
abhiyanshu_rawat โ changed the visibility of the branch 3456710-polyfill.io-library-is to hidden.
abhiyanshu_rawat โ made their first commit to this issueโs fork.
abhiyanshu_rawat โ made their first commit to this issueโs fork.
@Rajab Natshah
I have reviewed the changes in Merge Request !8 and applied the #5 patch. Both are working correctly.
Moving this to RTBC. Thanks.
@bharath-kondeti,
Have you checked if the patch is working correctly?
When I apply the patch manually by placing it in the root directory of the module and running git apply -v 2869592-disabled-update-module-63.patch
, it throws an error regarding a missing file or directory. The same patch may also encounter issues when applied via Composer.
Reviewed Merge Request !19 by Rajan Kumar@2026, and it seems good overall.
However, there were some alignment issues that have been addressed with the above raised MR. The styles of the mini pager and full pager have been updated accordingly, Thanks.
Attaching some screenshots for better clarity !!!
Moving this to RTBC.
abhiyanshu_rawat โ made their first commit to this issueโs fork.
Hi @aitala
The site is running on version 10.2.7, and after updating to version 3.2.0, the memory allocation error likely occurs because newer versions sometimes include performance improvements and bug fixes that could reduce memory usage.
I think the solution for this is to increase the PHP memory limit. Here are the steps:
- Locate your php.ini file.
- Increase the PHP Memory Limit:
- Edit the file and look for the line that sets memory_limit.
- Increase this value to a higher limit. For example, change memory_limit = 500M to memory_limit = 1024M (for 1GB of memory).
- Save the file and restart the web server for the changes to take effect.
- Confirm the new memory_limit value using a PHP info file (phpinfo.php).
Hope this works !
@Hamid.ali, I've aligned the color scheme with the full pager shown in the parent screenshot, as per your suggestion. Kindly refer to the attached screenshot for details.
abhiyanshu_rawat โ made their first commit to this issueโs fork.
Hi @Marcus_Johansson, I understand your concern.
I just cloned this module locally and took a brief overview of it. Based on this overview and the features/details defined for this module on its detail page, I am compiling the necessary documentation and information and converting them into the README file.
I have just verified merge request !7, and now the FieldType is displaying properly with the full descriptions, unlike before.
Please refer to the attached screenshots for further clarity, Thanks.
Fixed the left spacing issue and now the footer view is properly visible for the mobile view as well.
Moving the issue into RTBC. Thank you! Please refer to the attached images.
abhiyanshu_rawat โ made their first commit to this issueโs fork.
Hi @Amandeep123,
I have reviewed your MR changes, and they're working well, but there's still an issue with overlapping. Please refer to the attached before/after screenshots for clarification.
Before ->
After ->
Hi @Sahana _N,
I have thoroughly reviewed it, and everything appears to be in order, It's ready for merging.
@VasyOK,
I think we can close this issue now !!!
Hi @VasyOk,
However, based on your reference,
Here's a more flexible and maintenance-friendly approach using the array_filter function to conditionally unset CSS files.
/**
* Implements hook_css_alter().
*/
function mytheme_css_alter(&$css, \Drupal\Core\Asset\AttachedAssetsInterface $assets) {
// List the CSS files you want to remove.
$css_to_remove = [
'modules/contrib/jquery_ui/assets/vendor/jquery.ui/themes/base/theme.css',
'core/assets/vendor/jquery.ui/themes/base/theme.css',
'modules/contrib/jquery_ui/assets/vendor/jquery.ui/themes/base/accordion.css',
];
// Unset the specified CSS files.
$css = array_filter($css, function ($key) use ($css_to_remove) {
return !in_array($key, $css_to_remove);
}, ARRAY_FILTER_USE_KEY);
}
It uses an array of file paths to remove and then filters the $css array to keep only the files that are not in the list of files to remove.
Make sure to clear the Drupal cache after adding or updating this code in your theme's mytheme.theme file.
The above code allows you to easily add or remove CSS files from the list as needed without altering the structure of the code.
abhiyanshu_rawat โ created an issue.
Hi @c_archer ,
I've ensured compatibility of this module with Drupal 10 and have crafted a corresponding patch for the update. You can find the attached patch for reference. Thank you.
@Shreya_th,
"I have carefully reviewed your changes and found that the code is running smoothly for three of the files. However, there is still one lingering linting error in the views-mini-pager.html.twig file.
I've taken the liberty to address this issue and have created a patch to rectify it.(Please refer to the attached patch)
With the fix in place, I'm now moving this to the 'RTBC' (Reviewed and Tested by the Community), Thank you.
Hi @Raghavendra A M ,
I've addressed coding standards and best practices issues in the module and created a patch for it.
Please refer to the attached patch, Thank you.
@HeikkiY ,
I scanned the project with Upgrade status and noticed the same problems reported by you
and i have fixed those reported problems and created the patch for it ,
Please refer to the attached patch file, Thanks.
@VasyOK,
It seems like you've made some indentation issue.
Proper indentation is crucial for the code to be parsed correctly.
Please follow-up with the below code, Hope it works.
Your code should look like this with correct indentation:
libraries-override:
jquery_ui/core:
css:
component:
assets/vendor/jquery.ui/themes/base/theme.css: false
assets/vendor/jquery.ui/themes/base/accordion.css: false
NOTE :-
In the above corrected code,
The component section is properly indented under css.
The CSS files you want to disable (theme.css and accordion.css) are correctly indented under component.
With this indentation, Drupal should be able to recognize and apply the libraries-override configuration as intended, disabling the specified CSS files from the jQuery UI library.
@gisle I have updated the Drupal 10 version of Scroll to topic,
Please refer to the attached patch, Thanks.
Hi @shweta__sharma,
I've Successfully reproduced the issue on my machine and fixed it
Please refer to the attached patch below,
Hope it helps, Thanks.
Hi @hcanning ,
I just reproduce your issue on my machine, I successfully installed it and set as default theme, Also I'm using the same Drupal version 9.5.10.
However, What i think that you missed is some minor spelling mistake on renaming the templates and functionals things.
Please refer the attached screens for more clarity.
For example,
If i give my subtheme named as dummy subtheme , so please make sure that you've given the name correctly to other files apart from the functional thing.
i.e..., dummytheme.info.yml , dummysubtheme.theme , dummysubtheme.libraries.yml etc
Let me know in case of any queries , happy to assist you further.
Hope it helps, Thanks.