🇮🇳India @abhiyanshu

Fixed all the PHPCS issues except for one warning.
I'll leave this for your decision, or please let me know how you'd like to proceed. Thanks you.

FILE: /var/www/web/themes/contrib/radix/includes/form.theme
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------
 77 | WARNING | Doc comment indicates hook_form_alter() but function signature is "radix_form_alter" instead of "form_form_alter". Did you
    |         | mean hook_form_FORM_ID_alter()?

abhiyanshu → created an issue.

abhiyanshu → created an issue.

abhiyanshu → created an issue.

abhiyanshu → created an issue.

abhiyanshu → created an issue.

abhiyanshu → created an issue.

Fixed the coding standards issues. Kindly review.
Please refer to the attached screenshot for more clarity. Thank you.

Note : The current README.md file does not follow the standard template defined by Drupal.
https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... →

We can create a separate issue for the README.md file.
Let me know how you'd like to proceed. I'm happy to contribute.
Thank you.

abhiyanshu → created an issue.

@nidhish, You can ignore the info file.

abhiyanshu → created an issue.

abhiyanshu → created an issue.

Fixed the coding standards issues. Kindly review.
Please refer to the attached screenshot for more clarity. Thank you.

abhiyanshu → created an issue.

abhiyanshu → made their first commit to this issue’s fork.

Fixed the remaining coding standard issues.
Please refer to the attached screenshot for more clarity. Thank you.

abhiyanshu → made their first commit to this issue’s fork.

abhiyanshu → created an issue.

Yes, agreed. The issues reported above are from version 2.0.0-beta14, which was released on January 3, 2025.

Could you please take a look at the two files below? I think there is room for improvement in both files.
JsEventsConfigForm.php
CssClassField.php

https://git.drupalcode.org/project/toolshed/-/blob/2.0.x/src/Element/Css...
https://git.drupalcode.org/project/toolshed/-/blob/2.0.x/src/Form/JsEven...

abhiyanshu → created an issue.

abhiyanshu → created an issue.

abhiyanshu → created an issue.

abhiyanshu → created an issue.

abhiyanshu → created an issue.

abhiyanshu → created an issue.

abhiyanshu → created an issue.

abhiyanshu → created an issue.

abhiyanshu → created an issue.

abhiyanshu → created an issue.

Hello there, Apologies for the delay. I wasn’t able to complete this task earlier,
but I’ve now added the new release: 1.1.6 →
Repo : https://git.drupalcode.org/project/revolt/

Please let me know if there's anything else I can assist with.

I have:

• Added the TypedConfigManagerInterface import.
• Added the TypedConfigManagerInterface type hint to the $typedConfigManager property.
• Updated the create method to use the service ID 'config.typed_config_manager

Thanks.

The suggested resolution is that the $typedConfigManager variable needs to be typed. However, in the attached patch #3, I see that the TypedConfigManagerInterface class is being removed, along with the entire $typedConfigManager variable. Instead of removing it, I think we should simply add:

protected TypedConfigManagerInterface $typedConfigManager;

This way, we maintain the necessary typing without removing the functionality.

@fjgarlin The changes appear to be correctly managed now, as the test-only job is working as expected, as seen in the pipeline checks (https://git.drupalcode.org/issue/drupal-3467080/-/pipelines/248717).
Moving it to RTBC. Thanks.

Sure @mabho,
I somehow missed the notification and just got the message after the MR.
I will continue addressing any remaining issues in the new alpha9 version. Thank you for your patience and understanding.

Since you want to export specific webforms,
Access your database with a tool like phpMyAdmin or a CLI, and run SQL queries to export the webform data.

SELECT * INTO OUTFILE '/path/to/export/webform_812.sql'
FROM webform
WHERE nid = 812;

SELECT * INTO OUTFILE '/path/to/export/webform_813.sql'
FROM webform
WHERE nid = 813;

This will generate SQL files containing the webform data.

@TR I would suggest to update the cspell Dictionary and add specific terms to ignoreWords if they are valid in your context.

Simply Update/add TforValue to ignoreWords in .cspell.json, save it, and run cspell again to check if it stops flagging TforValue.

{
  "version": "0.1",
  "ignoreWords": [
    "TforValue"
  ]
}

Resolved all the issues reported by PHPCS. There are just a few remaining warnings, primarily related to lines exceeding 80 characters and the min.js file.

@cleavinjosh, I have reviewed and can confirm that the patch provided in #8 is still not working as expected. Moving it to "Needs Work" for further refinement. Thanks for your efforts!
Please refer to the attached screenshot for more clarity.

I think we should try adding timeout parameters to the connect and pconnect methods to see if increasing the timeout resolves the issue.

$client->connect($host, $port, 10);

I have reviewed MR !1, but there are still some PHPCS issues remaining.
Fix few of them, Below are the list of issues remaining. Thanks!
I have raised a separate MR as I encountered some issues on the 1.0.x branch. I have also updated the pipeline for MR !2 (Branch name -> 3372544-fix-the-issues)

FILE: /home/developer/projects/orgissues/modules/contrib/opencollective/opencollective.routing.yml
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------
7 | WARNING | The administration page callback should probably use "administer site configuration" - which implies the user can
| | change something - rather than "access administration pages" which is about viewing but not changing configurations.
-------------------------------------------------------------------------------------------------------------------------------------

FILE: /home/developer/projects/orgissues/modules/contrib/opencollective/README.md
---------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
---------------------------------------------------------------------------------
7 | WARNING | Line exceeds 80 characters; contains 152 characters
21 | WARNING | Line exceeds 80 characters; contains 81 characters
39 | WARNING | Line exceeds 80 characters; contains 92 characters
---------------------------------------------------------------------------------

FILE: ...eveloper/projects/orgissues/modules/contrib/opencollective/modules/opencollective_webhooks/src/Entity/WebhookEventInterface.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------
8 | ERROR | Doc comment is empty
-------------------------------------------------------------------------------------------------------------------------------------

FILE: /home/developer/projects/orgissues/modules/contrib/opencollective/modules/opencollective_webhooks/src/Form/TestForm.php
-----------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------
27 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-----------------------------------------------------------------------------------------------------------------------------

FILE: ...developer/projects/orgissues/modules/contrib/opencollective/modules/opencollective_webhooks/src/Service/PollingTokenManager.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------
30 | ERROR | Doc comment is empty
-------------------------------------------------------------------------------------------------------------------------------------

FILE: /home/developer/projects/orgissues/modules/contrib/opencollective/modules/opencollective_api/css/api-events.css
---------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------
1 | ERROR | Class definition is empty
---------------------------------------------------------------------------------------------------------------------

FILE: /home/developer/projects/orgissues/modules/contrib/opencollective/modules/opencollective_api/README.md
------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------
10 | WARNING | Line exceeds 80 characters; contains 93 characters
------------------------------------------------------------------------------------------------------------

FILE: /home/developer/projects/orgissues/modules/contrib/opencollective/modules/opencollective_api/src/ApiQueryPluginBase.php
-----------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------
23 | WARNING | Possible useless method overriding detected
-----------------------------------------------------------------------------------------------------------------------------

FILE: /home/developer/projects/orgissues/modules/contrib/opencollective/modules/opencollective_api/src/Service/ApiClientFactory.php
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------
10 | ERROR | Doc comment is empty
-----------------------------------------------------------------------------------------------------------------------------------

FILE: ...es/contrib/opencollective/modules/opencollective_commerce/src/Plugin/Commerce/PaymentGateway/ContributionFlowPaymentGateway.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
-------------------------------------------------------------------------------------------------------------------------------------
37 | ERROR | Missing short description in doc comment
38 | ERROR | Missing parameter comment
40 | ERROR | Description for the @return value is missing
-------------------------------------------------------------------------------------------------------------------------------------

FILE: ...me/developer/projects/orgissues/modules/contrib/opencollective/modules/opencollective_commerce/src/Service/EventSyncManager.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AND 2 WARNINGS AFFECTING 8 LINES
-------------------------------------------------------------------------------------------------------------------------------------
16 | ERROR | Doc comment is empty
76 | ERROR | Missing short description in doc comment
77 | ERROR | Description for the @return value is missing
164 | ERROR | Missing short description in doc comment
165 | ERROR | Missing parameter comment
167 | ERROR | Description for the @return value is missing
200 | WARNING | Unused variable $slug.
216 | WARNING | Unused variable $slug.
-------------------------------------------------------------------------------------------------------------------------------------

abhiyanshu → made their first commit to this issue’s fork.

@chandu7929 While scanning this module via Upgrade Status, I initially found 54 problems. After addressing many of them, only 40 warnings remain.
I can confirm that apart from these warnings, the module is compatible with Drupal 11.

However, most of the warnings appearing are related to the same issue mentioned below.
i.e..,
Twig template modules/contrib/commerce/modules/payment/templates/commerce-payment-total-summary.html.twig contains a syntax error and cannot be parsed.
The 'commerce_cart/admin' library is not defined because the defining extension is not installed. Cannot decide if it is deprecated or not.
Support from all Views contextual filter settings for the default_argument_skip_url setting is removed from drupal:11.0.0. No replacement is provided. See https://www.drupal.org/node/3382316.

For additional clarity, please refer to the attached screenshot. Thanks!

@lostcarpark, I locally scanned the module and found only one PHPCS issue. Please refer to the attached patch.
Additionally attaching the Screenshot for more clarity. Thanks!

Now able to create a view successfully without any warnings.

I followed the same steps to reproduce the issue, but instead, I encountered another error that appears as soon as we enable this module.

Fatal error: Declaration of Drupal\doc_serialization\Encoder\Doc::encode($data, $format, array $context = []) must be compatible with Symfony\Component\Serializer\Encoder\EncoderInterface::encode(mixed $data, string $format, array $context = []): string in /var/www/html/modules/contrib/doc_serialization/src/Encoder/Doc.php on line 44

The above error is encountering due to a mismatch between the method signature in your class and the method signature defined in the EncoderInterface from Symfony. I have updated encode method to match the interface's signature.

I tried to reproduce the issue again, and the view is now creating successfully without any warnings. Kindly review. Thanks.

I have thoroughly reviewed MR !3 and can confirm that it resolves all the PHPCS issues.
For additional clarity, please refer to the attached screenshot. Excellent work on this!
Moving it to RTBC. Thanks!

I have thoroughly reviewed MR !5 and can confirm that it resolves all the PHPCS issues.
Excellent work on this! There are just a few minor updates needed in the README file to fully align with the standards.
For additional clarity, please refer to the attached screenshot.

@rloos289 Kindly review it now. Thank you!

abhiyanshu → made their first commit to this issue’s fork.

I have thoroughly reviewed MR !1 and can confirm that it resolves all the PHPCS issues.
For additional clarity, please refer to the attached screenshot. Excellent work on this!
Moving it to RTBC. Thanks!

The attached patch is working fine, and I am no longer getting the warning of an undefined array.
Moving it to RTBC. Thanks!

@mabho No worries, I'll fix this locally and attach a patch once the PHPCS issues are resolved. Thanks.

@darrenwh, The #2 patch addresses potential warnings by preemptively updating the code to avoid deprecated features, ensuring compatibility with future PHP standards.
Moving this to RTBC. Thanks.

Resolved all the PHPCS errors and warnings for the requested files.
There was a 404 Page Not Found error when creating the branch.
Attaching the patch for the same. Thanks.

@sis-sumados, no worries. I've made the necessary updates to the correct line and created a corresponding patch. Please find the attached patch file for your review.
Moving this to RTBC. Thank you!

@dtfabio, I waited for a while since the changes were not that big, so I went ahead and pushed them.
I will make sure to follow up on those things next time. Thank you for your valuable suggestions and the review. I appreciate your guidance!

@fishfree
Yes, if you configure a field on the Schema.org settings page (/admin/config/schemadotorg/settings/properties#edit-schemadotorg-inline-entity-form) to use the inline entity form, then the inline entity form widget will be automatically applied to that field.

It will be automatically applied to that field because the configuration you set at /admin/config/schemadotorg/settings/properties#edit-schemadotorg-inline-entity-form specifies that the inline entity form should be used for that field. This configuration instructs Drupal to replace the default widget with the inline entity form widget, providing an inline editing experience for entities associated with that field.

Hope it helps. Thanks.

@sis-sumados, I have created a patch to resolve the Watchdog ERROR and substitute the error line as proposed.
This patch ensures that 'search-form__submit' is added to the class attribute array. If the class attribute is not already an array, this line will create an array and add the class to it.

Additionally, I am attaching a screenshot of the successful installation of the theme without any errors in the Drupal 10.3.0 version. Thanks.

Disabling a module/Commenting out the code should generally be considered a temporary workaround.
It's better to address the error instead.

Coming to the error, it seems there's a problem with the setRequest() method of the ViewExecutable class in the Views module. Specifically, it expects a Symfony\Component\HttpFoundation\Request object as the argument, but it's receiving null instead.

I think we need to set a request object before calling setRequest()

use Symfony\Component\HttpFoundation\Request;

$request = Request::createFromGlobals();
$viewExecutable->setRequest($request);

@lostcarpark The syntax is now correct for the DeprecationHelper. I have scanned the module locally to ensure there are no remaining issues.
Please refer to the attached screenshot for further clarity.
Moving this to RTBC. Thanks.

@pfrenssen , Done this on the 2.x.
Please review. Thanks.

abhiyanshu → made their first commit to this issue’s fork.

@tim-diels,
I have set the requirement in the module for the file. Please refer to the screenshot for more clarity. Thanks.

abhiyanshu → made their first commit to this issue’s fork.

Hi @Prashant Mishra Sir,
I have reviewed the README file and made changes to align it with the Drupal standards as suggested in the README template( https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... → ). It now meets the recommended standards. Thanks.

abhiyanshu → made their first commit to this issue’s fork.

Sure, I revisited Merge Request !42 and created a patch for it.
Included some missing code, Hope it works. Thanks.

Absolutely correct @tr,
Since getMockForAbstractClass() has been removed without a direct replacement method within PHPUnit itself, the recommended approach now is to use the getMockBuilder() method directly to create a mock object for an abstract class.

i.e..,

use PHPUnit\Framework\TestCase;

abstract class AbstractClass {
    abstract public function method1();
    abstract public function method2();
}

class MyTest extends TestCase {
    public function testSomething() {
        $mock = $this->getMockBuilder(AbstractClass::class)
                     ->getMock();

        // Define mock behavior or expectations
        $mock->expects($this->any())
             ->method('method1')
             ->willReturn('foo');

        // Assertions or test logic with $mock
        $this->assertEquals('foo', $mock->method1());
    }
}

I can verify that #9 no longer produces any PHPCS warnings in the README.md file.
I have also reviewed the template, and it aligns with the standards suggested in #4 by @ressa. Everything looks good to me.
Moving this to RTBC. Thanks.

Created patch for the same. Thanks.

Hi @Tim,
I have resolved the issue with the deprecated code by using ::renderInIsolation(). Thanks.
Below are the files in which the issues have been resolved:

tests/src/Kernel/EntityViewTest.php

src/Logger/RulesDebugLog.php

abhiyanshu_rawat → made their first commit to this issue’s fork.

Hi @greggles,
I installed the theme locally and didn't find any comments related to polyfill.io.
However, polyfill-io is present only in the .js.map file, and the changes related to it are not in the base file of the map file.
Please refer to the attached screenshot for more clarity.

I believe we can ignore it or If you have any suggestions, please let us know so that we can proceed accordingly. Thanks.

abhiyanshu_rawat → made their first commit to this issue’s fork.

Since it's only one change, but to avoid accidentally using the wrong CDN for the files, I have updated the CDN library to use polyfill-fastly.io. Thanks.

abhiyanshu_rawat → made their first commit to this issue’s fork.

I have updated all the comments with polyfill-fastly.io to avoid accidentally using the wrong CDN for the files. Thanks.

I have updated all the comments with polyfill-fastly.io to avoid accidentally using the wrong CDN for the files. Thanks.

abhiyanshu_rawat → changed the visibility of the branch 3456710-polyfill.io-library-is to hidden.

abhiyanshu_rawat → made their first commit to this issue’s fork.

abhiyanshu_rawat → made their first commit to this issue’s fork.

@Rajab Natshah
I have reviewed the changes in Merge Request !8 and applied the #5 patch. Both are working correctly.
Moving this to RTBC. Thanks.

@bharath-kondeti,
Have you checked if the patch is working correctly?
When I apply the patch manually by placing it in the root directory of the module and running git apply -v 2869592-disabled-update-module-63.patch, it throws an error regarding a missing file or directory. The same patch may also encounter issues when applied via Composer.

Reviewed Merge Request !19 by Rajan Kumar@2026, and it seems good overall.
However, there were some alignment issues that have been addressed with the above raised MR. The styles of the mini pager and full pager have been updated accordingly, Thanks.

Attaching some screenshots for better clarity !!!
Moving this to RTBC.

abhiyanshu_rawat → made their first commit to this issue’s fork.