Contrib.social

Fix issues reported by PHPCS

Open on Drupal.org ā†’
Created on 27 February 2025, about 1 month ago

Problem/Motivation

It would be great to address the below minor PHPCS issues :

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml solo/


FILE: /var/www/web/themes/contrib/solo/includes/_theme_settings_helper_functions.inc
------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------
 660 | WARNING | Unused variable $key.
------------------------------------------------------------------------------------


FILE: /var/www/web/themes/contrib/solo/includes/_solo_theme_alter.inc
-----------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------
 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormStateInterface.
-----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/web/themes/contrib/solo/includes/_solo_theme_preprocess.inc
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
-----------------------------------------------------------------------------------------------------------------------------------
  14 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Routing\RouteMatchInterface.
 765 | ERROR | [x] Missing function doc comment
 774 | ERROR | [x] Comments may not appear after statements
-----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/web/themes/contrib/solo/theme-settings.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
----------------------------------------------------------------------
 28 | WARNING | Unused variable $d_s.
 29 | WARNING | Unused variable $d_m.
 30 | WARNING | Unused variable $d_l.
 31 | WARNING | Unused variable $updated_regions.
 32 | WARNING | Unused variable $counts.
 33 | WARNING | Unused variable $attributes.
----------------------------------------------------------------------

Time: 8.46 secs; Memory: 26MB

Steps to reproduce

  • Install the theme, composer require 'drupal/solo:^1.0'
  • Run the command,

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml solo/

Proposed resolution

Fix the PHPCS issues.

šŸ“Œ Task
Status

Active

Version

1.0

Component

Code

Created by

šŸ‡®šŸ‡³India abhiyanshu

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @abhiyanshu
  • First commit to issue fork.
  • Merge request !15Fixes issue #3509309: Fixed PHPCS issues ā†’ (Open) created by Unnamed author
  • Comment about 1 month ago ā†’
    šŸ‡®šŸ‡³India GGH
  • Comment about 1 month ago ā†’
    šŸ‡µšŸ‡­Philippines clarkssquared

    Hi,

    I applied the MR and I can still see PHPCS error and warnings.

    āžœ  contrib git:(main) āœ— phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml solo/

FILE: ...drupal-project/web/themes/contrib/solo/includes/_solo_theme_preprocess.inc
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 14 | ERROR | [x] Use statements should be sorted alphabetically. The first
    |       |     wrong one is Drupal\Core\Routing\RouteMatchInterface.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...ject/web/themes/contrib/solo/includes/_theme_settings_helper_functions.inc
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 660 | WARNING | Unused variable $_.
--------------------------------------------------------------------------------


FILE: ...rupal-project/web/themes/contrib/solo/solo_subtheme/solo_subtheme.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------
 1 | WARNING | Remove "project" from the info file, it will be added by
   |         | drupal.org packaging automatically
 1 | WARNING | Remove "datestamp" from the info file, it will be added by
   |         | drupal.org packaging automatically
 1 | WARNING | Remove "version" from the info file, it will be added by
   |         | drupal.org packaging automatically
--------------------------------------------------------------------------------


FILE: ...rojects/drupal-issues/drupal-project/web/themes/contrib/solo/solo.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------
 1 | WARNING | Remove "project" from the info file, it will be added by
   |         | drupal.org packaging automatically
 1 | WARNING | Remove "datestamp" from the info file, it will be added by
   |         | drupal.org packaging automatically
 1 | WARNING | Remove "version" from the info file, it will be added by
   |         | drupal.org packaging automatically
--------------------------------------------------------------------------------

Time: 5.35 secs; Memory: 26MB

āžœ  contrib git:(main) āœ—
  • Comment 18 days ago ā†’
    šŸ‡ŗšŸ‡øUnited States flashwebcenter Austin TX
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024