🇵🇭Philippines clarkssquared
Hi
I checked the MR and I confirmed that it created and replaced the README.txt file with README.md, and the README.md file follows the Drupal README.md template →
RTBC +1 from me
🇵🇭Philippines clarkssquared
Hi
I applied MR !8 and I confirmed that it fixes all PHPCS issues and error
➜ paragraphs_asymmetric_translation_widgets git:(8.x-1.x) curl https://git.drupalcode.org/project/paragraphs_asymmetric_translation_widgets/-/merge_requests/8.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 30626 0 30626 0 0 51925 0 --:--:-- --:--:-- --:--:-- 52531
patching file 'config/schema/paragraphs_asymmetric_translation_widgets.schema.yml'
patching file credits.txt
patching file paragraphs_asymmetric_translation_widgets.module
patching file 'src/Plugin/Field/FieldWidget/ParagraphsClassicAsymmetricWidget.php'
patching file 'tests/src/Functional/ParagraphsAsymmetricTranslationTest.php'
➜ paragraphs_asymmetric_translation_widgets git:(8.x-1.x) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml paragraphs_asymmetric_translation_widgets
➜ contrib git:(main) ✗ 🇵🇭Philippines clarkssquared
Hi
I applied MR !19 and I confirmed that it fixes the PHPCS issue in the module
➜ r4032login git:(2.2.x) curl https://git.drupalcode.org/project/r4032login/-/merge_requests/19.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 400 0 400 0 0 713 0 --:--:-- --:--:-- --:--:-- 723
patching file r4032login.install
➜ r4032login git:(2.2.x) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml r4032login
➜ contrib git:(main) ✗
RTBC +1 from me
🇵🇭Philippines clarkssquared
Hi
I applied the MR !4 and I confirmed that it fixes the PHPCS issues in the module,
➜ disable_web_install git:(main) ✗ curl https://git.drupalcode.org/project/disable_web_install/-/merge_requests/4.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 574 0 574 0 0 1077 0 --:--:-- --:--:-- --:--:-- 1099
patching file disable_web_install.module
➜ disable_web_install git:(main) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml disable_web_install
FILE: ...local/web/modules/contrib/disable_web_install/disable_web_install.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by
| | drupal.org packaging automatically
--------------------------------------------------------------------------------
Time: 123ms; Memory: 10MB
➜ contrib git:(main) ✗ The warning that my terminal reported occurs when a module is installed via composer.
RTBC +1 from me
🇵🇭Philippines clarkssquared
Hi
I applied patch #2 and confirmed that there's no PHPCS issue a I execute the PHPCS command:
➜ commerce_shipping_mondial_relay git:(1.0.x) curl https://www.drupal.org/files/issues/2023-08-05/3379421-2.patch | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 1632 100 1632 0 0 5136 0 --:--:-- --:--:-- --:--:-- 5247
patching file 'src/Plugin/Commerce/ShippingMethod/MondialRelay.php'
➜ commerce_shipping_mondial_relay git:(1.0.x) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml commerce_shipping_mondial_relay/
➜ contrib git:(main) ✗
However, can you kindly add your changes into the existing MR rather than creating a patch? in that way the maintainer can easily merge and look at it, U will transition this to needs work for that matter.
🇵🇭Philippines clarkssquared
Hi
I applied MR !11 and it fixes all the PHPCS issues, I will retaing the status to needs review so that others can give their feedback.
➜ form_mode_control git:(8.x-2.3) ✗ curl https://git.drupalcode.org/project/form_mode_control/-/merge_requests/11.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 15224 0 15224 0 0 21405 0 --:--:-- --:--:-- --:--:-- 21625
patching file form_mode_control.module
patching file form_mode_control.routing.yml
patching file 'src/Form/FormModeConfigForm.php'
patching file 'src/FormModePermission.php'
➜ form_mode_control git:(8.x-2.3) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml form_mode_control
➜ contrib git:(master) ✗
🇵🇭Philippines clarkssquared
Hi
I applied the updated MR !9 and I can confirm that it fixes PHPCS issues
➜ quicklink git:(2.0.x) curl https://git.drupalcode.org/project/quicklink/-/merge_requests/9.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 10100 0 10100 0 0 15314 0 --:--:-- --:--:-- --:--:-- 15467
patching file .gitlab-ci.yml
patching file README.md
patching file quicklink.install
patching file quicklink.module
patching file 'src/Form/QuicklinkConfigForm.php'
patching file 'tests/quicklink_test/quicklink_test.info.yml'
➜ quicklink git:(2.0.x) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml quicklink
➜ contrib git:(master) ✗
retaining the status to needs review for other's feedback
🇵🇭Philippines clarkssquared
Hi
I applied the MR !1 but there are files being rejected as I apply it
➜ freshchat git:(master) ✗ curl https://git.drupalcode.org/project/freshchat/-/merge_requests/1.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 2168 0 2168 0 0 2958 0 --:--:-- --:--:-- --:--:-- 2982
patching file README.md
patching file README.txt
patching file freshchat.info.yml
1 out of 1 hunks failed--saving rejects to freshchat.info.yml.rej
🇵🇭Philippines clarkssquared
Hi
I applied the patch but it fails and being rejected
➜ layout_builder_accordion git:(1.x) curl https://www.drupal.org/files/issues/2022-07-13/phpcs-drupal-standard-3295736-2.patch | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 3537 100 3537 0 0 12160 0 --:--:-- --:--:-- --:--:-- 12498
patching file layout_builder_accordion.module
No such line 11 in input file, ignoring
1 out of 1 hunks failed--saving rejects to layout_builder_accordion.module.rej
patching file 'src/Plugin/Layout/AccordionsLayout.php'
2 out of 2 hunks failed--saving rejects to 'src/Plugin/Layout/AccordionsLayout.php.rej'🇵🇭Philippines clarkssquared
🇵🇭Philippines clarkssquared
This is now ready for review
🇵🇭Philippines clarkssquared
clarkssquared → created an issue.
🇵🇭Philippines clarkssquared
Hi
I applied MR !4 and there are PHPCS error that PHPCS reported:
➜ user_email_verification git:(8.x-1.2) curl https://git.drupalcode.org/project/user_email_verification/-/merge_requests/4.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 10239 0 10239 0 0 13598 0 --:--:-- --:--:-- --:--:-- 13725
patching file 'src/Controller/UserEmailVerificationVerify.php'
patching file 'src/Controller/UserEmailVerificationVerifyExtended.php'
patching file 'src/Event/UserEmailVerificationBlockAccountEvent.php'
patching file 'src/Event/UserEmailVerificationCreateVerificationEvent.php'
patching file 'src/Event/UserEmailVerificationDeleteAccountEvent.php'
patching file 'src/Event/UserEmailVerificationVerifyEvent.php'
patching file 'src/Form/UserEmailVerificationRequestForm.php'
patching file 'src/Plugin/views/filter/EmailVerification.php'
patching file 'src/UserEmailVerification.php'
patching file user_email_verification.install
patching file user_email_verification.module
➜ user_email_verification git:(8.x-1.2) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml user_email_verification
FILE: ...trib/user_email_verification/src/Plugin/views/filter/EmailVerification.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
149 | ERROR | The array declaration extends to column 83 (the limit is 80).
| | The array content should be split up over multiple lines
--------------------------------------------------------------------------------
FILE: .../web/modules/contrib/user_email_verification/src/UserEmailVerification.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
671 | ERROR | The array declaration extends to column 83 (the limit is 80).
| | The array content should be split up over multiple lines
--------------------------------------------------------------------------------
Time: 687ms; Memory: 16MB
➜ contrib git:(master) ✗
🇵🇭Philippines clarkssquared
Hi
I applied the MR !5 and I confirmed that most of the PHPCS issues were fixed. However, there is 1 phpcs issue that remains in the module
➜ flysystem_sftp git:(8.x-1.x) curl https://git.drupalcode.org/project/flysystem_sftp/-/merge_requests/5.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 1832 0 1832 0 0 3670 0 --:--:-- --:--:-- --:--:-- 3716
patching file 'src/Flysystem/Sftp.php'
patching file 'src/Tests/ModuleInstallUninstallWebTest.php'
➜ flysystem_sftp git:(8.x-1.x) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml flysystem_sftp
FILE: ...-subing/Projects/d9/d9-local/web/modules/contrib/flysystem_sftp/README.txt
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
16 | WARNING | Line exceeds 80 characters; contains 84 characters
--------------------------------------------------------------------------------
Time: 247ms; Memory: 10MB
➜ contrib git:(master) ✗ Retaining the status to needs review for other to replicate the same PHPCS issue I reported.
🇵🇭Philippines clarkssquared
Hi
I applied the MR !6 and I confirmed that it fixes the typo issue of the module's info.yml file.
RTBC +1 from me
🇵🇭Philippines clarkssquared
Hi Rajesh,
I applied your MR !5 and I confirmed that it created a README.md in Actions module and it is following the Drupal README.md template → , below is the README.md content
# Action
Actions are module-defined tasks that can be executed on the site;
for example, unpublishing content, sending an email message, or
blocking a user.
## Table of contents
- Requirements
- Installation
- Configuration
- Maintainers
## Requirements
This module requires no modules outside of Drupal core.
## Installation
Install as you would normally install a contributed Drupal module. For further
information, see
[Installing Drupal Modules](https://www.drupal.org/docs/extending-drupal/installing-drupal-modules).
### Composer
If your site is [managed via Composer](https://www.drupal.org/node/2718229), use
Composer to download the module:
```sh
composer require "drupal/action"
```
It downloads the latest release, use 1.x-dev to get the -dev release instead.
Use ```composer update drupal/action --with-dependencies``` to update to a new
release.
### Ludwig
Composer is recommended whenever possible. However, if you are not familiar with
Composer yet (or you want to avoid it for other reasons) you can install and use
[Ludwig](https://www.drupal.org/project/ludwig) module to manage Address module
library dependencies.
Read more at Ludwig Installation and Usage guide:
https://www.drupal.org/docs/contributed-modules/ludwig/installation-and-usage
## Configuration
The configuration page is at `/admin/config/system/actions`,
where you can configure the Action module.
## Maintainers
- Andrey Postnikov - [andypost](https://www.drupal.org/u/ndypost)
🇵🇭Philippines clarkssquared
Hi silvi,
I applied the MR !8 after cloning 3.0.x and I confirmed that PHPCS issues were resolved.
➜ openchurch_core git:(3.0.x) curl https://git.drupalcode.org/project/openchurch_core/-/merge_requests/8.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 1199 0 1199 0 0 2227 0 --:--:-- --:--:-- --:--:-- 2266
patching file openchurch_core.install
patching file openchurch_core.module
➜ openchurch_core git:(3.0.x) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml openchurch_core
➜ contrib git:(master) ✗ I will retain the status to needs review for others to look at your MR and also for their feedback
🇵🇭Philippines clarkssquared
Hi
I applied the updated MR !2 and I can see that there's a PHPCS warning about Translatable String that the PHPCS reported
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml config_ignore_auto
FILE: ...9-local/web/modules/contrib/config_ignore_auto/config_ignore_auto.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by
| | drupal.org packaging automatically
--------------------------------------------------------------------------------
FILE: ...s/d9/d9-local/web/modules/contrib/config_ignore_auto/src/Form/Settings.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
96 | WARNING | Translatable strings must not begin or end with white spaces,
| | use placeholders with t() for variables
--------------------------------------------------------------------------------
Time: 244ms; Memory: 10MB
➜ contrib git:(master) ✗
🇵🇭Philippines clarkssquared
clarkssquared → created an issue.
🇵🇭Philippines clarkssquared
Hi
I applied the MR !2 into 9.1.x-dev version ( it says 9.1.x in my terminal) and I can still see this phpcs issues
➜ da_vinci git:(9.1.x) curl https://git.drupalcode.org/project/da_vinci/-/merge_requests/2.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 1187 0 1187 0 0 2375 0 --:--:-- --:--:-- --:--:-- 2412
patching file da_vinci.theme
patching file 'subtheme/subtheme.theme'
➜ da_vinci git:(9.1.x) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml da_vinci
FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/themes/contrib/da_vinci/subtheme/subtheme.theme
--------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
--------------------------------------------------------------------------------------------------------
8 | WARNING | [x] Unused use statement
9 | WARNING | [x] Unused use statement
10 | WARNING | [x] Unused use statement
11 | WARNING | [x] Unused use statement
12 | WARNING | [x] Unused use statement
--------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------
FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/themes/contrib/da_vinci/subtheme/subtheme.info
-------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------
1 | ERROR | "name" property is missing in the info file
1 | ERROR | "description" property is missing in the info file
1 | ERROR | "core" property is missing in the info file
-------------------------------------------------------------------------------------------------------
FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/themes/contrib/da_vinci/da_vinci.info.yml
-----------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-----------------------------------------------------------------------------------------------------------
FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/themes/contrib/da_vinci/css/maintenance.css
----------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
----------------------------------------------------------------------------------------------------
FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/themes/contrib/da_vinci/css/user-password.css
------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
------------------------------------------------------------------------------------------------------
FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/themes/contrib/da_vinci/css/main.css
---------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
---------------------------------------------------------------------------------------------
FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/themes/contrib/da_vinci/css/README.md
----------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------
10 | WARNING | Line exceeds 80 characters; contains 81 characters
----------------------------------------------------------------------------------------------
FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/themes/contrib/da_vinci/css/user-register.css
------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
------------------------------------------------------------------------------------------------------
FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/themes/contrib/da_vinci/css/user-login.css
---------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
---------------------------------------------------------------------------------------------------
FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/themes/contrib/da_vinci/css/pages/maintenance.css
----------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
----------------------------------------------------------------------------------------------------------
FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/themes/contrib/da_vinci/css/pages/user-password.css
------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
------------------------------------------------------------------------------------------------------------
FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/themes/contrib/da_vinci/css/pages/user-register.css
------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
------------------------------------------------------------------------------------------------------------
FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/themes/contrib/da_vinci/css/pages/user-login.css
---------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
---------------------------------------------------------------------------------------------------------
Time: 348ms; Memory: 12MB
➜ contrib git:(master) ✗
🇵🇭Philippines clarkssquared
Hi
I checked the GITLAB CI in your MR !7 and the PHPCS still failed and this is the issue the GITLAB reported:
Running with gitlab-runner 16.11.0 (91a27b2a)
on gitlab-prod-runner-gitlab-runner-5d6b64f896-rz4f2 _hJ-7HCk, system ID: r_Z0MqGKHApPJk
Resolving secrets
Preparing the "kubernetes" executor
00:00
"CPURequest" overwritten with "2"
Using Kubernetes namespace: gitlabci-prod
Using Kubernetes executor with image drupalci/php-8.1-apache:production ...
Using attach strategy to execute scripts...
Preparing environment
00:31
Using FF_USE_POD_ACTIVE_DEADLINE_SECONDS, the Pod activeDeadlineSeconds will be set to the job timeout: 1h0m0s...
Waiting for pod gitlabci-prod/runner-hj-7hck-project-62103-concurrent-1-ug74h61m to be running, status is Pending
Running on runner-hj-7hck-project-62103-concurrent-1-ug74h61m via gitlab-prod-runner-gitlab-runner-5d6b64f896-rz4f2...
Getting source from Git repository
00:01
Fetching changes with git depth set to 50...
Initialized empty Git repository in /builds/project/masquerade_log/.git/
Created fresh repository.
Checking out b510089b as detached HEAD (ref is 8.x-1.x)...
Skipping Git submodules setup
Downloading artifacts
00:05
Downloading artifacts for composer (1751132)...
Downloading artifacts from coordinator... ok host=drupal-gitlab-job-artifacts.s3.us-west-2.amazonaws.com id=1751132 responseStatus=200 OK token=glcbt-64
Executing "step_script" stage of the job script
00:01
$ [[ $_CURL_TEMPLATES_REF == "" ]] && export _CURL_TEMPLATES_REF=$_GITLAB_TEMPLATES_REF # collapsed multi-line command
$ test -f phpcs.xml.dist || curl -OL https://git.drupalcode.org/$_CURL_TEMPLATES_REPO/-/raw/$_CURL_TEMPLATES_REF/assets/phpcs.xml.dist
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 320 100 320 0 0 2644 0 --:--:-- --:--:-- --:--:-- 2644
$ vendor/bin/phpcs --version
PHP_CodeSniffer version 3.10.1 (stable) by Squiz and PHPCSStandards
$ composer show | awk '$0 ~ /codesniffer|coder|coding-standard|variable-analysis/ {print $1 " " $2}';
dealerdirect/phpcodesniffer-composer-installer 1.0.0
drupal/coder 8.3.24
sirbrillig/phpcs-variable-analysis 2.11.18
slevomat/coding-standard 8.15.0
squizlabs/php_codesniffer 3.10.1
$ vendor/bin/phpcs --config-show installed_paths
Using config file: /builds/project/masquerade_log/vendor/squizlabs/php_codesniffer/CodeSniffer.conf
installed_paths: ../../drupal/coder/coder_sniffer,../../sirbrillig/phpcs-variable-analysis,../../slevomat/coding-standard
$ vendor/bin/phpcs -i
The installed coding standards are MySource, PEAR, PSR1, PSR2, PSR12, Squiz, Zend, Drupal, DrupalPractice, VariableAnalysis and SlevomatCodingStandard
$ vendor/bin/phpcs -s $_WEB_ROOT/modules/custom --report-junit=junit.xml --report-full --report-summary --report-source $_PHPCS_EXTRA
FILE: ...b/modules/custom/masquerade_log/tests/src/Functional/MasqueradeLogTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
3 | ERROR | [x] Expected strict_types=1, found strict_types = 1.
| | (SlevomatCodingStandard.TypeHints.DeclareStrictTypes.IncorrectStrictTypesFormat)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...squerade_log/web/modules/custom/masquerade_log/src/MasqueradeLogLogger.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
3 | ERROR | [x] Expected strict_types=1, found strict_types = 1.
| | (SlevomatCodingStandard.TypeHints.DeclareStrictTypes.IncorrectStrictTypesFormat)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Time: 129ms; Memory: 6MB
PHP CODE SNIFFER REPORT SUMMARY
--------------------------------------------------------------------------------
FILE ERRORS WARNINGS
--------------------------------------------------------------------------------
...b/modules/custom/masquerade_log/src/MasqueradeLogLogger.php 1 0
...m/masquerade_log/tests/src/Functional/MasqueradeLogTest.php 1 0
--------------------------------------------------------------------------------
A TOTAL OF 2 ERRORS AND 0 WARNINGS WERE FOUND IN 3 FILES
--------------------------------------------------------------------------------
PHPCBF CAN FIX 2 OF THESE SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
PHP CODE SNIFFER VIOLATION SOURCE SUMMARY
--------------------------------------------------------------------------------
SOURCE COUNT
--------------------------------------------------------------------------------
[x] SlevomatCodingStandard.TypeHints.DeclareStrictTypes.IncorrectStrictTy 2
--------------------------------------------------------------------------------
A TOTAL OF 2 SNIFF VIOLATIONS WERE FOUND IN 1 SOURCE
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SOURCES AUTOMATICALLY (2 VIOLATIONS IN TOTAL)
--------------------------------------------------------------------------------
Uploading artifacts for failed job
00:02
Uploading artifacts...
junit.xml: found 1 matching artifact files and directories
Uploading artifacts as "archive" to coordinator... 201 Created id=1751134 responseStatus=201 Created token=glcbt-64
Uploading artifacts...
junit.xml: found 1 matching artifact files and directories
Uploading artifacts as "junit" to coordinator... 201 Created id=1751134 responseStatus=201 Created token=glcbt-64
Cleaning up project directory and file based variables
00:00
ERROR: Job failed: command terminated with exit code 1🇵🇭Philippines clarkssquared
Hi quadrexdev,
I looked at your branch and visited the GITLAB CI test and I can see that the phpcs and cspell passes and all are green.
RTBC +1 from me
🇵🇭Philippines clarkssquared
Hi
I applied the updated MR !1 and I confirmed that it has no PHPCS issues,
➜ interface_views_sort git:(1.0.x) curl https://git.drupalcode.org/project/interface_views_sort/-/merge_requests/1.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 11098 0 11098 0 0 20516 0 --:--:-- --:--:-- --:--:-- 20705
patching file .gitlab-ci.yml
patching file interface_views_sort.module
patching file 'src/Plugin/views/sort/LanguageSwitcherSort.php'
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml interface_views_sort
➜ contrib git:(master) ✗
RTBC +1 from me, retaining the status to needs review for others to contribute
🇵🇭Philippines clarkssquared
🇵🇭Philippines clarkssquared
clarkssquared → created an issue. See original summary → .
🇵🇭Philippines clarkssquared
Hi
I applied patch #4 and I confirmed that it fixes the PHPCS issues that were reported.
➜ stop_broken_link_in_body git:(8.x-2.2) curl https://www.drupal.org/files/issues/2023-06-30/fix-phpcs-3371162-4.patch | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 9509 100 9509 0 0 14730 0 --:--:-- --:--:-- --:--:-- 14857
patching file 'src/Controller/BrokenLinkController.php'
patching file 'src/Form/RunContentBrokenLink.php'
patching file stop_broken_link_in_body.module
➜ stop_broken_link_in_body git:(8.x-2.2) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml stop_broken_link_in_body
➜ contrib git:(master) ✗
however, instead of uploading your patdh file here, can you add your changes inside the existing MR? so that if it passed by the community the Maintainer can easily look at it and merge . I will transition the status to needs work for that matter.
🇵🇭Philippines clarkssquared
Hi,
When reporting a PHPCS issues, please look at Apaderno's comment. 🐛 Fix the warnings/errors reported by PHP_CodeSniffer RTBC , Apaderno said in the comment:
Since the issue is showing what PHP_CodeSniffer shows, let us rescope it to fix all the warnings/errors reported by PHP_CodeSniffer.
The issue summary should always describe what the issue is trying to fix and, in the case of coding standards issues, show which command and arguments have been used and which report that command shown. In this way, project maintainers can verify the patch/MR fixes all the warnings/errors.I will move transition the issue to needs work so that the reporter can update it.
🇵🇭Philippines clarkssquared
Hi
I applied the updated MR !2 and I followed the steps to reproduce and confirmed that the PHPCS issues:
➜ contrib git:(master) ✗ phpcs --standard=Drupal --extensions=php,module,inc,install,info,txt,md multi_region
FILE: ...local/web/modules/contrib/multi_region/src/Form/ConfigurableRegionForm.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
10 | WARNING | The class short comment should describe what the class does and
| | not simply repeat the class name
--------------------------------------------------------------------------------
FILE: ...ules/contrib/multi_region/src/Plugin/Block/RegionLanguageSwitcherBlock.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Core\Access\AccessResult.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...b/modules/contrib/multi_region/src/ConfigurableRegionHtmlRouteProvider.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
19 | WARNING | Possible useless method overriding detected
--------------------------------------------------------------------------------
FILE: ...odules/contrib/multi_region/src/ConfigurableRegionAccessControlHandler.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
8 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Core\Access\AccessResult.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...cal/web/modules/contrib/multi_region/src/ConfigurableRegionListBuilder.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
7 | WARNING | [x] Unused use statement
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...rojects/d9/d9-local/web/modules/contrib/multi_region/src/RegionManager.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------------
5 | WARNING | [x] Unused use statement
8 | WARNING | [x] Unused use statement
129 | ERROR | [x] Object operator not indented correctly; expected 8 spaces
| | but found 10
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Time: 157ms; Memory: 8MB
➜ contrib git:(master) ✗ cd multi_region
➜ multi_region git:(master) ✗ curl https://git.drupalcode.org/project/multi_region/-/merge_requests/2.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 10218 0 10218 0 0 19688 0 --:--:-- --:--:-- --:--:-- 19918
patching file 'src/ConfigurableRegionAccessControlHandler.php'
patching file 'src/ConfigurableRegionHtmlRouteProvider.php'
patching file 'src/ConfigurableRegionListBuilder.php'
patching file 'src/Form/ConfigurableRegionForm.php'
patching file 'src/Plugin/Block/RegionLanguageSwitcherBlock.php'
patching file 'src/RegionManager.php'
➜ multi_region git:(master) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal --extensions=php,module,inc,install,info,txt,md multi_region
➜ contrib git:(master) ✗ 🇵🇭Philippines clarkssquared
Hi ptmkenny,
I applied the updated MR !4 after commit 873f5808, and I confirmed that there are no PHPCS issues
➜ jsonrpc git:(2.x) curl https://git.drupalcode.org/project/jsonrpc/-/merge_requests/4.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 11826 0 11826 0 0 26106 0 --:--:-- --:--:-- --:--:-- 26456
patching file 'modules/jsonrpc_core/src/Plugin/jsonrpc/Method/AddPermissionToRole.php'
patching file 'modules/jsonrpc_core/src/Plugin/jsonrpc/Method/Cache.php'
patching file 'modules/jsonrpc_core/src/Plugin/jsonrpc/Method/ListPermissions.php'
patching file 'modules/jsonrpc_core/src/Plugin/jsonrpc/Method/Plugins.php'
patching file 'modules/jsonrpc_core/tests/src/Functional/MaintenanceModeEnabledTest.php'
patching file 'modules/jsonrpc_core/tests/src/Functional/PluginsTest.php'
patching file 'src/Annotation/JsonRpcParameterDefinition.php'
patching file 'src/Handler.php'
patching file 'src/Object/Error.php'
patching file 'src/Object/ParameterBag.php'
patching file 'src/Object/Response.php'
patching file 'src/Plugin/JsonRpcMethodManager.php'
patching file 'src/Shaper/RpcRequestFactory.php'
patching file 'tests/src/Functional/JsonRpcTestBase.php'
patching file 'tests/src/Functional/ResponseHeadersTest.php'
➜ jsonrpc git:(2.x) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml jsonrpc
➜ contrib git:(master) ✗
RTBC +1 from me, I will retain the status to needs review for others to also give their feedbacks.
🇵🇭Philippines clarkssquared
HI
I applied the updated MR !3 and I see some PHPCS issue below:
➜ content_editing_message git:(55518f7) curl https://git.drupalcode.org/project/content_editing_message/-/merge_requests/3.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 8506 0 8506 0 0 14703 0 --:--:-- --:--:-- --:--:-- 14896
patching file README.md
patching file content_editing_message.module
patching file 'src/Controller/ContentEditingMessageListBuilder.php'
patching file 'src/Form/ContentEditingMessageDeleteForm.php'
patching file 'src/Form/ContentEditingMessageFormBase.php'
patching file 'tests/src/Unit/ContentEditingMessageTest.php'
➜ content_editing_message git:(55518f7) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml content_editing_message
FILE: ...web/modules/contrib/content_editing_message/content_editing_message.module
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
82 | ERROR | All functions defined in a module file must be prefixed with the
| | module's name, found "append_message" but expected
| | "content_editing_message_append_message"
--------------------------------------------------------------------------------
FILE: ...contrib/content_editing_message/src/Form/ContentEditingMessageFormBase.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------------
194 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency
| | injection instead
301 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: )
313 | ERROR | [ ] The array declaration extends to column 125 (the limit is
| | 80). The array content should be split up over multiple
| | lines
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Time: 266ms; Memory: 12MB
➜ contrib git:(master) ✗
Retaining this to needs review for others to give feedback.
🇵🇭Philippines clarkssquared
Hi
I applied the updated MR !4 and there's still a PHPCS error below:
➜ jsonrpc git:(2.x) curl https://git.drupalcode.org/project/jsonrpc/-/merge_requests/4.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 10938 0 10938 0 0 16218 0 --:--:-- --:--:-- --:--:-- 16374
patching file 'modules/jsonrpc_core/src/Plugin/jsonrpc/Method/AddPermissionToRole.php'
patching file 'modules/jsonrpc_core/src/Plugin/jsonrpc/Method/Cache.php'
patching file 'modules/jsonrpc_core/src/Plugin/jsonrpc/Method/ListPermissions.php'
patching file 'modules/jsonrpc_core/src/Plugin/jsonrpc/Method/Plugins.php'
patching file 'modules/jsonrpc_core/tests/src/Functional/MaintenanceModeEnabledTest.php'
patching file 'modules/jsonrpc_core/tests/src/Functional/PluginsTest.php'
patching file 'src/Annotation/JsonRpcParameterDefinition.php'
patching file 'src/Handler.php'
patching file 'src/Object/Error.php'
patching file 'src/Object/ParameterBag.php'
patching file 'src/Object/Response.php'
patching file 'src/Plugin/JsonRpcMethodManager.php'
patching file 'src/Shaper/RpcRequestFactory.php'
patching file 'tests/src/Functional/JsonRpcTestBase.php'
patching file 'tests/src/Functional/ResponseHeadersTest.php'
➜ jsonrpc git:(2.x) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml jsonrpc
FILE: ...9/d9-local/web/modules/contrib/jsonrpc/src/Plugin/JsonRpcMethodManager.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Core\Cache\CacheBackendInterface.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...s/d9/d9-local/web/modules/contrib/jsonrpc/src/Shaper/RpcRequestFactory.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
12 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\jsonrpc\ParameterDefinitionInterface.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Time: 646ms; Memory: 12MB
➜ contrib git:(master) ✗
Below is the full PHPCS result before and after applying the MR !4
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml jsonrpc
FILE: ...local/web/modules/contrib/jsonrpc/tests/src/Functional/JsonRpcTestBase.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
15 | WARNING | The class short comment should describe what the class does and
| | not simply repeat the class name
--------------------------------------------------------------------------------
FILE: ...l/web/modules/contrib/jsonrpc/tests/src/Functional/ResponseHeadersTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
16 | ERROR | Missing member variable doc comment
--------------------------------------------------------------------------------
FILE: ...c/modules/jsonrpc_core/tests/src/Functional/MaintenanceModeEnabledTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
15 | ERROR | Missing member variable doc comment
--------------------------------------------------------------------------------
FILE: .../contrib/jsonrpc/modules/jsonrpc_core/tests/src/Functional/PluginsTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
15 | ERROR | Missing member variable doc comment
--------------------------------------------------------------------------------
FILE: ...rpc/modules/jsonrpc_core/src/Plugin/jsonrpc/Method/AddPermissionToRole.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
31 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...s/contrib/jsonrpc/modules/jsonrpc_core/src/Plugin/jsonrpc/Method/Cache.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
16 | WARNING | The class short comment should describe what the class does and
| | not simply repeat the class name
--------------------------------------------------------------------------------
FILE: ...contrib/jsonrpc/modules/jsonrpc_core/src/Plugin/jsonrpc/Method/Plugins.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------
63 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
65 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...jsonrpc/modules/jsonrpc_core/src/Plugin/jsonrpc/Method/ListPermissions.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
37 | WARNING | [x] 'TODO: Fix the schema.' should match the format '@todo Fix
| | problem X here.'
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...ng-subing/Projects/d9/d9-local/web/modules/contrib/jsonrpc/src/Handler.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------------
155 | WARNING | [x] '@TODO: Remove the following when PHP7 is the minimum
| | supported version.' should match the format '@todo Fix
| | problem X here.'
218 | WARNING | [x] 'TODO: Add cacheability metadata here.' should match the
| | format '@todo Fix problem X here.'
219 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...9/d9-local/web/modules/contrib/jsonrpc/src/Plugin/JsonRpcMethodManager.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Core\Cache\CacheBackendInterface.
41 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: .../web/modules/contrib/jsonrpc/src/Annotation/JsonRpcParameterDefinition.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
72 | ERROR | [x] Use null coalesce operator instead of ternary operator.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...s/d9/d9-local/web/modules/contrib/jsonrpc/src/Shaper/RpcRequestFactory.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
--------------------------------------------------------------------------------
12 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\jsonrpc\ParameterDefinitionInterface.
106 | ERROR | [x] Use null coalesce operator instead of ternary operator.
177 | WARNING | [x] 'TODO: Wrap other shaper transformations in a similar way
| | for nicer' should match the format '@todo Fix problem X
| | here.'
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...g/Projects/d9/d9-local/web/modules/contrib/jsonrpc/src/Object/Response.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
58 | ERROR | Parameter $headers is not described in comment
--------------------------------------------------------------------------------
FILE: ...bing/Projects/d9/d9-local/web/modules/contrib/jsonrpc/src/Object/Error.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
22 | ERROR | Missing member variable doc comment
30 | ERROR | Missing member variable doc comment
--------------------------------------------------------------------------------
FILE: ...ojects/d9/d9-local/web/modules/contrib/jsonrpc/src/Object/ParameterBag.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
49 | ERROR | [x] Use null coalesce operator instead of ternary operator.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Time: 712ms; Memory: 12MB
➜ contrib git:(master) ✗ cd jsonrpc
➜ jsonrpc git:(2.x) curl https://git.drupalcode.org/project/jsonrpc/-/merge_requests/4.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 10938 0 10938 0 0 16218 0 --:--:-- --:--:-- --:--:-- 16374
patching file 'modules/jsonrpc_core/src/Plugin/jsonrpc/Method/AddPermissionToRole.php'
patching file 'modules/jsonrpc_core/src/Plugin/jsonrpc/Method/Cache.php'
patching file 'modules/jsonrpc_core/src/Plugin/jsonrpc/Method/ListPermissions.php'
patching file 'modules/jsonrpc_core/src/Plugin/jsonrpc/Method/Plugins.php'
patching file 'modules/jsonrpc_core/tests/src/Functional/MaintenanceModeEnabledTest.php'
patching file 'modules/jsonrpc_core/tests/src/Functional/PluginsTest.php'
patching file 'src/Annotation/JsonRpcParameterDefinition.php'
patching file 'src/Handler.php'
patching file 'src/Object/Error.php'
patching file 'src/Object/ParameterBag.php'
patching file 'src/Object/Response.php'
patching file 'src/Plugin/JsonRpcMethodManager.php'
patching file 'src/Shaper/RpcRequestFactory.php'
patching file 'tests/src/Functional/JsonRpcTestBase.php'
patching file 'tests/src/Functional/ResponseHeadersTest.php'
➜ jsonrpc git:(2.x) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml jsonrpc
FILE: ...9/d9-local/web/modules/contrib/jsonrpc/src/Plugin/JsonRpcMethodManager.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Core\Cache\CacheBackendInterface.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...s/d9/d9-local/web/modules/contrib/jsonrpc/src/Shaper/RpcRequestFactory.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
12 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\jsonrpc\ParameterDefinitionInterface.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Time: 646ms; Memory: 12MB
➜ contrib git:(master) ✗
Moving this to needs work
🇵🇭Philippines clarkssquared
🇵🇭Philippines clarkssquared
Hi
I agree with comment #3, also for deepak5423 instead of uploading the README file here you can just create a patch or create a Merge Request so that the maintainers can look at it and they can easily merge. for README file let's follow the Drupal README.md template → hence I will move the status to needs work
🇵🇭Philippines clarkssquared
Hi
I applied the patch and I confirmed that it fixes the PHPCS issues and the remaining issue occurs when a module is installed via composer.
➜ body_node_id_class git:(master) ✗ curl https://www.drupal.org/files/issues/2024-05-15/resolve_phpcs_issues.patch | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 1982 100 1982 0 0 3242 0 --:--:-- --:--:-- --:--:-- 3281
patching file README.md
patching file body_node_id_class.module
➜ body_node_id_class git:(master) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml body_node_id_class
FILE: ...9-local/web/modules/contrib/body_node_id_class/body_node_id_class.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by
| | drupal.org packaging automatically
--------------------------------------------------------------------------------
Time: 104ms; Memory: 10MB
➜ contrib git:(master) ✗ RTBC +1 from me, I will retain the status to Needs Review for others to review the patch
🇵🇭Philippines clarkssquared
Hi
I applied the patch and I confirmed that it fixes the PHPCS issues.
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml entityform_block
FILE: ...ules/contrib/entityform_block/tests/src/Functional/EntityFormBlockTest.php
--------------------------------------------------------------------------------
FOUND 8 ERRORS AND 5 WARNINGS AFFECTING 12 LINES
--------------------------------------------------------------------------------
24 | ERROR | [x] Short array syntax must be used to define arrays
30 | WARNING | [x] A comma should follow the last multiline array item. Found:
| | 'contact'
38 | ERROR | [x] Short array syntax must be used to define arrays
38 | ERROR | [ ] The array declaration extends to column 82 (the limit is
| | 80). The array content should be split up over multiple
| | lines
40 | ERROR | [x] Short array syntax must be used to define arrays
59 | ERROR | [x] Short array syntax must be used to define arrays
62 | WARNING | [ ] t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
73 | ERROR | [x] Short array syntax must be used to define arrays
78 | WARNING | [ ] t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
83 | ERROR | [x] Short array syntax must be used to define arrays
86 | WARNING | [ ] t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
96 | ERROR | [x] Short array syntax must be used to define arrays
99 | WARNING | [ ] t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...l/web/modules/contrib/entityform_block/tests/src/Functional/LocaleTest.php
--------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
15 | ERROR | [ ] Missing member variable doc comment
27 | ERROR | [x] Expected 1 space after "="; 2 found
29 | ERROR | [x] Short array syntax must be used to define arrays
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: .../modules/contrib/entityform_block/src/Plugin/Block/EntityEditFormBlock.php
--------------------------------------------------------------------------------
FOUND 7 ERRORS AND 2 WARNINGS AFFECTING 9 LINES
--------------------------------------------------------------------------------
76 | ERROR | [x] Short array syntax must be used to define arrays
105 | ERROR | [x] Short array syntax must be used to define arrays
123 | ERROR | [x] Short array syntax must be used to define arrays
148 | ERROR | [x] Short array syntax must be used to define arrays
152 | ERROR | [x] Short array syntax must be used to define arrays
160 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency
| | injection instead
166 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency
| | injection instead
167 | ERROR | [x] Expected 1 blank line after function; 0 found
168 | ERROR | [x] The closing brace for the class must have an empty line
| | before it
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Time: 125ms; Memory: 10MB
➜ contrib git:(master) ✗ cd entityform_block
➜ entityform_block git:(8.x-1.0-alpha4) curl https://www.drupal.org/files/issues/2024-05-16/resolve_phpcs_issues.patch | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 10024 100 10024 0 0 32212 0 --:--:-- --:--:-- --:--:-- 33082
patching file 'src/Plugin/Block/EntityEditFormBlock.php'
patching file 'tests/src/Functional/EntityFormBlockTest.php'
patching file 'tests/src/Functional/LocaleTest.php'
➜ entityform_block git:(8.x-1.0-alpha4) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml entityform_block
➜ contrib git:(master) ✗
RTBC +1 from me. retaining the status to needs review for others to verify the patch
🇵🇭Philippines clarkssquared
Hi
I applied the MR !2 and I can still see many PHPCS issues and errors
➜ da_vinci git:(9.1.0-beta2) curl https://git.drupalcode.org/project/da_vinci/-/merge_requests/2.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 1187 0 1187 0 0 2214 0 --:--:-- --:--:-- --:--:-- 2235
patching file da_vinci.theme
patching file 'subtheme/subtheme.theme'
➜ da_vinci git:(9.1.0-beta2) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml da_vinci
FILE: ...g/Projects/d9/d9-local/web/themes/contrib/da_vinci/subtheme/subtheme.theme
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
--------------------------------------------------------------------------------
8 | WARNING | [x] Unused use statement
9 | WARNING | [x] Unused use statement
10 | WARNING | [x] Unused use statement
11 | WARNING | [x] Unused use statement
12 | WARNING | [x] Unused use statement
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...ng/Projects/d9/d9-local/web/themes/contrib/da_vinci/subtheme/subtheme.info
--------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | ERROR | "name" property is missing in the info file
1 | ERROR | "description" property is missing in the info file
1 | ERROR | "core" property is missing in the info file
--------------------------------------------------------------------------------
FILE: ...-subing/Projects/d9/d9-local/web/themes/contrib/da_vinci/da_vinci.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | Remove "version" from the info file, it will be added by
| | drupal.org packaging automatically
--------------------------------------------------------------------------------
FILE: ...ubing/Projects/d9/d9-local/web/themes/contrib/da_vinci/css/maintenance.css
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
--------------------------------------------------------------------------------
FILE: ...ing/Projects/d9/d9-local/web/themes/contrib/da_vinci/css/user-password.css
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
--------------------------------------------------------------------------------
FILE: ...ubing-subing/Projects/d9/d9-local/web/themes/contrib/da_vinci/css/main.css
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
--------------------------------------------------------------------------------
FILE: ...bing-subing/Projects/d9/d9-local/web/themes/contrib/da_vinci/css/README.md
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
10 | WARNING | Line exceeds 80 characters; contains 81 characters
--------------------------------------------------------------------------------
FILE: ...ing/Projects/d9/d9-local/web/themes/contrib/da_vinci/css/user-register.css
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
--------------------------------------------------------------------------------
FILE: ...subing/Projects/d9/d9-local/web/themes/contrib/da_vinci/css/user-login.css
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
--------------------------------------------------------------------------------
FILE: ...Projects/d9/d9-local/web/themes/contrib/da_vinci/css/pages/maintenance.css
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
--------------------------------------------------------------------------------
FILE: ...ojects/d9/d9-local/web/themes/contrib/da_vinci/css/pages/user-password.css
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
--------------------------------------------------------------------------------
FILE: ...ojects/d9/d9-local/web/themes/contrib/da_vinci/css/pages/user-register.css
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
--------------------------------------------------------------------------------
FILE: .../Projects/d9/d9-local/web/themes/contrib/da_vinci/css/pages/user-login.css
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
--------------------------------------------------------------------------------
Time: 375ms; Memory: 12MB
➜ contrib git:(master) ✗
🇵🇭Philippines clarkssquared
Hi silvi
I applied your patch #17 and I can still see some PHPCS errors
➜ entity_usage git:(642974e) curl https://www.drupal.org/files/issues/2024-04-24/3332136-entity-usage-17.patch | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 36980 100 36980 0 0 65083 0 --:--:-- --:--:-- --:--:-- 66035
patching file entity_usage.install
patching file entity_usage.module
patching file entity_usage.post_update.php
patching file 'src/Commands/EntityUsageCommands.php'
patching file 'src/Controller/ListUsageController.php'
patching file 'src/EntityUpdateManager.php'
patching file 'src/EntityUpdateManagerInterface.php'
patching file 'src/EntityUsage.php'
patching file 'src/EntityUsageBatchManager.php'
patching file 'src/EntityUsageInterface.php'
patching file 'src/EntityUsageQueueBatchManager.php'
patching file 'src/EntityUsageTrackBase.php'
patching file 'src/Form/BatchUpdateForm.php'
patching file 'src/Form/EntityUsageSettingsForm.php'
patching file 'src/Plugin/EntityUsage/Track/BlockField.php'
patching file 'src/Plugin/EntityUsage/Track/CkeditorImage.php'
patching file 'src/Plugin/EntityUsage/Track/EntityEmbed.php'
patching file 'src/Plugin/EntityUsage/Track/LayoutBuilder.php'
patching file 'src/Plugin/EntityUsage/Track/LinkIt.php'
patching file 'src/Plugin/EntityUsage/Track/MediaEmbed.php'
patching file 'src/Plugin/QueueWorker/EntityUsageRegenerateTrackingInfoWorker.php'
patching file 'tests/modules/entity_usage_test/config/install/field.storage.node.field_eu_test_related_nodes.yml'
patching file 'tests/modules/entity_usage_test/src/Plugin/Block/DependenciesBlock.php'
patching file 'tests/src/FunctionalJavascript/EmbeddedContentTest.php'
patching file 'tests/src/FunctionalJavascript/EntityUsageLayoutBuilderEntityBrowserBlockTest.php'
patching file 'tests/src/FunctionalJavascript/IntegrationTest.php'
patching file 'tests/src/Kernel/EntityUsageTest.php'
patching file 'tests/src/Kernel/EntityUsageTrackFileTest.php'
➜ entity_usage git:(642974e) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml entity_usage
FILE: ...bing/Projects/d9/d9-local/web/modules/contrib/entity_usage/tests/src/FunctionalJavascript/EmbeddedContentTest.php
-----------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------
431 | ERROR | The array declaration extends to column 111 (the limit is 80). The array content should be split up
| | over multiple lines
-----------------------------------------------------------------------------------------------------------------------
FILE: ...ubing/Projects/d9/d9-local/web/modules/contrib/entity_usage/tests/src/Functional/EntityUsageLayoutBuilderTest.php
-----------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------
65 | ERROR | The array declaration extends to column 81 (the limit is 80). The array content should be split up over
| | multiple lines
66 | ERROR | The array declaration extends to column 81 (the limit is 80). The array content should be split up over
| | multiple lines
-----------------------------------------------------------------------------------------------------------------------
FILE: ...ers/clarksubing-subing/Projects/d9/d9-local/web/modules/contrib/entity_usage/src/Commands/EntityUsageCommands.php
-----------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------
80 | ERROR | The array declaration extends to column 113 (the limit is 80). The array content should be split up over
| | multiple lines
-----------------------------------------------------------------------------------------------------------------------
Time: 2.35 secs; Memory: 16MB
➜ contrib git:(master) ✗
If possible, add your fixes in the existing Merge Request so that maintainers can test it conveniently.
🇵🇭Philippines clarkssquared
Hi
I applied the updated MR !24 and I can still see PHPCS issues
➜ field_permissions git:(a5aee30) curl https://git.drupalcode.org/project/field_permissions/-/merge_requests/24.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 19437 0 19437 0 0 33991 0 --:--:-- --:--:-- --:--:-- 34462
patching file CHANGELOG.md
patching file field_permissions.info.yml
patching file field_permissions.module
patching file 'src/Controller/FieldPermissionsController.php'
patching file 'src/FieldPermissionsService.php'
patching file 'src/Plugin/migrate/process/FieldPermissionSettings.php'
patching file 'tests/modules/field_permissions_test/src/Plugin/FieldPermissionType/TestAccess.php'
patching file 'tests/src/Unit/FieldPermissionsServiceTest.php'
patching file 'tests/src/Unit/Plugin/FieldPermissionType/CustomAccessTest.php'
patching file 'tests/src/Unit/Plugin/FieldPermissionType/PrivateAccessTest.php'
➜ field_permissions git:(a5aee30) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml field_permissions
FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/modules/contrib/field_permissions/CHANGELOG.md
-------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------
15 | WARNING | Line exceeds 80 characters; contains 84 characters
50 | WARNING | Line exceeds 80 characters; contains 88 characters
-------------------------------------------------------------------------------------------------------
FILE: ...-subing/Projects/d9/d9-local/web/modules/contrib/field_permissions/tests/src/Unit/FieldPermissionsServiceTest.php
-----------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------
144 | ERROR | The array declaration extends to column 95 (the limit is 80). The array content should be split up over
| | multiple lines
-----------------------------------------------------------------------------------------------------------------------
FILE: ...g/Projects/d9/d9-local/web/modules/contrib/field_permissions/tests/src/Functional/FieldPermissionsCommentTest.php
-----------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------
194 | ERROR | The array declaration extends to column 98 (the limit is 80). The array content should be split up over
| | multiple lines
-----------------------------------------------------------------------------------------------------------------------
FILE: ...bing/Projects/d9/d9-local/web/modules/contrib/field_permissions/tests/src/Functional/FieldPermissionsNodeTest.php
-----------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AND 1 WARNING AFFECTING 4 LINES
-----------------------------------------------------------------------------------------------------------------------
74 | ERROR | The array declaration extends to column 98 (the limit is 80). The array content should be split up
| | over multiple lines
91 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
212 | ERROR | The array declaration extends to column 104 (the limit is 80). The array content should be split up
| | over multiple lines
238 | ERROR | The array declaration extends to column 94 (the limit is 80). The array content should be split up
| | over multiple lines
-----------------------------------------------------------------------------------------------------------------------
FILE: ...bing-subing/Projects/d9/d9-local/web/modules/contrib/field_permissions/src/Plugin/FieldPermissionType/Manager.php
-----------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------
56 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-----------------------------------------------------------------------------------------------------------------------
FILE: ...g-subing/Projects/d9/d9-local/web/modules/contrib/field_permissions/src/Controller/FieldPermissionsController.php
-----------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------
100 | ERROR | The array declaration extends to column 95 (the limit is 80). The array content should be split up over
| | multiple lines
-----------------------------------------------------------------------------------------------------------------------
Time: 877ms; Memory: 12MB
retaining the status to needs review so that others can give their feedback
🇵🇭Philippines clarkssquared
Hi
I applied MR !2 and there are few PHPCS warning and errors
➜ file_management git:(6c34ec1) curl https://git.drupalcode.org/project/file_management/-/merge_requests/2.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 24382 0 24382 0 0 44059 0 --:--:-- --:--:-- --:--:-- 44574
patching file .gitlab-ci.yml
patching file composer.json
patching file file_management.info.yml
patching file 'modules/file_management_view/README.md'
patching file 'modules/file_management_view/file_management_view.info.yml'
patching file 'modules/file_management_view/file_management_view.install'
patching file 'modules/file_management_view/src/Controller/FileManagementViewController.php'
patching file 'src/Controller/FileManagementController.php'
patching file 'src/FileManagement.php'
patching file 'src/Form/FileManagementDeleteFileConfirmForm.php'
patching file 'src/Form/FileManagementEditFileForm.php'
patching file 'src/Plugin/views/field/FileManagementOperations.php'
➜ file_management git:(6c34ec1) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml file_management
FILE: .../web/modules/contrib/file_management/modules/file_management_view/src/Controller/FileManagementViewController.php
-----------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------
23 | WARNING | Line exceeds 80 characters; contains 98 characters
-----------------------------------------------------------------------------------------------------------------------
FILE: ...arksubing-subing/Projects/d9/d9-local/web/modules/contrib/file_management/src/Form/FileManagementEditFileForm.php
-----------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is
| | Drupal\Core\Entity\EntityTypeManagerInterface.
-----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------
FILE: ...bing/Projects/d9/d9-local/web/modules/contrib/file_management/src/Plugin/views/field/FileManagementOperations.php
-----------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Url.
-----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------
FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/modules/contrib/file_management/src/FileManagement.php
-----------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is
| | Drupal\field\Entity\FieldConfig.
-----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------
FILE: ...ubing-subing/Projects/d9/d9-local/web/modules/contrib/file_management/src/Controller/FileManagementController.php
-----------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------
10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is
| | Drupal\file_management\FileManagement.
-----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------
Time: 384ms; Memory: 10MB
➜ contrib git:(master) ✗
retaining the status to needs review for others to take a look and if they can replicate the issues I reported
🇵🇭Philippines clarkssquared
Hi
I checked the MR !3 and can we make the README.md file to follow the Drupal README.md template →
🇵🇭Philippines clarkssquared
Hi
I looked at the README.md file in the 3226913-add-a-detailed branch and I suggest that revise the README.md file according to Drupal README.md template → to meet Drupal's standard.
🇵🇭Philippines clarkssquared
Hi
I applied MR !17 and there are PHPCS issues that were reported
➜ tagadelic git:(master) ✗ curl https://git.drupalcode.org/project/tagadelic/-/merge_requests/17.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 4299 0 4299 0 0 8480 0 --:--:-- --:--:-- --:--:-- 8615
patching file README.md
patching file 'css/tagadelic.css'
patching file 'src/TagadelicCloudView.php'
➜ tagadelic git:(master) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml tagadelic
FILE: ...bing/Projects/d9/d9-local/web/modules/contrib/tagadelic/tagadelic.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by
| | drupal.org packaging automatically
--------------------------------------------------------------------------------
FILE: ...ing/Projects/d9/d9-local/web/modules/contrib/tagadelic/tagadelic.theme.inc
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
28 | ERROR | The array declaration extends to column 106 (the limit is 80).
| | The array content should be split up over multiple lines
--------------------------------------------------------------------------------
FILE: ...jects/d9/d9-local/web/modules/contrib/tagadelic/src/TagadelicCloudBase.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------
93 | WARNING | Unused private method sortByname()
100 | WARNING | Unused private method sortBycount()
--------------------------------------------------------------------------------
FILE: .../d9/d9-local/web/modules/contrib/tagadelic/src/Tests/TagadelicMenuTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
24 | ERROR | The array declaration extends to column 102 (the limit is 80).
| | The array content should be split up over multiple lines
--------------------------------------------------------------------------------
FILE: .../d9-local/web/modules/contrib/tagadelic/src/Tests/TagadelicServiceTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
121 | ERROR | The array declaration extends to column 81 (the limit is 80).
| | The array content should be split up over multiple lines
--------------------------------------------------------------------------------
FILE: ...d9/d9-local/web/modules/contrib/tagadelic/src/Tests/TagadelicAdminTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
33 | ERROR | The array declaration extends to column 102 (the limit is 80).
| | The array content should be split up over multiple lines
--------------------------------------------------------------------------------
Time: 532ms; Memory: 10MB
➜ contrib git:(master) ✗
🇵🇭Philippines clarkssquared
Hi Mohd
I applied your MR !1 and I noticed that the README.md file has missing required sections and doesn't follow the Drupal README.md template → please revise it according to Drupal's standard.
🇵🇭Philippines clarkssquared
I applied MR !4 and I can still see these PHPCS errors
opigno_poll git:(master) ✗ curl https://git.drupalcode.org/project/opigno_poll/-/merge_requests/4.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 51667 0 51667 0 0 59528 0 --:--:-- --:--:-- --:--:-- 60008
patching file opigno_poll.install
patching file opigno_poll.links.action.yml
patching file opigno_poll.links.menu.yml
patching file opigno_poll.module
patching file 'src/Entity/Poll.php'
patching file 'src/Form/PollDeleteForm.php'
patching file 'src/Form/PollForm.php'
patching file 'src/Form/PollSettingsForm.php'
patching file 'src/Form/PollViewForm.php'
patching file 'src/Plugin/Block/ChartBlock.php'
patching file 'src/Plugin/Block/PollRecentBlock.php'
patching file 'src/Plugin/Field/FieldWidget/PollChoiceDefaultWidget.php'
patching file 'src/Plugin/migrate/destination/PollVote.php'
patching file 'src/Plugin/views/field/PollStatus.php'
patching file 'src/PollAccessControlHandler.php'
patching file 'src/PollInterface.php'
patching file 'src/PollListBuilder.php'
patching file 'src/PollPostRenderCache.php'
patching file 'src/PollVoteStorage.php'
➜ opigno_poll git:(master) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml opigno_poll
FILE: ...s/d9/d9-local/web/modules/contrib/opigno_poll/opigno_poll.links.action.yml
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
6 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: .../Projects/d9/d9-local/web/modules/contrib/opigno_poll/opigno_poll.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by
| | drupal.org packaging automatically
--------------------------------------------------------------------------------
FILE: ...ng/Projects/d9/d9-local/web/modules/contrib/opigno_poll/opigno_poll.module
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
11 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\opigno_poll\PollInterface.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...bing-subing/Projects/d9/d9-local/web/modules/contrib/opigno_poll/README.md
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
4 | WARNING | Line exceeds 80 characters; contains 195 characters
--------------------------------------------------------------------------------
FILE: ...ects/d9/d9-local/web/modules/contrib/opigno_poll/src/Form/PollViewForm.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
14 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Core\Render\RendererInterface.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...ntrib/opigno_poll/src/Plugin/Field/FieldWidget/PollChoiceDefaultWidget.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
10 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Core\Entity\EntityTypeManagerInterface.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...9/d9-local/web/modules/contrib/opigno_poll/src/Plugin/Block/ChartBlock.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
10 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\opigno_poll\PollVoteStorageInterface.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...ts/d9/d9-local/web/modules/contrib/opigno_poll/src/PollPostRenderCache.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Core\DependencyInjection\ClassResolver.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...ojects/d9/d9-local/web/modules/contrib/opigno_poll/src/PollVoteStorage.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
8 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Core\Entity\EntityTypeManagerInterface.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Time: 829ms; Memory: 12MB
➜ contrib git:(master) ✗
🇵🇭Philippines clarkssquared
Hi
I applied MR !8 and tested the PHPCS and I confirmed that it fixes the PHPCS issues
➜ webform_analysis git:(b254416) curl https://git.drupalcode.org/project/webform_analysis/-/merge_requests/8.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 6078 0 6078 0 0 11687 0 --:--:-- --:--:-- --:--:-- 11801
patching file 'modules/webform_node_analysis/src/EntityTypeInfo.php'
patching file 'modules/webform_node_analysis/src/Plugin/Derivative/WebformNodeAnalysisLocalTask.php'
patching file 'src/Form/WebformAnalysisForm.php'
patching file 'src/Plugin/Block/WebformAnalysisBlock.php'
patching file 'src/WebformAnalysis.php'
patching file 'src/WebformAnalysisInterface.php'
➜ webform_analysis git:(b254416) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml webform_analysis
➜ contrib git:(master) ✗ 🇵🇭Philippines clarkssquared
Hi
I applied the MR !6 and it says in my terminal composer.json file not found
➜ simple_styleguide git:(2.0.x) curl https://git.drupalcode.org/project/simple_styleguide/-/merge_requests/6.diff | git apply -v
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 1619 0 1619 0 0 3150 0 --:--:-- --:--:-- --:--:-- 3199
Checking patch composer.json...
error: composer.json: No such file or directory
Checking patch src/Controller/DefaultController.php...
Checking patch src/Form/StyleguideSettings.php...
➜ simple_styleguide git:(2.0.x) 🇵🇭Philippines clarkssquared
Hi
I apply the updated MR !36 into the module and it applied successfully, but when I try to execute the PHPCS command, I can also see the same phpcs issue that comment #9
➜ config_pages git:(master) ✗ curl https://git.drupalcode.org/project/config_pages/-/merge_requests/36.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 29496 0 29496 0 0 28574 0 --:--:-- 0:00:01 --:--:-- 28917
patching file config_pages.module
patching file 'src/Command/GetValueCommand.php'
patching file 'src/Command/SetValueCommand.php'
patching file 'src/ConfigPagesAccessControlHandler.php'
patching file 'src/ConfigPagesContextBase.php'
patching file 'src/ConfigPagesContextManager.php'
patching file 'src/ConfigPagesForm.php'
patching file 'src/ConfigPagesListBuilder.php'
patching file 'src/ConfigPagesPermissions.php'
patching file 'src/ConfigPagesTypeForm.php'
patching file 'src/ConfigPagesTypeListBuilder.php'
patching file 'src/Controller/ConfigPagesController.php'
patching file 'src/Entity/ConfigPages.php'
patching file 'src/Entity/ConfigPagesType.php'
patching file 'src/Form/ConfigPagesClearConfirmationForm.php'
patching file 'src/Plugin/Block/ConfigPagesBlock.php'
patching file 'src/Plugin/Condition/ConfigPagesValueAccess.php'
1 out of 3 hunks failed--saving rejects to 'src/Plugin/Condition/ConfigPagesValueAccess.php.rej'
patching file 'tests/src/Functional/ClearConfigPageTest.php'
patching file 'tests/src/Functional/DeleteConfigPageTypeTest.php'
➜ config_pages git:(master) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml
ERROR: You must supply at least one file or directory to process.
Run "phpcs --help" for usage information
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml config_pages
FILE: ...rojects/d9/d9-local/web/modules/contrib/config_pages/config_pages.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by
| | drupal.org packaging automatically
--------------------------------------------------------------------------------
FILE: ...dules/contrib/config_pages/src/Plugin/Condition/ConfigPagesValueAccess.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------
217 | WARNING | Unused variable $cp_type.
217 | WARNING | Unused variable $data_type.
--------------------------------------------------------------------------------
Time: 872ms; Memory: 12MB
➜ contrib git:(master) ✗
🇵🇭Philippines clarkssquared
Hi
I applied MR 5 and I confirmed that it fixes the WSOD error after installing the sitewide-alerts module, I attached the screenshots of before and after I applied the patch
🇵🇭Philippines clarkssquared
Hi
I looked at your patch #2 and I suggest to rearrange the README.md according to Drupal README.md template →
🇵🇭Philippines clarkssquared
Hi
I applied MR !12 and I confirmed that it replaced the README.txt file with README.md, its content is good though I suggest to arrange it according to Drupal README.md template → hence moving this to needs work
For convenience this is the README.md that the MR !12 created:
# Panelizer
The Panelizer module allows supported entities to be treated as Panels, giving options for different default displays on a per bundle basis. For example, this allows each node display to be customized individually.
Panelizer is a descendent and replacement for the "Panel Nodes" module bundled with Panels; no upgrade path is available as of yet.
## Features
* Supports all of Drupal core's included entities - nodes, taxonomy terms, users, and comments. (More may be available in the future)
* Can be easily extended to support additional entities, e.g., Fieldable Panels Panes and Bean includes full support.
* Each entity bundle (content type, vocabulary, etc) may have each view mode configured individually, allowing for each to be tailored separately.
* Each entity bundle may optionally have multiple displays defined; if this option is enabled, each entity of that type/bundle will have an option to select which is used.
* Each entity bundle / view mode combination may its default display controlled.
* Full support for content revisions, and provides integration with both Revisioning and Workbench Moderation.
## Requirements
* CTools v7.x-1.9 or newer.
* Panels v7.x-3.6 or newer.
## Installation
Install as you would normally install a contributed Drupal module.
For further information, see [Installing Drupal Modules](https://www.drupal.org/docs/extending-drupal/installing-drupal-modules).
## Configuration & Usage
Visit Structure >> Panelizer to enable the module for the entities you need; these may also be controlled via the entity bundle's settings page, e.g., for an "Article" content type it may be enabled at the following page: `admin/structure/types/manage/article`. You may need to visit Site Building >> Pages and enable the appropriate pages for supported entities to use their "Full page override" view mode.
Note that in all cases, modifying Panelizer settings for an entity requires the corresponding 'update' permission for that entity.
Panelizer operates in four basic modes:
- **No Default, No Choice:**
In this mode, the given bundle is panelized, but there is no default panel associated or selectable. In this case, each entity has a small form on the "Customize display" tab that says to 'Panelize it!'. When this button is clicked, a default panel is attached to the entity, and the display may then be customized.
- **With Default, No Choice:**
In this mode, all entities of the given bundle are given the default panel automatically. Users with appropriate privileges may then customize the panel for that node. Once customized, the default is no longer applied, and changes to the default will not propagate downstream.
- **No Default, With Choice:**
In this mode, all entities of this bundle will be given a selector to choose which panel to display on the entity page. The default choice will be "No Panel". When a panel has been chosen, users with permission can then customize that panel. Once this is done, the default choice will no longer be associated with the panel, and a choice can no longer be made. The "Reset" button on the Panelizer settings tab for that entity can return the entity to a default state and restore the choice.
- **With Default, With Choice:**
Like above, entities will have a selector to choose which panel to use. However, unlike above, entities that have never made a selection will automatically be given the default panel. All configured entities will have some kind of panel, whether it is one of the choices or a customized panel for that entity.
## Entity View Modes
Panelizer will allow you to panelize each view mode individually. One view mode, the "Full page override," is not actually a view mode - it uses Page Manager to completely override the output of the page the entity is viewed on. This will often conflict somewhat with the Default view mode. It is recommended that you do not panelize both the Default and the Full page override, but instead pick whichever one you think is most needed. The actual difference between the two is quite subtle: Placement of the title is different, and the comment form will not appear in the Default view mode but it will appear in the Full Page Override.
## Permissions
Once Panelizer is enabled for an entity/bundle combination, it may be necessary to visit People >> Permissions and give users appropriate permissions. All of the Panelizer tabs have their own permission, and if these are revoked it is possible to create panelized entities that can only choose panels but not modify them.
## Known Issues / Caveats
Panelizer currently uses the Page Manager to render the panelized entities. At this time there is no direct support for view modes. This is a desired feature, though we are somewhat hampered by Drupal only allowing 2 levels of local tasks (tabs) where configuring for multiple view modes really would prefer a third level.
Panelizer 7.x-3.x is Revision Aware. This has the downside that duplicating panels for revisions can generate a lot of extra data. Please keep this in mind -- it may be necessary to periodically clean up older revisions.
## API
Panelizer 7.x-3.x is constructed on an Object Oriented plugin. There is one plugin per entity type and it MUST be named exactly the same as the entity type. The easiest way to add Panelizer support for a custom entity is to copy the node entity.
As a CTools plugin, you will be required to implement `hook_ctools_plugin_directory`. Then copy `node.inc` to your plugin directory as `MY_ENTITY_TYPE.inc` and modify the name of the handler it uses. Copy `PanelizerEntityNode.class.php` to `MyModuleEntityMyEntity.class.php` -- and make sure the name of this file matches the handler in your `.inc` file.
The required implementation pieces are straightforward. You do need to set a flag if the entity supports revisions so that Panelizer can write the information.
If the entity does not support bundles it can only panelize the entire entity.
## Troubleshooting / Known Issues
* When using older releases of Pathauto it was possible that saving an entity's overridden Panelizer display (i.e., nodes, etc) would cause the entity's path alias to be reset. This was a bug in Pathauto prior to v7.x-1.3 and can be fixed by updating that module to the latest release.
* Revisions handling using Workbench Moderation and the Panels IPE (In-Place Editor) is problematic. This problem is being collaborated on in the following issue: [Drupal Issue 2457113](https://www.drupal.org/node/2457113)
## Credits / Contact
Currently maintained by Damien McKenna. Originally written by merlinofchaos, with many contributions by dww and awebb.
Ongoing development is sponsored by Mediacurrent.
The best way to contact the author is to submit an issue, be it a support request, a feature request, or a bug report, in the project issue queue: [Panelizer Issue Queue](https://www.drupal.org/project/issues/panelizer)
## References
1: [Panels](https://www.drupal.org/project/panels)
2: [Fieldable Panels Panes](https://www.drupal.org/project/fieldable_panels_panes)
3: [Bean](https://www.drupal.org/project/bean)
4: [Damien McKenna](https://www.drupal.org/u/damienmckenna)
5: [merlinofchaos](https://www.drupal.org/u/merlinofchaos)
6: [dww](https://www.drupal.org/u/dww)
7: [awebb](https://www.drupal.org/u/awebb)
8: [Mediacurrent](https://www.mediacurrent.com/)
🇵🇭Philippines clarkssquared
Hi
I applied MR !1 and I confirm that it created and implemented hook_help() in the module, and below is what the hook help page says
<h3>About
</h3>The Untranslated Paragraph Warning module was created to warn content managers about paragraphs in the node form that have been attached to the node in the site's default language, but not yet translated.
<h3>Uses</h3>
The use case for this is to help prevent content managers from accidentally publishing content with untranslated paragraphs in them.
Untranslated Paragraph Warning administration pages
<ul>
<li>Untranslated Paragraph Warning Settings</li>
</ul>🇵🇭Philippines clarkssquared
Hi
I applied patch #3 and I confirmed that it fixes all the PHPCS issues
➜ domain_access_logo git:(2.0.x) curl https://www.drupal.org/files/issues/2024-04-12/phpcs-3440266-3.patch | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 2537 100 2537 0 0 4795 0 --:--:-- --:--:-- --:--:-- 4964
patching file domain_access_logo.module
patching file 'src/Form/DomainAccessLogoSettingsForm.php'
➜ domain_access_logo git:(2.0.x) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml domain_access_logo
➜ contrib git:(master) ✗
🇵🇭Philippines clarkssquared
Hi
I applied your MR !31 and I can still see many PHPCS errors in my end
➜ school_theme git:(master) ✗ curl https://git.drupalcode.org/project/school_theme/-/merge_requests/31.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 12742 0 12742 0 0 24997 0 --:--:-- --:--:-- --:--:-- 25281
patching file school.theme
➜ school_theme git:(master) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml school_theme
FILE: ...ubing/Projects/d9/d9-local/web/themes/contrib/school_theme/school.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by
| | drupal.org packaging automatically
--------------------------------------------------------------------------------
FILE: ...-subing/Projects/d9/d9-local/web/themes/contrib/school_theme/css/style.css
--------------------------------------------------------------------------------
FOUND 369 ERRORS AFFECTING 230 LINES
--------------------------------------------------------------------------------
1 | ERROR | [x] Selectors must be on a single line
2 | ERROR | [x] Selectors must be on a single line
3 | ERROR | [x] Selectors must be on a single line
4 | ERROR | [x] Multiple selectors should each be on a single line
4 | ERROR | [x] Multiple selectors should each be on a single line
4 | ERROR | [x] Multiple selectors should each be on a single line
4 | ERROR | [x] Multiple selectors should each be on a single line
4 | ERROR | [x] Multiple selectors should each be on a single line
4 | ERROR | [x] Multiple selectors should each be on a single line
4 | ERROR | [x] Multiple selectors should each be on a single line
4 | ERROR | [x] Multiple selectors should each be on a single line
4 | ERROR | [x] Multiple selectors should each be on a single line
4 | ERROR | [x] Multiple selectors should each be on a single line
4 | ERROR | [x] Multiple selectors should each be on a single line
4 | ERROR | [x] Multiple selectors should each be on a single line
4 | ERROR | [x] Multiple selectors should each be on a single line
4 | ERROR | [x] Multiple selectors should each be on a single line
4 | ERROR | [x] Multiple selectors should each be on a single line
4 | ERROR | [x] Multiple selectors should each be on a single line
4 | ERROR | [x] Multiple selectors should each be on a single line
4 | ERROR | [x] Multiple selectors should each be on a single line
4 | ERROR | [x] Multiple selectors should each be on a single line
4 | ERROR | [x] Multiple selectors should each be on a single line
4 | ERROR | [x] Multiple selectors should each be on a single line
4 | ERROR | [x] Multiple selectors should each be on a single line
4 | ERROR | [x] Multiple selectors should each be on a single line
4 | ERROR | [x] Multiple selectors should each be on a single line
4 | ERROR | [x] Multiple selectors should each be on a single line
5 | ERROR | [x] Multiple selectors should each be on a single line
5 | ERROR | [x] Multiple selectors should each be on a single line
5 | ERROR | [x] Multiple selectors should each be on a single line
5 | ERROR | [x] Multiple selectors should each be on a single line
5 | ERROR | [x] Multiple selectors should each be on a single line
5 | ERROR | [x] Multiple selectors should each be on a single line
5 | ERROR | [x] Multiple selectors should each be on a single line
5 | ERROR | [x] Multiple selectors should each be on a single line
5 | ERROR | [x] Multiple selectors should each be on a single line
5 | ERROR | [x] Multiple selectors should each be on a single line
5 | ERROR | [x] Multiple selectors should each be on a single line
5 | ERROR | [x] Multiple selectors should each be on a single line
5 | ERROR | [x] Multiple selectors should each be on a single line
5 | ERROR | [x] Multiple selectors should each be on a single line
5 | ERROR | [x] Multiple selectors should each be on a single line
5 | ERROR | [x] Multiple selectors should each be on a single line
5 | ERROR | [x] Multiple selectors should each be on a single line
5 | ERROR | [x] Multiple selectors should each be on a single line
5 | ERROR | [x] Multiple selectors should each be on a single line
5 | ERROR | [x] Multiple selectors should each be on a single line
5 | ERROR | [x] Multiple selectors should each be on a single line
5 | ERROR | [x] Multiple selectors should each be on a single line
5 | ERROR | [x] Multiple selectors should each be on a single line
5 | ERROR | [x] Multiple selectors should each be on a single line
5 | ERROR | [x] Multiple selectors should each be on a single line
5 | ERROR | [x] Multiple selectors should each be on a single line
5 | ERROR | [x] Multiple selectors should each be on a single line
6 | ERROR | [x] Multiple selectors should each be on a single line
6 | ERROR | [x] Multiple selectors should each be on a single line
6 | ERROR | [x] Multiple selectors should each be on a single line
6 | ERROR | [x] Multiple selectors should each be on a single line
6 | ERROR | [x] Multiple selectors should each be on a single line
6 | ERROR | [x] Multiple selectors should each be on a single line
6 | ERROR | [x] Multiple selectors should each be on a single line
6 | ERROR | [x] Multiple selectors should each be on a single line
6 | ERROR | [x] Multiple selectors should each be on a single line
6 | ERROR | [x] Multiple selectors should each be on a single line
6 | ERROR | [x] Multiple selectors should each be on a single line
6 | ERROR | [x] Multiple selectors should each be on a single line
6 | ERROR | [x] Multiple selectors should each be on a single line
6 | ERROR | [x] Multiple selectors should each be on a single line
6 | ERROR | [x] Multiple selectors should each be on a single line
6 | ERROR | [x] Multiple selectors should each be on a single line
6 | ERROR | [x] Multiple selectors should each be on a single line
6 | ERROR | [x] Multiple selectors should each be on a single line
7 | ERROR | [x] Multiple selectors should each be on a single line
7 | ERROR | [x] Multiple selectors should each be on a single line
7 | ERROR | [x] Multiple selectors should each be on a single line
7 | ERROR | [x] Multiple selectors should each be on a single line
7 | ERROR | [x] Multiple selectors should each be on a single line
7 | ERROR | [x] Multiple selectors should each be on a single line
7 | ERROR | [x] Multiple selectors should each be on a single line
17 | ERROR | [x] Multiple selectors should each be on a single line
17 | ERROR | [x] Multiple selectors should each be on a single line
17 | ERROR | [x] Multiple selectors should each be on a single line
17 | ERROR | [x] Multiple selectors should each be on a single line
17 | ERROR | [x] Multiple selectors should each be on a single line
17 | ERROR | [x] Multiple selectors should each be on a single line
17 | ERROR | [x] Multiple selectors should each be on a single line
17 | ERROR | [x] Multiple selectors should each be on a single line
17 | ERROR | [x] Multiple selectors should each be on a single line
17 | ERROR | [x] Multiple selectors should each be on a single line
45 | ERROR | [x] Closing brace of class definition must be on new line
137 | ERROR | [x] CSS colours must be defined in lowercase; expected #00a0a0
| | but found #00A0A0
144 | ERROR | [x] CSS colours must be defined in lowercase; expected #00a0a0
| | but found #00A0A0
152 | ERROR | [x] Multiple selectors should each be on a single line
160 | ERROR | [x] Multiple selectors should each be on a single line
190 | ERROR | [x] Closing brace of class definition must be on new line
194 | ERROR | [x] CSS colours must be defined in lowercase; expected #221e20
| | but found #221E20
194 | ERROR | [x] Closing brace of class definition must be on new line
195 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
196 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
197 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
197 | ERROR | [x] Closing brace of class definition must be on new line
215 | ERROR | [x] Closing brace of class definition must be on new line
216 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
217 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
218 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
218 | ERROR | [x] Closing brace of class definition must be on new line
219 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
220 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
221 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
222 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
234 | ERROR | [x] CSS colours must be defined in lowercase; expected #2c2c2c
| | but found #2C2C2C
244 | ERROR | [x] CSS colours must be defined in lowercase; expected #2c2c2c
| | but found #2C2C2C
266 | ERROR | [x] CSS colours must be defined in lowercase; expected #221e20
| | but found #221E20
275 | ERROR | [x] CSS colours must be defined in lowercase; expected #ededed
| | but found #EDEDED
281 | ERROR | [x] CSS colours must be defined in lowercase; expected #e5e6f0
| | but found #E5E6F0
282 | ERROR | [x] CSS colours must be defined in lowercase; expected #e5e6f0
| | but found #E5E6F0
283 | ERROR | [x] CSS colours must be defined in lowercase; expected #e5e6f0
| | but found #E5E6F0
287 | ERROR | [x] CSS colours must be defined in lowercase; expected #221e20
| | but found #221E20
295 | ERROR | [x] Closing brace of class definition must be on new line
296 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
297 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
298 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
298 | ERROR | [x] Closing brace of class definition must be on new line
299 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 4
300 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
301 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
301 | ERROR | [x] Closing brace of class definition must be on new line
308 | ERROR | [x] Closing brace of class definition must be on new line
309 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
310 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
310 | ERROR | [x] Closing brace of class definition must be on new line
311 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 4
312 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
313 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
314 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
315 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
315 | ERROR | [x] Closing brace of class definition must be on new line
316 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 6
317 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 8
318 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 8
318 | ERROR | [x] Closing brace of class definition must be on new line
319 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 6
320 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 8
320 | ERROR | [x] Closing brace of class definition must be on new line
321 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 6
322 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 8
323 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 8
324 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 8
325 | ERROR | [x] Line indented incorrectly; expectI didn't pasted all the PHPCS errors and warning because it's way too many, moving this to neeeds work.
🇵🇭Philippines clarkssquared
Hi
So I applied patch #3 into 8.x-1.4 version of the module, but it didn't replace the README.txt into README.md it just adds content inside the README.txt and the file's content doesn't follow the Drupal README.md template → hence moving this to needs work.
for convenience this is what the patch created:
## CONTENTS OF THIS FILE
* Introduction
* Installation
* Use cases
## INTRODUCTION
This module allows site builders to create node with their custom nid. If the node with given nid is already exist a message will occur that "Nid already exists".
## INSTALLATION
* Install as you would normally install a contributed Drupal module.
See: https://www.drupal.org/node/895232 for further information.
## USE CASES :-
1. In case when you write any business logic on the basis of node id you can use this module.
2. When you transfer data from one instance to another you can set id according your choice.
🇵🇭Philippines clarkssquared
🇵🇭Philippines clarkssquared
HI
I applied the. update MR !18 but I can still see many PHPCS issues
I didn't include all the errors because its too long but herre's some of the errors
➜ january_theme git:(1.0.x) curl https://git.drupalcode.org/project/january_theme/-/merge_requests/18.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 83351 0 83351 0 0 132k 0 --:--:-- --:--:-- --:--:-- 133k
patching file 'config/install/january.settings.yml'
patching file 'css/base/fonts.css'
patching file 'css/base/fonts.pcss.css'
patching file 'css/base/variables.css'
patching file 'css/base/variables.pcss.css'
patching file 'css/components/action-links.pcss.css'
patching file 'css/components/ajax-progress.module.pcss.css'
patching file 'css/components/autocomplete-loading.module.pcss.css'
patching file 'css/components/block.pcss.css'
patching file 'css/components/book.pcss.css'
patching file 'css/components/button.css'
patching file 'css/components/cke-dialog.pcss.css'
patching file 'css/components/comments.css'
patching file 'css/components/comments.pcss.css'
patching file 'css/components/details.pcss.css'
patching file 'css/components/dropbutton.css'
patching file 'css/components/dropbutton.pcss.css'
patching file 'css/components/feed.pcss.css'
patching file 'css/components/footer.pcss.css'
patching file 'css/components/form-select.css'
patching file 'css/components/form-text.css'
patching file 'css/components/form-textarea.pcss.css'
patching file 'css/components/form.css'
patching file 'css/components/header-search-narrow.css'
patching file 'css/components/header-search-narrow.pcss.css'
patching file 'css/components/maintenance-page.pcss.css'
patching file 'css/components/navigation/menu-sidebar.pcss.css'
patching file 'css/components/navigation/nav-button-mobile.pcss.css'
patching file 'css/components/node-preview-container.pcss.css'
patching file 'css/components/off-canvas.pcss.css'
patching file 'css/components/pager.css'
patching file 'css/components/progress.pcss.css'
patching file 'css/layout/grid.css'
patching file 'css/layout/layout-builder-fourcol-section.pcss.css'
patching file 'css/layout/layout-builder-threecol-section.pcss.css'
patching file 'css/layout/layout-builder-twocol-section.pcss.css'
patching file 'css/layout/layout-content-medium.pcss.css'
patching file 'css/layout/layout-content-narrow.pcss.css'
patching file 'css/layout/layout-discovery-section-layout.pcss.css'
patching file 'css/layout/layout-footer.pcss.css'
patching file 'css/layout/layout-views-grid-horizontal.css'
patching file 'css/layout/layout-views-grid-horizontal.pcss.css'
patching file 'css/layout/layout-views-grid-vertical.pcss.css'
patching file 'css/layout/layout.pcss.css'
patching file 'css/layout/region-content-below.pcss.css'
patching file 'css/layout/region-content.pcss.css'
patching file 'css/layout/region-secondary-menu.css'
patching file 'css/layout/region-secondary-menu.pcss.css'
patching file 'css/layout/region.pcss.css'
patching file 'css/layout/social-bar.pcss.css'
patching file 'css/layout/views.pcss.css'
patching file 'css/theme/ckeditor-frame.pcss.css'
patching file january.theme
patching file theme-settings.php
➜ january_theme git:(1.0.x) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml january_theme
FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/themes/contrib/january_theme/css/layout/layout-builder-twocol-section.pcss.css
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------
13 | ERROR | [x] Selectors must be on a single line
---------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/themes/contrib/january_theme/css/layout/region-secondary-menu.pcss.css
-------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------------------------
21 | ERROR | [ ] Style definitions must end with a semicolon
21 | ERROR | [x] Selectors must be on a single line
22 | ERROR | [ ] Style definitions must end with a semicolon
-------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/themes/contrib/january_theme/css/layout/layout-views-grid-horizontal.pcss.css
--------------------------------------------------------------------------------------------------------------------------------------
FOUND 8 ERRORS AFFECTING 8 LINES
--------------------------------------------------------------------------------------------------------------------------------------
15 | ERROR | Style definitions must end with a semicolon
27 | ERROR | Style definitions must end with a semicolon
40 | ERROR | Style definitions must end with a semicolon
63 | ERROR | Style definitions must end with a semicolon
86 | ERROR | Style definitions must end with a semicolon
119 | ERROR | Style definitions must end with a semicolon
152 | ERROR | Style definitions must end with a semicolon
185 | ERROR | Style definitions must end with a semicolon
--------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/themes/contrib/january_theme/css/layout/layout-builder-fourcol-section.pcss.css
----------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------
13 | ERROR | [x] Selectors must be on a single line
----------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/themes/contrib/january_theme/css/layout/layout-footer.pcss.css
-----------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------
29 | ERROR | Style definitions must end with a semicolon
-----------------------------------------------------------------------------------------------------------------------
FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/themes/contrib/january_theme/css/layout/views.pcss.css
---------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------
10 | ERROR | [x] Selectors must be on a single line
11 | ERROR | [ ] Style definitions must end with a semicolon
---------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------
FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/themes/contrib/january_theme/css/layout/social-bar.pcss.css
--------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------------------------------------------------
24 | ERROR | [ ] Style definitions must end with a semicolon
38 | ERROR | [ ] Style definitions must end with a semicolon
72 | ERROR | [x] Selectors must be on a single line
73 | ERROR | [ ] Style definitions must end with a semicolon
--------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------
FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/themes/contrib/january_theme/css/layout/region-content-below.pcss.css
------------------------------------------------------------------------------------------------------------------------------
FOUND 15 ERRORS AFFECTING 11 LINES
------------------------------------------------------------------------------------------------------------------------------
14 | ERROR | [x] Selectors must be on a single line
15 | ERROR | [x] Selectors must be on a single line
16 | ERROR | [x] Selectors must be on a single line
17 | ERROR | [x] Selectors must be on a single line
18 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
18 | ERROR | [ ] Style definitions must end with a semicolon
19 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
19 | ERROR | [ ] Style definitions must end with a semicolon
24 | ERROR | [x] Blank lines are not allowed in class definitions
27 | ERROR | [x] Selectors must be on a single line
28 | ERROR | [x] Blank lines are not allowed between class names
29 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
29 | ERROR | [ ] Style definitions must end with a semicolon
30 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
30 | ERROR | [ ] Style definitions must end with a semicolon
------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 11 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/themes/contrib/january_theme/css/layout/layout-sidebar.pcss.css
------------------------------------------------------------------------------------------------------------------------
FOUND 7 ERRORS AFFECTING 7 LINES
------------------------------------------------------------------------------------------------------------------------
12 | ERROR | [x] Selectors must be on a single line
13 | ERROR | [x] Blank lines are not allowed between class names
21 | ERROR | [x] Selectors must be on a single line
22 | ERROR | [x] Blank lines are not allowed between class names
37 | ERROR | [x] Blank lines are not allowed in class definitions
40 | ERROR | [x] Selectors must be on a single line
41 | ERROR | [x] Blank lines are not allowed between class names
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------
FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/themes/contrib/january_theme/css/layout/layout-builder-threecol-section.pcss.css
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------
13 | ERROR | [x] Selectors must be on a single line
-----------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/th🇵🇭Philippines clarkssquared
Hi
Moving this to needs work to fix the merge conflict in the MR
🇵🇭Philippines clarkssquared
Hi
I applied MR !1 and I confirmed that it creates README.md according to Drupal's template.
The README content:
# OTP Auth
This module will allow you to register/login to a site just using mobile
number/OTP sent to the provided mobile number.
For a full description of the module, visit the
[project page](https://www.drupal.org/project/otp_auth).
Submit bug reports and feature suggestions, or track changes in the
[issue queue](https://www.drupal.org/project/issues/otp_auth).
## Table of contents
- Requirements
- Installation
- Configuration
- Maintainers
- Queue and Cron
- Use OTP Auth as a service
## Requirements
- sms and sms_user modules that are part of smsframework module.
- basic_auth, restui, rest and serialization (Only if you want to use
OTP Auth as a service)
## Installation
OTP Auth can be installed like any other Drupal module.
Place it in the modules directory for your site and enable it
on the `admin/modules` page or
see [Installing Drupal Modules](https://www.drupal.org/docs/extending-drupal/installing-drupal-modules).
## Configuration
Once the module is installed, a link 'OTP Auth Settings' will appear on
`/admin/config` page under 'People'.
1. Go to `/admin/config/people/otp_auth` to configure OTP Auth related
settings
- Enable 'Activate OTP Auth' to enable OTP Auth.
- Choose OTP Platform.
ZzzWith 'SMS framework', you can use any supported gateway to send OTP.
- If you want to purge users who have been blocked / not logged-in for a
specific number of days, enable the provided checkbox and enter number
of days.
- If you want to purge blocked or never logged-in users at any moment,
click on tab 'OTP Auth - purge users'
(/admin/config/people/otp_auth/user_purge) and press button
'Purge users'.
1. Place the 'OTP Auth link' block:
- Go to `/admin/structure/block` and place 'OTP Auth link' block to your
preferred region.
- The link block will be shown only to anonymous users and if
'Activate OTP Auth' is enabled.
In addition, also configure settings related to smsframework module.
1. Go to `/admin/config/smsframework/settings` to configure 'Fallback gateway'
and 'Phone verification path'.
1. Go to `/admin/config/smsframework/gateways` to add new gateway.
1. Go to `/admin/config/smsframework/phone_number` to add phone number settings:
- Click on 'Add phone number settings' button.
- Select 'user' bundle.
- Under 'Field mapping' -> 'Phone number' select 'Create a new telephone
field'.
- You can choose to keep everything else as-is.
If you want to use OTP Auth as a service:
1. Go to `/admin/config/services/rest`.
1. Enable 'Generate OTP', 'Submit OTP' and 'Logout OTP' resources.
## Maintainers
- Amir Koulivand - [vispa](https://www.drupal.org/u/vispa)
### Queue and Cron
Considering the fact that, on few sites, there could be hundreds of users who
would try to login through OTP, our module will not send OTP directly.
Instead, it will Queue the OTP and will be sent on next cron run.
### Use OTP Auth as a service
You can use functionalities of this module as a service, so that it can be
used with your mobile app, for example.
Below are the urls and parameters that needs to be passed to those urls:
1. URL: `/otp/generate`
parameters: mobile_number
1. URL: `/otp/login`
parameters: otp and mobile_number
1. URL: `/otp/logout`
parameters: session_id and mobile_number
🇵🇭Philippines clarkssquared
Hi
I applied MR !3 and there's no PHPCS issues left
➜ webform_submission_import git:(8.x-2.1) curl https://git.drupalcode.org/project/webform_submission_import/-/merge_requests/3.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 2040 0 2040 0 0 4224 0 --:--:-- --:--:-- --:--:-- 4294
patching file README.md
patching file 'src/Form/SubmissionImportForm.php'
patching file webform_submission_import.links.task.yml
➜ webform_submission_import git:(8.x-2.1) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml webform_submission_import
➜ contrib git:(master) ✗
RTBC +1 from me
🇵🇭Philippines clarkssquared
Hi
I applied MR !4 and I confirmed that it fixes the PHPCS issues that were reported, the remaining PHPCS warnings happen when the module is installed via composer.
➜ views_summary_tabs git:(master) ✗ curl https://git.drupalcode.org/project/views_summary_tabs/-/merge_requests/4.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 529 0 529 0 0 932 0 --:--:-- --:--:-- --:--:-- 944
patching file views_summary_tabs.theme.inc
➜ views_summary_tabs git:(master) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml views_summary_tabs
FILE: ...9-local/web/modules/contrib/views_summary_tabs/views_summary_tabs.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by
| | drupal.org packaging automatically
--------------------------------------------------------------------------------
Time: 194ms; Memory: 10MB
➜ contrib git:(master) ✗ RTBC +1 from me
🇵🇭Philippines clarkssquared
Hi
I applied MR !2 and there are still PHPCS issues that needs to be resolved.
➜ seeds_layouts git:(master) ✗ curl https://git.drupalcode.org/project/seeds_layouts/-/merge_requests/2.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 40643 0 40643 0 0 76147 0 --:--:-- --:--:-- --:--:-- 76975
patching file 'assets/images/seeds_1col.svg'
Patch creates file that already exists! Assume -R? [y] y
patching file 'assets/images/seeds_2col.svg'
Patch creates file that already exists! Assume -R? [y] y
patching file 'assets/images/seeds_3col.svg'
Patch creates file that already exists! Assume -R? [y] y
patching file seeds_3col.svg
Patch creates file that already exists! Assume -R? [y]
patching file seeds_layouts.info.yml
1 out of 1 hunks failed--saving rejects to seeds_layouts.info.yml.rej
patching file seeds_layouts.install
Reversed (or previously applied) patch detected! Assume -R? [y] y
patching file seeds_layouts.layouts.yml
Reversed (or previously applied) patch detected! Assume -R? [y]
patching file seeds_layouts.libraries.yml
Reversed (or previously applied) patch detected! Assume -R? [y]
patching file seeds_layouts.module
patching file 'src/Element/BlocksWrapper.php'
patching file 'src/Form/ColumnsForm.php'
patching file 'src/Form/FrameworkImportForm.php'
patching file 'src/Form/SeedsLayoutsConfigForm.php'
patching file 'src/Plugin/LayoutField/BackgroundImageField.php'
patching file 'src/Plugin/LayoutField/CheckboxField.php'
patching file 'src/Plugin/LayoutField/HideField.php'
patching file 'src/Plugin/LayoutField/SelectField.php'
patching file 'src/Plugin/LayoutField/WrapBlocksField.php'
patching file 'src/Plugin/LayoutField/WrapField.php'
patching file 'src/Plugin/LayoutFieldBase.php'
patching file 'src/Plugin/LayoutFieldInterface.php'
patching file 'src/Plugin/SeedsLayout.php'
Reversed (or previously applied) patch detected! Assume -R? [y]
4 out of 8 hunks failed--saving rejects to 'src/Plugin/SeedsLayout.php.rej'
patching file 'src/SeedsLayoutsManager.php'
2 out of 3 hunks failed--saving rejects to 'src/SeedsLayoutsManager.php.rej'
patching file 'templates/seeds-2col.html.twig'
➜ seeds_layouts git:(master) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml seeds_layouts
FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/modules/contrib/seeds_layouts/seeds_layouts.info.yml
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-------------------------------------------------------------------------------------------------------------
FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/modules/contrib/seeds_layouts/seeds_layouts.module
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------
94 | ERROR | The array declaration extends to column 93 (the limit is 80). The array content should be split up over multiple lines
-------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/modules/contrib/seeds_layouts/src/Plugin/SeedsLayout.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AND 3 WARNINGS AFFECTING 7 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
75 | ERROR | [ ] Doc comment short description must start with a capital letter
127 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
132 | ERROR | [ ] The array declaration extends to column 111 (the limit is 80). The array content should be split up over multiple lines
211 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
211 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
220 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
288 | ERROR | [ ] The array declaration extends to column 159 (the limit is 80). The array content should be split up over multiple lines
290 | ERROR | [ ] The array declaration extends to column 110 (the limit is 80). The array content should be split up over multiple lines
----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/modules/contrib/seeds_layouts/src/SeedsLayoutsManager.php
------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------
50 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
175 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
------------------------------------------------------------------------------------------------------------------
Time: 677ms; Memory: 12MB
➜ contrib git:(master) ✗
🇵🇭Philippines clarkssquared
Hi
I applied and tested MR !4 and I can still see many PHPCS issues
➜ opigno_poll git:(master) ✗ curl https://git.drupalcode.org/project/opigno_poll/-/merge_requests/4.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 22491 0 22491 0 0 38902 0 --:--:-- --:--:-- --:--:-- 39736
patching file opigno_poll.install
patching file opigno_poll.links.action.yml
patching file opigno_poll.links.menu.yml
patching file opigno_poll.module
patching file 'src/Form/PollDeleteForm.php'
patching file 'src/Form/PollForm.php'
patching file 'src/Form/PollViewForm.php'
patching file 'src/Plugin/Field/FieldWidget/PollChoiceDefaultWidget.php'
patching file 'src/Plugin/migrate/destination/PollVote.php'
patching file 'src/Plugin/views/field/PollStatus.php'
patching file 'src/PollListBuilder.php'
patching file 'src/PollPostRenderCache.php'
➜ opigno_poll git:(master) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml opigno_poll
FILE: ...s/d9/d9-local/web/modules/contrib/opigno_poll/opigno_poll.links.action.yml
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
6 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: .../Projects/d9/d9-local/web/modules/contrib/opigno_poll/opigno_poll.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by
| | drupal.org packaging automatically
--------------------------------------------------------------------------------
FILE: ...ng/Projects/d9/d9-local/web/modules/contrib/opigno_poll/opigno_poll.module
--------------------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------------
15 | WARNING | Global constants should not be used, move it to a class or
| | interface
20 | WARNING | Global constants should not be used, move it to a class or
| | interface
236 | ERROR | Doc comment is empty
--------------------------------------------------------------------------------
FILE: ...bing-subing/Projects/d9/d9-local/web/modules/contrib/opigno_poll/README.md
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
4 | WARNING | Line exceeds 80 characters; contains 195 characters
--------------------------------------------------------------------------------
FILE: ...Projects/d9/d9-local/web/modules/contrib/opigno_poll/src/Form/PollForm.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
96 | ERROR | The array declaration extends to column 95 (the limit is 80). The
| | array content should be split up over multiple lines
--------------------------------------------------------------------------------
FILE: ...ects/d9/d9-local/web/modules/contrib/opigno_poll/src/Form/PollViewForm.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AND 9 WARNINGS AFFECTING 10 LINES
--------------------------------------------------------------------------------
75 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
95 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
126 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
182 | ERROR | The array declaration extends to column 117 (the limit is 80).
| | The array content should be split up over multiple lines
182 | ERROR | The array declaration extends to column 116 (the limit is 80).
| | The array content should be split up over multiple lines
242 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
244 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
298 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
299 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
304 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
356 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
--------------------------------------------------------------------------------
FILE: .../d9/d9-local/web/modules/contrib/opigno_poll/src/Form/PollSettingsForm.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
33 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
--------------------------------------------------------------------------------
FILE: .../d9-local/web/modules/contrib/opigno_poll/src/PollAccessControlHandler.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
23 | ERROR | The array declaration extends to column 109 (the limit is 80).
| | The array content should be split up over multiple lines
46 | ERROR | The array declaration extends to column 113 (the limit is 80).
| | The array content should be split up over multiple lines
--------------------------------------------------------------------------------
FILE: ...g/Projects/d9/d9-local/web/modules/contrib/opigno_poll/src/Entity/Poll.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
290 | ERROR | The array declaration extends to column 102 (the limit is 80).
| | The array content should be split up over multiple lines
--------------------------------------------------------------------------------
FILE: ...ntrib/opigno_poll/src/Plugin/Field/FieldWidget/PollChoiceDefaultWidget.php
--------------------------------------------------------------------------------
FOUND 6 ERRORS AND 1 WARNING AFFECTING 7 LINES
--------------------------------------------------------------------------------
10 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is
| | Drupal\Core\Entity\EntityTypeManagerInterface.
38 | ERROR | [ ] Doc comment for parameter $plugin_id does not match actual
| | variable name $entity_type_manager
40 | ERROR | [ ] Doc comment for parameter $plugin_definition does not
| | match actual variable name $entity_type_manager
42 | ERROR | [ ] Superfluous parameter comment
44 | ERROR | [ ] Superfluous parameter comment
49 | ERROR | [x] Expected 1 blank line after function; 2 found
138 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency
| | injection instead
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...9/d9-local/web/modules/contrib/opigno_poll/src/Plugin/Block/ChartBlock.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES
--------------------------------------------------------------------------------
30 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
32 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
36 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
40 | WARNING | Unused variable $key.
63 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
73 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
79 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
--------------------------------------------------------------------------------
FILE: ...ojects/d9/d9-local/web/modules/contrib/opigno_poll/src/PollVoteStorage.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 8 WARNINGS AFFECTING 8 LINES
--------------------------------------------------------------------------------
84 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
85 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
136 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
155 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
178 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
189 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
195 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
208 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
--------------------------------------------------------------------------------
Time: 906ms; Memory: 12MB
➜ contrib git:(master) ✗
🇵🇭Philippines clarkssquared
Hi
I applied patch #2 and I confirmed that it fixes all the PHPCS issues.
➜ google_translator git:(master) ✗ curl https://www.drupal.org/files/issues/2024-03-21/3432640-2.patch | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 1300 100 1300 0 0 2119 0 --:--:-- --:--:-- --:--:-- 2145
patching file google_translator.info.yml
patching file 'js/disclaimer.js'
➜ google_translator git:(master) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml google_translator
➜ contrib git:(master) ✗ RTBC +1 from me.
🇵🇭Philippines clarkssquared
Hi
I applied MR !2 and I confirmed it fixes most of the PHPCS but there is line exceeding character warning.
➜ image_comparator git:(1.0.x) curl https://git.drupalcode.org/project/image_comparator/-/merge_requests/2.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 9185 0 9185 0 0 13861 0 --:--:-- --:--:-- --:--:-- 13980
patching file .gitlab-ci.yml
patching file image_comparator.info.yml
patching file 'src/Services/ImageComparatorService.php'
patching file 'src/Services/ImageComparatorServiceInterface.php'
➜ image_comparator git:(1.0.x) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml image_comparator
FILE: ...subing/Projects/d9/d9-local/web/modules/contrib/image_comparator/README.md
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
3 | WARNING | Line exceeds 80 characters; contains 111 characters
--------------------------------------------------------------------------------
Time: 201ms; Memory: 10MB
➜ contrib git:(master) ✗ I will retain the status to needs review so that others can test it, and also to hear from the maintainer if this warning is intentional or intended for some purposes.
🇵🇭Philippines clarkssquared
Hi
I applied MR !1 and I confirmed that I can no longer see any PHPCS issues/errors.
➜ prod_no_redirect git:(1.0.x) curl https://git.drupalcode.org/project/prod_no_redirect/-/merge_requests/1.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 8391 0 8391 0 0 14629 0 --:--:-- --:--:-- --:--:-- 14798
patching file .gitlab-ci.yml
patching file 'lib/ProdNoRedirectDrupalKernel.php'
patching file 'src/EventSubscriber/ExceptionDetectNeedsInstallSubscriber.php'
➜ prod_no_redirect git:(1.0.x) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml prod_no_redirect
➜ contrib git:(master) ✗
🇵🇭Philippines clarkssquared
Hi
I applied the MR !12 and there are two files that the patch fails to apply, and there are two PHPCS issue that were flagged. I will also move this to needs work because the MR was blocked maybe fix the merge conflict issues.
➜ list_formatter git:(ade7e9f) curl https://git.drupalcode.org/project/list_formatter/-/merge_requests/12.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 11654 0 11654 0 0 23425 0 --:--:-- --:--:-- --:--:-- 23686
patching file READ.md
patching file 'src/Plugin/Field/FieldFormatter/ListFormatter.php'
patching file 'src/Plugin/ListFormatterPluginManager.php'
1 out of 2 hunks failed--saving rejects to 'src/Plugin/ListFormatterPluginManager.php.rej'
patching file 'src/Plugin/list_formatter/EntityReferenceList.php'
patching file 'src/Plugin/list_formatter/LinkList.php'
patching file 'src/Plugin/list_formatter/OptionsList.php'
patching file 'src/Plugin/list_formatter/TaxonomyList.php'
patching file 'src/Plugin/list_formatter/TextList.php'
patching file 'src/Tests/OutputTest.php'
1 out of 1 hunks failed--saving rejects to 'src/Tests/OutputTest.php.rej'
➜ list_formatter git:(ade7e9f) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml list_formatter
FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/modules/contrib/list_formatter/src/Tests/OutputTest.php
----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------
45 | WARNING | Unused variable $delta.
----------------------------------------------------------------------------------------------------------------
FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/modules/contrib/list_formatter/src/Plugin/ListFormatterPluginManager.php
---------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------
51 | WARNING | Unused variable $id.
---------------------------------------------------------------------------------------------------------------------------------
Time: 414ms; Memory: 12MB
➜ contrib git:(master) ✗
🇵🇭Philippines clarkssquared
Hi
I reviewed the updated MR !1 and now the README.md file looks good according to Drupal's template.
🇵🇭Philippines clarkssquared
Hi
I reviewed the patch #6 and I confirmed that it applies successfully, however, I would recommend this.
in this section:
## Username
## Introduction
Provides a variety of username modes for registration and login.
For a full description of the module, visit the
[project page](https://www.drupal.org/project/username).You can do this instead:
## Username
Username module provides a variety of username modes for registration and login.
For a full description of the module, visit the
[project page](https://www.drupal.org/project/username).and if you do this, you can also remove the - Introduction from the ## Table of Contents sections.
the rest are good according to Drupal's template, kindly look at my suggestion and feedback
🇵🇭Philippines clarkssquared
Hi
I also applied MR !1 and I confirmed that it resolves the PHPCS issues reported, the PHPCS issues that my terminal flags happens when a module is installed via composer.
➜ time_ticker git:(master) ✗ curl https://git.drupalcode.org/project/time_ticker/-/merge_requests/1.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 10706 0 10706 0 0 20692 0 --:--:-- --:--:-- --:--:-- 20992
patching file 'src/Controller/TimeController.php'
patching file 'src/Form/TimeSettingsForm.php'
patching file 'src/Plugin/Block/TimeBlock.php'
patching file 'src/TimeService.php'
patching file 'templates/time-ticker-block.html.twig'
patching file time_ticker.info.yml
1 out of 1 hunks failed--saving rejects to time_ticker.info.yml.rej
patching file time_ticker.libraries.yml
patching file time_ticker.module
patching file time_ticker.services.yml
➜ time_ticker git:(master) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml time_ticker
FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/modules/contrib/time_ticker/time_ticker.info.yml
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-------------------------------------------------------------------------------------------------------------
Time: 248ms; Memory: 10MB
➜ contrib git:(master) ✗
🇵🇭Philippines clarkssquared
Hi
I applied MR !1 and there are few remaining PHPCS issues has been reported.
➜ trapadata git:(1.0.x) curl https://git.drupalcode.org/project/trapadata/-/merge_requests/1.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 9553 0 9553 0 0 19321 0 --:--:-- --:--:-- --:--:-- 19696
patching file .gitlab-ci.yml
patching file 'src/Form/TrapadataForm.php'
patching file trapadata.module
➜ trapadata git:(1.0.x) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml trapadata
FILE: ...bing/Projects/d9/d9-local/web/modules/contrib/trapadata/trapadata.info.yml
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
6 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...subing/Projects/d9/d9-local/web/modules/contrib/trapadata/trapadata.module
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
43 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced
| | with use statements
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Time: 198ms; Memory: 10MB
➜ contrib git:(master) ✗ 🇵🇭Philippines clarkssquared
Hi
I applied the patch #3 and I noticed that the README.md content doesn't follow Drupal README.md template →
This is the README.md content that the patch created
# Username Module
## Introduction
Brief introduction about the module and its purpose.
## Installation
Instructions on how to install the module. Include any dependencies or prerequisites.
## Requirements
List the required dependencies for the module.
## Contributing
Provide guidelines for contributors. This may include how to report bugs, suggest enhancements, or submit pull requests.
## Usage
Explain how to use the module. Provide examples or code snippets if applicable.
## Configuration
Describe any configuration options or settings that users may need to adjust.
## License
Specify the license under which the module is distributed.
## Acknowledgements
Give credit to any individuals or organizations whose work has influenced or contributed to the module.
## Maintainers
List the maintainers of the module.🇵🇭Philippines clarkssquared
Hi
I applied MR !2 and I confirmed that it creates README.md file according to Drupal's template
this is README.md file that the MR created after I applied it
# Bible Reference
Bible Reference is a Drupal module that enhances the content management system by providing functionality related to Bible references. This module facilitates the management and display of Bible references within Drupal websites.
For a full description of the module, visit the [project page](https://www.drupal.org/project/bible_reference).
Submit bug reports and feature suggestions, or track changes in the [issue queue](https://www.drupal.org/project/issues/bible_reference).
## Table of Contents
- Requirements
- Installation
- Configuration
- Maintainers
## Requirements
This module requires the following module:
- [Taxonomy](https://www.drupal.org/project/taxonomy)
## Installation
Install as you would normally install a contributed Drupal module. For further information, see [Installing Drupal Modules](https://www.drupal.org/docs/extending-drupal/installing-drupal-modules).
## Configuration
1. Enable the module at Administration > Extend.
2. Configure the module settings as needed.
## Maintainers
- Vince Tikász - [tikaszvince](https://www.drupal.org/u/tikaszvince)
🇵🇭Philippines clarkssquared
Hi
I applied MR !1 and I confirmed that it fixes most of the PHPCS issues of hte module, however there are PHPCS issues regarding line exceeds 80 characters, hence I will retain the status to needs review so that others can review if these remaining PHPCS issues should be fixed or not.
➜ multi_image_formatter git:(1.0.x) curl https://git.drupalcode.org/project/multi_image_formatter/-/merge_requests/1.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 24368 0 24368 0 0 27217 0 --:--:-- --:--:-- --:--:-- 27472
patching file README.md
patching file 'config/install/core.entity_form_mode.media.asset_edit.yml'
patching file 'config/install/core.entity_view_mode.media.asset_format.yml'
patching file multi_image_formatter.info.yml
patching file multi_image_formatter.module
patching file 'src/Controller/AssetFormatController.php'
patching file 'src/Plugin/Field/FieldFormatter/MultiImageFormatter.php'
patching file 'src/Routing/RouteSubscriber.php'
➜ multi_image_formatter git:(1.0.x) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml multi_image_formatter
FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/modules/contrib/multi_image_formatter/src/Plugin/Field/FieldFormatter/MultiImageFormatter.php
------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------------
46 | WARNING | Line exceeds 80 characters; contains 106 characters
------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/modules/contrib/multi_image_formatter/src/Controller/AssetFormatController.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------------------------------
11 | WARNING | [x] Unused use statement
38 | WARNING | [ ] Line exceeds 80 characters; contains 92 characters
---------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/modules/contrib/multi_image_formatter/src/Routing/RouteSubscriber.php
------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------
32 | WARNING | Line exceeds 80 characters; contains 83 characters
------------------------------------------------------------------------------------------------------------------------------
Time: 350ms; Memory: 10MB
➜ contrib git:(master) ✗
🇵🇭Philippines clarkssquared
Hi
I applied MR !1 and confirmed that it creates README.md file according to Drupal's template and standards.
For convenience below is the README.md content that the MR !1 created.
# CKEditor Tabber
This module adds a new button to Drupal 8 built-in CKEditor which allows the
user to create tabbed content on their pages.
The styling is very minimal, allowing the developers to overwrite the look
easily using CSS.
For a full description of the module, visit the
[project page](https://www.drupal.org/project/ckeditor_tabber).
Submit bug reports and feature suggestions, or track changes in the
[issue queue](https://www.drupal.org/project/issues/ckeditor_tabber).
## Table of contents
- Requirements
- Installation
- Configuration
- Maintainers
## Requirements
This module requires no modules outside of Drupal core.
## Installation
Install as you would normally install a contributed Drupal module. For further
information, see
[Installing Drupal Modules](https://www.drupal.org/docs/extending-drupal/installing-drupal-modules).
## Configuration
1. Go to Administration » Configuration » Content authoring » Text formats
and editors
1. Edit a text format, for example "Basic HTML"
1. Drag and Drop the Add Tab button to the toolbar to show it to the users
1. Scroll down to the bottom to "Allowed HTML tags"
1. Find and replace `<dl>` with `<dl class>`
1. This makes sure CKEditor doesn't remove the class name Tabber uses
### Code structure example
```html
<section class="ckeditor-tabber-tabs"
<ul class="tabs-holder">
<li><a class="tab tab-1 active">Tab 1</a></li>
<li><a class="tab tab-2">Tab 1</a></li>
</ul>
<div class="tabs-content-holder">
<div class="tab-content tab-content-1 active">
<p>Tab 1 contents</p>
</div>
<div class="tab-content tab-content-2">
<p>Tab 2 contents</p>
</div>
</div>
</section>
```
## Maintainers
- Juhani Väätäjä - [j-vee](https://www.drupal.org/u/j-vee)
- Sébastien Corbin - [sebcorbin](https://www.drupal.org/u/sebcorbin)
🇵🇭Philippines clarkssquared
Hi
I applied the updated MR !1 and I confirmed that it creates a README.md file according to Drupal's standard, however I noticed that there's FAQ listed in the Table of contents section but there's no FAQ section in the README file, I suggest to remove the FAQ from the Table of contents.
Here's the content of the README file that MR !1 created
# Term Manager
Term Manager used to manage term in advanced mode.
**Current Feature**
- Move Term to another Vocabulary
- Merge Term (under development)
For a full description of the module, visit the
[project page](https://www.drupal.org/project/term_manager).
Submit bug reports and feature suggestions, or track changes in the
[issue queue](https://www.drupal.org/project/issues/term_manager).
## Table of contents
- Requirements
- Installation
- Configuration
- Troubleshooting
- FAQ
- Maintainers
## Requirements
This module requires no modules outside of Drupal core.
## Installation
Install as you would normally install a contributed Drupal module. For further
information, see
[Installing Drupal Modules](https://www.drupal.org/docs/extending-drupal/installing-drupal-modules).
## Configuration
The module has no menu or modifiable settings. There is no configuration. When
enabled, the module will prevent the links from appearing. To get the links
back, disable the module and clear caches.
## Maintainers
- Wendy William - [drupalnesia](https://www.drupal.org/u/drupalnesia)🇵🇭Philippines clarkssquared
This is ready for review
🇵🇭Philippines clarkssquared
Hi
I also confirm that there's no PHPCS issues after applying MR !8
➜ term_condition git:(2.0.x) curl https://git.drupalcode.org/project/term_condition/-/merge_requests/8.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 957 0 957 0 0 1698 0 --:--:-- --:--:-- --:--:-- 1718
patching file term_condition.install
➜ term_condition git:(2.0.x) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml term_condition
➜ contrib git:(master) ✗
🇵🇭Philippines clarkssquared
Hi
I checked your MR and I see that the README.md file doesn't follow the Drupal README.md template →
🇵🇭Philippines clarkssquared
Hi
I applied MR !3 but there are still many PHPCS issues that needs to be resolved.
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml taxonomy_protect
FILE: ...s/d9/d9-local/web/modules/contrib/taxonomy_protect/taxonomy_protect.module
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...d9/d9-local/web/modules/contrib/taxonomy_protect/taxonomy_protect.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by
| | drupal.org packaging automatically
--------------------------------------------------------------------------------
FILE: .../d9/d9-local/web/modules/contrib/taxonomy_protect/taxonomy_protect.install
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...les/contrib/taxonomy_protect/src/Form/TaxonomyProtectAdminSettingsForm.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------
32 | WARNING | Vocabulary::loadMultiple calls should be avoided in classes,
| | use dependency injection instead
45 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
--------------------------------------------------------------------------------
Time: 236ms; Memory: 10MB
➜ contrib git:(master) ✗ cd taxonomy_protect
➜ taxonomy_protect git:(master) ✗ curl https://git.drupalcode.org/project/taxonomy_protect/-/merge_requests/3.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 4166 0 4166 0 0 4991 0 --:--:-- --:--:-- --:--:-- 5025
patching file 'src/Form/TaxonomyProtectAdminSettingsForm.php'
2 out of 3 hunks failed--saving rejects to 'src/Form/TaxonomyProtectAdminSettingsForm.php.rej'
patching file taxonomy_protect.install
patching file taxonomy_protect.module
➜ taxonomy_protect git:(master) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml taxonomy_protect
FILE: ...s/d9/d9-local/web/modules/contrib/taxonomy_protect/taxonomy_protect.module
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...d9/d9-local/web/modules/contrib/taxonomy_protect/taxonomy_protect.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by
| | drupal.org packaging automatically
--------------------------------------------------------------------------------
FILE: ...les/contrib/taxonomy_protect/src/Form/TaxonomyProtectAdminSettingsForm.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
32 | WARNING | Vocabulary::loadMultiple calls should be avoided in classes,
| | use dependency injection instead
--------------------------------------------------------------------------------
Time: 95ms; Memory: 10MB
➜ contrib git:(master) ✗ 🇵🇭Philippines clarkssquared
Hi
I applied patch #2 and I confirm that it fixes all PHPCS issues in the module
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml string_field_formatter
FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/modules/contrib/string_field_formatter/string_field_formatter.info.yml
-------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------
1 | WARNING | "core_version_requirement" property is missing in the info.yml file
-------------------------------------------------------------------------------------------------------------------------------
FILE: ...subing-subing/Projects/d9/d9-local/web/modules/contrib/string_field_formatter/src/Plugin/Field/FieldFormatter/PlainStringFormatter.php
--------------------------------------------------------------------------------------------------------------------------------------------
FOUND 11 ERRORS AND 9 WARNINGS AFFECTING 17 LINES
--------------------------------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Field\FormatterBase.
43 | ERROR | [x] Short array syntax must be used to define arrays
60 | ERROR | [x] Short array syntax must be used to define arrays
61 | ERROR | [x] Short array syntax must be used to define arrays
62 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
| | instead
68 | ERROR | [x] Short array syntax must be used to define arrays
69 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
| | instead
73 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
| | instead
83 | ERROR | [x] Short array syntax must be used to define arrays
86 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
| | instead
89 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
| | instead
89 | ERROR | [x] Short array syntax must be used to define arrays
96 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
| | instead
96 | ERROR | [x] Short array syntax must be used to define arrays
97 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
| | instead
97 | ERROR | [x] Short array syntax must be used to define arrays
101 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
| | instead
127 | ERROR | [x] Short array syntax must be used to define arrays
137 | ERROR | [x] Short array syntax must be used to define arrays
143 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
--------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 12 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------
Time: 98ms; Memory: 10MB
➜ contrib git:(master) ✗ cd string_field_formatter
➜ string_field_formatter git:(8.x-1.x) curl https://www.drupal.org/files/issues/2024-03-08/3426545-2.patch | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 4785 100 4785 0 0 16853 0 --:--:-- --:--:-- --:--:-- 17336
patching file 'src/Plugin/Field/FieldFormatter/PlainStringFormatter.php'
patching file string_field_formatter.info.yml
➜ string_field_formatter git:(8.x-1.x) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml string_field_formatter
➜ contrib git:(master) ✗
🇵🇭Philippines clarkssquared
Hi
I applied patch #4 and I confirmed that all PHPCS issues were resolved, the remaining issue that my terminal flagged happens when the module is installed via composer.
➜ commerce_tax_conditions git:(master) ✗ curl https://www.drupal.org/files/issues/2024-03-05/3350996-4.patch | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 2826 100 2826 0 0 6325 0 --:--:-- --:--:-- --:--:-- 6422
patching file commerce_tax_conditions.module
patching file 'src/Plugin/Commerce/Condition/CustomerRoleCondition.php'
patching file 'src/Resolver/ConditionTaxRateResolver.php'
patching file 'tests/src/Unit/TaxExemptManagerTest.php'
➜ commerce_tax_conditions git:(master) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml commerce_tax_conditions
FILE: ...b/modules/contrib/commerce_tax_conditions/commerce_tax_conditions.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by
| | drupal.org packaging automatically
--------------------------------------------------------------------------------
Time: 313ms; Memory: 10MB
➜ contrib git:(master) ✗ 🇵🇭Philippines clarkssquared
Hi
I applied MR !1 again and I can still see some PHPCS errors
➜ database_dashboard git:(master) ✗ curl https://git.drupalcode.org/project/database_dashboard/-/merge_requests/1.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 2495 0 2495 0 0 5172 0 --:--:-- --:--:-- --:--:-- 5286
patching file database_dashboard.info.yml
1 out of 1 hunks failed--saving rejects to database_dashboard.info.yml.rej
patching file database_dashboard.module
patching file 'src/Controller/DatabaseDashboardController.php'
➜ database_dashboard git:(master) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml database_dashboard
FILE: ...jects/d9/d9-local/web/modules/contrib/database_dashboard/css/dashboard.css
--------------------------------------------------------------------------------
FOUND 9 ERRORS AFFECTING 6 LINES
--------------------------------------------------------------------------------
2 | ERROR | [x] Selectors must be on a single line
3 | ERROR | [x] Multiple selectors should each be on a single line
3 | ERROR | [x] Selectors must be on a single line
4 | ERROR | [x] Selectors must be on a single line
5 | ERROR | [x] Multiple selectors should each be on a single line
5 | ERROR | [x] Selectors must be on a single line
6 | ERROR | [ ] Style definitions must end with a semicolon
18 | ERROR | [x] There must be no space before a colon in a style definition
18 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...9-local/web/modules/contrib/database_dashboard/database_dashboard.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by
| | drupal.org packaging automatically
7 | WARNING | All dependencies must be prefixed with the project name, for
| | example "drupal:"
--------------------------------------------------------------------------------
Time: 200ms; Memory: 10MB
➜ contrib git:(master) ✗
🇵🇭Philippines clarkssquared
Hi
Your MR !1 is cannot be applied, please look at below
➜ otp_auth git:(master) ✗ curl https://git.drupalcode.org/project/otp_auth/-/merge_requests/1.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 101 0 101 0 0 193 0 --:--:-- --:--:-- --:--:-- 195
I can't seem to find a patch in there anywhere.
➜ otp_auth git:(master) ✗ curl https://git.drupalcode.org/project/otp_auth/-/merge_requests/1.diff | git apply -v
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 101 0 101 0 0 208 0 --:--:-- --:--:-- --:--:-- 211
Skipped patch 'README.txt => README.md'.
➜ otp_auth git:(master) ✗
I also noticed that the MR will just change the filename of the README file and the existing README in the module doesn't follow the Drupal README.md template →
So replace it with new README.md file that follows drupal standards.
🇵🇭Philippines clarkssquared
Hi
I also applied MR !3 and I confirmed that all PHPCS issues were resolved.
➜ fb_likebox git:(8.x-2.3) curl https://git.drupalcode.org/project/fb_likebox/-/merge_requests/3.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 1567 0 1567 0 0 3023 0 --:--:-- --:--:-- --:--:-- 3066
patching file fb_likebox.module
patching file 'tests/src/Functional/FBLikeboxBlockTest.php'
➜ fb_likebox git:(8.x-2.3) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml fb_likebox
➜ contrib git:(master) ✗
🇵🇭Philippines clarkssquared
clarkssquared → created an issue.
🇵🇭Philippines clarkssquared
This is now ready for review
🇵🇭Philippines clarkssquared
clarkssquared → created an issue.
🇵🇭Philippines clarkssquared
Hi
I applied the updated patch #8 and I confirmed that after applying the patch, all the PHPCS issues were resolved.
➜ paint git:(main) curl https://www.drupal.org/files/issues/2024-03-01/3423100-8.patch | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 21204 100 21204 0 0 45190 0 --:--:-- --:--:-- --:--:-- 45995
patching file README.md
patching file 'css/paint-paint-widget.css'
patching file 'js/paint.js'
patching file paint.module
patching file 'src/Plugin/Field/FieldFormatter/PaintDefaultFormatter.php'
patching file 'src/Plugin/Field/FieldFormatter/PaintImageFormatter.php'
patching file 'src/Plugin/Field/FieldType/PaintItem.php'
patching file 'src/Plugin/Field/FieldWidget/PaintWidget.php'
patching file 'templates/paint-image-formatter.html.twig'
➜ paint git:(main) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml paint
➜ contrib git:(master) ✗
🇵🇭Philippines clarkssquared
Hi
I applied MR !2 and I confirmed that it fixes all the PHPCS erors, the remaining errors about happens when you install the module via composer.
➜ cmm git:(master) ✗ curl https://git.drupalcode.org/project/cmm/-/merge_requests/2.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 4517 0 4517 0 0 11211 0 --:--:-- --:--:-- --:--:-- 11377
patching file README.md
patching file cmm.info.yml
1 out of 1 hunks failed--saving rejects to cmm.info.yml.rej
patching file cmm.module
patching file cmm.routing.yml
patching file cmm.services.yml
patching file 'src/Form/UserLoginHiddenForm.php'
patching file 'src/Routing/RouteSubscriber.php'
➜ cmm git:(master) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml cmm
FILE: ...arksubing-subing/Projects/d9/d9-local/web/modules/contrib/cmm/cmm.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by
| | drupal.org packaging automatically
--------------------------------------------------------------------------------
Time: 197ms; Memory: 10MB
➜ contrib git:(master) ✗ 🇵🇭Philippines clarkssquared
Hi
I applied the MR !6 and there are PHPCS errors and warning that my terminal flagged
➜ readonlymode git:(3abe435) curl https://git.drupalcode.org/project/readonlymode/-/merge_requests/6.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 18417 0 18417 0 0 36829 0 --:--:-- --:--:-- --:--:-- 37432
patching file readonlymode.module
patching file 'src/Plugin/Block/ReadonlymodeBlock.php'
patching file 'tests/fixtures/drupal7.php'
patching file 'tests/src/Functional/ReadonlymodeTest.php'
➜ readonlymode git:(3abe435) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml readonlymode
FILE: ...web/modules/contrib/readonlymode/tests/src/Functional/ReadonlymodeTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
13 | ERROR | Class name doesn't match filename; expected "class
| | ReadonlymodeTest"
--------------------------------------------------------------------------------
FILE: ...al/web/modules/contrib/readonlymode/src/Plugin/Block/ReadonlymodeBlock.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------------
15 | ERROR | Class name doesn't match filename; expected "class
| | ReadonlymodeBlock"
22 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
24 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
--------------------------------------------------------------------------------
Time: 339ms; Memory: 12MB
➜ contrib git:(master) ✗
🇵🇭Philippines clarkssquared
Hi
I applied MR !1 and I confirmed that it replaces README.txt with README.md file and its content is as per drupal README template,
# Anime
This module integrates the [Anime.js](https://github.com/juliangarnier/anime)
library.
Anime.js (/ˈæn.ə.meɪ/) is a lightweight JavaScript animation library with a
simple, yet powerful API.
It works with CSS properties, SVG, DOM attributes and JavaScript Objects.
For a full description of the module, visit the
[project page](https://www.drupal.org/project/form_mode_control).
Submit bug reports and feature suggestions, or track changes in the
[issue queue](https://www.drupal.org/project/issues/form_mode_control).
## Table of contents
- Requirements
- Installation
- Features
- Configuration
- Maintainers
## Requirements
Download [Anime.js](https://github.com/juliangarnier/anime/archive/master.zip)
library.
## Installation
1. Download 'Anime' module archive
- https://www.drupal.org/project/anime
1. Extract and place it in the root modules directory i.e.
/modules/anime or /modules/contrib/anime
1. Create a libraries directory in the root, if not already there i.e.
/libraries
1. Create a 'anime' directory inside it i.e.
/libraries/anime
1. Download 'Anime' library
- https://github.com/juliangarnier/anime/archive/master.zip
1. Place it in the /libraries/anime directory i.e.
/libraries/anime/lib/anime.min.js
1. Now, enable 'Anime' module.
## Features
'jQuery Anime' plugin is:
- Lightweight
- Easy to use
- Powerful
- Responsive
- Customizable
## Usage
Here is an Anime example:
```
anime({
targets: 'div',
translateX: 250,
rotate: '1turn',
backgroundColor: '#FFF',
duration: 800
});
```
Check official Anime.js documentation for more information:
- https://animejs.com/documentation/
## Configuration
1. Download Anime.js library, Follow INSTALLATION in above.
1. Enable "Anime" module, Follow INSTALLATION in above.
1. Add script to your theme/module ja file, Follow USAGE in above.
1. Enjoy that.
## Maintainers
- Mahyar Sabeti - [mahyarsbt](https://www.drupal.org/u/mahyarsbt)
🇵🇭Philippines clarkssquared
Hi
I applied MR !1 and I confirmed that it created a README.md file that replaced README.txt, however, the README.md is not following the Drupal README.md template →
# Notification Update Nodes
The Notification Update Nodes module allows site administrators to configure notifications to be sent when nodes are updated on the site.
For a full description of the module, visit the
[project page](https://www.drupal.org/project/notification_update_nodes).
Submit bug reports and feature suggestions, or track changes in the
[issue queue](https://www.drupal.org/project/issues/notification_update_nodes).
## Requirements
This module requires no modules outside of Drupal core.
## Installation
Install as you would normally install a contributed Drupal module. For further
information, see
[Installing Drupal Modules](https://www.drupal.org/docs/extending-drupal/installing-drupal-modules).
## Configuration
1. Go to Administration » Configuration » System » setting_notifications
2. Enter the email on which you want receive to receive updates.
hence I will move this to needs work
🇵🇭Philippines clarkssquared
Hi
I applied MR !36 and I confirmed that it fixes most of the PHPCS issues stated above, but since there are few remaining PHPCS issues I will move this ticket to needs work so that all PHPCS issues will be resolved.
➜ config_pages git:(master) ✗ curl https://git.drupalcode.org/project/config_pages/-/merge_requests/36.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 25607 0 25607 0 0 46401 0 --:--:-- --:--:-- --:--:-- 47071
patching file config_pages.module
patching file 'src/Command/GetValueCommand.php'
patching file 'src/Command/SetValueCommand.php'
patching file 'src/ConfigPagesAccessControlHandler.php'
patching file 'src/ConfigPagesContextBase.php'
patching file 'src/ConfigPagesContextManager.php'
patching file 'src/ConfigPagesForm.php'
patching file 'src/ConfigPagesListBuilder.php'
patching file 'src/ConfigPagesPermissions.php'
patching file 'src/ConfigPagesTypeForm.php'
patching file 'src/ConfigPagesTypeListBuilder.php'
patching file 'src/Controller/ConfigPagesController.php'
patching file 'src/Entity/ConfigPages.php'
patching file 'src/Entity/ConfigPagesType.php'
patching file 'src/Form/ConfigPagesClearConfirmationForm.php'
patching file 'src/Plugin/Block/ConfigPagesBlock.php'
patching file 'src/Plugin/Condition/ConfigPagesValueAccess.php'
1 out of 3 hunks failed--saving rejects to 'src/Plugin/Condition/ConfigPagesValueAccess.php.rej'
patching file 'tests/src/Functional/ClearConfigPageTest.php'
patching file 'tests/src/Functional/DeleteConfigPageTypeTest.php'
➜ config_pages git:(master) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml config_pages
FILE: ...rojects/d9/d9-local/web/modules/contrib/config_pages/config_pages.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by
| | drupal.org packaging automatically
--------------------------------------------------------------------------------
FILE: ...dules/contrib/config_pages/src/Plugin/Condition/ConfigPagesValueAccess.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------
217 | WARNING | Unused variable $cp_type.
217 | WARNING | Unused variable $data_type.
--------------------------------------------------------------------------------
FILE: .../web/modules/contrib/config_pages/src/Controller/ConfigPagesController.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
169 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
--------------------------------------------------------------------------------
FILE: ...s/d9/d9-local/web/modules/contrib/config_pages/src/ConfigPagesTypeForm.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
118 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
--------------------------------------------------------------------------------
Time: 858ms; Memory: 12MB
➜ contrib git:(master) ✗
🇵🇭Philippines clarkssquared
Hi
I applied patch #2 and I confirmed that it fixes all the PHPCS issues of the module
➜ entity_holder git:(1.0.x) curl https://www.drupal.org/files/issues/2024-02-21/3422897-2.patch | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 5432 100 5432 0 0 10613 0 --:--:-- --:--:-- --:--:-- 10756
patching file entity_holder.services.yml
patching file 'src/Controller/EntityHolderController.php'
patching file 'src/EntityHolderStorage.php'
patching file 'src/Form/EntityHolderForm.php'
➜ entity_holder git:(1.0.x) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml entity_holder
➜ contrib git:(master) ✗
🇵🇭Philippines clarkssquared
Hi
I applied your patch #2 and it didn't apply properly and there are still PHPCS issues being flagged.
➜ database_dashboard git:(master) ✗ curl https://www.drupal.org/files/issues/2024-02-21/3422911-2.patch | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 2297 100 2297 0 0 3570 0 --:--:-- --:--:-- --:--:-- 3605
patching file database_dashboard.info.yml
1 out of 1 hunks failed--saving rejects to database_dashboard.info.yml.rej
patching file database_dashboard.module
patching file 'src/Controller/DatabaseDashboardController.php'
➜ database_dashboard git:(master) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml database_dashboard
FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/modules/contrib/database_dashboard/css/dashboard.css
-------------------------------------------------------------------------------------------------------------
FOUND 9 ERRORS AFFECTING 6 LINES
-------------------------------------------------------------------------------------------------------------
2 | ERROR | [x] Selectors must be on a single line
3 | ERROR | [x] Multiple selectors should each be on a single line
3 | ERROR | [x] Selectors must be on a single line
4 | ERROR | [x] Selectors must be on a single line
5 | ERROR | [x] Multiple selectors should each be on a single line
5 | ERROR | [x] Selectors must be on a single line
6 | ERROR | [ ] Style definitions must end with a semicolon
18 | ERROR | [x] There must be no space before a colon in a style definition
18 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
-------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------
FILE: ...rs/clarksubing-subing/Projects/d9/d9-local/web/modules/contrib/database_dashboard/database_dashboard.info.yml
-------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
7 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
-------------------------------------------------------------------------------------------------------------------
Time: 284ms; Memory: 10MB
➜ contrib git:(master) ✗
🇵🇭Philippines clarkssquared
Hi
I checked your MR and it only changes the filename from README.txt to README.md
diff --git a/README.txt b/README.md
similarity index 100%
rename from README.txt
rename to README.mdMuch better if there is content inside the README.md file according to Drupal README.md template →
🇵🇭Philippines clarkssquared
Hi
I applied your patch #2 and I can still see many PHPCS errors in the module
➜ paint git:(main) curl https://www.drupal.org/files/issues/2024-02-22/3423100-2.patch | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 9501 100 9501 0 0 20831 0 --:--:-- --:--:-- --:--:-- 21113
patching file README.md
patching file paint.module
patching file 'src/Plugin/Field/FieldFormatter/PaintDefaultFormatter.php'
patching file 'src/Plugin/Field/FieldFormatter/PaintImageFormatter.php'
patching file 'src/Plugin/Field/FieldType/PaintItem.php'
patching file 'src/Plugin/Field/FieldWidget/PaintWidget.php'
patching file 'templates/paint-image-formatter.html.twig'
➜ paint git:(main) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml paint
FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/modules/contrib/paint/css/paint-paint-widget.css
---------------------------------------------------------------------------------------------------------
FOUND 139 ERRORS AFFECTING 139 LINES
---------------------------------------------------------------------------------------------------------
2 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
6 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
10 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
11 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
15 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
16 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
18 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
19 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
20 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
22 | ERROR | [x] Blank lines are not allowed in class definitions
23 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
28 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
29 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
30 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
34 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
38 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
39 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
40 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
41 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
42 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
43 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
44 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
45 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
46 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
51 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
52 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
53 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
54 | ERROR | [x] Blank lines are not allowed in class definitions
55 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
56 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
57 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
58 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
59 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
63 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
64 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
65 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
66 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
67 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
68 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
72 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
73 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
74 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
75 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
76 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
80 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
81 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
82 | ERROR | [x] Blank lines are not allowed in class definitions
83 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
84 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
85 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
86 | ERROR | [x] Blank lines are not allowed in class definitions
87 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
88 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
92 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
93 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
94 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
95 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
96 | ERROR | [x] Blank lines are not allowed in class definitions
97 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
98 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
99 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
103 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
104 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
105 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
106 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
107 | ERROR | [x] Blank lines are not allowed in class definitions
108 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
109 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
110 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
114 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
115 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
116 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
117 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
121 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
122 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
123 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
124 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
128 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
129 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
130 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
134 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
135 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
136 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
137 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
138 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
139 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
140 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
141 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
142 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
143 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
144 | ERROR | [x] Blank lines are not allowed in class definitions
145 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
146 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
147 | ERROR | [x] Blank lines are not allowed in class definitions
148 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
149 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
150 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
154 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
158 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
162 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
166 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
170 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
174 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
178 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
179 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
180 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
181 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
184 | ERROR | [x] Multiple selectors should each be on a single line
185 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
186 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
187 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
188 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
189 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
190 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
195 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
199 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
203 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
204 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
205 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
206 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
207 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
211 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
212 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
213 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
214 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
218 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
219 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
220 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
224 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
225 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
226 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
227 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
228 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
233 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
234 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
235 | ERROR | [x] Expected 1 newline at end of file; 0 found
---------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 139 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------
Time: 259ms; Memory: 10MB
➜ contrib git:(master) ✗
Hence I will move this to needs work
🐛 | stub project from issue ref | Spacing issue when there are multiple components in the same section in Layout Builder
🇵🇭Philippines clarkssquared
This is now ready for review
🇵🇭Philippines clarkssquared
Hi
I applied MR !38 after ravikant's commit and I confirmed that it updated the README file according to Drupal
# Components!
The Components module makes it easier for a theme to organize its components.
It allows themes (and modules) to register Twig namespaces and provides some
additional Twig functions and filters for use in Drupal templates.
For a full description of the module, visit the
[project page](https://www.drupal.org/project/components).
Submit bug reports and feature suggestions, or track changes in the
[issue queue](https://www.drupal.org/project/issues/components?categories=All).
## Table of contents
- Features
- Installation
- Requirements
- Configuration
- Usage
- Maintainers
## Features
- Offers feature called Template namespaces.
## Installation
Install as you would normally install a contributed Drupal module. For further
information, see
[Installing Drupal Modules](https://www.drupal.org/docs/extending-drupal/installing-drupal-modules).
## Requirements
This module requires no modules outside of Drupal core.
## Configuration
This modules doesn't have any configuration. It allows user to add the template
namespaces.
## Maintainers
- John Albin Wilkins - [JohnAlbin](https://www.drupal.org/u/johnalbin)
- Rob Loach - [RobLoach](https://www.drupal.org/u/robloach)🇵🇭Philippines clarkssquared
Hi
I applied your patch #2 and there are still PHPCS issues that were flagged in my terminal.
➜ multiparagraph_flow git:(1.0.x) curl https://www.drupal.org/files/issues/2024-02-22/3423175-2.patch | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 789 100 789 0 0 1492 0 --:--:-- --:--:-- --:--:-- 1505
patching file multiparagraph_flow.module
➜ multiparagraph_flow git:(1.0.x) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml multiparagraph_flow
FILE: ...s/d9/d9-local/web/modules/contrib/multiparagraph_flow/dist/global/grid.css
--------------------------------------------------------------------------------
FOUND 26 ERRORS AFFECTING 26 LINES
--------------------------------------------------------------------------------
15 | ERROR | [x] Closing brace of class definition must be on new line
19 | ERROR | [x] Closing brace of class definition must be on new line
23 | ERROR | [x] Closing brace of class definition must be on new line
27 | ERROR | [x] Closing brace of class definition must be on new line
31 | ERROR | [x] Closing brace of class definition must be on new line
35 | ERROR | [x] Closing brace of class definition must be on new line
39 | ERROR | [x] Closing brace of class definition must be on new line
43 | ERROR | [x] Closing brace of class definition must be on new line
47 | ERROR | [x] Closing brace of class definition must be on new line
51 | ERROR | [x] Closing brace of class definition must be on new line
55 | ERROR | [x] Closing brace of class definition must be on new line
59 | ERROR | [x] Closing brace of class definition must be on new line
63 | ERROR | [x] Closing brace of class definition must be on new line
67 | ERROR | [x] Closing brace of class definition must be on new line
71 | ERROR | [x] Closing brace of class definition must be on new line
75 | ERROR | [x] Closing brace of class definition must be on new line
79 | ERROR | [x] Closing brace of class definition must be on new line
83 | ERROR | [x] Closing brace of class definition must be on new line
87 | ERROR | [x] Closing brace of class definition must be on new line
91 | ERROR | [x] Closing brace of class definition must be on new line
95 | ERROR | [x] Closing brace of class definition must be on new line
99 | ERROR | [x] Closing brace of class definition must be on new line
101 | ERROR | [x] Closing brace of class definition must be on new line
104 | ERROR | [x] Closing brace of class definition must be on new line
107 | ERROR | [x] Closing brace of class definition must be on new line
113 | ERROR | [x] Closing brace of class definition must be on new line
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 26 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Time: 195ms; Memory: 10MB
➜ contrib git:(master) ✗ moving this to needs work