🇵🇭Philippines clarkssquared
I applied MR !12 in the module and there are no PHPCS issues found in the module
➜ funnelback git:(2.0.0-beta4) curl https://git.drupalcode.org/project/funnelback/-/merge_requests/12.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 9877 0 9877 0 0 19630 0 --:--:-- --:--:-- --:--:-- 19913
patching file funnelback.info.yml
patching file 'src/Form/FunnelbackSettingsForm.php'
patching file 'src/FunnelbackClient.php'
➜ funnelback git:(2.0.0-beta4) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml funnelback
➜ contrib git:(main) ✗
RTBC +1
🇵🇭Philippines clarkssquared
Hi
I applied MR !13 and I can still see PHPCS errors in the module,
➜ paragraphs_paste git:(2.0.0-beta7) curl https://git.drupalcode.org/project/paragraphs_paste/-/merge_requests/13.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 3263 0 3263 0 0 6108 0 --:--:-- --:--:-- --:--:-- 6191
patching file README.md
patching file paragraphs_paste.routing.yml
patching file 'tests/modules/paragraphs_paste_test/paragraphs_paste_test.info.yml'
➜ paragraphs_paste git:(2.0.0-beta7) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml paragraphs_paste
FILE: /Users/clarksubing-subing/Projects/drupal-issues/drupal-project/web/modules/contrib/paragraphs_paste/tests/src/FunctionalJavascript/ParagraphsPasteJavascriptTestBase.php
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\dblog\Controller\DbLogController.
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/clarksubing-subing/Projects/drupal-issues/drupal-project/web/modules/contrib/paragraphs_paste/tests/src/Kernel/Controller/PropertyPathAutocompleteControllerTest.php
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\paragraphs_paste\Controller\PropertyPathAutocompleteController.
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Time: 400ms; Memory: 12MB🇵🇭Philippines clarkssquared
Hi,
I cloned the module and applied MR !4 and I can no longer see any PHPCS issues,
➜ nava git:(1.0.x) curl https://git.drupalcode.org/project/nava/-/merge_requests/4.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 241k 0 241k 0 0 383k 0 --:--:-- --:--:-- --:--:-- 389k
patching file README.md
patching file README.txt
patching file Theme_Changelog.txt
patching file 'config/optional/block.block.nava_account_menu.yml'
patching file 'config/optional/block.block.nava_breadcrumbs.yml'
patching file 'config/schema/nava.schema.yml'
patching file 'css/bootstrap-icons.css'
patching file 'css/slider.css'
patching file 'css/style.css'
patching file 'css/theme-settings.css'
patching file nava.libraries.yml
patching file nava.theme
patching file theme-settings.php
➜ nava git:(1.0.x) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml nava
➜ contrib git:(main) ✗ RTBC +1
🇵🇭Philippines clarkssquared
Hi,
I applied the MR and I can still see PHPCS error and warnings.
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml solo/
FILE: ...drupal-project/web/themes/contrib/solo/includes/_solo_theme_preprocess.inc
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
14 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Core\Routing\RouteMatchInterface.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...ject/web/themes/contrib/solo/includes/_theme_settings_helper_functions.inc
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
660 | WARNING | Unused variable $_.
--------------------------------------------------------------------------------
FILE: ...rupal-project/web/themes/contrib/solo/solo_subtheme/solo_subtheme.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by
| | drupal.org packaging automatically
--------------------------------------------------------------------------------
FILE: ...rojects/drupal-issues/drupal-project/web/themes/contrib/solo/solo.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by
| | drupal.org packaging automatically
--------------------------------------------------------------------------------
Time: 5.35 secs; Memory: 26MB
➜ contrib git:(main) ✗
🇵🇭Philippines clarkssquared
Hi @ggh,
I saw that you moved this ticket to needs review but there's no MR nor a patch file to be tested?
🇵🇭Philippines clarkssquared
Hi jaswinsingh,
I tested your commit 107f602c and I can no longer see any PHPCS issues
➜ taxonomy_parents_index git:(1.0.x) curl https://git.drupalcode.org/project/taxonomy_parents_index/-/merge_requests/3.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 6520 0 6520 0 0 12596 0 --:--:-- --:--:-- --:--:-- 12809
patching file README.md
patching file 'src/Form/IndexTaxonomyParents.php'
patching file 'src/TaxonomyParentsIndexManager.php'
patching file taxonomy_parents_index.install
patching file taxonomy_parents_index.module
➜ taxonomy_parents_index git:(1.0.x) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml taxonomy_parents_index
➜ contrib git:(main) ✗ RTBC +1
🇵🇭Philippines clarkssquared
Hi
The testing might be pretty straight forward since we can now see the View live preview under the MR !9's branch, but just in case I looked at the tugboat env I checked if the module is installed and yes it is. Please refer to this snapshots Screenshot
RTBC +1
🐛 | Provus | Color selections for backgrounds appear non-active (grayed out) even though the user can select them.
🇵🇭Philippines clarkssquared
clarkssquared → created an issue.
🇵🇭Philippines clarkssquared
Hi alyaj2a,
upon checking the MR !38, I noticed that there are still many PHPCS issues that needs to be settled, please refer to
➜ file_mdm git:(3.2.x) curl https://git.drupalcode.org/project/file_mdm/-/merge_requests/38.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 46377 0 46377 0 0 82486 0 --:--:-- --:--:-- --:--:-- 83411
patching file 'config/install/file_mdm.settings.yml'
patching file 'file_mdm_exif/src/ExifTagMapper.php'
patching file 'file_mdm_exif/src/Plugin/FileMetadata/Exif.php'
patching file 'file_mdm_exif/tests/src/Kernel/FileMetadataExifTest.php'
patching file 'file_mdm_font/src/Plugin/FileMetadata/Font.php'
patching file 'file_mdm_font/tests/src/Kernel/FileMetadataFontTest.php'
patching file 'src/Element/FileMetadataCaching.php'
patching file 'src/FileMetadata.php'
patching file 'src/FileMetadataManager.php'
patching file 'src/Form/SettingsForm.php'
patching file 'src/Plugin/Attribute/FileMetadata.php'
patching file 'src/Plugin/FileMetadata/FileMetadataPluginBase.php'
patching file 'src/Plugin/FileMetadata/GetImageSize.php'
patching file 'src/Plugin/FileMetadataPluginManager.php'
patching file 'tests/src/Functional/SettingsFormTest.php'
patching file 'tests/src/Kernel/FileMetadataManagerTest.php'
patching file 'tests/src/Kernel/FileMetadataManagerTestBase.php'
➜ file_mdm git:(3.2.x) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml file_mdm
FILE: ...s/contrib/file_mdm/file_mdm_font/tests/src/Kernel/FileMetadataFontTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
8 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\file_mdm\FileMetadataInterface.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...issues/drupal-project/web/modules/contrib/file_mdm/file_mdm_font/README.md
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
15 | WARNING | Line exceeds 80 characters; contains 91 characters
--------------------------------------------------------------------------------
FILE: ...ect/web/modules/contrib/file_mdm/tests/src/Functional/SettingsFormTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
10 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\file_mdm\FileMetadataManagerInterface.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: .../modules/contrib/file_mdm/tests/src/Kernel/FileMetadataManagerTestBase.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
10 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\file_mdm\FileMetadataInterface.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...s/contrib/file_mdm/file_mdm_exif/tests/src/Kernel/FileMetadataExifTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
9 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\file_mdm\FileMetadataInterface.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...issues/drupal-project/web/modules/contrib/file_mdm/file_mdm_exif/README.md
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------
82 | WARNING | Line exceeds 80 characters; contains 83 characters
88 | WARNING | Line exceeds 80 characters; contains 107 characters
--------------------------------------------------------------------------------
FILE: ...l-project/web/modules/contrib/file_mdm/file_mdm_exif/src/ExifTagMapper.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
13 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is lsolesen\pel\PelIfd.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...eb/modules/contrib/file_mdm/file_mdm_exif/src/Plugin/FileMetadata/Exif.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
13 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is lsolesen\pel\PelEntry.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...ojects/drupal-issues/drupal-project/web/modules/contrib/file_mdm/README.md
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
--------------------------------------------------------------------------------
12 | WARNING | Line exceeds 80 characters; contains 93 characters
16 | WARNING | Line exceeds 80 characters; contains 94 characters
68 | WARNING | Line exceeds 80 characters; contains 115 characters
75 | WARNING | Line exceeds 80 characters; contains 93 characters
105 | WARNING | Line exceeds 80 characters; contains 82 characters
--------------------------------------------------------------------------------
Time: 912ms; Memory: 14MB
➜ contrib git:(main) ✗
🇵🇭Philippines clarkssquared
Hi kinyein,
I applied and tested your MR !2 and I can still see PHPCS errors on my end.
➜ synimport git:(8.x-1.96) curl https://git.drupalcode.org/project/synimport/-/merge_requests/2.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 24333 0 24333 0 0 45099 0 --:--:-- --:--:-- --:--:-- 45567
patching file 'src/Drush/Commands/SynimportCommands.php'
patching file 'src/Service/Export/Block.php'
patching file 'src/Service/Export/CreateYml.php'
patching file 'src/Service/Export/CreateYmlBase.php'
patching file 'src/Service/Export/Export.php'
patching file 'src/Service/Export/Node.php'
patching file 'src/Service/Export/Product.php'
patching file 'src/Service/Export/Taxonomy.php'
patching file 'src/Service/Import/Block.php'
patching file 'src/Service/Import/CreateEntity.php'
patching file 'src/Service/Import/Files.php'
patching file 'src/Service/Import/Import.php'
patching file 'src/Service/Import/Menu.php'
patching file 'src/Service/Import/Node.php'
patching file 'src/Service/Import/Product.php'
patching file 'src/Service/Import/Redis.php'
patching file 'src/Service/Import/Taxonomy.php'
patching file 'src/Service/Logger.php'
➜ synimport git:(8.x-1.96) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml synimport
FILE: ...l-project/web/modules/contrib/synimport/content file examples/contacts.yml
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
18 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...oject/web/modules/contrib/synimport/content file examples/node_project.yml
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
75 | ERROR | [x] Expected 1 newline at end of file; 3 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...jects/drupal-issues/drupal-project/web/modules/contrib/synimport/README.md
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 19 WARNINGS AFFECTING 19 LINES
--------------------------------------------------------------------------------
4 | WARNING | Line exceeds 80 characters; contains 89 characters
5 | WARNING | Line exceeds 80 characters; contains 103 characters
32 | WARNING | Line exceeds 80 characters; contains 101 characters
62 | WARNING | Line exceeds 80 characters; contains 82 characters
64 | WARNING | Line exceeds 80 characters; contains 85 characters
68 | WARNING | Line exceeds 80 characters; contains 125 characters
69 | WARNING | Line exceeds 80 characters; contains 113 characters
70 | WARNING | Line exceeds 80 characters; contains 89 characters
72 | WARNING | Line exceeds 80 characters; contains 81 characters
74 | WARNING | Line exceeds 80 characters; contains 136 characters
78 | WARNING | Line exceeds 80 characters; contains 97 characters
82 | WARNING | Line exceeds 80 characters; contains 113 characters
86 | WARNING | Line exceeds 80 characters; contains 118 characters
90 | WARNING | Line exceeds 80 characters; contains 106 characters
100 | WARNING | Line exceeds 80 characters; contains 104 characters
101 | WARNING | Line exceeds 80 characters; contains 115 characters
119 | WARNING | Line exceeds 80 characters; contains 88 characters
136 | WARNING | Line exceeds 80 characters; contains 90 characters
138 | WARNING | Line exceeds 80 characters; contains 81 characters
--------------------------------------------------------------------------------
FILE: ...pal-issues/drupal-project/web/modules/contrib/synimport/synimport.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
6 | WARNING | All dependencies must be prefixed with the project name, for
| | example "drupal:"
--------------------------------------------------------------------------------
FILE: .../drupal-project/web/modules/contrib/synimport/src/Service/Import/Files.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------
91 | WARNING | Unused variable $tmp.
139 | WARNING | Unused variable $tmp.
--------------------------------------------------------------------------------
FILE: ...-project/web/modules/contrib/synimport/src/Service/Import/CreateEntity.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Core\Entity\EntityStorageInterface.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Time: 858ms; Memory: 12MB
➜ contrib git:(main) ✗
🇵🇭Philippines clarkssquared
Hi
I applied the updated MR !76, and I can still see many PHPCS errors and warning, there are so many issues being reported.
➜ ctools git:(4.1.x) curl https://git.drupalcode.org/project/ctools/-/merge_requests/76.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 54150 0 54150 0 0 99322 0 --:--:-- --:--:-- --:--:-- 98k
patching file ctools.post_update.php
patching file 'modules/ctools_entity_mask/src/MaskContentEntityStorage.php'
patching file 'modules/ctools_views/src/Plugin/Display/Block.php'
patching file 'src/ConstraintConditionInterface.php'
patching file 'src/ContextNotFoundException.php'
patching file 'src/Form/ManageContext.php'
patching file 'src/Form/RequiredContext.php'
patching file 'src/Plugin/Block/EntityView.php'
patching file 'src/Plugin/BlockPluginCollection.php'
patching file 'src/Plugin/BlockVariantTrait.php'
patching file 'src/Plugin/Condition/EntityBundle.php'
patching file 'src/Plugin/Condition/NodeType.php'
patching file 'src/Plugin/Deriver/EntityBundle.php'
patching file 'src/Plugin/Deriver/TypedDataEntityRelationshipDeriver.php'
patching file 'src/Plugin/Deriver/TypedDataLanguageRelationshipDeriver.php'
patching file 'src/Plugin/Deriver/TypedDataPropertyDeriverBase.php'
patching file 'src/Plugin/Deriver/TypedDataRelationshipDeriver.php'
patching file 'src/Plugin/Relationship/TypedDataEntityRelationship.php'
patching file 'src/Plugin/Relationship/TypedDataLanguageRelationship.php'
patching file 'src/Plugin/Relationship/TypedDataRelationship.php'
patching file 'src/Plugin/RelationshipBase.php'
patching file 'src/Plugin/RelationshipInterface.php'
patching file 'src/Plugin/VariantCollectionTrait.php'
patching file 'src/Plugin/VariantPluginCollection.php'
patching file 'src/SerializableTempstore.php'
patching file 'src/SerializableTempstoreFactory.php'
patching file 'src/Testing/EntityCreationTrait.php'
patching file 'src/TypedDataResolver.php'
patching file 'src/Wizard/EntityFormWizardBase.php'
patching file 'src/Wizard/EntityFormWizardInterface.php'
patching file 'src/Wizard/FormWizardBase.php'
patching file 'src/Wizard/FormWizardInterface.php'
patching file 'tests/modules/ctools_block_display_test/src/Plugin/DisplayVariant/BlockDisplayVariant.php'
patching file 'tests/modules/ctools_wizard_test/src/Entity/ExampleConfigEntity.php'
patching file 'tests/modules/ctools_wizard_test/src/ExampleConfigEntityInterface.php'
patching file 'tests/modules/ctools_wizard_test/src/ExampleConfigEntityListBuilder.php'
patching file 'tests/modules/ctools_wizard_test/src/Wizard/EntityAddWizard.php'
patching file 'tests/modules/ctools_wizard_test/src/Wizard/EntityEditWizard.php'
patching file 'tests/modules/ctools_wizard_test/src/Wizard/EntityWizard.php'
patching file 'tests/src/Functional/CToolsWizardTest.php'
patching file 'tests/src/Kernel/RelationshipsTestBase.php'
patching file 'tests/src/Kernel/TypedDataResolverTest.php'
patching file 'tests/src/Unit/BlockDisplayVariantTest.php'
patching file 'tests/src/Unit/BlockPluginCollectionTest.php'
patching file 'tests/src/Unit/BlockVariantTraitTest.php'
patching file 'tests/src/Unit/ContextMapperTest.php'
patching file 'tests/src/Unit/VariantCollectionTraitTest.php'
➜ ctools git:(4.1.x) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml ctools
FILE: ...ontrib/ctools/tests/modules/ctools_wizard_test/ctools_wizard_test.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | Remove "version" from the info file, it will be added by
| | drupal.org packaging automatically
--------------------------------------------------------------------------------
FILE: ...rib/ctools/tests/modules/ctools_wizard_test/ctools_wizard_test.routing.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------
9 | WARNING | Open page callback found, please add a comment before the line
| | why there is no access restriction
18 | WARNING | Open page callback found, please add a comment before the line
| | why there is no access restriction
--------------------------------------------------------------------------------
FILE: ...sts/modules/ctools_wizard_test/src/Form/ExampleConfigEntityGeneralForm.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
26 | WARNING | Unused variable $config_entity.
--------------------------------------------------------------------------------
FILE: ...tests/modules/ctools_block_display_test/ctools_block_display_test.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | Remove "version" from the info file, it will be added by
| | drupal.org packaging automatically
--------------------------------------------------------------------------------
FILE: ...t/web/modules/contrib/ctools/tests/src/Unit/VariantCollectionTraitTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Component\Plugin\PluginManagerInterface.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...al-project/web/modules/contrib/ctools/tests/src/Unit/ContextMapperTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Core\DependencyInjection\ContainerBuilder.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...ject/web/modules/contrib/ctools/tests/src/Unit/BlockDisplayVariantTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Component\Uuid\UuidInterface.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...roject/web/modules/contrib/ctools/tests/src/Unit/BlockVariantTraitTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Component\Uuid\UuidInterface.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...ct/web/modules/contrib/ctools/tests/src/Unit/BlockPluginCollectionTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Core\Block\BlockManagerInterface.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...ject/web/modules/contrib/ctools/tests/src/Kernel/RelationshipsTestBase.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
61 | WARNING | Unused variable $article.
--------------------------------------------------------------------------------
FILE: ...ct/web/modules/contrib/ctools/tests/src/Kernel/BlockDisplayVariantTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\ctools\Event\BlockVariantEvent.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...ects/drupal-issues/drupal-project/web/modules/contrib/ctools/ctools.module
--------------------------------------------------------------------------------
FOUND 15 ERRORS AND 5 WARNINGS AFFECTING 8 LINES
--------------------------------------------------------------------------------
17 | WARNING | Hook implementations should not duplicate @param documentation
17 | ERROR | Missing parameter comment
17 | ERROR | Missing parameter type
18 | WARNING | Hook implementations should not duplicate @param documentation
18 | ERROR | Missing parameter comment
18 | ERROR | Missing parameter type
19 | WARNING | Hook implementations should not duplicate @param documentation
19 | ERROR | Missing parameter comment
19 | ERROR | Missing parameter type
20 | WARNING | Hook implementations should not duplicate @param documentation
20 | ERROR | Missing parameter comment
20 | ERROR | Missing parameter type
22 | WARNING | Hook implementations should not duplicate @return documentation
22 | ERROR | Description for the @return value is missing
50 | ERROR | Missing parameter comment
50 | ERROR | Missing parameter type
67 | ERROR | Missing parameter comment
67 | ERROR | Missing parameter type
90 | ERROR | Missing parameter comment
90 | ERROR | Missing parameter type
--------------------------------------------------------------------------------
FILE: ...Projects/drupal-issues/drupal-project/web/modules/contrib/ctools/README.md
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
86 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...odules/ctools_views/tests/src/Functional/CToolsViewsBasicViewBlockTest.php
--------------------------------------------------------------------------------
FOUND 3 ERRORS AND 1 WARNING AFFECTING 4 LINES
--------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is
| | Drupal\Core\StringTranslation\StringTranslationTrait.
24 | ERROR | [ ] The @var tag must be the first tag in a member variable
| | comment
26 | ERROR | [ ] Do not disable strict config schema checking in tests.
| | Instead ensure your module properly declares its schema for
| | configurations.
80 | WARNING | [ ] Unused variable $result.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...dules/ctools_views/tests/src/Functional/CToolsViewsEntityViewBlockTest.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AND 3 WARNINGS AFFECTING 5 LINES
--------------------------------------------------------------------------------
8 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\taxonomy\Entity\Vocabulary.
83 | ERROR | [ ] Do not disable strict config schema checking in tests.
| | Instead ensure your module properly declares its schema
| | for configurations.
183 | WARNING | [ ] Unused variable $default_theme.
275 | WARNING | [ ] Unused variable $default_theme.
277 | WARNING | [ ] Unused variable $filter_op_id.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...roject/web/modules/contrib/ctools/modules/ctools_views/ctools_views.module
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
9 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\ctools_views\Plugin\Display\Block.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...b/modules/contrib/ctools/modules/ctools_views/src/Plugin/Display/Block.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
--------------------------------------------------------------------------------
284 | WARNING | Unused variable $identifier.
309 | WARNING | Line exceeds 80 characters; contains 81 characters
365 | WARNING | Unused variable $exposed_info.
758 | WARNING | Unused variable $id.
--------------------------------------------------------------------------------
FILE: ...ock/tests/modules/ctools_block_field_test/ctools_block_field_test.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | Remove "version" from the info file, it will be added by
| | drupal.org packaging automatically
--------------------------------------------------------------------------------
FILE: ...tools_entity_mask/tests/modules/entity_mask_test/entity_mask_test.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | "Description" property is missing in the info.yml file
--------------------------------------------------------------------------------
FILE: ...rib/ctools/modules/ctools_entity_mask/tests/src/Functional/DisplayTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------------
13 | WARNING | The class short comment should describe what the class does and
| | not simply repeat the class name
87 | ERROR | unserialize() is insecure unless allowed classes are limited.
| | Use a safe format like JSON or use the allowed_classes option.
--------------------------------------------------------------------------------
FILE: ...trib/ctools/modules/ctools_entity_mask/tests/src/Kernel/EntityMaskTest.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
130 | ERROR | Public method name "EntityMaskTest::testNotExposedToFieldUI" is
| | not in lowerCamel format
156 | ERROR | unserialize() is insecure unless allowed classes are limited.
| | Use a safe format like JSON or use the allowed_classes option.
--------------------------------------------------------------------------------
FILE: ...upal-project/web/modules/contrib/ctools/src/Form/RelationshipConfigure.php
--------------------------------------------------------------------------------
FOUND 7 ERRORS AFFECTING 7 LINES
--------------------------------------------------------------------------------
11 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Core\TempStore\SharedTempStoreFactory.
39 | ERROR | [ ] Class property $tempstore_id should use lowerCamel naming
| | without underscores
46 | ERROR | [ ] Class property $machine_name should use lowerCamel naming
| | without underscores
151 | ERROR | [ ] Return type "array In the format of" must not contain spaces
161 | ERROR | [ ] Missing parameter comment
163 | ERROR | [ ] Parameter tags must be grouped together in a doc comment
177 | ERROR | [ ] Description for the @return value is missing
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...upal-project/web/modules/contrib/ctools/src/Form/RequiredContextDelete.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
9 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Core\TempStore\SharedTempStoreFactory.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...project/web/modules/contrib/ctools/src/Form/ResolverRelationshipDelete.php
--------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------------
9 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Core\TempStore\SharedTempStoreFactory.
36 | ERROR | [ ] Class property $tempstore_id should use lowerCamel naming
| | without underscores
43 | ERROR | [ ] Class property $machine_name should use lowerCamel naming
| | without underscores
133 | ERROR | [ ] Missing parameter type
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...ject/web/modules/contrib/ctools/src/Form/ResolverRelationshipConfigure.php
--------------------------------------------------------------------------------
FOUND 14 ERRORS AND 2 WARNINGS AFFECTING 12 LINES
--------------------------------------------------------------------------------
19 | ERROR | Missing short description in doc comment
24 | ERROR | Missing short description in doc comment
27 | ERROR | Class property $tempstore_id should use lowerCamel naming
| | without underscores
29 | ERROR | Missing short description in doc comment
32 | ERROR | Class property $machine_name should use lowerCamel naming
| | without underscores
126 | WARNING | Unused variable $id.
181 | ERROR | Missing parameter comment
181 | ERROR | Missing parameter type
185 | WARNING | Line exceeds 80 characters; contains 92 characters
192 | ERROR | Missing parameter comment
192 | ERROR | Missing parameter type
194 | ERROR | Description for the @return value is missing
201 | ERROR | Missing parameter comment
201 | ERROR | Missing parameter type
203 | ERROR | Parameter tags must be grouped together in a doc comment
203 | ERROR | Missing parameter type
--------------------------------------------------------------------------------
FILE: ...ssues/drupal-project/web/modules/contrib/ctools/src/Form/ContextDelete.php
--------------------------------------------------------------------------------
FOUND 7 ERRORS AFFECTING 7 LINES
--------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Core\Form\ConfirmFormBase.
15 | ERROR | [ ] Missing short description in doc comment
20 | ERROR | [ ] Missing short description in doc comment
23 | ERROR | [ ] Class property $tempstore_id should use lowerCamel naming
| | without underscores
25 | ERROR | [ ] Missing short description in doc comment
28 | ERROR | [ ] Class property $machine_name should use lowerCamel naming
| | without underscores
35 | ERROR | [ ] Class property $context_id should use lowerCamel naming
| | without underscores
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...es/drupal-project/web/modules/contrib/ctools/src/Form/ContextConfigure.php
--------------------------------------------------------------------------------
FOUND 12 ERRORS AND 2 WARNINGS AFFECTING 11 LINES
--------------------------------------------------------------------------------
43 | ERROR | Class property $tempstore_id should use lowerCamel naming
| | without underscores
50 | ERROR | Class property $machine_name should use lowerCamel naming
| | without underscores
172 | WARNING | Line exceeds 80 characters; contains 107 characters
246 | ERROR | Missing parameter comment
246 | ERROR | Missing parameter type
250 | WARNING | Line exceeds 80 characters; contains 92 characters
257 | ERROR | Missing parameter comment
257 | ERROR | Missing parameter type
259 | ERROR | Description for the @return value is missing
283 | ERROR | Missing parameter type
293 | ERROR | Parameter $machine_name is not described in comment
296 | ERROR | Missing parameter comment
296 | ERROR | Missing parameter type
298 | ERROR | Description for the @return value is missing
--------------------------------------------------------------------------------
FILE: ...ues/drupal-project/web/modules/contrib/ctools/src/Form/ConditionDelete.php
--------------------------------------------------------------------------------
FOUND 11 ERRORS AND 1 WARNING AFFECTING 12 LINES
--------------------------------------------------------------------------------
11 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Core\TempStore\SharedTempStoreFactory.
19 | ERROR | [ ] Missing short description in doc comment
24 | ERROR | [ ] Missing short description in doc comment
29 | ERROR | [ ] Missing short description in doc comment
32 | ERROR | [ ] Class property $tempstore_id should use lowerCamel naming
| | without underscores
34 | ERROR | [ ] Missing short description in doc comment
37 | ERROR | [ ] Class property $machine_name should use lowerCamel naming
| | without underscores
39 | ERROR | [ ] Missing short description in doc comment
116 | ERROR | [ ] Missing parameter type
118 | ERROR | [ ] Missing parameter type
198 | WARNING | [ ] Line exceeds 80 characters; contains 92 characters
232 | ERROR | [ ] Description for the @return value is missing
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...es/drupal-project/web/modules/contrib/ctools/src/Form/ManageConditions.php
--------------------------------------------------------------------------------
FOUND 28 ERRORS AND 1 WARNING AFFECTING 24 LINES
--------------------------------------------------------------------------------
15 | ERROR | Doc comment is empty
20 | ERROR | Missing short description in doc comment
32 | ERROR | Missing short description in doc comment
35 | ERROR | Class property $machine_name should use lowerCamel naming
| | without underscores
37 | ERROR | Doc comment is empty
47 | ERROR | Doc comment is empty
111 | ERROR | Doc comment is empty
133 | ERROR | Missing short description in doc comment
134 | ERROR | Missing parameter comment
134 | ERROR | Missing parameter type
136 | ERROR | Description for the @return value is missing
151 | ERROR | Key specified for array entry; first entry has no key
159 | ERROR | Doc comment is empty
197 | ERROR | Description for the @return value is missing
204 | ERROR | Missing parameter comment
206 | ERROR | Description for the @return value is missing
213 | ERROR | Description for the @return value is missing
226 | ERROR | Missing parameter comment
228 | ERROR | Parameter tags must be grouped together in a doc comment
228 | ERROR | Missing parameter comment
230 | ERROR | Parameter tags must be grouped together in a doc comment
230 | ERROR | Missing parameter comment
234 | WARNING | Line exceeds 80 characters; contains 88 characters
241 | ERROR | Missing parameter comment
241 | ERROR | Missing parameter type
243 | ERROR | Description for the @return value is missing
250 | ERROR | Missing parameter comment
250 | ERROR | Missing parameter type
252 | ERROR | Description for the @return value is missing
--------------------------------------------------------------------------------
FILE: ...ues/drupal-project/web/modules/contrib/ctools/src/Form/RequiredContext.php
--------------------------------------------------------------------------------
FOUND 11 ERRORS AND 1 WARNING AFFECTING 12 LINES
--------------------------------------------------------------------------------
12 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Core\Form\FormBuilderInterface.
19 | ERROR | [ ] Missing short description in doc comment
31 | ERROR | [ ] Missing short description in doc comment
34 | ERROR | [ ] Class property $machine_name should use lowerCamel naming
| | without underscores
117 | ERROR | [ ] Missing parameter comment
118 | ERROR | [ ] Missing parameter comment
120 | ERROR | [ ] Description for the @return value is missing
134 | ERROR | [ ] Missing parameter type
143 | WARNING | [ ] Unused variable $machine_name.
150 | ERROR | [ ] The array declaration extends to column 129 (the limit is
| | 120). The array content should be split up over multiple
| | lines
152 | ERROR | [ ] Key specified for array entry; first entry has no key
163 | ERROR | [ ] Missing parameter type
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...ssues/drupal-project/web/modules/contrib/ctools/src/Form/ManageContext.php
--------------------------------------------------------------------------------
FOUND 4 ERRORS AND 1 WARNING AFFECTING 5 LINES
--------------------------------------------------------------------------------
26 | ERROR | Class property $machine_name should use lowerCamel naming
| | without underscores
54 | ERROR | Class property $property_types should use lowerCamel naming
| | without underscores
119 | WARNING | Variable $types inside unset call is undefined.
273 | ERROR | Key specified for array entry; first entry has no key
426 | ERROR | Missing short description in doc comment
--------------------------------------------------------------------------------
FILE: .../drupal-project/web/modules/contrib/ctools/src/Form/ConditionConfigure.php
--------------------------------------------------------------------------------
FOUND 8 ERRORS AFFECTING 8 LINES
--------------------------------------------------------------------------------
14 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Core\TempStore\SharedTempStoreFactory.
23 | ERROR | [ ] Missing short description in doc comment
28 | ERROR | [ ] Missing short description in doc comment
33 | ERROR | [ ] Missing short description in doc comment
36 | ERROR | [ ] Class property $tempstore_id should use lowerCamel naming
| | without underscores
38 | ERROR | [ ] Missing short description in doc comment
41 | ERROR | [ ] Class property $machine_name should use lowerCamel naming
| | without underscores
190 | ERROR | [ ] Parameter tags must be grouped together in a doc comment
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...roject/web/modules/contrib/ctools/src/Form/ManageResolverRelationships.php
--------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
25 | ERROR | Class property $machine_name should use lowerCamel naming
| | without underscores
32 | ERROR | Class property $property_types should use lowerCamel naming
| | without underscores
187 | ERROR | Key specified for array entry; first entry has no key
--------------------------------------------------------------------------------
FILE: ...al-project/web/modules/contrib/ctools/src/SerializableTempstoreFactory.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Core\TempStore\SharedTempStore.
11 | ERROR | [ ] Each @deprecated tag must have a @see tag immediately
| | following it
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...s/drupal-project/web/modules/contrib/ctools/src/Access/TempstoreAccess.php
--------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
--------------------------------------------------------------------------------
10 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Core\TempStore\SharedTempStoreFactory.
42 | ERROR | [ ] Missing parameter comment
43 | ERROR | [ ] Missing parameter comment
44 | ERROR | [ ] Missing parameter comment
46 | ERROR | [ ] Description for the @return value is missing
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...oject/web/modules/contrib/ctools/src/ParamConverter/TempstoreConverter.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
96 | ERROR | Parameter $entity_type_manager is not described in comment
99 | ERROR | Missing parameter comment
--------------------------------------------------------------------------------
FILE: ...b/modules/contrib/ctools/src/Plugin/DisplayVariant/BlockDisplayVariant.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
9 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Core\Display\ContextAwareVariantInterface.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...upal-project/web/modules/contrib/ctools/src/Plugin/RelationshipManager.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Core\Cache\CacheBackendInterface.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...-project/web/modules/contrib/ctools/src/Plugin/VariantPluginCollection.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
18 | WARNING | Possible useless method overriding detected
--------------------------------------------------------------------------------
FILE: ...rupal-project/web/modules/contrib/ctools/src/Plugin/Condition/NodeType.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
17 | ERROR | Missing short description in doc comment
--------------------------------------------------------------------------------
FILE: ...l-project/web/modules/contrib/ctools/src/Plugin/Condition/EntityBundle.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------
26 | WARNING | Unused variable $definition_id.
39 | WARNING | Unused variable $definition_id.
--------------------------------------------------------------------------------
FILE: ...modules/contrib/ctools/src/Plugin/Deriver/TypedDataRelationshipDeriver.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------
36 | WARNING | Only string literals should be passed to t() where possible
79 | WARNING | Only string literals should be passed to t() where possible
--------------------------------------------------------------------------------
FILE: ...pal-project/web/modules/contrib/ctools/src/Plugin/Deriver/EntityBundle.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
10 | ERROR | Each @deprecated tag must have a @see tag immediately following
| | it
--------------------------------------------------------------------------------
FILE: ...roject/web/modules/contrib/ctools/src/Plugin/Deriver/EntityDeriverBase.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Core\Entity\EntityFieldManagerInterface.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...al-project/web/modules/contrib/ctools/src/Plugin/BlockPluginCollection.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
19 | WARNING | Possible useless method overriding detected
--------------------------------------------------------------------------------
FILE: .../drupal-project/web/modules/contrib/ctools/src/Plugin/Block/EntityView.php
--------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------------
10 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is
| | Drupal\Core\Entity\EntityDisplayRepositoryInterface.
27 | ERROR | [ ] Missing member variable doc comment
106 | ERROR | [ ] Doc comment is empty
116 | ERROR | [ ] Doc comment is empty
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...ues/drupal-project/web/modules/contrib/ctools/src/Wizard/WizardFactory.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
8 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Core\Render\RendererInterface.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...es/drupal-project/web/modules/contrib/ctools/src/Wizard/FormWizardBase.php
--------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
17 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Core\TempStore\SharedTempStoreFactory.
59 | ERROR | [ ] Class property $tempstore_id should use lowerCamel naming
| | without underscores
66 | ERROR | [ ] Class property $machine_name should use lowerCamel naming
| | without underscores
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...pal-project/web/modules/contrib/ctools/src/Wizard/EntityFormWizardBase.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
12 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Core\TempStore\SharedTempStoreFactory.
45 | ERROR | [ ] Doc comment for parameter $tempstore_id does not match actual
| | variable name $step
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...project/web/modules/contrib/ctools/src/Controller/WizardFormController.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
45 | ERROR | Missing short description in doc comment
--------------------------------------------------------------------------------
FILE: ...t/web/modules/contrib/ctools/src/Controller/WizardEntityFormController.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
23 | ERROR | Missing short description in doc comment
--------------------------------------------------------------------------------
FILE: ...pal-project/web/modules/contrib/ctools/src/Testing/EntityCreationTrait.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Component\Render\FormattableMarkup.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...es/drupal-project/web/modules/contrib/ctools/src/SerializableTempstore.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
11 | ERROR | Each @deprecated tag must have a @see tag immediately following
| | it
--------------------------------------------------------------------------------
FILE: ...drupal-project/web/modules/contrib/ctools/src/ContextNotFoundException.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
8 | WARNING | Line exceeds 80 characters; contains 100 characters
--------------------------------------------------------------------------------
FILE: ...issues/drupal-project/web/modules/contrib/ctools/src/Event/WizardEvent.php
--------------------------------------------------------------------------------
FOUND 7 ERRORS AFFECTING 7 LINES
--------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Component\EventDispatcher\Event.
13 | ERROR | [ ] Missing short description in doc comment
18 | ERROR | [ ] Missing short description in doc comment
23 | ERROR | [ ] Doc comment is empty
31 | ERROR | [ ] Doc comment is empty
38 | ERROR | [ ] Doc comment is empty
45 | ERROR | [ ] Doc comment is empty
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: .../drupal-project/web/modules/contrib/ctools/src/Event/BlockVariantEvent.php
--------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
9 | ERROR | Doc comment is empty
44 | ERROR | Description for the @return value is missing
53 | ERROR | Description for the @return value is missing
--------------------------------------------------------------------------------
FILE: ...pal-project/web/modules/contrib/ctools/src/Ajax/OpenModalWizardCommand.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
7 | ERROR | Doc comment is empty
12 | ERROR | Doc comment is empty
--------------------------------------------------------------------------------
Time: 2.48 secs; Memory: 18MB
➜ contrib git:(main) ✗
🇵🇭Philippines clarkssquared
hi gajendersingh1999,
I applied your patch #2 but I can still se some phpcs warnings:
➜ pie_chart git:(main) ✗ curl https://www.drupal.org/files/issues/2025-01-31/issueFixed_3503609_2.patch | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 13198 100 13198 0 0 27464 0 --:--:-- --:--:-- --:--:-- 27961
patching file 'js/pie_chart.js'
patching file 'src/Controller/NodePieChartController.php'
patching file 'src/Plugin/Block/NodePieChartBlock.php'
➜ pie_chart git:(main) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml pie_chart
FILE: ...pal-issues/drupal-project/web/modules/contrib/pie_chart/pie_chart.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | File has mixed line endings; this may cause incorrect results
1 | WARNING | Remove "project" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by
| | drupal.org packaging automatically
--------------------------------------------------------------------------------
Time: 255ms; Memory: 10MB
➜ contrib git:(main) ✗
Also, can you create a merge request for your patch? so that it will be convenient on maintainer's end, thanks.
🇵🇭Philippines clarkssquared
Hi kinyein,
I checked your MR and applied it in my local, after executing the PHPCS commandd I can still see phpcs issues and warning
➜ ewelink git:(1.0.x) curl https://git.drupalcode.org/project/ewelink/-/merge_requests/2.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 11186 0 11186 0 0 18209 0 --:--:-- --:--:-- --:--:-- 18337
patching file 'scripts/devices.js'
patching file 'scripts/getdevice.js'
patching file 'scripts/getdeviceswitch.js'
patching file 'scripts/toggledevice.js'
patching file 'src/Controller/EWeLink.php'
➜ ewelink git:(1.0.x) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml ewelink
FILE: .../drupal-issues/drupal-project/web/modules/contrib/ewelink/ewelink.info.yml
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
4 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...s/drupal-issues/drupal-project/web/modules/contrib/ewelink/ewelink.install
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | ERROR | [x] Expected 1 newline at end of file; 2 found
1 | ERROR | [x] Missing file doc comment
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...rojects/drupal-issues/drupal-project/web/modules/contrib/ewelink/README.md
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
--------------------------------------------------------------------------------
17 | WARNING | Line exceeds 80 characters; contains 89 characters
39 | WARNING | Line exceeds 80 characters; contains 136 characters
47 | WARNING | Line exceeds 80 characters; contains 85 characters
53 | WARNING | Line exceeds 80 characters; contains 128 characters
--------------------------------------------------------------------------------
FILE: ...ts/drupal-issues/drupal-project/web/modules/contrib/ewelink/ewelink.module
--------------------------------------------------------------------------------
FOUND 5 ERRORS AND 2 WARNINGS AFFECTING 6 LINES
--------------------------------------------------------------------------------
4 | ERROR | [x] The second line in the file doc comment must be "@file"
4 | WARNING | [ ] Format should be "* Implements hook_foo().", "* Implements
| | hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", "*
| | Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or
| | "* Implements hook_foo_BAR_ID_bar() for block templates."
5 | ERROR | [x] There must be no blank lines after the function comment
12 | WARNING | [ ] Format should be "* Implements hook_foo().", "* Implements
| | hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", "*
| | Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or
| | "* Implements hook_foo_BAR_ID_bar() for block templates."
13 | ERROR | [x] There must be no blank lines after the function comment
16 | ERROR | [x] Whitespace found at end of line
21 | ERROR | [x] Whitespace found at end of line
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...rupal-project/web/modules/contrib/ewelink/src/Form/EwelinkSettingsForm.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------
62 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
63 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
--------------------------------------------------------------------------------
FILE: ...sues/drupal-project/web/modules/contrib/ewelink/src/Controller/EWeLink.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------
96 | WARNING | Unused variable $res.
101 | WARNING | There must be no blank line following an inline comment
--------------------------------------------------------------------------------
Time: 281ms; Memory: 10MB
➜ contrib git:(main) ✗
🇵🇭Philippines clarkssquared
Hi nidhish,
I applied MR !13 and executed the PHPCS command, these are the only remaining PHPCS issues in the module after I applied your MR
➜ solo git:(main) ✗ curl https://git.drupalcode.org/project/solo/-/merge_requests/13.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 1670 0 1670 0 0 3258 0 --:--:-- --:--:-- --:--:-- 3340
patching file 'includes/_solo_theme_preprocess.inc'
patching file 'includes/_theme_settings_helper_functions.inc'
patching file theme-settings.php
➜ solo git:(main) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml solo
FILE: /Users/clarksubing-subing/Projects/drupal-issues/drupal-project/web/themes/contrib/solo/solo_subtheme/solo_subtheme.info.yml
----------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
----------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/clarksubing-subing/Projects/drupal-issues/drupal-project/web/themes/contrib/solo/solo.info.yml
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-------------------------------------------------------------------------------------------------------------
Time: 4.37 secs; Memory: 26MB
➜ contrib git:(main) ✗
I will leave the decision to the maintainer if this needs to be fixed or no, hence retaining the status to needs review
🇵🇭Philippines clarkssquared
Hi abhiyanshu,
I applied the MR !126 and I can see PHPCS errors aside from the one you mentioned.
➜ radix git:(main) ✗ curl https://git.drupalcode.org/project/radix/-/merge_requests/126.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 8653 0 8653 0 0 13631 0 --:--:-- --:--:-- --:--:-- 13822
patching file 'components/comment/comment.component.yml'
patching file 'components/dropdown-menu/dropdown-menu.component.yml'
patching file 'components/field-comment/field-comment.component.yml'
patching file 'components/fieldset/fieldset.component.yml'
patching file 'components/form-element--label/form-element--label.component.yml'
patching file 'components/form-element--radiocheckbox/form-element--radiocheckbox.component.yml'
patching file 'components/list-group/list-group.component.yml'
patching file 'components/local-tasks/local-tasks.component.yml'
patching file 'components/media/media.component.yml'
patching file 'components/offcanvas/offcanvas.component.yml'
patching file 'components/progress/progress.component.yml'
patching file 'components/taxonomy/taxonomy.component.yml'
patching file radix.info.yml
1 out of 1 hunks failed--saving rejects to radix.info.yml.rej
patching file 'src/kits/radix_starterkit/radix_starterkit.info.yml'
1 out of 1 hunks failed--saving rejects to 'src/kits/radix_starterkit/radix_starterkit.info.yml.rej'
patching file 'src/kits/radix_starterkit/radix_starterkit.libraries.yml'
patching file 'src/kits/radix_starterkit/radix_starterkit.starterkit.yml'
➜ radix git:(main) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml radix
FILE: /Users/clarksubing-subing/Projects/drupal-issues/drupal-project/web/themes/contrib/radix/radix.info.yml
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-------------------------------------------------------------------------------------------------------------
FILE: /Users/clarksubing-subing/Projects/drupal-issues/drupal-project/web/themes/contrib/radix/includes/block.theme
------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------
9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\block_content\BlockContentInterface.
------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/clarksubing-subing/Projects/drupal-issues/drupal-project/web/themes/contrib/radix/includes/form.theme
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------
77 | WARNING | Doc comment indicates hook_form_alter() but function signature is "radix_form_alter" instead of "form_form_alter". Did you mean hook_form_FORM_ID_alter()?
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/clarksubing-subing/Projects/drupal-issues/drupal-project/web/themes/contrib/radix/src/kits/radix_starterkit/radix_starterkit.info.yml
--------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
--------------------------------------------------------------------------------------------------------------------------------------------------
Time: 497ms; Memory: 10MB
➜ contrib git:(main) ✗
🇵🇭Philippines clarkssquared
Hi all,
I checked the updated MR !9 and comment #4 has been fixed, Help Page also looks to me.
RTBC +1
🇵🇭Philippines clarkssquared
Hi,
The file is converted to REAME.md, however can we make the README.md contents to follow the Drupal README.md template → Moving to needs work, thanks.
🇵🇭Philippines clarkssquared
Hi,
I tried installing the 1.0.x-dev version in my drupal project, and I was able to install it.
➜ drupal-project git:(main) ✗ composer require 'drupal/ai_search_block:1.0.x-dev@dev'
./composer.json has been updated
Running composer update drupal/ai_search_block
Loading composer repositories with package information
Updating dependencies
Lock file operations: 11 installs, 0 updates, 0 removals
- Locking drupal/ai (1.0.3)
- Locking drupal/ai_search (1.0.3)
- Locking drupal/ai_search_block (dev-1.0.x 2319014)
- Locking drupal/key (1.19.0)
- Locking drupal/search_api (1.37.0)
- Locking league/commonmark (2.6.1)
- Locking league/config (v1.2.0)
- Locking league/html-to-markdown (5.1.1)
- Locking nette/schema (v1.3.2)
- Locking nette/utils (v4.0.5)
- Locking yethee/tiktoken (0.5.1)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 11 installs, 0 updates, 0 removals
- Downloading league/html-to-markdown (5.1.1)
- Downloading nette/utils (v4.0.5)
- Downloading nette/schema (v1.3.2)
- Downloading league/config (v1.2.0)
- Downloading league/commonmark (2.6.1)
- Downloading yethee/tiktoken (0.5.1)
- Downloading drupal/key (1.19.0)
- Downloading drupal/ai (1.0.3)
- Syncing drupal/ai_search_block (dev-1.0.x 2319014) into cache
- Installing league/html-to-markdown (5.1.1): Extracting archive
- Installing nette/utils (v4.0.5): Extracting archive
- Installing nette/schema (v1.3.2): Extracting archive
- Installing league/config (v1.2.0): Extracting archive
- Installing league/commonmark (2.6.1): Extracting archive
- Installing drupal/search_api (1.37.0): Extracting archive
- Installing yethee/tiktoken (0.5.1): Extracting archive
- Installing drupal/key (1.19.0): Extracting archive
- Installing drupal/ai (1.0.3): Extracting archive
- Installing drupal/ai_search (1.0.3)
- Installing drupal/ai_search_block (dev-1.0.x 2319014): Cloning 23190147c5 from cache
3 package suggestions were added by new dependencies, use `composer suggest` to see details.
Generating autoload files
47 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
No security vulnerability advisories found.
➜ drupal-project git:(main) ✗
📌 | Masquerade | Change README.txt to README.md and update according to "README.md template" in 8.x-2.x branch.
🇵🇭Philippines clarkssquared
Hi jay jangid,
I looked at the README content and added a comment regarding line #3 which it exceeds the 80 character line limit. Please check.
🇵🇭Philippines clarkssquared
Hi ravi,
I reviewed your changes in behalf of ken, and the README file now looks good.
RTBC +1 from me.
Retaining the status to needs review to givr others the chance to review.
🇵🇭Philippines clarkssquared
Hi @_utsavsharma
your MR only removes the README.txt, but the README.md file needs to be updated based on the ticket's title. So the remaining task is to update the README file to follow the Drupal README.md template →
🇵🇭Philippines clarkssquared
This will not be added in core, hence closing this ticket.
🇵🇭Philippines clarkssquared
clarkssquared → created an issue.
🇵🇭Philippines clarkssquared
Hi radheymkumar
I applied patch #2 and I confirmed that it fixes all the PHPCS issues
➜ metatag_search_gov git:(main) ✗ curl https://www.drupal.org/files/issues/2024-12-14/metatag_search_gov-3493966.patch | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 1789 100 1789 0 0 3975 0 --:--:-- --:--:-- --:--:-- 4047
patching file README.md
patching file metatag_search_gov.info.yml
patching file 'src/Plugin/SearchCustomBase.php'
➜ metatag_search_gov git:(main) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml metatag_search_gov
➜ contrib git:(main) ✗ RTBC +1 from me, retaining the status to needs review for others.
🇵🇭Philippines clarkssquared
Hi kinyein,
I added a small commit in your MR because I its previous version there's this PHPCS issues
➜ decoupled_interface_translations git:(1.0.x) curl https://git.drupalcode.org/project/decoupled_interface_translations/-/merge_requests/4.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 6667 0 6667 0 0 11764 0 --:--:-- --:--:-- --:--:-- 11926
patching file 'src/Controller/DecoupledInterfaceTranslationsController.php'
➜ decoupled_interface_translations git:(1.0.x) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml decoupled_interface_translations
FILE: ...e_translations/src/Controller/DecoupledInterfaceTranslationsController.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------------
8 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Core\Controller\ControllerBase.
114 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency
| | injection instead
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLYThen I added a commit to fix the use statements order, the remaining PHPCS issue is \Drupal calls should be avoided in classes, use dependency injection instead and I will leave the decision to the maintainers if this issue should be fixed or not.
Retaining the status to needs review.
🇵🇭Philippines clarkssquared
clarkssquared → made their first commit to this issue’s fork.
🇵🇭Philippines clarkssquared
Hi kinyein,
I applied your MR !5 and I can still see many PHPCS issues in the module
➜ jqcloud git:(3.0.x) curl https://git.drupalcode.org/project/jqcloud/-/merge_requests/5.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 3889 0 3889 0 0 776 0 --:--:-- 0:00:05 --:--:-- 1026
patching file 'src/Plugin/Block/JqcloudBlock.php'
patching file 'src/TermService.php'
patching file 'src/TermServiceInterface.php'
patching file 'tests/src/FunctionalJavascript/JqcloudJavascriptTest.php'
➜ jqcloud git:(3.0.x) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml jqcloud
FILE: ...rib/jqcloud/tests/modules/jqcloud_library_test/jqcloud_library_test.module
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
9 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Core\Routing\RouteMatchInterface.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...ib/jqcloud/tests/modules/jqcloud_library_test/jqcloud_library_test.install
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...s/contrib/jqcloud/tests/src/FunctionalJavascript/JqcloudJavascriptTest.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 19 WARNINGS AFFECTING 19 LINES
--------------------------------------------------------------------------------
211 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
256 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
269 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
283 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
296 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
315 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
330 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
352 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
366 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
376 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
393 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
410 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
434 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
458 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
472 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
489 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
505 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
540 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
542 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
--------------------------------------------------------------------------------
FILE: ...ts/drupal-issues/drupal-project/web/modules/contrib/jqcloud/jqcloud.module
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
9 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Core\Link.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...upal-project/web/modules/contrib/jqcloud/src/Plugin/Block/JqcloudBlock.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
11 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is
| | Drupal\Core\Plugin\ContainerFactoryPluginInterface.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...upal-issues/drupal-project/web/modules/contrib/jqcloud/src/TermService.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
9 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Core\Cache\DatabaseBackend.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Time: 375ms; Memory: 12MB
➜ contrib git:(main) ✗
🇵🇭Philippines clarkssquared
Hi kwiseman,
The MR is pretty straight forward as it removes the .DS_Store files as per the report, I applied it and I confirmed that there are no .DS_Store files anywhere in the theme's directory
➜ bootstrap_barrio git:(5.5.x) find . -name .DS_Store
./subtheme/config/.DS_Store
./css/.DS_Store
./config/.DS_Store
➜ bootstrap_barrio git:(5.5.x) curl https://git.drupalcode.org/project/bootstrap_barrio/-/merge_requests/88.diff | git apply -v
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 666 0 666 0 0 1070 0 --:--:-- --:--:-- --:--:-- 1081
Checking patch config/.DS_Store...
Checking patch css/.DS_Store...
Checking patch subtheme/config/.DS_Store...
Applied patch config/.DS_Store cleanly.
Applied patch css/.DS_Store cleanly.
Applied patch subtheme/config/.DS_Store cleanly.
➜ bootstrap_barrio git:(5.5.x) ✗ find . -name .DS_Store
➜ bootstrap_barrio git:(5.5.x) ✗
🇵🇭Philippines clarkssquared
Hi
I checked MR !1 and I confirmed that it updates the README.md file according to Drupal README.md template →
🇵🇭Philippines clarkssquared
Hi
I applied MR !2 and I confirmed that it fixes all the PHPCS issues
➜ rest_invalidate_cache git:(1.x) curl https://git.drupalcode.org/project/rest_invalidate_cache/-/merge_requests/2.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 1024 0 1024 0 0 2086 0 --:--:-- --:--:-- --:--:-- 2115
patching file 'src/Plugin/rest/resource/InvalidateCache.php'
➜ rest_invalidate_cache git:(1.x) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml rest_invalidate_cache
➜ contrib git:(main) ✗ RTBC +1
🇵🇭Philippines clarkssquared
Hi alyaj2a,
I applied your MR !3 and I can still see some PHPCS issues though these issues can be resolved via PHPCBF
➜ taxonomy_parents_index git:(1.0.x) curl https://git.drupalcode.org/project/taxonomy_parents_index/-/merge_requests/3.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 6570 0 6570 0 0 13248 0 --:--:-- --:--:-- --:--:-- 13463
patching file README.md
patching file 'src/Form/IndexTaxonomyParents.php'
patching file 'src/Plugin/views/relationship/TaxonomyIndexReverseToParents.php'
patching file taxonomy_parents_index.install
patching file taxonomy_parents_index.module
➜ taxonomy_parents_index git:(1.0.x) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml taxonomy_parents_index
FILE: ...modules/contrib/taxonomy_parents_index/src/TaxonomyParentsIndexManager.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
51 | ERROR | [x] Multi-line function declarations must have a trailing comma
| | after the last parameter
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...ents_index/src/Plugin/views/relationship/TaxonomyIndexReverseToParents.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is
| | Drupal\views\Plugin\views\relationship\RelationshipPluginBase.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Time: 278ms; Memory: 10MB
➜ contrib git:(main) ✗ 🇵🇭Philippines clarkssquared
clarkssquared → changed the visibility of the branch 34897930-remove-hardcoded-fonts to hidden.
🇵🇭Philippines clarkssquared
clarkssquared → created an issue.
🇵🇭Philippines clarkssquared
Hi dhruv
I applied the updated MR !2 and this is the remaining PHPCS issues that phpcs reported.
➜ layout_builder_paragraphs git:(1.0.x) curl https://git.drupalcode.org/project/layout_builder_paragraphs/-/merge_requests/2.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 26498 0 26498 0 0 45536 0 --:--:-- --:--:-- --:--:-- 46163
patching file layout_builder_paragraphs.api.php
patching file layout_builder_paragraphs.module
patching file 'src/Controller/ChooseParagraphController.php'
patching file 'src/Controller/ModalLayoutRebuildTrait.php'
patching file 'src/Controller/ModalMoveBlockController.php'
patching file 'src/Element/ModalLayoutBuilder.php'
patching file 'src/Form/AddParagraphForm.php'
patching file 'src/Form/ModalAddBlockForm.php'
patching file 'src/Form/ModalMoveBlockForm.php'
patching file 'src/Form/ModalRemoveBlockForm.php'
patching file 'src/Form/ModalRemoveSectionForm.php'
patching file 'src/Form/ModalUpdateBlockForm.php'
patching file 'src/Routing/RouteSubscriber.php'
➜ layout_builder_paragraphs git:(1.0.x) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml layout_builder_paragraphs
FILE: ...odules/contrib/layout_builder_paragraphs/layout_builder_paragraphs.api.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
20 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...modules/contrib/layout_builder_paragraphs/layout_builder_paragraphs.module
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------
18 | WARNING | All constants defined by a module must be prefixed with the
| | module's name, expected
| | "LAYOUT_BUILDER_PARAGRAPHS_PARAGRAPH_FIELD" but found
| | "PARAGRAPH_FIELD"
18 | WARNING | Global constants should not be used, move it to a class or
| | interface
--------------------------------------------------------------------------------
FILE: ...eb/modules/contrib/layout_builder_paragraphs/src/Form/AddParagraphForm.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
155 | WARNING | Unused variable $value.
--------------------------------------------------------------------------------
Time: 329ms; Memory: 10MB
➜ contrib git:(main) ✗
🇵🇭Philippines clarkssquared
Hi
I applied MR !11 and I can still see many PHPCS issues that phpcs reported
➜ mercury_layouts git:(2.0.x) curl https://git.drupalcode.org/project/mercury_layouts/-/merge_requests/11.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 12054 0 12054 0 0 23397 0 --:--:-- --:--:-- --:--:-- 23681
patching file README.md
patching file 'components/cluster/cluster.component.yml'
patching file 'components/columns-2/columns-2.component.yml'
patching file 'components/columns-3/columns-3.component.yml'
patching file 'components/columns-4/columns-4.component.yml'
patching file 'components/columns-5/columns-5.component.yml'
patching file 'components/columns/columns.component.yml'
patching file 'components/columns/columns.css'
patching file 'components/container/container.component.yml'
patching file 'components/container/container.stories.yml'
patching file 'components/container/container.theme.css'
patching file 'components/grid/grid.component.yml'
patching file 'components/grid/grid.css'
patching file 'components/grid/grid.stories.yml'
patching file 'components/skeleton/skeleton.component.yml'
patching file 'components/skeleton/skeleton.css'
patching file 'components/stack/stack.component.yml'
patching file 'components/stack/stack.layout.css'
patching file 'components/stack/stack.stories.yml'
patching file 'css/utilities.css'
patching file 'src/Plugin/StyleOption/MercuryBoxSize.php'
patching file 'src/Plugin/StyleOption/MercuryColumnRatio.php'
➜ mercury_layouts git:(2.0.x) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml mercury_layouts
FILE: ...upal-issues/drupal/drupal/web/modules/contrib/mercury_layouts/css/tabs.css
--------------------------------------------------------------------------------
FOUND 11 ERRORS AFFECTING 11 LINES
--------------------------------------------------------------------------------
12 | ERROR | [x] Selectors must be on a single line
13 | ERROR | [x] Selectors must be on a single line
14 | ERROR | [x] Selectors must be on a single line
15 | ERROR | [x] Selectors must be on a single line
16 | ERROR | [x] Selectors must be on a single line
17 | ERROR | [x] Selectors must be on a single line
18 | ERROR | [x] Selectors must be on a single line
19 | ERROR | [x] Selectors must be on a single line
20 | ERROR | [ ] Style definitions must end with a semicolon
38 | ERROR | [x] Selectors must be on a single line
39 | ERROR | [ ] Style definitions must end with a semicolon
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 9 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...-issues/drupal/drupal/web/modules/contrib/mercury_layouts/css/settings.css
--------------------------------------------------------------------------------
FOUND 29 ERRORS AFFECTING 29 LINES
--------------------------------------------------------------------------------
3 | ERROR | Style definitions must end with a semicolon
4 | ERROR | Style definitions must end with a semicolon
5 | ERROR | Style definitions must end with a semicolon
6 | ERROR | Style definitions must end with a semicolon
7 | ERROR | Style definitions must end with a semicolon
8 | ERROR | Style definitions must end with a semicolon
9 | ERROR | Style definitions must end with a semicolon
10 | ERROR | Style definitions must end with a semicolon
11 | ERROR | Style definitions must end with a semicolon
12 | ERROR | Style definitions must end with a semicolon
13 | ERROR | Style definitions must end with a semicolon
14 | ERROR | Style definitions must end with a semicolon
15 | ERROR | Style definitions must end with a semicolon
16 | ERROR | Style definitions must end with a semicolon
17 | ERROR | Style definitions must end with a semicolon
23 | ERROR | Style definitions must end with a semicolon
24 | ERROR | Style definitions must end with a semicolon
25 | ERROR | Style definitions must end with a semicolon
26 | ERROR | Style definitions must end with a semicolon
27 | ERROR | Style definitions must end with a semicolon
28 | ERROR | Style definitions must end with a semicolon
29 | ERROR | Style definitions must end with a semicolon
30 | ERROR | Style definitions must end with a semicolon
31 | ERROR | Style definitions must end with a semicolon
32 | ERROR | Style definitions must end with a semicolon
33 | ERROR | Style definitions must end with a semicolon
34 | ERROR | Style definitions must end with a semicolon
35 | ERROR | Style definitions must end with a semicolon
36 | ERROR | Style definitions must end with a semicolon
--------------------------------------------------------------------------------
FILE: ...upal/web/modules/contrib/mercury_layouts/css/dynamic-regions-editor-ui.css
--------------------------------------------------------------------------------
FOUND 19 ERRORS AFFECTING 17 LINES
--------------------------------------------------------------------------------
15 | ERROR | [x] Selectors must be on a single line
16 | ERROR | [ ] Style definitions must end with a semicolon
40 | ERROR | [x] Selectors must be on a single line
41 | ERROR | [x] Selectors must be on a single line
42 | ERROR | [x] Selectors must be on a single line
43 | ERROR | [x] Selectors must be on a single line
44 | ERROR | [x] Selectors must be on a single line
45 | ERROR | [x] Selectors must be on a single line
46 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
46 | ERROR | [ ] Style definitions must end with a semicolon
52 | ERROR | [x] Expected 1 space before opening brace of class definition; 2
| | found
57 | ERROR | [x] Selectors must be on a single line
58 | ERROR | [x] Selectors must be on a single line
59 | ERROR | [x] Selectors must be on a single line
60 | ERROR | [x] Selectors must be on a single line
61 | ERROR | [x] Selectors must be on a single line
62 | ERROR | [x] Selectors must be on a single line
63 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
63 | ERROR | [ ] Style definitions must end with a semicolon
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 16 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...contrib/mercury_layouts/mercury_layouts_incorrect_attach_library.patch.txt
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | Line exceeds 80 characters; contains 86 characters
--------------------------------------------------------------------------------
FILE: ...s/drupal/drupal/web/modules/contrib/mercury_layouts/mercury_layouts.module
--------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
--------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
6 | ERROR | [x] There must be one blank line after the last USE statement; 2
| | found;
12 | ERROR | [x] Expected 1 blank line before function; 2 found
54 | ERROR | [ ] Missing parameter type
57 | ERROR | [ ] Description for the @return value is missing
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...pal/drupal/web/modules/contrib/mercury_layouts/mercury_layouts.routing.yml
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
44 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...les/contrib/mercury_layouts/src/Plugin/Layout/DynamicRegionsLayoutBase.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
26 | ERROR | [x] Multi-line function declarations must have a trailing comma
| | after the last parameter
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...trib/mercury_layouts/src/Controller/EditDynamicRegionsLayoutController.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Core\Ajax\AjaxHelperTrait.
67 | ERROR | [x] Multi-line function declarations must have a trailing comma
| | after the last parameter
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Time: 452ms; Memory: 12MB
➜ contrib git:(main) ✗
🇵🇭Philippines clarkssquared
clarkssquared → created an issue.
🇵🇭Philippines clarkssquared
Hi
I also applied MR !9 and I confirmed that the WSOD error is now fixed, please look at the monosnap screenshot in Before and After MR for your reference.
🇵🇭Philippines clarkssquared
Hi
I applied the MR !104 and I can see some PHPCS issues
upgrade_status git:(4.x) curl https://git.drupalcode.org/project/upgrade_status/-/merge_requests/104.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 92837 0 92837 0 0 165k 0 --:--:-- --:--:-- --:--:-- 167k
patching file README.md
patching file 'css/upgrade_status.admin.theme.css'
patching file 'src/CSSDeprecationAnalyzer.php'
patching file 'src/ConfigSchemaDeprecationAnalyzer.php'
patching file 'src/Controller/ScanResultController.php'
patching file 'src/DeprecationAnalyzer.php'
patching file 'src/DeprecationMessage.php'
patching file 'src/Drush/Commands/UpgradeStatusCommands.php'
patching file 'src/ExtensionMetadataDeprecationAnalyzer.php'
patching file 'src/Form/UpgradeStatusForm.php'
patching file 'src/LibraryDeprecationAnalyzer.php'
patching file 'src/ProjectCollector.php'
patching file 'src/RouteDeprecationAnalyzer.php'
patching file 'src/ScanResultFormatter.php'
patching file 'src/ThemeFunctionDeprecationAnalyzer.php'
patching file 'src/TwigDeprecationAnalyzer.php'
patching file 'tests/modules/upgrade_status_test_11_compatible/node_modules/upgrade_status_test_11_compatible.inc'
patching file 'tests/modules/upgrade_status_test_contrib_error/src/Controller/UpgradeStatusTestContribErrorController.php'
patching file 'tests/modules/upgrade_status_test_contrib_error/upgrade_status_test_contrib_error.module'
patching file 'tests/modules/upgrade_status_test_error/config/views.view.remove_default_argument_skip_url.yml'
patching file 'tests/modules/upgrade_status_test_error/src/Controller/UpgradeStatusTestErrorController.php'
patching file 'tests/modules/upgrade_status_test_library/upgrade_status_test_library.module'
patching file 'tests/modules/upgrade_status_test_theme_functions/upgrade_status_test_theme_functions.module'
patching file 'tests/modules/upgrade_status_test_twig/src/TwigExtension/DeprecatedFilter.php'
patching file 'tests/src/Functional/UpgradeStatusAnalyzeTest.php'
patching file 'tests/src/Functional/UpgradeStatusCommandsTest.php'
patching file 'tests/src/Functional/UpgradeStatusUiTest.php'
patching file 'tests/src/Kernel/TwigDeprecationAnalyzerTest.php'
patching file 'tests/themes/upgrade_status_test_theme/upgrade_status_test_theme.theme'
patching file upgrade_status.api.php
patching file upgrade_status.module
➜ upgrade_status git:(4.x) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml upgrade_status
FILE: ...sts/modules/upgrade_status_test_library/upgrade_status_test_library.module
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
3 | ERROR | Missing short description in doc comment
--------------------------------------------------------------------------------
FILE: ...atus/tests/modules/upgrade_status_test_error/upgrade_status_test_error.css
--------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
1 | ERROR | Class definition is empty
5 | ERROR | Class definition is empty
9 | ERROR | Class definition is empty
--------------------------------------------------------------------------------
FILE: ...tests/modules/upgrade_status_test_error/upgrade_status_test_error.info.yml
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
5 | ERROR | "dependencies" should be an array in the info yaml file
--------------------------------------------------------------------------------
FILE: ...rade_status_test_error/src/Controller/UpgradeStatusTestErrorController.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
12 | ERROR | Doc comment is empty
--------------------------------------------------------------------------------
FILE: ...status/tests/modules/upgrade_status_test_error/src/DeprecatedBaseClass.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
10 | ERROR | Each @deprecated tag must have a @see tag immediately following
| | it
--------------------------------------------------------------------------------
FILE: ...atus_test_11_compatible/node_modules/upgrade_status_test_11_compatible.inc
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
3 | ERROR | Missing short description in doc comment
7 | ERROR | Doc comment is empty
--------------------------------------------------------------------------------
FILE: ...ade_status_test_theme_functions/upgrade_status_test_theme_functions.module
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
3 | ERROR | Missing short description in doc comment
31 | ERROR | All functions defined in a module file must be prefixed with the
| | module's name, found "upgrade_status_test_theme_function" but
| | expected
| | "upgrade_status_test_theme_functions_upgrade_status_test_theme_function"
--------------------------------------------------------------------------------
FILE: ...ts/modules/upgrade_status_test_twig/src/TwigExtension/DeprecatedFilter.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
8 | ERROR | Doc comment is empty
13 | ERROR | Doc comment is empty
--------------------------------------------------------------------------------
FILE: ...t_contrib_11_compatible/upgrade_status_test_contrib_11_compatible.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by
| | drupal.org packaging automatically
--------------------------------------------------------------------------------
FILE: ...grade_status_test_contrib_error/upgrade_status_test_contrib_error.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by
| | drupal.org packaging automatically
--------------------------------------------------------------------------------
FILE: ...upgrade_status_test_contrib_error/upgrade_status_test_contrib_error.module
--------------------------------------------------------------------------------
FOUND 11 ERRORS AFFECTING 11 LINES
--------------------------------------------------------------------------------
3 | ERROR | Missing short description in doc comment
10 | ERROR | Each @deprecated tag must have a @see tag immediately following
| | it
14 | ERROR | The trigger_error message
| | 'upgrade_status_test_contrib_error_function_9_to_10() is
| | deprecated in Drupal 9.1.0 and will be removed before Drupal
| | 10.0.0. Use the replacement instead. See LINK' does not match the
| | strict standard format: %thing% is deprecated in
| | %deprecation-version% and is removed from %removal-version%.
| | %extra-info%. See %cr-link%
20 | ERROR | Each @deprecated tag must have a @see tag immediately following
| | it
24 | ERROR | The trigger_error message
| | 'upgrade_status_test_contrib_error_function_9_to_11() is
| | deprecated in Drupal 9.1.0 and will be removed before Drupal
| | 11.0.0. Use the replacement instead. See LINK' does not match the
| | strict standard format: %thing% is deprecated in
| | %deprecation-version% and is removed from %removal-version%.
| | %extra-info%. See %cr-link%
30 | ERROR | Each @deprecated tag must have a @see tag immediately following
| | it
34 | ERROR | The trigger_error message
| | 'upgrade_status_test_contrib_error_function_10_to_11() is
| | deprecated in Drupal 10.3.0 and will be removed before Drupal
| | 11.0.0. Use the replacement instead. See LINK' does not match the
| | strict standard format: %thing% is deprecated in
| | %deprecation-version% and is removed from %removal-version%.
| | %extra-info%. See %cr-link%
40 | ERROR | Each @deprecated tag must have a @see tag immediately following
| | it
44 | ERROR | The trigger_error message
| | 'upgrade_status_test_contrib_error_function_10_to_12() is
| | deprecated in Drupal 10.0.0 and will be removed before Drupal
| | 12.0.0. Use the replacement instead. See LINK' does not match the
| | strict standard format: %thing% is deprecated in
| | %deprecation-version% and is removed from %removal-version%.
| | %extra-info%. See %cr-link%
50 | ERROR | Each @deprecated tag must have a @see tag immediately following
| | it
54 | ERROR | The trigger_error message
| | 'upgrade_status_test_contrib_error_function_11_to_13() is
| | deprecated in Drupal 11.1.0 and will be removed before Drupal
| | 13.0.0. Use the replacement instead. See LINK' does not match the
| | strict standard format: %thing% is deprecated in
| | %deprecation-version% and is removed from %removal-version%.
| | %extra-info%. See %cr-link%
--------------------------------------------------------------------------------
FILE: ...t_contrib_error/src/Controller/UpgradeStatusTestContribErrorController.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
12 | ERROR | Doc comment is empty
--------------------------------------------------------------------------------
FILE: ...tus/tests/themes/upgrade_status_test_theme/upgrade_status_test_theme.theme
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
3 | ERROR | Missing short description in doc comment
--------------------------------------------------------------------------------
FILE: ...s/contrib/upgrade_status/tests/src/Functional/UpgradeStatusAnalyzeTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
12 | ERROR | Doc comment is empty
--------------------------------------------------------------------------------
FILE: ...les/contrib/upgrade_status/tests/src/Kernel/CSSDeprecationAnalyzerTest.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
18 | ERROR | Missing @var tag in member variable comment
46 | ERROR | Public method name
| | "CSSDeprecationAnalyzerTest::testGetAllCSSFiles" is not in
| | lowerCamel format
--------------------------------------------------------------------------------
FILE: ...es/contrib/upgrade_status/tests/src/Kernel/TwigDeprecationAnalyzerTest.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
15 | ERROR | Missing member variable doc comment
20 | ERROR | Doc comment is empty
--------------------------------------------------------------------------------
FILE: ...l/drupal/web/modules/contrib/upgrade_status/src/Form/UpgradeStatusForm.php
--------------------------------------------------------------------------------
FOUND 11 ERRORS AND 14 WARNINGS AFFECTING 23 LINES
--------------------------------------------------------------------------------
28 | ERROR | Doc comment is empty
144 | ERROR | Parameter $database is not described in comment
167 | ERROR | Doc comment for parameter $connection does not match actual
| | variable name $kernel
239 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
336 | WARNING | Translatable strings must not begin or end with white spaces,
| | use placeholders with t() for variables
336 | ERROR | Concatenating translatable strings is not allowed, use
| | placeholders instead and only one string literal
339 | WARNING | Translatable strings must not begin or end with white spaces,
| | use placeholders with t() for variables
339 | ERROR | Concatenating translatable strings is not allowed, use
| | placeholders instead and only one string literal
561 | ERROR | Public method name
| | "UpgradeStatusForm::upgrade_status_preprocess_table_custom_header"
| | is not in lowerCamel format
899 | WARNING | Role::loadMultiple calls should be avoided in classes, use
| | dependency injection instead
900 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
940 | ERROR | join() is a function name alias, use implode() instead
1015 | WARNING | Avoid backslash escaping in translatable strings when
| | possible, use "" quotes instead
1105 | WARNING | Unused variable $addendum.
1124 | WARNING | Line exceeds 80 characters; contains 94 characters
1147 | WARNING | Line exceeds 80 characters; contains 93 characters
1160 | WARNING | Unused variable $addendum.
1166 | WARNING | Unused variable $addendum.
1229 | ERROR | join() is a function name alias, use implode() instead
1422 | ERROR | Public method name "UpgradeStatusForm::exportReportASCII" is
| | not in lowerCamel format
1482 | ERROR | Missing parameter type
1484 | ERROR | Missing parameter type
1586 | WARNING | Unused variable $config.
1587 | WARNING | Unused variable $databases.
1588 | WARNING | Unused variable $class_loader.
--------------------------------------------------------------------------------
FILE: .../drupal/drupal/web/modules/contrib/upgrade_status/src/ProjectCollector.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------------
521 | WARNING | Avoid backslash escaping in translatable strings when
| | possible, use "" quotes instead
564 | ERROR | Public method name "ProjectCollector::isCompatibleWithPHP" is
| | not in lowerCamel format
--------------------------------------------------------------------------------
FILE: ...upal/drupal/web/modules/contrib/upgrade_status/src/ScanResultFormatter.php
--------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------------
12 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is dekor\ArrayToTextTable.
205 | ERROR | [ ] join() is a function name alias, use implode() instead
329 | ERROR | [ ] join() is a function name alias, use implode() instead
484 | ERROR | [ ] join() is a function name alias, use implode() instead
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...eb/modules/contrib/upgrade_status/src/ThemeFunctionDeprecationAnalyzer.php
--------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
--------------------------------------------------------------------------------
37 | ERROR | Parameter $container is not described in comment
40 | ERROR | Doc comment for parameter $this->container does not match actual
| | variable name $container
53 | ERROR | Description for the @return value is missing
96 | ERROR | Missing parameter type
101 | ERROR | Description for the @return value is missing
--------------------------------------------------------------------------------
FILE: ...web/modules/contrib/upgrade_status/src/Controller/ScanResultController.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------------
13 | ERROR | Doc comment is empty
141 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
--------------------------------------------------------------------------------
FILE: ...rupal/drupal/web/modules/contrib/upgrade_status/src/DeprecationMessage.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
41 | ERROR | Parameter $analyzer is not described in comment
--------------------------------------------------------------------------------
FILE: ...upal/web/modules/contrib/upgrade_status/src/LibraryDeprecationAnalyzer.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
--------------------------------------------------------------------------------
120 | ERROR | Unnecessarily gendered language in a comment
353 | WARNING | The use of function fnmatch() is discouraged
439 | ERROR | Unnecessarily gendered language in a comment
--------------------------------------------------------------------------------
FILE: ...l/drupal/web/modules/contrib/upgrade_status/src/CSSDeprecationAnalyzer.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
50 | ERROR | Private method name "CSSDeprecationAnalyzer::getAllCSSFiles" is
| | not in lowerCamel format
--------------------------------------------------------------------------------
FILE: ...upal/drupal/web/modules/contrib/upgrade_status/src/DeprecationAnalyzer.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
--------------------------------------------------------------------------------
15 | ERROR | Doc comment is empty
130 | ERROR | Class property $CSSDeprecationAnalyzer should use lowerCamel
| | naming without underscores
661 | WARNING | Line exceeds 80 characters; contains 83 characters
--------------------------------------------------------------------------------
FILE: ...odules/contrib/upgrade_status/src/ExtensionMetadataDeprecationAnalyzer.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
62 | WARNING | '@todo' should match the format '@todo Fix problem X here.'
--------------------------------------------------------------------------------
FILE: ...odules/contrib/upgrade_status/src/Drush/Commands/UpgradeStatusCommands.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES
--------------------------------------------------------------------------------
13 | WARNING | [x] Unused use statement
280 | WARNING | [ ] Line exceeds 80 characters; contains 88 characters
284 | ERROR | [ ] The array declaration extends to column 247 (the limit is
| | 120). The array content should be split up over multiple
| | lines
363 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency
| | injection instead
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: .../drupal/web/modules/contrib/upgrade_status/src/TwigDeprecationAnalyzer.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
11 | ERROR | Doc comment is empty
39 | ERROR | Description for the @return value is missing
--------------------------------------------------------------------------------
Time: 1.68 secs; Memory: 20MB
➜ contrib git:(main) ✗
🇵🇭Philippines clarkssquared
Hi chr.
I applied MR !19 and I confirmed that the Deprecation error is now fixed and not displaying on /user/#/edit page
Please look at this screenshot Before and After MR I sent a monosnap link instead of uploading the screenshot file here.
🇵🇭Philippines clarkssquared
clarkssquared → created an issue.
🇵🇭Philippines clarkssquared
🇵🇭Philippines clarkssquared
clarkssquared → created an issue.
🇵🇭Philippines clarkssquared
🇵🇭Philippines clarkssquared
🇵🇭Philippines clarkssquared
clarkssquared → created an issue.
🇵🇭Philippines clarkssquared
Hi @alyaj2a,
I applied your MR !5 and I confirmed that it fixes all the PHPCS issues of the module.
➜ auto_block_translate git:(1.0.x) curl https://git.drupalcode.org/project/auto_block_translate/-/merge_requests/5.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 2150 0 2150 0 0 4332 0 --:--:-- --:--:-- --:--:-- 4405
patching file auto_block_translate.module
patching file 'src/Form/TranslationForm.php'
patching file 'src/Plugin/Derivative/AutoBlockTranslateLocalTasks.php'
➜ auto_block_translate git:(1.0.x) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml auto_block_translate
➜ contrib git:(main) ✗
RTBC +1 from me, retaining the status to needs review for others to give their feedbacks.
🇵🇭Philippines clarkssquared
Hi @alyaj2a,
I applied your MR !10 and there's 1 remaining PHPCS issue that is fixable with PHPCBF, please check
➜ l10n_tools git:(1.0.x) curl https://git.drupalcode.org/project/l10n_tools/-/merge_requests/10.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 3668 0 3668 0 0 7355 0 --:--:-- --:--:-- --:--:-- 7501
patching file README.md
patching file 'src/Commands/L10nToolsCommands.php'
patching file 'src/Form/L10nToolsForm.php'
➜ l10n_tools git:(1.0.x) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml l10n_tools
FILE: ...l/drupal/web/modules/contrib/l10n_tools/src/Commands/L10nToolsCommands.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
36 | ERROR | [x] Multi-line function declarations must have a trailing comma
| | after the last parameter
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Time: 352ms; Memory: 12MB
➜ contrib git:(main) ✗ 🇵🇭Philippines clarkssquared
I also applied MR !3 and I confirmed that the module has no PHPCS issues
➜ birthday_wish_mail git:(2.0.x) curl https://git.drupalcode.org/project/birthday_wish_mail/-/merge_requests/3.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 1128 0 1128 0 0 2209 0 --:--:-- --:--:-- --:--:-- 2233
patching file birthday_wish_mail.module
patching file 'src/Form/BirthdayWishMailSettingsForm.php'
➜ birthday_wish_mail git:(2.0.x) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml birthday_wish_mail
➜ contrib git:(main) ✗
RTBC +1 from me
🐛 | Office Hours | Warning: 'Undefined array key' on page 'Manage form display' when changing field settings.
🇵🇭Philippines clarkssquared
Hi
Im using Drupal Core version 10.1.8 but I can't seem to replicate the error.
🇵🇭Philippines clarkssquared
Hi
I got an WSOD error after applying MR !1 hence I updated line 21 of .module file to fix it this is the error https://monosnap.com/file/1mSqbZkGJYxOjv0dJM0dLr311xV4yG , and this is after I update line 21 https://monosnap.com/file/FoQ6IJvYtft3VCTgItbTeXJjX3fyED
🇵🇭Philippines clarkssquared
clarkssquared → made their first commit to this issue’s fork.
🇵🇭Philippines clarkssquared
Hi shubham,
I applied your MR but it fails to apply
➜ composer_deploy git:(8.x-1.10) ✗ curl https://git.drupalcode.org/project/composer_deploy/-/merge_requests/4.diff | git apply -v
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 895 0 895 0 0 1716 0 --:--:-- --:--:-- --:--:-- 1761
Checking patch composer_deploy.module...
error: while searching for:
use Drupal\Core\Extension\Extension;
use Drupal\Core\Url;
use DrupalFinder\DrupalFinder;
/**
* @param array $info
error: patch failed: composer_deploy.module:4
error: composer_deploy.module: patch does not apply🇵🇭Philippines clarkssquared
Hi shubham,
I applied your MR !3 and I confirmed that it implemented the hook_help function, here's the screenshot of help page that your MR created https://monosnap.com/file/qCzhW5cPvbayWF4RL0kxRPehlwiEJ9 I sent a link of monosnap for the screenshot to avoid uploading screenshot/images in the issue queue
🇵🇭Philippines clarkssquared
Hi shubham,
I checked your MR !7 and I confirmed that it implemented a hook_help function, the Help page is very straight forward. I sent a monosnap link of the screenshot I created regarding the help page instead of uploading the screenshot https://monosnap.com/file/djtaSX4ma2FCv83rFokA9bq7iHN3yY
🇵🇭Philippines clarkssquared
Hi frederikvho,
I have the same version of PHPCS with you and I checked the updated MR !6 and I can confirmed that there's no PHPCS issues in the module
➜ amazon_sns git:(65644ed) curl https://git.drupalcode.org/project/amazon_sns/-/merge_requests/6.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 2048 0 2048 0 0 4317 0 --:--:-- --:--:-- --:--:-- 4394
patching file 'src/Event/MessageEventDispatcher.php'
patching file 'src/Event/SnsMessageEvent.php'
patching file 'src/Form/SnsSettingsForm.php'
patching file 'tests/fixtures/plain-text-message-server.php'
➜ amazon_sns git:(65644ed) ✗ ..
➜ contrib git:(2.1.x) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml amazon_sns
➜ contrib git:(2.1.x) ✗ RTBC +1 from me, will retain the status to needs review for others.
🇵🇭Philippines clarkssquared
Hi frederikvho,
I applied MR !6 but I can still see some PHPCS issues
➜ amazon_sns git:(65644ed) curl https://git.drupalcode.org/project/amazon_sns/-/merge_requests/6.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 6301 0 6301 0 0 12655 0 --:--:-- --:--:-- --:--:-- 12806
patching file 'src/Controller/NotificationController.php'
patching file 'src/Event/MessageEventDispatcher.php'
patching file 'src/Event/SnsMessageEvent.php'
patching file 'src/Form/SnsSettingsForm.php'
patching file 'tests/fixtures/plain-text-message-server.php'
patching file 'tests/src/Kernel/SnsNotificationSubscriberTest.php'
patching file 'tests/src/Unit/NotificationControllerTest.php'
patching file 'tests/src/Unit/RequestMessageValidatorTest.php'
patching file 'tests/src/Unit/SnsMessageEventTest.php'
patching file 'tests/src/Unit/SnsSubscriptionConfirmationSubscriberTest.php'
➜ amazon_sns git:(65644ed) ✗ ..
➜ contrib git:(2.1.x) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml amazon_sns
FILE: ...ib/amazon_sns/tests/src/Unit/SnsSubscriptionConfirmationSubscriberTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\amazon_sns\Event\SnsMessageEvent.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...trib/web/modules/contrib/amazon_sns/tests/src/Unit/SnsMessageEventTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\amazon_sns\Event\SnsMessageEvent.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: .../modules/contrib/amazon_sns/tests/src/Unit/RequestMessageValidatorTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\amazon_sns\RequestMessageValidator.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...b/modules/contrib/amazon_sns/tests/src/Unit/NotificationControllerTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is
| | Drupal\amazon_sns\Controller\NotificationController.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...ules/contrib/amazon_sns/tests/src/Kernel/SnsNotificationSubscriberTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
8 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is
| | Drupal\amazon_sns\Controller\NotificationController.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...b/web/modules/contrib/amazon_sns/src/Controller/NotificationController.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
10 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\amazon_sns\Event\MessageEventDispatcher.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Time: 345ms; Memory: 10MB
➜ contrib git:(2.1.x) ✗
🇵🇭Philippines clarkssquared
Hi
I applied the updated MR !6 and I confirmed that all PHPCS issues were fixed.
➜ certificatelogin git:(2.x) curl https://git.drupalcode.org/project/certificatelogin/-/merge_requests/6.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 49212 0 49212 0 0 76934 0 --:--:-- --:--:-- --:--:-- 77499
patching file README.md
patching file certificatelogin.install
patching file certificatelogin.module
patching file certificatelogin.routing.yml
patching file 'css/certificatelogin.css'
patching file 'src/Annotation/CaSignatureVerificationPlugin.php'
patching file 'src/Controller/CertificateLoginController.php'
patching file 'src/Form/CertificateLoginSettingsForm.php'
patching file 'src/Form/ConfirmForm.php'
patching file 'src/Form/LoginForm.php'
patching file 'src/Plugin/Block/CertificateLoginBlock.php'
patching file 'src/Plugin/CaSignatureVerificationPlugin/PHPSecLib.php'
patching file 'src/Plugin/CaSignatureVerificationPluginBase.php'
patching file 'src/Plugin/CaSignatureVerificationPluginInterface.php'
patching file 'src/Plugin/CaSignatureVerificationPluginManager.php'
patching file 'src/Plugin/Menu/LoginLogoutMenuLink.php'
patching file 'src/Service/LoginRegisterService.php'
➜ certificatelogin git:(2.x) ✗ ..
➜ contrib git:(2.1.x) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml certificatelogin
➜ contrib git:(2.1.x) ✗
🇵🇭Philippines clarkssquared
Hi @ divyansh.gupta
Got it, I will move the status to needs review so that other users can check also, RTBC +1 from me.
Thanks
🇵🇭Philippines clarkssquared
Closing this ticket since there's no work to be done here and this was used for onboarding purposes.
🇵🇭Philippines clarkssquared
clarkssquared → created an issue.
🇵🇭Philippines clarkssquared
Hi
I applied MR !4 and checked the PHPCS and there is only one PHPCS warning left in the module
➜ total_control git:(3.0.x) curl https://git.drupalcode.org/project/total_control/-/merge_requests/4.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 11520 0 11520 0 0 21209 0 --:--:-- --:--:-- --:--:-- 21532
patching file 'src/Plugin/Block/AdministerContentTypes.php'
patching file 'src/Plugin/Block/AdministerMenus.php'
patching file 'src/Plugin/Block/AdministerPanelPages.php'
patching file 'src/Plugin/Block/AdministerTaxonomy.php'
patching file 'src/Plugin/Block/ContentOverview.php'
patching file 'src/Plugin/Block/CreateContent.php'
patching file 'src/Plugin/Derivative/TotalControlMenuLink.php'
patching file 'src/Routing/RouteSubscriber.php'
patching file 'tests/src/FunctionalJavascript/TotalControlDashboardPageCheckTest.php'
➜ total_control git:(3.0.x) ✗ ..
➜ contrib git:(2.1.x) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml total_control
FILE: ...ksubing-subing/Projects/drupal-issues/drupal-contrib/web/modules/contrib/total_control/css/theme/total-control.theme.css
------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
------------------------------------------------------------------------------------------------------------------------------
Time: 734ms; Memory: 10MB
➜ contrib git:(2.1.x) ✗
🇵🇭Philippines clarkssquared
Hi
I applied MR !6 and I can still see many PHPCS issues
➜ certificatelogin git:(2.x) curl https://git.drupalcode.org/project/certificatelogin/-/merge_requests/6.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 38848 0 38848 0 0 61051 0 --:--:-- --:--:-- --:--:-- 61859
patching file certificatelogin.install
patching file certificatelogin.module
patching file 'src/Annotation/CaSignatureVerificationPlugin.php'
patching file 'src/Controller/CertificateLoginController.php'
patching file 'src/Form/CertificateLoginSettingsForm.php'
patching file 'src/Form/ConfirmForm.php'
patching file 'src/Form/LoginForm.php'
patching file 'src/Plugin/Block/CertificateLoginBlock.php'
patching file 'src/Plugin/CaSignatureVerificationPlugin/PHPSecLib.php'
patching file 'src/Plugin/CaSignatureVerificationPluginBase.php'
patching file 'src/Plugin/CaSignatureVerificationPluginInterface.php'
patching file 'src/Plugin/CaSignatureVerificationPluginManager.php'
patching file 'src/Plugin/Menu/LoginLogoutMenuLink.php'
patching file 'src/Service/LoginRegisterService.php'
➜ certificatelogin git:(2.x) ✗ ..
➜ contrib git:(2.1.x) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml certificatelogin
FILE: ...s/clarksubing-subing/Projects/drupal-issues/drupal-contrib/web/modules/contrib/certificatelogin/css/certificatelogin.css
------------------------------------------------------------------------------------------------------------------------------
FOUND 54 ERRORS AFFECTING 18 LINES
------------------------------------------------------------------------------------------------------------------------------
7 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
7 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
7 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
8 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
8 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
8 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
9 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
9 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
9 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
10 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
10 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
10 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
11 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
11 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
11 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
12 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
12 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
12 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
13 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
13 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
13 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
14 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
14 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
15 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
15 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
15 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
16 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
16 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
16 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
17 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
17 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
18 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
18 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
18 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
19 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
19 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
19 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
20 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
20 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
20 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
24 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
24 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
25 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
25 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
25 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
29 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
29 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
29 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
30 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
30 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
30 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 54 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/clarksubing-subing/Projects/drupal-issues/drupal-contrib/web/modules/contrib/certificatelogin/README.md
--------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
--------------------------------------------------------------------------------------------------------------------
14 | WARNING | Line exceeds 80 characters; contains 103 characters
15 | WARNING | Line exceeds 80 characters; contains 131 characters
23 | WARNING | Line exceeds 80 characters; contains 92 characters
34 | WARNING | Line exceeds 80 characters; contains 104 characters
46 | WARNING | Line exceeds 80 characters; contains 96 characters
47 | WARNING | Line exceeds 80 characters; contains 107 characters
--------------------------------------------------------------------------------------------------------------------
FILE: ...s/clarksubing-subing/Projects/drupal-issues/drupal-contrib/web/modules/contrib/certificatelogin/certificatelogin.install
------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------
9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is
| | Drupal\certificatelogin\Controller\CertificateLoginController.
------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------
FILE: ...arksubing-subing/Projects/drupal-issues/drupal-contrib/web/modules/contrib/certificatelogin/certificatelogin.routing.yml
------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------
37 | WARNING | The administration page callback should probably use "administer site configuration" - which implies the user
| | can change something - rather than "access administration pages" which is about viewing but not changing
| | configurations.
------------------------------------------------------------------------------------------------------------------------------
FILE: ...ers/clarksubing-subing/Projects/drupal-issues/drupal-contrib/web/modules/contrib/certificatelogin/src/Form/LoginForm.php
------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is
| | Drupal\certificatelogin\Service\LoginRegisterService.
------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------
FILE: ...ing/Projects/drupal-issues/drupal-contrib/web/modules/contrib/certificatelogin/src/Form/CertificateLoginSettingsForm.php
------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is
| | Drupal\certificatelogin\Plugin\CaSignatureVerificationPluginManager.
------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------
FILE: ...Projects/drupal-issues/drupal-contrib/web/modules/contrib/certificatelogin/src/Controller/CertificateLoginController.php
------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is
| | Drupal\certificatelogin\Service\LoginRegisterService.
------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------
FILE: ...g-subing/Projects/drupal-issues/drupal-contrib/web/modules/contrib/certificatelogin/src/Service/LoginRegisterService.php
------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is
| | Drupal\certificatelogin\Plugin\CaSignatureVerificationPluginManager.
------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------
Time: 388ms; Memory: 12MB
➜ contrib git:(2.1.x) ✗
🇵🇭Philippines clarkssquared
Hi @atulghate
I checked the README.md file but it seems its not organized according to Drupal README.md template →
🇵🇭Philippines clarkssquared
Hi olegry,
I want to ask for some advice how do you install the theme? because when I install the theme in my drupal site a WSOD error will occur in my end. The issue will be fixed in a separate d.o ticket though especially openy theme installation error 🐛 unable to install theme Active
🇵🇭Philippines clarkssquared
Hi
I also encountered this issue when installing the theme I got a WSOD
The website encountered an unexpected error. Please try again later.
Drupal\Core\Config\UnmetDependenciesException: Configuration objects provided by <em class="placeholder">openy_carnation</em> have unmet dependencies: <em class="placeholder">block.block.openy_carnation_footermenuright (system.menu.footer-menu-right, openy_menu_footer)</em> in Drupal\Core\Config\UnmetDependenciesException::create() (line 100 of core/lib/Drupal/Core/Config/UnmetDependenciesException.php).
Drupal\Core\Config\ConfigInstaller->checkConfigurationToInstall('theme', 'openy_carnation') (Line: 132)
Drupal\Core\ProxyClass\Config\ConfigInstaller->checkConfigurationToInstall('theme', 'openy_carnation') (Line: 218)
Drupal\Core\Extension\ThemeInstaller->install(Array) (Line: 225)
Drupal\system\Controller\ThemeController->setDefaultTheme(Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 592)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 181)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object, 1, 1) (Line: 704)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)I encountered this in V3.0.x-dev
🇵🇭Philippines clarkssquared
Hi
I applied the MR !15 and I confirmed that it fixes all the PHPCS issues
➜ floating_block git:(2.0.x) curl https://git.drupalcode.org/project/floating_block/-/merge_requests/15.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 1113 0 1113 0 0 2227 0 --:--:-- --:--:-- --:--:-- 2248
patching file 'tests/modules/floating_block_test/css/floating_block_test.css'
patching file 'tests/src/Unit/HelperTest.php'
➜ floating_block git:(2.0.x) ✗ ..
➜ contrib git:(2.1.x) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml floating_block
➜ contrib git:(2.1.x) ✗
RTBC +1 from me
🇵🇭Philippines clarkssquared
I added a minor comments on the README.md please check
🇵🇭Philippines clarkssquared
🇵🇭Philippines clarkssquared
clarkssquared → changed the visibility of the branch 3479520-buttons-and-links to hidden.
🇵🇭Philippines clarkssquared
🇵🇭Philippines clarkssquared
clarkssquared → created an issue.
🇵🇭Philippines clarkssquared
Hi
I checked the MR !4 and I have some minor comments regarding Drupal README.md template →
🇵🇭Philippines clarkssquared
Hi
I applied the updated MR !18, and it replaced the README.txt file with README.md with the content below
# Date
The Date module suite provides an API for handling date values, a field for
Drupal 7's Field API system, and a wealth of submodules for various purposes.
For a full description of the module, visit the
[project page](https://www.drupal.org/project/date).
Submit bug reports and feature suggestions, or track changes in the
[issue queue](https://www.drupal.org/project/issues/date).
## Table of contents
- Requirements
- Installation
- Configuration
- Related Modules
- Maintainers
## Requirements
This module requires no modules outside of Drupal core.
## Installation
Install as you would normally install a contributed Drupal module. For further
information, see
[Installing Drupal Modules](https://www.drupal.org/docs/extending-drupal/installing-drupal-modules).
## Configuration
The module has no menu or modifiable settings. There is no configuration.
## Related modules
This is the beginning of a list of modules that extend Date to solve particular problems.
Please check them out if the core Date functionality isn't sufficient for your needs.
- [Calendar](http://drupal.org/project/calendar)
- [Date iCal](http://drupal.org/project/date_ical)
- [Partial Date](http://drupal.org/project/partial_date)
- [Signup](http://drupal.org/project/signup)
- [CCK Signup](http://drupal.org/project/cck_signup)
- [Registration](http://drupal.org/project/registration)
## Maintainers
- Andrii Podanenko - [podarok](https://www.drupal.org/u/podarok)
- Alex Schedrov - [sanchiz](https://www.drupal.org/u/sanchiz)
- Damien McKenna - [Damien McKenna](https://www.drupal.org/u/damienmckenna)
- Vijaya Chandran Mani - [vijaycs85](https://www.drupal.org/u/vijaycs85)
- Karen Stevenson - [KarenS](https://www.drupal.org/u/karens)
- Arlin Sandbulte - [arlinsandbulte](https://www.drupal.org/u/arlinsandbulte)
- Derek Wright - [dww](https://www.drupal.org/u/dww)
- Gisle Hannemyr - [gisle](https://www.drupal.org/u/gisle)
- Angie Byron - [webchick](https://www.drupal.org/u/webchick)
- David Goode - [David Goode](https://www.drupal.org/user/291318)
- developer-x - [developer-x](https://www.drupal.org/user/399625)
- Peter Lieverdink - [cafuego](https://www.drupal.org/u/cafuego)RTBC +1 from me
🇵🇭Philippines clarkssquared
Hi
I applied patch #2 but it fails to apply, please look at below
➜ administration_language_negotiation git:(2.x) curl https://www.drupal.org/files/issues/2024-09-18/3475316.patch | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 603 100 603 0 0 1207 0 --:--:-- --:--:-- --:--:-- 1228
patching file administration_language_negotiation.info.yml
1 out of 1 hunks failed--saving rejects to administration_language_negotiation.info.yml.rejSo I created a MR based on patch #2.
🇵🇭Philippines clarkssquared
clarkssquared → made their first commit to this issue’s fork.
🇵🇭Philippines clarkssquared
clarkssquared → created an issue.
🇵🇭Philippines clarkssquared
clarkssquared → changed the visibility of the branch 3477673- to hidden.
🇵🇭Philippines clarkssquared
Will create a new branch since I have a hard time fixing the merge conflict in my MR !219 hence I will also close that merge request.
🇵🇭Philippines clarkssquared
clarkssquared → created an issue.
🇵🇭Philippines clarkssquared
Hi
I applied MR !2 but it didn't properly applied in the module and has 2 out of 2 hunks failed--saving rejects to field_display_toggle.module.rej
➜ field_display_toggle git:(2.1.x) ✗ curl https://git.drupalcode.org/project/field_display_toggle/-/merge_requests/2.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 3087 0 3087 0 0 6348 0 --:--:-- --:--:-- --:--:-- 6417
patching file README.md
patching file field_display_toggle.module
2 out of 2 hunks failed--saving rejects to field_display_toggle.module.rej
➜ field_display_toggle git:(2.1.x) ✗ ..
➜ contrib git:(2.1.x) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml field_display_toggle
FILE: ...rib/web/modules/contrib/field_display_toggle/field_display_toggle.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by
| | drupal.org packaging automatically
--------------------------------------------------------------------------------
FILE: ...ntrib/web/modules/contrib/field_display_toggle/field_display_toggle.module
--------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
--------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
4 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Core\Form\FormStateInterface.
17 | WARNING | [ ] Format should be "* Implements hook_foo().", "* Implements
| | hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", "*
| | Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or
| | "* Implements hook_foo_BAR_ID_bar() for block templates."
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Time: 89ms; Memory: 10MB
➜ contrib git:(2.1.x) ✗
🇵🇭Philippines clarkssquared
Hi
I applied and checked MR !36 and I confirm that it fixes all the PHPCS issues
➜ prevnext git:(2.0.x) curl https://git.drupalcode.org/project/prevnext/-/merge_requests/36.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 4304 0 4304 0 0 7123 0 --:--:-- --:--:-- --:--:-- 7185
patching file prevnext.module
patching file 'src/Form/PrevNextSettingsForm.php'
patching file 'src/Plugin/Block/PrevNextBlock.php'
patching file 'src/Plugin/views/field/PrevNextLinks.php'
patching file 'src/PrevNextService.php'
➜ prevnext git:(2.0.x) ✗ ..
➜ contrib git:(2.1.x) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml prevnext
➜ contrib git:(2.1.x) ✗
🇵🇭Philippines clarkssquared
I applied MR !6 after commit cae62d5d and I confirmed that all PHPCS issues were fixed.
➜ fontawesome_menu_icons git:(3.x) curl https://git.drupalcode.org/project/fontawesome_menu_icons/-/merge_requests/6.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 6772 0 6772 0 0 13477 0 --:--:-- --:--:-- --:--:-- 13653
patching file fontawesome_menu_icons.install
patching file fontawesome_menu_icons.module
➜ fontawesome_menu_icons git:(3.x) ✗ ..
➜ contrib git:(2.1.x) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml fontawesome_menu_icons
➜ contrib git:(2.1.x) ✗ 🇵🇭Philippines clarkssquared
Hi @seth.e.shaw
What is your current Drupal version if I may ask? because I investigated the issue in my local Drupal core v10.3.5, I installed bootstrap_barrio v5.5.17 and I can see the right version in info.yml file
# Information added by Drupal.org packaging script on 2024-09-09
version: '5.5.17'
project: 'bootstrap_barrio'
datestamp: 1725856217🇵🇭Philippines clarkssquared
Hi amit,
I applied your MR !6 but there's still 1 PHPCS issues that remains
➜ fontawesome_menu_icons git:(3.x) curl https://git.drupalcode.org/project/fontawesome_menu_icons/-/merge_requests/6.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 6611 0 6611 0 0 2710 0 --:--:-- 0:00:02 --:--:-- 2717
patching file fontawesome_menu_icons.install
patching file fontawesome_menu_icons.module
➜ fontawesome_menu_icons git:(3.x) ✗ ..
➜ contrib git:(2.1.x) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml fontawesome_menu_icons
FILE: ...al-issues/drupal-contrib/web/modules/contrib/fontawesome_menu_icons/fontawesome_menu_icons.module
-------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------
9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is
| | Drupal\Core\Routing\RouteMatchInterface.
-------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------
Time: 187ms; Memory: 12MB
➜ contrib git:(2.1.x) ✗
Also try to avoid opening a new Merge Request, let's use the existing Merge Request in the issue.
Thanks
🇵🇭Philippines clarkssquared
Hi siddhraj,
I applied your patch #3 and I confirmed that it implements hook_help() with the module's overview, I will not upload a screenshot for issue's etiquette but this is the content of the help page:
Address suggestion
Add to Default shortcuts
The Address Suggestion module is a powerful tool for automatically suggesting addresses during form input. It is an alternative to the deprecated Address Autocomplete module, offering more robust features and better integration.
Features
- Automatic address suggestions with country-specific precision.
- Configurable per field widget.
- Supports both plain text fields and address fields.
- Supports CKEditor5 for address fields.
- House number auto-addition.
- Integration with Geo fields and Geolocation fields.
The module improves address input accuracy by retrieving more precise suggestions, based on the country site by default.
🇵🇭Philippines clarkssquared
clarkssquared → created an issue.
🇵🇭Philippines clarkssquared
clarkssquared → changed the visibility of the branch 3476332-update-testimonial-component to active.
🇵🇭Philippines clarkssquared
clarkssquared → changed the visibility of the branch 3476332-update-testimonial-component to hidden.
🇵🇭Philippines clarkssquared
clarkssquared → created an issue.
🇵🇭Philippines clarkssquared
clarkssquared → created an issue.
🇵🇭Philippines clarkssquared
clarkssquared → changed the visibility of the branch 3476085-update-cta-component to hidden.
🇵🇭Philippines clarkssquared
clarkssquared → changed the visibility of the branch 3476085-update-cta-component to hidden.
🇵🇭Philippines clarkssquared
Closing this ticket since this is a duplicate of Update Media and CTA component 📌 Update Media and CTA component Fixed
🇵🇭Philippines clarkssquared
clarkssquared → created an issue.