🇵🇭Philippines clarkssquared
clarkssquared → created an issue.
🇵🇭Philippines clarkssquared
Hi radheymkumar
I applied patch #2 and I confirmed that it fixes all the PHPCS issues
➜ metatag_search_gov git:(main) ✗ curl https://www.drupal.org/files/issues/2024-12-14/metatag_search_gov-3493966.patch | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 1789 100 1789 0 0 3975 0 --:--:-- --:--:-- --:--:-- 4047
patching file README.md
patching file metatag_search_gov.info.yml
patching file 'src/Plugin/SearchCustomBase.php'
➜ metatag_search_gov git:(main) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml metatag_search_gov
➜ contrib git:(main) ✗ RTBC +1 from me, retaining the status to needs review for others.
🇵🇭Philippines clarkssquared
Hi kinyein,
I added a small commit in your MR because I its previous version there's this PHPCS issues
➜ decoupled_interface_translations git:(1.0.x) curl https://git.drupalcode.org/project/decoupled_interface_translations/-/merge_requests/4.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 6667 0 6667 0 0 11764 0 --:--:-- --:--:-- --:--:-- 11926
patching file 'src/Controller/DecoupledInterfaceTranslationsController.php'
➜ decoupled_interface_translations git:(1.0.x) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml decoupled_interface_translations
FILE: ...e_translations/src/Controller/DecoupledInterfaceTranslationsController.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------------
8 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Core\Controller\ControllerBase.
114 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency
| | injection instead
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLYThen I added a commit to fix the use statements order, the remaining PHPCS issue is \Drupal calls should be avoided in classes, use dependency injection instead and I will leave the decision to the maintainers if this issue should be fixed or not.
Retaining the status to needs review.
🇵🇭Philippines clarkssquared
clarkssquared → made their first commit to this issue’s fork.
🇵🇭Philippines clarkssquared
Hi kinyein,
I applied your MR !5 and I can still see many PHPCS issues in the module
➜ jqcloud git:(3.0.x) curl https://git.drupalcode.org/project/jqcloud/-/merge_requests/5.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 3889 0 3889 0 0 776 0 --:--:-- 0:00:05 --:--:-- 1026
patching file 'src/Plugin/Block/JqcloudBlock.php'
patching file 'src/TermService.php'
patching file 'src/TermServiceInterface.php'
patching file 'tests/src/FunctionalJavascript/JqcloudJavascriptTest.php'
➜ jqcloud git:(3.0.x) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml jqcloud
FILE: ...rib/jqcloud/tests/modules/jqcloud_library_test/jqcloud_library_test.module
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
9 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Core\Routing\RouteMatchInterface.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...ib/jqcloud/tests/modules/jqcloud_library_test/jqcloud_library_test.install
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...s/contrib/jqcloud/tests/src/FunctionalJavascript/JqcloudJavascriptTest.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 19 WARNINGS AFFECTING 19 LINES
--------------------------------------------------------------------------------
211 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
256 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
269 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
283 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
296 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
315 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
330 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
352 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
366 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
376 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
393 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
410 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
434 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
458 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
472 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
489 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
505 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
540 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
542 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
--------------------------------------------------------------------------------
FILE: ...ts/drupal-issues/drupal-project/web/modules/contrib/jqcloud/jqcloud.module
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
9 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Core\Link.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...upal-project/web/modules/contrib/jqcloud/src/Plugin/Block/JqcloudBlock.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
11 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is
| | Drupal\Core\Plugin\ContainerFactoryPluginInterface.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...upal-issues/drupal-project/web/modules/contrib/jqcloud/src/TermService.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
9 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Core\Cache\DatabaseBackend.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Time: 375ms; Memory: 12MB
➜ contrib git:(main) ✗
🇵🇭Philippines clarkssquared
Hi kwiseman,
The MR is pretty straight forward as it removes the .DS_Store files as per the report, I applied it and I confirmed that there are no .DS_Store files anywhere in the theme's directory
➜ bootstrap_barrio git:(5.5.x) find . -name .DS_Store
./subtheme/config/.DS_Store
./css/.DS_Store
./config/.DS_Store
➜ bootstrap_barrio git:(5.5.x) curl https://git.drupalcode.org/project/bootstrap_barrio/-/merge_requests/88.diff | git apply -v
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 666 0 666 0 0 1070 0 --:--:-- --:--:-- --:--:-- 1081
Checking patch config/.DS_Store...
Checking patch css/.DS_Store...
Checking patch subtheme/config/.DS_Store...
Applied patch config/.DS_Store cleanly.
Applied patch css/.DS_Store cleanly.
Applied patch subtheme/config/.DS_Store cleanly.
➜ bootstrap_barrio git:(5.5.x) ✗ find . -name .DS_Store
➜ bootstrap_barrio git:(5.5.x) ✗
🇵🇭Philippines clarkssquared
Hi
I checked MR !1 and I confirmed that it updates the README.md file according to Drupal README.md template →
🇵🇭Philippines clarkssquared
Hi
I applied MR !2 and I confirmed that it fixes all the PHPCS issues
➜ rest_invalidate_cache git:(1.x) curl https://git.drupalcode.org/project/rest_invalidate_cache/-/merge_requests/2.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 1024 0 1024 0 0 2086 0 --:--:-- --:--:-- --:--:-- 2115
patching file 'src/Plugin/rest/resource/InvalidateCache.php'
➜ rest_invalidate_cache git:(1.x) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml rest_invalidate_cache
➜ contrib git:(main) ✗ RTBC +1
🇵🇭Philippines clarkssquared
Hi alyaj2a,
I applied your MR !3 and I can still see some PHPCS issues though these issues can be resolved via PHPCBF
➜ taxonomy_parents_index git:(1.0.x) curl https://git.drupalcode.org/project/taxonomy_parents_index/-/merge_requests/3.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 6570 0 6570 0 0 13248 0 --:--:-- --:--:-- --:--:-- 13463
patching file README.md
patching file 'src/Form/IndexTaxonomyParents.php'
patching file 'src/Plugin/views/relationship/TaxonomyIndexReverseToParents.php'
patching file taxonomy_parents_index.install
patching file taxonomy_parents_index.module
➜ taxonomy_parents_index git:(1.0.x) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml taxonomy_parents_index
FILE: ...modules/contrib/taxonomy_parents_index/src/TaxonomyParentsIndexManager.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
51 | ERROR | [x] Multi-line function declarations must have a trailing comma
| | after the last parameter
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...ents_index/src/Plugin/views/relationship/TaxonomyIndexReverseToParents.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is
| | Drupal\views\Plugin\views\relationship\RelationshipPluginBase.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Time: 278ms; Memory: 10MB
➜ contrib git:(main) ✗ 🇵🇭Philippines clarkssquared
clarkssquared → changed the visibility of the branch 34897930-remove-hardcoded-fonts to hidden.
🇵🇭Philippines clarkssquared
clarkssquared → created an issue.
🇵🇭Philippines clarkssquared
Hi dhruv
I applied the updated MR !2 and this is the remaining PHPCS issues that phpcs reported.
➜ layout_builder_paragraphs git:(1.0.x) curl https://git.drupalcode.org/project/layout_builder_paragraphs/-/merge_requests/2.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 26498 0 26498 0 0 45536 0 --:--:-- --:--:-- --:--:-- 46163
patching file layout_builder_paragraphs.api.php
patching file layout_builder_paragraphs.module
patching file 'src/Controller/ChooseParagraphController.php'
patching file 'src/Controller/ModalLayoutRebuildTrait.php'
patching file 'src/Controller/ModalMoveBlockController.php'
patching file 'src/Element/ModalLayoutBuilder.php'
patching file 'src/Form/AddParagraphForm.php'
patching file 'src/Form/ModalAddBlockForm.php'
patching file 'src/Form/ModalMoveBlockForm.php'
patching file 'src/Form/ModalRemoveBlockForm.php'
patching file 'src/Form/ModalRemoveSectionForm.php'
patching file 'src/Form/ModalUpdateBlockForm.php'
patching file 'src/Routing/RouteSubscriber.php'
➜ layout_builder_paragraphs git:(1.0.x) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml layout_builder_paragraphs
FILE: ...odules/contrib/layout_builder_paragraphs/layout_builder_paragraphs.api.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
20 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...modules/contrib/layout_builder_paragraphs/layout_builder_paragraphs.module
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------
18 | WARNING | All constants defined by a module must be prefixed with the
| | module's name, expected
| | "LAYOUT_BUILDER_PARAGRAPHS_PARAGRAPH_FIELD" but found
| | "PARAGRAPH_FIELD"
18 | WARNING | Global constants should not be used, move it to a class or
| | interface
--------------------------------------------------------------------------------
FILE: ...eb/modules/contrib/layout_builder_paragraphs/src/Form/AddParagraphForm.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
155 | WARNING | Unused variable $value.
--------------------------------------------------------------------------------
Time: 329ms; Memory: 10MB
➜ contrib git:(main) ✗
🇵🇭Philippines clarkssquared
Hi
I applied MR !11 and I can still see many PHPCS issues that phpcs reported
➜ mercury_layouts git:(2.0.x) curl https://git.drupalcode.org/project/mercury_layouts/-/merge_requests/11.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 12054 0 12054 0 0 23397 0 --:--:-- --:--:-- --:--:-- 23681
patching file README.md
patching file 'components/cluster/cluster.component.yml'
patching file 'components/columns-2/columns-2.component.yml'
patching file 'components/columns-3/columns-3.component.yml'
patching file 'components/columns-4/columns-4.component.yml'
patching file 'components/columns-5/columns-5.component.yml'
patching file 'components/columns/columns.component.yml'
patching file 'components/columns/columns.css'
patching file 'components/container/container.component.yml'
patching file 'components/container/container.stories.yml'
patching file 'components/container/container.theme.css'
patching file 'components/grid/grid.component.yml'
patching file 'components/grid/grid.css'
patching file 'components/grid/grid.stories.yml'
patching file 'components/skeleton/skeleton.component.yml'
patching file 'components/skeleton/skeleton.css'
patching file 'components/stack/stack.component.yml'
patching file 'components/stack/stack.layout.css'
patching file 'components/stack/stack.stories.yml'
patching file 'css/utilities.css'
patching file 'src/Plugin/StyleOption/MercuryBoxSize.php'
patching file 'src/Plugin/StyleOption/MercuryColumnRatio.php'
➜ mercury_layouts git:(2.0.x) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml mercury_layouts
FILE: ...upal-issues/drupal/drupal/web/modules/contrib/mercury_layouts/css/tabs.css
--------------------------------------------------------------------------------
FOUND 11 ERRORS AFFECTING 11 LINES
--------------------------------------------------------------------------------
12 | ERROR | [x] Selectors must be on a single line
13 | ERROR | [x] Selectors must be on a single line
14 | ERROR | [x] Selectors must be on a single line
15 | ERROR | [x] Selectors must be on a single line
16 | ERROR | [x] Selectors must be on a single line
17 | ERROR | [x] Selectors must be on a single line
18 | ERROR | [x] Selectors must be on a single line
19 | ERROR | [x] Selectors must be on a single line
20 | ERROR | [ ] Style definitions must end with a semicolon
38 | ERROR | [x] Selectors must be on a single line
39 | ERROR | [ ] Style definitions must end with a semicolon
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 9 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...-issues/drupal/drupal/web/modules/contrib/mercury_layouts/css/settings.css
--------------------------------------------------------------------------------
FOUND 29 ERRORS AFFECTING 29 LINES
--------------------------------------------------------------------------------
3 | ERROR | Style definitions must end with a semicolon
4 | ERROR | Style definitions must end with a semicolon
5 | ERROR | Style definitions must end with a semicolon
6 | ERROR | Style definitions must end with a semicolon
7 | ERROR | Style definitions must end with a semicolon
8 | ERROR | Style definitions must end with a semicolon
9 | ERROR | Style definitions must end with a semicolon
10 | ERROR | Style definitions must end with a semicolon
11 | ERROR | Style definitions must end with a semicolon
12 | ERROR | Style definitions must end with a semicolon
13 | ERROR | Style definitions must end with a semicolon
14 | ERROR | Style definitions must end with a semicolon
15 | ERROR | Style definitions must end with a semicolon
16 | ERROR | Style definitions must end with a semicolon
17 | ERROR | Style definitions must end with a semicolon
23 | ERROR | Style definitions must end with a semicolon
24 | ERROR | Style definitions must end with a semicolon
25 | ERROR | Style definitions must end with a semicolon
26 | ERROR | Style definitions must end with a semicolon
27 | ERROR | Style definitions must end with a semicolon
28 | ERROR | Style definitions must end with a semicolon
29 | ERROR | Style definitions must end with a semicolon
30 | ERROR | Style definitions must end with a semicolon
31 | ERROR | Style definitions must end with a semicolon
32 | ERROR | Style definitions must end with a semicolon
33 | ERROR | Style definitions must end with a semicolon
34 | ERROR | Style definitions must end with a semicolon
35 | ERROR | Style definitions must end with a semicolon
36 | ERROR | Style definitions must end with a semicolon
--------------------------------------------------------------------------------
FILE: ...upal/web/modules/contrib/mercury_layouts/css/dynamic-regions-editor-ui.css
--------------------------------------------------------------------------------
FOUND 19 ERRORS AFFECTING 17 LINES
--------------------------------------------------------------------------------
15 | ERROR | [x] Selectors must be on a single line
16 | ERROR | [ ] Style definitions must end with a semicolon
40 | ERROR | [x] Selectors must be on a single line
41 | ERROR | [x] Selectors must be on a single line
42 | ERROR | [x] Selectors must be on a single line
43 | ERROR | [x] Selectors must be on a single line
44 | ERROR | [x] Selectors must be on a single line
45 | ERROR | [x] Selectors must be on a single line
46 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
46 | ERROR | [ ] Style definitions must end with a semicolon
52 | ERROR | [x] Expected 1 space before opening brace of class definition; 2
| | found
57 | ERROR | [x] Selectors must be on a single line
58 | ERROR | [x] Selectors must be on a single line
59 | ERROR | [x] Selectors must be on a single line
60 | ERROR | [x] Selectors must be on a single line
61 | ERROR | [x] Selectors must be on a single line
62 | ERROR | [x] Selectors must be on a single line
63 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
63 | ERROR | [ ] Style definitions must end with a semicolon
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 16 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...contrib/mercury_layouts/mercury_layouts_incorrect_attach_library.patch.txt
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | Line exceeds 80 characters; contains 86 characters
--------------------------------------------------------------------------------
FILE: ...s/drupal/drupal/web/modules/contrib/mercury_layouts/mercury_layouts.module
--------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
--------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
6 | ERROR | [x] There must be one blank line after the last USE statement; 2
| | found;
12 | ERROR | [x] Expected 1 blank line before function; 2 found
54 | ERROR | [ ] Missing parameter type
57 | ERROR | [ ] Description for the @return value is missing
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...pal/drupal/web/modules/contrib/mercury_layouts/mercury_layouts.routing.yml
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
44 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...les/contrib/mercury_layouts/src/Plugin/Layout/DynamicRegionsLayoutBase.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
26 | ERROR | [x] Multi-line function declarations must have a trailing comma
| | after the last parameter
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...trib/mercury_layouts/src/Controller/EditDynamicRegionsLayoutController.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Core\Ajax\AjaxHelperTrait.
67 | ERROR | [x] Multi-line function declarations must have a trailing comma
| | after the last parameter
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Time: 452ms; Memory: 12MB
➜ contrib git:(main) ✗
🇵🇭Philippines clarkssquared
clarkssquared → created an issue.
🇵🇭Philippines clarkssquared
Hi
I also applied MR !9 and I confirmed that the WSOD error is now fixed, please look at the monosnap screenshot in Before and After MR for your reference.
🇵🇭Philippines clarkssquared
Hi
I applied the MR !104 and I can see some PHPCS issues
upgrade_status git:(4.x) curl https://git.drupalcode.org/project/upgrade_status/-/merge_requests/104.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 92837 0 92837 0 0 165k 0 --:--:-- --:--:-- --:--:-- 167k
patching file README.md
patching file 'css/upgrade_status.admin.theme.css'
patching file 'src/CSSDeprecationAnalyzer.php'
patching file 'src/ConfigSchemaDeprecationAnalyzer.php'
patching file 'src/Controller/ScanResultController.php'
patching file 'src/DeprecationAnalyzer.php'
patching file 'src/DeprecationMessage.php'
patching file 'src/Drush/Commands/UpgradeStatusCommands.php'
patching file 'src/ExtensionMetadataDeprecationAnalyzer.php'
patching file 'src/Form/UpgradeStatusForm.php'
patching file 'src/LibraryDeprecationAnalyzer.php'
patching file 'src/ProjectCollector.php'
patching file 'src/RouteDeprecationAnalyzer.php'
patching file 'src/ScanResultFormatter.php'
patching file 'src/ThemeFunctionDeprecationAnalyzer.php'
patching file 'src/TwigDeprecationAnalyzer.php'
patching file 'tests/modules/upgrade_status_test_11_compatible/node_modules/upgrade_status_test_11_compatible.inc'
patching file 'tests/modules/upgrade_status_test_contrib_error/src/Controller/UpgradeStatusTestContribErrorController.php'
patching file 'tests/modules/upgrade_status_test_contrib_error/upgrade_status_test_contrib_error.module'
patching file 'tests/modules/upgrade_status_test_error/config/views.view.remove_default_argument_skip_url.yml'
patching file 'tests/modules/upgrade_status_test_error/src/Controller/UpgradeStatusTestErrorController.php'
patching file 'tests/modules/upgrade_status_test_library/upgrade_status_test_library.module'
patching file 'tests/modules/upgrade_status_test_theme_functions/upgrade_status_test_theme_functions.module'
patching file 'tests/modules/upgrade_status_test_twig/src/TwigExtension/DeprecatedFilter.php'
patching file 'tests/src/Functional/UpgradeStatusAnalyzeTest.php'
patching file 'tests/src/Functional/UpgradeStatusCommandsTest.php'
patching file 'tests/src/Functional/UpgradeStatusUiTest.php'
patching file 'tests/src/Kernel/TwigDeprecationAnalyzerTest.php'
patching file 'tests/themes/upgrade_status_test_theme/upgrade_status_test_theme.theme'
patching file upgrade_status.api.php
patching file upgrade_status.module
➜ upgrade_status git:(4.x) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml upgrade_status
FILE: ...sts/modules/upgrade_status_test_library/upgrade_status_test_library.module
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
3 | ERROR | Missing short description in doc comment
--------------------------------------------------------------------------------
FILE: ...atus/tests/modules/upgrade_status_test_error/upgrade_status_test_error.css
--------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
1 | ERROR | Class definition is empty
5 | ERROR | Class definition is empty
9 | ERROR | Class definition is empty
--------------------------------------------------------------------------------
FILE: ...tests/modules/upgrade_status_test_error/upgrade_status_test_error.info.yml
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
5 | ERROR | "dependencies" should be an array in the info yaml file
--------------------------------------------------------------------------------
FILE: ...rade_status_test_error/src/Controller/UpgradeStatusTestErrorController.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
12 | ERROR | Doc comment is empty
--------------------------------------------------------------------------------
FILE: ...status/tests/modules/upgrade_status_test_error/src/DeprecatedBaseClass.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
10 | ERROR | Each @deprecated tag must have a @see tag immediately following
| | it
--------------------------------------------------------------------------------
FILE: ...atus_test_11_compatible/node_modules/upgrade_status_test_11_compatible.inc
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
3 | ERROR | Missing short description in doc comment
7 | ERROR | Doc comment is empty
--------------------------------------------------------------------------------
FILE: ...ade_status_test_theme_functions/upgrade_status_test_theme_functions.module
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
3 | ERROR | Missing short description in doc comment
31 | ERROR | All functions defined in a module file must be prefixed with the
| | module's name, found "upgrade_status_test_theme_function" but
| | expected
| | "upgrade_status_test_theme_functions_upgrade_status_test_theme_function"
--------------------------------------------------------------------------------
FILE: ...ts/modules/upgrade_status_test_twig/src/TwigExtension/DeprecatedFilter.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
8 | ERROR | Doc comment is empty
13 | ERROR | Doc comment is empty
--------------------------------------------------------------------------------
FILE: ...t_contrib_11_compatible/upgrade_status_test_contrib_11_compatible.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by
| | drupal.org packaging automatically
--------------------------------------------------------------------------------
FILE: ...grade_status_test_contrib_error/upgrade_status_test_contrib_error.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by
| | drupal.org packaging automatically
--------------------------------------------------------------------------------
FILE: ...upgrade_status_test_contrib_error/upgrade_status_test_contrib_error.module
--------------------------------------------------------------------------------
FOUND 11 ERRORS AFFECTING 11 LINES
--------------------------------------------------------------------------------
3 | ERROR | Missing short description in doc comment
10 | ERROR | Each @deprecated tag must have a @see tag immediately following
| | it
14 | ERROR | The trigger_error message
| | 'upgrade_status_test_contrib_error_function_9_to_10() is
| | deprecated in Drupal 9.1.0 and will be removed before Drupal
| | 10.0.0. Use the replacement instead. See LINK' does not match the
| | strict standard format: %thing% is deprecated in
| | %deprecation-version% and is removed from %removal-version%.
| | %extra-info%. See %cr-link%
20 | ERROR | Each @deprecated tag must have a @see tag immediately following
| | it
24 | ERROR | The trigger_error message
| | 'upgrade_status_test_contrib_error_function_9_to_11() is
| | deprecated in Drupal 9.1.0 and will be removed before Drupal
| | 11.0.0. Use the replacement instead. See LINK' does not match the
| | strict standard format: %thing% is deprecated in
| | %deprecation-version% and is removed from %removal-version%.
| | %extra-info%. See %cr-link%
30 | ERROR | Each @deprecated tag must have a @see tag immediately following
| | it
34 | ERROR | The trigger_error message
| | 'upgrade_status_test_contrib_error_function_10_to_11() is
| | deprecated in Drupal 10.3.0 and will be removed before Drupal
| | 11.0.0. Use the replacement instead. See LINK' does not match the
| | strict standard format: %thing% is deprecated in
| | %deprecation-version% and is removed from %removal-version%.
| | %extra-info%. See %cr-link%
40 | ERROR | Each @deprecated tag must have a @see tag immediately following
| | it
44 | ERROR | The trigger_error message
| | 'upgrade_status_test_contrib_error_function_10_to_12() is
| | deprecated in Drupal 10.0.0 and will be removed before Drupal
| | 12.0.0. Use the replacement instead. See LINK' does not match the
| | strict standard format: %thing% is deprecated in
| | %deprecation-version% and is removed from %removal-version%.
| | %extra-info%. See %cr-link%
50 | ERROR | Each @deprecated tag must have a @see tag immediately following
| | it
54 | ERROR | The trigger_error message
| | 'upgrade_status_test_contrib_error_function_11_to_13() is
| | deprecated in Drupal 11.1.0 and will be removed before Drupal
| | 13.0.0. Use the replacement instead. See LINK' does not match the
| | strict standard format: %thing% is deprecated in
| | %deprecation-version% and is removed from %removal-version%.
| | %extra-info%. See %cr-link%
--------------------------------------------------------------------------------
FILE: ...t_contrib_error/src/Controller/UpgradeStatusTestContribErrorController.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
12 | ERROR | Doc comment is empty
--------------------------------------------------------------------------------
FILE: ...tus/tests/themes/upgrade_status_test_theme/upgrade_status_test_theme.theme
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
3 | ERROR | Missing short description in doc comment
--------------------------------------------------------------------------------
FILE: ...s/contrib/upgrade_status/tests/src/Functional/UpgradeStatusAnalyzeTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
12 | ERROR | Doc comment is empty
--------------------------------------------------------------------------------
FILE: ...les/contrib/upgrade_status/tests/src/Kernel/CSSDeprecationAnalyzerTest.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
18 | ERROR | Missing @var tag in member variable comment
46 | ERROR | Public method name
| | "CSSDeprecationAnalyzerTest::testGetAllCSSFiles" is not in
| | lowerCamel format
--------------------------------------------------------------------------------
FILE: ...es/contrib/upgrade_status/tests/src/Kernel/TwigDeprecationAnalyzerTest.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
15 | ERROR | Missing member variable doc comment
20 | ERROR | Doc comment is empty
--------------------------------------------------------------------------------
FILE: ...l/drupal/web/modules/contrib/upgrade_status/src/Form/UpgradeStatusForm.php
--------------------------------------------------------------------------------
FOUND 11 ERRORS AND 14 WARNINGS AFFECTING 23 LINES
--------------------------------------------------------------------------------
28 | ERROR | Doc comment is empty
144 | ERROR | Parameter $database is not described in comment
167 | ERROR | Doc comment for parameter $connection does not match actual
| | variable name $kernel
239 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
336 | WARNING | Translatable strings must not begin or end with white spaces,
| | use placeholders with t() for variables
336 | ERROR | Concatenating translatable strings is not allowed, use
| | placeholders instead and only one string literal
339 | WARNING | Translatable strings must not begin or end with white spaces,
| | use placeholders with t() for variables
339 | ERROR | Concatenating translatable strings is not allowed, use
| | placeholders instead and only one string literal
561 | ERROR | Public method name
| | "UpgradeStatusForm::upgrade_status_preprocess_table_custom_header"
| | is not in lowerCamel format
899 | WARNING | Role::loadMultiple calls should be avoided in classes, use
| | dependency injection instead
900 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
940 | ERROR | join() is a function name alias, use implode() instead
1015 | WARNING | Avoid backslash escaping in translatable strings when
| | possible, use "" quotes instead
1105 | WARNING | Unused variable $addendum.
1124 | WARNING | Line exceeds 80 characters; contains 94 characters
1147 | WARNING | Line exceeds 80 characters; contains 93 characters
1160 | WARNING | Unused variable $addendum.
1166 | WARNING | Unused variable $addendum.
1229 | ERROR | join() is a function name alias, use implode() instead
1422 | ERROR | Public method name "UpgradeStatusForm::exportReportASCII" is
| | not in lowerCamel format
1482 | ERROR | Missing parameter type
1484 | ERROR | Missing parameter type
1586 | WARNING | Unused variable $config.
1587 | WARNING | Unused variable $databases.
1588 | WARNING | Unused variable $class_loader.
--------------------------------------------------------------------------------
FILE: .../drupal/drupal/web/modules/contrib/upgrade_status/src/ProjectCollector.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------------
521 | WARNING | Avoid backslash escaping in translatable strings when
| | possible, use "" quotes instead
564 | ERROR | Public method name "ProjectCollector::isCompatibleWithPHP" is
| | not in lowerCamel format
--------------------------------------------------------------------------------
FILE: ...upal/drupal/web/modules/contrib/upgrade_status/src/ScanResultFormatter.php
--------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------------
12 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is dekor\ArrayToTextTable.
205 | ERROR | [ ] join() is a function name alias, use implode() instead
329 | ERROR | [ ] join() is a function name alias, use implode() instead
484 | ERROR | [ ] join() is a function name alias, use implode() instead
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...eb/modules/contrib/upgrade_status/src/ThemeFunctionDeprecationAnalyzer.php
--------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
--------------------------------------------------------------------------------
37 | ERROR | Parameter $container is not described in comment
40 | ERROR | Doc comment for parameter $this->container does not match actual
| | variable name $container
53 | ERROR | Description for the @return value is missing
96 | ERROR | Missing parameter type
101 | ERROR | Description for the @return value is missing
--------------------------------------------------------------------------------
FILE: ...web/modules/contrib/upgrade_status/src/Controller/ScanResultController.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------------
13 | ERROR | Doc comment is empty
141 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
--------------------------------------------------------------------------------
FILE: ...rupal/drupal/web/modules/contrib/upgrade_status/src/DeprecationMessage.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
41 | ERROR | Parameter $analyzer is not described in comment
--------------------------------------------------------------------------------
FILE: ...upal/web/modules/contrib/upgrade_status/src/LibraryDeprecationAnalyzer.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
--------------------------------------------------------------------------------
120 | ERROR | Unnecessarily gendered language in a comment
353 | WARNING | The use of function fnmatch() is discouraged
439 | ERROR | Unnecessarily gendered language in a comment
--------------------------------------------------------------------------------
FILE: ...l/drupal/web/modules/contrib/upgrade_status/src/CSSDeprecationAnalyzer.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
50 | ERROR | Private method name "CSSDeprecationAnalyzer::getAllCSSFiles" is
| | not in lowerCamel format
--------------------------------------------------------------------------------
FILE: ...upal/drupal/web/modules/contrib/upgrade_status/src/DeprecationAnalyzer.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
--------------------------------------------------------------------------------
15 | ERROR | Doc comment is empty
130 | ERROR | Class property $CSSDeprecationAnalyzer should use lowerCamel
| | naming without underscores
661 | WARNING | Line exceeds 80 characters; contains 83 characters
--------------------------------------------------------------------------------
FILE: ...odules/contrib/upgrade_status/src/ExtensionMetadataDeprecationAnalyzer.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
62 | WARNING | '@todo' should match the format '@todo Fix problem X here.'
--------------------------------------------------------------------------------
FILE: ...odules/contrib/upgrade_status/src/Drush/Commands/UpgradeStatusCommands.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES
--------------------------------------------------------------------------------
13 | WARNING | [x] Unused use statement
280 | WARNING | [ ] Line exceeds 80 characters; contains 88 characters
284 | ERROR | [ ] The array declaration extends to column 247 (the limit is
| | 120). The array content should be split up over multiple
| | lines
363 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency
| | injection instead
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: .../drupal/web/modules/contrib/upgrade_status/src/TwigDeprecationAnalyzer.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
11 | ERROR | Doc comment is empty
39 | ERROR | Description for the @return value is missing
--------------------------------------------------------------------------------
Time: 1.68 secs; Memory: 20MB
➜ contrib git:(main) ✗
🇵🇭Philippines clarkssquared
Hi chr.
I applied MR !19 and I confirmed that the Deprecation error is now fixed and not displaying on /user/#/edit page
Please look at this screenshot Before and After MR I sent a monosnap link instead of uploading the screenshot file here.
🇵🇭Philippines clarkssquared
clarkssquared → created an issue.
🇵🇭Philippines clarkssquared
🇵🇭Philippines clarkssquared
clarkssquared → created an issue.
🇵🇭Philippines clarkssquared
🇵🇭Philippines clarkssquared
🇵🇭Philippines clarkssquared
clarkssquared → created an issue.
🇵🇭Philippines clarkssquared
Hi @alyaj2a,
I applied your MR !5 and I confirmed that it fixes all the PHPCS issues of the module.
➜ auto_block_translate git:(1.0.x) curl https://git.drupalcode.org/project/auto_block_translate/-/merge_requests/5.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 2150 0 2150 0 0 4332 0 --:--:-- --:--:-- --:--:-- 4405
patching file auto_block_translate.module
patching file 'src/Form/TranslationForm.php'
patching file 'src/Plugin/Derivative/AutoBlockTranslateLocalTasks.php'
➜ auto_block_translate git:(1.0.x) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml auto_block_translate
➜ contrib git:(main) ✗
RTBC +1 from me, retaining the status to needs review for others to give their feedbacks.
🇵🇭Philippines clarkssquared
Hi @alyaj2a,
I applied your MR !10 and there's 1 remaining PHPCS issue that is fixable with PHPCBF, please check
➜ l10n_tools git:(1.0.x) curl https://git.drupalcode.org/project/l10n_tools/-/merge_requests/10.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 3668 0 3668 0 0 7355 0 --:--:-- --:--:-- --:--:-- 7501
patching file README.md
patching file 'src/Commands/L10nToolsCommands.php'
patching file 'src/Form/L10nToolsForm.php'
➜ l10n_tools git:(1.0.x) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml l10n_tools
FILE: ...l/drupal/web/modules/contrib/l10n_tools/src/Commands/L10nToolsCommands.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
36 | ERROR | [x] Multi-line function declarations must have a trailing comma
| | after the last parameter
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Time: 352ms; Memory: 12MB
➜ contrib git:(main) ✗ 🇵🇭Philippines clarkssquared
I also applied MR !3 and I confirmed that the module has no PHPCS issues
➜ birthday_wish_mail git:(2.0.x) curl https://git.drupalcode.org/project/birthday_wish_mail/-/merge_requests/3.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 1128 0 1128 0 0 2209 0 --:--:-- --:--:-- --:--:-- 2233
patching file birthday_wish_mail.module
patching file 'src/Form/BirthdayWishMailSettingsForm.php'
➜ birthday_wish_mail git:(2.0.x) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml birthday_wish_mail
➜ contrib git:(main) ✗
RTBC +1 from me
🐛 | Office Hours | Warning: 'Undefined array key' on page 'Manage form display' when changing field settings.
🇵🇭Philippines clarkssquared
Hi
Im using Drupal Core version 10.1.8 but I can't seem to replicate the error.
🇵🇭Philippines clarkssquared
Hi
I got an WSOD error after applying MR !1 hence I updated line 21 of .module file to fix it this is the error https://monosnap.com/file/1mSqbZkGJYxOjv0dJM0dLr311xV4yG , and this is after I update line 21 https://monosnap.com/file/FoQ6IJvYtft3VCTgItbTeXJjX3fyED
🇵🇭Philippines clarkssquared
clarkssquared → made their first commit to this issue’s fork.
🇵🇭Philippines clarkssquared
Hi shubham,
I applied your MR but it fails to apply
➜ composer_deploy git:(8.x-1.10) ✗ curl https://git.drupalcode.org/project/composer_deploy/-/merge_requests/4.diff | git apply -v
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 895 0 895 0 0 1716 0 --:--:-- --:--:-- --:--:-- 1761
Checking patch composer_deploy.module...
error: while searching for:
use Drupal\Core\Extension\Extension;
use Drupal\Core\Url;
use DrupalFinder\DrupalFinder;
/**
* @param array $info
error: patch failed: composer_deploy.module:4
error: composer_deploy.module: patch does not apply🇵🇭Philippines clarkssquared
Hi shubham,
I applied your MR !3 and I confirmed that it implemented the hook_help function, here's the screenshot of help page that your MR created https://monosnap.com/file/qCzhW5cPvbayWF4RL0kxRPehlwiEJ9 I sent a link of monosnap for the screenshot to avoid uploading screenshot/images in the issue queue
🇵🇭Philippines clarkssquared
Hi shubham,
I checked your MR !7 and I confirmed that it implemented a hook_help function, the Help page is very straight forward. I sent a monosnap link of the screenshot I created regarding the help page instead of uploading the screenshot https://monosnap.com/file/djtaSX4ma2FCv83rFokA9bq7iHN3yY
🇵🇭Philippines clarkssquared
Hi frederikvho,
I have the same version of PHPCS with you and I checked the updated MR !6 and I can confirmed that there's no PHPCS issues in the module
➜ amazon_sns git:(65644ed) curl https://git.drupalcode.org/project/amazon_sns/-/merge_requests/6.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 2048 0 2048 0 0 4317 0 --:--:-- --:--:-- --:--:-- 4394
patching file 'src/Event/MessageEventDispatcher.php'
patching file 'src/Event/SnsMessageEvent.php'
patching file 'src/Form/SnsSettingsForm.php'
patching file 'tests/fixtures/plain-text-message-server.php'
➜ amazon_sns git:(65644ed) ✗ ..
➜ contrib git:(2.1.x) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml amazon_sns
➜ contrib git:(2.1.x) ✗ RTBC +1 from me, will retain the status to needs review for others.
🇵🇭Philippines clarkssquared
Hi frederikvho,
I applied MR !6 but I can still see some PHPCS issues
➜ amazon_sns git:(65644ed) curl https://git.drupalcode.org/project/amazon_sns/-/merge_requests/6.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 6301 0 6301 0 0 12655 0 --:--:-- --:--:-- --:--:-- 12806
patching file 'src/Controller/NotificationController.php'
patching file 'src/Event/MessageEventDispatcher.php'
patching file 'src/Event/SnsMessageEvent.php'
patching file 'src/Form/SnsSettingsForm.php'
patching file 'tests/fixtures/plain-text-message-server.php'
patching file 'tests/src/Kernel/SnsNotificationSubscriberTest.php'
patching file 'tests/src/Unit/NotificationControllerTest.php'
patching file 'tests/src/Unit/RequestMessageValidatorTest.php'
patching file 'tests/src/Unit/SnsMessageEventTest.php'
patching file 'tests/src/Unit/SnsSubscriptionConfirmationSubscriberTest.php'
➜ amazon_sns git:(65644ed) ✗ ..
➜ contrib git:(2.1.x) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml amazon_sns
FILE: ...ib/amazon_sns/tests/src/Unit/SnsSubscriptionConfirmationSubscriberTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\amazon_sns\Event\SnsMessageEvent.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...trib/web/modules/contrib/amazon_sns/tests/src/Unit/SnsMessageEventTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\amazon_sns\Event\SnsMessageEvent.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: .../modules/contrib/amazon_sns/tests/src/Unit/RequestMessageValidatorTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\amazon_sns\RequestMessageValidator.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...b/modules/contrib/amazon_sns/tests/src/Unit/NotificationControllerTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is
| | Drupal\amazon_sns\Controller\NotificationController.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...ules/contrib/amazon_sns/tests/src/Kernel/SnsNotificationSubscriberTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
8 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is
| | Drupal\amazon_sns\Controller\NotificationController.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...b/web/modules/contrib/amazon_sns/src/Controller/NotificationController.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
10 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\amazon_sns\Event\MessageEventDispatcher.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Time: 345ms; Memory: 10MB
➜ contrib git:(2.1.x) ✗
🇵🇭Philippines clarkssquared
Hi
I applied the updated MR !6 and I confirmed that all PHPCS issues were fixed.
➜ certificatelogin git:(2.x) curl https://git.drupalcode.org/project/certificatelogin/-/merge_requests/6.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 49212 0 49212 0 0 76934 0 --:--:-- --:--:-- --:--:-- 77499
patching file README.md
patching file certificatelogin.install
patching file certificatelogin.module
patching file certificatelogin.routing.yml
patching file 'css/certificatelogin.css'
patching file 'src/Annotation/CaSignatureVerificationPlugin.php'
patching file 'src/Controller/CertificateLoginController.php'
patching file 'src/Form/CertificateLoginSettingsForm.php'
patching file 'src/Form/ConfirmForm.php'
patching file 'src/Form/LoginForm.php'
patching file 'src/Plugin/Block/CertificateLoginBlock.php'
patching file 'src/Plugin/CaSignatureVerificationPlugin/PHPSecLib.php'
patching file 'src/Plugin/CaSignatureVerificationPluginBase.php'
patching file 'src/Plugin/CaSignatureVerificationPluginInterface.php'
patching file 'src/Plugin/CaSignatureVerificationPluginManager.php'
patching file 'src/Plugin/Menu/LoginLogoutMenuLink.php'
patching file 'src/Service/LoginRegisterService.php'
➜ certificatelogin git:(2.x) ✗ ..
➜ contrib git:(2.1.x) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml certificatelogin
➜ contrib git:(2.1.x) ✗
🇵🇭Philippines clarkssquared
Hi @ divyansh.gupta
Got it, I will move the status to needs review so that other users can check also, RTBC +1 from me.
Thanks
🇵🇭Philippines clarkssquared
Closing this ticket since there's no work to be done here and this was used for onboarding purposes.
🇵🇭Philippines clarkssquared
clarkssquared → created an issue.
🇵🇭Philippines clarkssquared
Hi
I applied MR !4 and checked the PHPCS and there is only one PHPCS warning left in the module
➜ total_control git:(3.0.x) curl https://git.drupalcode.org/project/total_control/-/merge_requests/4.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 11520 0 11520 0 0 21209 0 --:--:-- --:--:-- --:--:-- 21532
patching file 'src/Plugin/Block/AdministerContentTypes.php'
patching file 'src/Plugin/Block/AdministerMenus.php'
patching file 'src/Plugin/Block/AdministerPanelPages.php'
patching file 'src/Plugin/Block/AdministerTaxonomy.php'
patching file 'src/Plugin/Block/ContentOverview.php'
patching file 'src/Plugin/Block/CreateContent.php'
patching file 'src/Plugin/Derivative/TotalControlMenuLink.php'
patching file 'src/Routing/RouteSubscriber.php'
patching file 'tests/src/FunctionalJavascript/TotalControlDashboardPageCheckTest.php'
➜ total_control git:(3.0.x) ✗ ..
➜ contrib git:(2.1.x) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml total_control
FILE: ...ksubing-subing/Projects/drupal-issues/drupal-contrib/web/modules/contrib/total_control/css/theme/total-control.theme.css
------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
------------------------------------------------------------------------------------------------------------------------------
Time: 734ms; Memory: 10MB
➜ contrib git:(2.1.x) ✗
🇵🇭Philippines clarkssquared
Hi
I applied MR !6 and I can still see many PHPCS issues
➜ certificatelogin git:(2.x) curl https://git.drupalcode.org/project/certificatelogin/-/merge_requests/6.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 38848 0 38848 0 0 61051 0 --:--:-- --:--:-- --:--:-- 61859
patching file certificatelogin.install
patching file certificatelogin.module
patching file 'src/Annotation/CaSignatureVerificationPlugin.php'
patching file 'src/Controller/CertificateLoginController.php'
patching file 'src/Form/CertificateLoginSettingsForm.php'
patching file 'src/Form/ConfirmForm.php'
patching file 'src/Form/LoginForm.php'
patching file 'src/Plugin/Block/CertificateLoginBlock.php'
patching file 'src/Plugin/CaSignatureVerificationPlugin/PHPSecLib.php'
patching file 'src/Plugin/CaSignatureVerificationPluginBase.php'
patching file 'src/Plugin/CaSignatureVerificationPluginInterface.php'
patching file 'src/Plugin/CaSignatureVerificationPluginManager.php'
patching file 'src/Plugin/Menu/LoginLogoutMenuLink.php'
patching file 'src/Service/LoginRegisterService.php'
➜ certificatelogin git:(2.x) ✗ ..
➜ contrib git:(2.1.x) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml certificatelogin
FILE: ...s/clarksubing-subing/Projects/drupal-issues/drupal-contrib/web/modules/contrib/certificatelogin/css/certificatelogin.css
------------------------------------------------------------------------------------------------------------------------------
FOUND 54 ERRORS AFFECTING 18 LINES
------------------------------------------------------------------------------------------------------------------------------
7 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
7 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
7 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
8 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
8 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
8 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
9 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
9 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
9 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
10 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
10 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
10 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
11 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
11 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
11 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
12 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
12 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
12 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
13 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
13 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
13 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
14 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
14 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
15 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
15 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
15 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
16 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
16 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
16 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
17 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
17 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
18 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
18 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
18 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
19 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
19 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
19 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
20 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
20 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
20 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
24 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
24 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
25 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
25 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
25 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
29 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
29 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
29 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
30 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
30 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
30 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 54 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/clarksubing-subing/Projects/drupal-issues/drupal-contrib/web/modules/contrib/certificatelogin/README.md
--------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
--------------------------------------------------------------------------------------------------------------------
14 | WARNING | Line exceeds 80 characters; contains 103 characters
15 | WARNING | Line exceeds 80 characters; contains 131 characters
23 | WARNING | Line exceeds 80 characters; contains 92 characters
34 | WARNING | Line exceeds 80 characters; contains 104 characters
46 | WARNING | Line exceeds 80 characters; contains 96 characters
47 | WARNING | Line exceeds 80 characters; contains 107 characters
--------------------------------------------------------------------------------------------------------------------
FILE: ...s/clarksubing-subing/Projects/drupal-issues/drupal-contrib/web/modules/contrib/certificatelogin/certificatelogin.install
------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------
9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is
| | Drupal\certificatelogin\Controller\CertificateLoginController.
------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------
FILE: ...arksubing-subing/Projects/drupal-issues/drupal-contrib/web/modules/contrib/certificatelogin/certificatelogin.routing.yml
------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------
37 | WARNING | The administration page callback should probably use "administer site configuration" - which implies the user
| | can change something - rather than "access administration pages" which is about viewing but not changing
| | configurations.
------------------------------------------------------------------------------------------------------------------------------
FILE: ...ers/clarksubing-subing/Projects/drupal-issues/drupal-contrib/web/modules/contrib/certificatelogin/src/Form/LoginForm.php
------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is
| | Drupal\certificatelogin\Service\LoginRegisterService.
------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------
FILE: ...ing/Projects/drupal-issues/drupal-contrib/web/modules/contrib/certificatelogin/src/Form/CertificateLoginSettingsForm.php
------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is
| | Drupal\certificatelogin\Plugin\CaSignatureVerificationPluginManager.
------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------
FILE: ...Projects/drupal-issues/drupal-contrib/web/modules/contrib/certificatelogin/src/Controller/CertificateLoginController.php
------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is
| | Drupal\certificatelogin\Service\LoginRegisterService.
------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------
FILE: ...g-subing/Projects/drupal-issues/drupal-contrib/web/modules/contrib/certificatelogin/src/Service/LoginRegisterService.php
------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is
| | Drupal\certificatelogin\Plugin\CaSignatureVerificationPluginManager.
------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------
Time: 388ms; Memory: 12MB
➜ contrib git:(2.1.x) ✗
🇵🇭Philippines clarkssquared
Hi @atulghate
I checked the README.md file but it seems its not organized according to Drupal README.md template →
🇵🇭Philippines clarkssquared
Hi olegry,
I want to ask for some advice how do you install the theme? because when I install the theme in my drupal site a WSOD error will occur in my end. The issue will be fixed in a separate d.o ticket though especially openy theme installation error 🐛 unable to install theme Active
🇵🇭Philippines clarkssquared
Hi
I also encountered this issue when installing the theme I got a WSOD
The website encountered an unexpected error. Please try again later.
Drupal\Core\Config\UnmetDependenciesException: Configuration objects provided by <em class="placeholder">openy_carnation</em> have unmet dependencies: <em class="placeholder">block.block.openy_carnation_footermenuright (system.menu.footer-menu-right, openy_menu_footer)</em> in Drupal\Core\Config\UnmetDependenciesException::create() (line 100 of core/lib/Drupal/Core/Config/UnmetDependenciesException.php).
Drupal\Core\Config\ConfigInstaller->checkConfigurationToInstall('theme', 'openy_carnation') (Line: 132)
Drupal\Core\ProxyClass\Config\ConfigInstaller->checkConfigurationToInstall('theme', 'openy_carnation') (Line: 218)
Drupal\Core\Extension\ThemeInstaller->install(Array) (Line: 225)
Drupal\system\Controller\ThemeController->setDefaultTheme(Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 592)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 181)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object, 1, 1) (Line: 704)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)I encountered this in V3.0.x-dev
🇵🇭Philippines clarkssquared
Hi
I applied the MR !15 and I confirmed that it fixes all the PHPCS issues
➜ floating_block git:(2.0.x) curl https://git.drupalcode.org/project/floating_block/-/merge_requests/15.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 1113 0 1113 0 0 2227 0 --:--:-- --:--:-- --:--:-- 2248
patching file 'tests/modules/floating_block_test/css/floating_block_test.css'
patching file 'tests/src/Unit/HelperTest.php'
➜ floating_block git:(2.0.x) ✗ ..
➜ contrib git:(2.1.x) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml floating_block
➜ contrib git:(2.1.x) ✗
RTBC +1 from me
🇵🇭Philippines clarkssquared
I added a minor comments on the README.md please check
🇵🇭Philippines clarkssquared
🇵🇭Philippines clarkssquared
clarkssquared → changed the visibility of the branch 3479520-buttons-and-links to hidden.
🇵🇭Philippines clarkssquared
🇵🇭Philippines clarkssquared
clarkssquared → created an issue.
🇵🇭Philippines clarkssquared
Hi
I checked the MR !4 and I have some minor comments regarding Drupal README.md template →
🇵🇭Philippines clarkssquared
Hi
I applied the updated MR !18, and it replaced the README.txt file with README.md with the content below
# Date
The Date module suite provides an API for handling date values, a field for
Drupal 7's Field API system, and a wealth of submodules for various purposes.
For a full description of the module, visit the
[project page](https://www.drupal.org/project/date).
Submit bug reports and feature suggestions, or track changes in the
[issue queue](https://www.drupal.org/project/issues/date).
## Table of contents
- Requirements
- Installation
- Configuration
- Related Modules
- Maintainers
## Requirements
This module requires no modules outside of Drupal core.
## Installation
Install as you would normally install a contributed Drupal module. For further
information, see
[Installing Drupal Modules](https://www.drupal.org/docs/extending-drupal/installing-drupal-modules).
## Configuration
The module has no menu or modifiable settings. There is no configuration.
## Related modules
This is the beginning of a list of modules that extend Date to solve particular problems.
Please check them out if the core Date functionality isn't sufficient for your needs.
- [Calendar](http://drupal.org/project/calendar)
- [Date iCal](http://drupal.org/project/date_ical)
- [Partial Date](http://drupal.org/project/partial_date)
- [Signup](http://drupal.org/project/signup)
- [CCK Signup](http://drupal.org/project/cck_signup)
- [Registration](http://drupal.org/project/registration)
## Maintainers
- Andrii Podanenko - [podarok](https://www.drupal.org/u/podarok)
- Alex Schedrov - [sanchiz](https://www.drupal.org/u/sanchiz)
- Damien McKenna - [Damien McKenna](https://www.drupal.org/u/damienmckenna)
- Vijaya Chandran Mani - [vijaycs85](https://www.drupal.org/u/vijaycs85)
- Karen Stevenson - [KarenS](https://www.drupal.org/u/karens)
- Arlin Sandbulte - [arlinsandbulte](https://www.drupal.org/u/arlinsandbulte)
- Derek Wright - [dww](https://www.drupal.org/u/dww)
- Gisle Hannemyr - [gisle](https://www.drupal.org/u/gisle)
- Angie Byron - [webchick](https://www.drupal.org/u/webchick)
- David Goode - [David Goode](https://www.drupal.org/user/291318)
- developer-x - [developer-x](https://www.drupal.org/user/399625)
- Peter Lieverdink - [cafuego](https://www.drupal.org/u/cafuego)RTBC +1 from me
🇵🇭Philippines clarkssquared
Hi
I applied patch #2 but it fails to apply, please look at below
➜ administration_language_negotiation git:(2.x) curl https://www.drupal.org/files/issues/2024-09-18/3475316.patch | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 603 100 603 0 0 1207 0 --:--:-- --:--:-- --:--:-- 1228
patching file administration_language_negotiation.info.yml
1 out of 1 hunks failed--saving rejects to administration_language_negotiation.info.yml.rejSo I created a MR based on patch #2.
🇵🇭Philippines clarkssquared
clarkssquared → made their first commit to this issue’s fork.
🇵🇭Philippines clarkssquared
clarkssquared → created an issue.
🇵🇭Philippines clarkssquared
clarkssquared → changed the visibility of the branch 3477673- to hidden.
🇵🇭Philippines clarkssquared
Will create a new branch since I have a hard time fixing the merge conflict in my MR !219 hence I will also close that merge request.
🇵🇭Philippines clarkssquared
clarkssquared → created an issue.
🇵🇭Philippines clarkssquared
Hi
I applied MR !2 but it didn't properly applied in the module and has 2 out of 2 hunks failed--saving rejects to field_display_toggle.module.rej
➜ field_display_toggle git:(2.1.x) ✗ curl https://git.drupalcode.org/project/field_display_toggle/-/merge_requests/2.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 3087 0 3087 0 0 6348 0 --:--:-- --:--:-- --:--:-- 6417
patching file README.md
patching file field_display_toggle.module
2 out of 2 hunks failed--saving rejects to field_display_toggle.module.rej
➜ field_display_toggle git:(2.1.x) ✗ ..
➜ contrib git:(2.1.x) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml field_display_toggle
FILE: ...rib/web/modules/contrib/field_display_toggle/field_display_toggle.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by
| | drupal.org packaging automatically
--------------------------------------------------------------------------------
FILE: ...ntrib/web/modules/contrib/field_display_toggle/field_display_toggle.module
--------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
--------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
4 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Core\Form\FormStateInterface.
17 | WARNING | [ ] Format should be "* Implements hook_foo().", "* Implements
| | hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", "*
| | Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or
| | "* Implements hook_foo_BAR_ID_bar() for block templates."
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Time: 89ms; Memory: 10MB
➜ contrib git:(2.1.x) ✗
🇵🇭Philippines clarkssquared
Hi
I applied and checked MR !36 and I confirm that it fixes all the PHPCS issues
➜ prevnext git:(2.0.x) curl https://git.drupalcode.org/project/prevnext/-/merge_requests/36.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 4304 0 4304 0 0 7123 0 --:--:-- --:--:-- --:--:-- 7185
patching file prevnext.module
patching file 'src/Form/PrevNextSettingsForm.php'
patching file 'src/Plugin/Block/PrevNextBlock.php'
patching file 'src/Plugin/views/field/PrevNextLinks.php'
patching file 'src/PrevNextService.php'
➜ prevnext git:(2.0.x) ✗ ..
➜ contrib git:(2.1.x) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml prevnext
➜ contrib git:(2.1.x) ✗
🇵🇭Philippines clarkssquared
I applied MR !6 after commit cae62d5d and I confirmed that all PHPCS issues were fixed.
➜ fontawesome_menu_icons git:(3.x) curl https://git.drupalcode.org/project/fontawesome_menu_icons/-/merge_requests/6.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 6772 0 6772 0 0 13477 0 --:--:-- --:--:-- --:--:-- 13653
patching file fontawesome_menu_icons.install
patching file fontawesome_menu_icons.module
➜ fontawesome_menu_icons git:(3.x) ✗ ..
➜ contrib git:(2.1.x) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml fontawesome_menu_icons
➜ contrib git:(2.1.x) ✗ 🇵🇭Philippines clarkssquared
Hi @seth.e.shaw
What is your current Drupal version if I may ask? because I investigated the issue in my local Drupal core v10.3.5, I installed bootstrap_barrio v5.5.17 and I can see the right version in info.yml file
# Information added by Drupal.org packaging script on 2024-09-09
version: '5.5.17'
project: 'bootstrap_barrio'
datestamp: 1725856217🇵🇭Philippines clarkssquared
Hi amit,
I applied your MR !6 but there's still 1 PHPCS issues that remains
➜ fontawesome_menu_icons git:(3.x) curl https://git.drupalcode.org/project/fontawesome_menu_icons/-/merge_requests/6.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 6611 0 6611 0 0 2710 0 --:--:-- 0:00:02 --:--:-- 2717
patching file fontawesome_menu_icons.install
patching file fontawesome_menu_icons.module
➜ fontawesome_menu_icons git:(3.x) ✗ ..
➜ contrib git:(2.1.x) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml fontawesome_menu_icons
FILE: ...al-issues/drupal-contrib/web/modules/contrib/fontawesome_menu_icons/fontawesome_menu_icons.module
-------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------
9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is
| | Drupal\Core\Routing\RouteMatchInterface.
-------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------
Time: 187ms; Memory: 12MB
➜ contrib git:(2.1.x) ✗
Also try to avoid opening a new Merge Request, let's use the existing Merge Request in the issue.
Thanks
🇵🇭Philippines clarkssquared
Hi siddhraj,
I applied your patch #3 and I confirmed that it implements hook_help() with the module's overview, I will not upload a screenshot for issue's etiquette but this is the content of the help page:
Address suggestion
Add to Default shortcuts
The Address Suggestion module is a powerful tool for automatically suggesting addresses during form input. It is an alternative to the deprecated Address Autocomplete module, offering more robust features and better integration.
Features
- Automatic address suggestions with country-specific precision.
- Configurable per field widget.
- Supports both plain text fields and address fields.
- Supports CKEditor5 for address fields.
- House number auto-addition.
- Integration with Geo fields and Geolocation fields.
The module improves address input accuracy by retrieving more precise suggestions, based on the country site by default.
🇵🇭Philippines clarkssquared
clarkssquared → created an issue.
🇵🇭Philippines clarkssquared
clarkssquared → changed the visibility of the branch 3476332-update-testimonial-component to active.
🇵🇭Philippines clarkssquared
clarkssquared → changed the visibility of the branch 3476332-update-testimonial-component to hidden.
🇵🇭Philippines clarkssquared
clarkssquared → created an issue.
🇵🇭Philippines clarkssquared
clarkssquared → created an issue.
🇵🇭Philippines clarkssquared
clarkssquared → changed the visibility of the branch 3476085-update-cta-component to hidden.
🇵🇭Philippines clarkssquared
clarkssquared → changed the visibility of the branch 3476085-update-cta-component to hidden.
🇵🇭Philippines clarkssquared
Closing this ticket since this is a duplicate of Update Media and CTA component 📌 Update Media and CTA component Fixed
🇵🇭Philippines clarkssquared
clarkssquared → created an issue.
🇵🇭Philippines clarkssquared
clarkssquared → created an issue.
🇵🇭Philippines clarkssquared
Hi
I applied MR !2 and I confirmed that it fixes all the PHPCS issues
➜ field_add_index git:(1.0.x) curl https://git.drupalcode.org/project/field_add_index/-/merge_requests/2.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 3547 0 3547 0 0 5261 0 --:--:-- --:--:-- --:--:-- 5325
patching file README.md
patching file field_add_index.module
➜ field_add_index git:(1.0.x) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml field_add_index
➜ contrib git:(main) ✗
🇵🇭Philippines clarkssquared
Hi
I tested your MR !3 and I can still see some PHPCS issues in the module
➜ paragraphs_summary git:(main) ✗ curl https://git.drupalcode.org/project/paragraphs_summary/-/merge_requests/3.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 4231 0 4231 0 0 6990 0 --:--:-- --:--:-- --:--:-- 7039
patching file 'src/Plugin/Field/FieldFormatter/ParagraphsSummaryFormatter.php'
➜ paragraphs_summary git:(main) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml paragraphs_summary
FILE: ...l_local/web/modules/contrib/paragraphs_summary/paragraphs_summary.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by
| | drupal.org packaging automatically
--------------------------------------------------------------------------------
FILE: ...phs_summary/src/Plugin/Field/FieldFormatter/ParagraphsSummaryFormatter.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 12 WARNINGS AFFECTING 12 LINES
--------------------------------------------------------------------------------
132 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
144 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
148 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
152 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
160 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
166 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
180 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
183 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
190 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
197 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
200 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
201 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
--------------------------------------------------------------------------------
Time: 215ms; Memory: 10MB
➜ contrib git:(main) ✗
🇵🇭Philippines clarkssquared
Hi
I checked and applied MR !1 and these are the remaining reported PHPCS issues
➜ revision_assignee git:(main) ✗ curl https://git.drupalcode.org/project/revision_assignee/-/merge_requests/1.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 3989 0 3989 0 0 8286 0 --:--:-- --:--:-- --:--:-- 8415
patching file README.txt
patching file revision_assignee.install
patching file revision_assignee.module
patching file revision_assignee.services.yml
patching file 'src/EventSubscriber/EntitySchemaSubscriber.php'
patching file 'src/Utility/RevisionAssigneeUtility.php'
➜ revision_assignee git:(main) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml revision_assignee
FILE: ...pal_local/web/modules/contrib/revision_assignee/revision_assignee.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by
| | drupal.org packaging automatically
--------------------------------------------------------------------------------
FILE: .../modules/contrib/revision_assignee/src/Utility/RevisionAssigneeUtility.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------
43 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
44 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
--------------------------------------------------------------------------------
Time: 277ms; Memory: 10MB
➜ contrib git:(main) ✗
🇵🇭Philippines clarkssquared
I checked the module and applied the MR !10 and I can still see PHPCS issues
➜ critical_css git:(2.0.x) curl https://git.drupalcode.org/project/critical_css/-/merge_requests/10.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 2082 0 2082 0 0 3953 0 --:--:-- --:--:-- --:--:-- 4011
patching file 'src/Asset/CriticalCssProvider.php'
patching file 'src/Asset/CssCollectionRenderer.php'
patching file 'tests/src/Functional/CriticalCssHeadTest.php'
➜ critical_css git:(2.0.x) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml critical_css
FILE: /Users/clarksubing-subing/Projects/d10/drupal_local/web/modules/contrib/critical_css/src/Form/SettingsForm.php
--------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------
34 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
--------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------
FILE: /Users/clarksubing-subing/Projects/d10/drupal_local/web/modules/contrib/critical_css/src/Asset/CriticalCssProvider.php
----------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------
152 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------
Time: 404ms; Memory: 12MB
➜ contrib git:(main) ✗
🇵🇭Philippines clarkssquared
🇵🇭Philippines clarkssquared
clarkssquared → created an issue.
🇵🇭Philippines clarkssquared
🇵🇭Philippines clarkssquared
clarkssquared → created an issue.
🇵🇭Philippines clarkssquared
🇵🇭Philippines clarkssquared
clarkssquared → created an issue.
🇵🇭Philippines clarkssquared
🇵🇭Philippines clarkssquared
clarkssquared → created an issue.
🇵🇭Philippines clarkssquared
🇵🇭Philippines clarkssquared
🇵🇭Philippines clarkssquared
clarkssquared → created an issue.
🇵🇭Philippines clarkssquared
I applied the MR !80 and I can still see PHPCS issues in the module
➜ token git:(8.x-1.15) curl https://git.drupalcode.org/project/token/-/merge_requests/80.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 87460 0 87460 0 0 157k 0 --:--:-- --:--:-- --:--:-- 159k
patching file README.md
patching file 'src/Controller/TokenDevelController.php'
patching file 'src/Controller/TokenTreeController.php'
patching file 'src/Element/TokenTreeTable.php'
patching file 'src/Plugin/Derivative/DevelLocalTask.php'
patching file 'src/Routing/RouteSubscriber.php'
patching file 'src/Token.php'
patching file 'src/TokenEntityMapper.php'
patching file 'src/TokenEntityMapperInterface.php'
patching file 'src/TokenFieldRender.php'
patching file 'src/TokenInterface.php'
patching file 'src/TokenServiceProvider.php'
patching file 'src/TreeBuilder.php'
patching file 'src/TreeBuilderInterface.php'
patching file 'tests/modules/token_module_test/token_module_test.module'
patching file 'tests/modules/token_module_test/token_module_test.tokens.inc'
patching file 'tests/src/Functional/TokenBlockTest.php'
patching file 'tests/src/Functional/TokenCurrentPageTest.php'
patching file 'tests/src/Functional/TokenFieldUiTest.php'
patching file 'tests/src/Functional/TokenMenuTest.php'
patching file 'tests/src/Functional/TokenTestTrait.php'
patching file 'tests/src/Functional/TokenURLTest.php'
patching file 'tests/src/Functional/TokenUserTest.php'
patching file 'tests/src/Functional/Tree/HelpPageTest.php'
patching file 'tests/src/Functional/Tree/TokenTreeTestTrait.php'
patching file 'tests/src/Functional/Tree/TreeTest.php'
patching file 'tests/src/Functional/UrlTest.php'
patching file 'tests/src/Kernel/ArrayTest.php'
patching file 'tests/src/Kernel/BookTest.php'
patching file 'tests/src/Kernel/CommentTest.php'
patching file 'tests/src/Kernel/DateTest.php'
patching file 'tests/src/Kernel/EntityTest.php'
patching file 'tests/src/Kernel/FieldTest.php'
patching file 'tests/src/Kernel/FileTest.php'
patching file 'tests/src/Kernel/LanguageTest.php'
patching file 'tests/src/Kernel/NodeTest.php'
patching file 'tests/src/Kernel/RandomTest.php'
patching file 'tests/src/Kernel/TaxonomyTest.php'
patching file 'tests/src/Kernel/UnitTest.php'
patching file 'tests/src/Kernel/UrlTest.php'
patching file token.install
patching file token.module
patching file token.pages.inc
patching file token.tokens.inc
➜ token git:(8.x-1.15) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml token
FILE: ...g-subing/Projects/d10/drupal_local/web/modules/contrib/token/css/token.css
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
16 | ERROR | [x] Multiple selectors should each be on a single line
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...s/d10/drupal_local/web/modules/contrib/token/css/token.treetable.theme.css
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
--------------------------------------------------------------------------------
FILE: ...ojects/d10/drupal_local/web/modules/contrib/token/css/jquery.treetable.css
--------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
6 | ERROR | [x] Blank lines are not allowed in class definitions
13 | ERROR | [x] Blank lines are not allowed in class definitions
18 | ERROR | [x] Blank lines are not allowed in class definitions
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...ontrib/token/tests/modules/token_module_test/token_module_test.routing.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
7 | WARNING | Open page callback found, please add a comment before the line
| | why there is no access restriction
--------------------------------------------------------------------------------
FILE: ...drupal_local/web/modules/contrib/token/tests/src/Kernel/KernelTestBase.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
5 | ERROR | [x] All trigger_error calls used for deprecation must be prefixed
| | by an "@"
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Time: 2.25 secs; Memory: 26MB
➜ contrib git:(main) ✗
🇵🇭Philippines clarkssquared
I checked MR !5 and there are PHPCS left in the module after applying it.
➜ fontawesome_menu_icons git:(3.x) curl https://git.drupalcode.org/project/fontawesome_menu_icons/-/merge_requests/5.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 5172 0 5172 0 0 9882 0 --:--:-- --:--:-- --:--:-- 10042
patching file fontawesome_menu_icons.install
patching file fontawesome_menu_icons.module
➜ fontawesome_menu_icons git:(3.x) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml fontawesome_menu_icons
FILE: .../web/modules/contrib/fontawesome_menu_icons/fontawesome_menu_icons.install
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
18 | ERROR | unserialize() is insecure unless allowed classes are limited. Use
| | a safe format like JSON or use the allowed_classes option.
--------------------------------------------------------------------------------
FILE: ...l/web/modules/contrib/fontawesome_menu_icons/fontawesome_menu_icons.module
--------------------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------------
9 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Core\Routing\RouteMatchInterface.
80 | WARNING | [ ] #options values usually have to run through t() for
| | translation
186 | WARNING | [ ] #options values usually have to run through t() for
| | translation
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Time: 339ms; Memory: 12MB
➜ contrib git:(main) ✗
🇵🇭Philippines clarkssquared
Hi
I checked your MR !5 and there's one remaining PHPCS issues being reported.
➜ text_field_formatter git:(2.0.x) curl https://git.drupalcode.org/project/text_field_formatter/-/merge_requests/5.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 4972 0 4972 0 0 10319 0 --:--:-- --:--:-- --:--:-- 10445
patching file README.md
patching file 'src/Plugin/Field/FieldFormatter/TextFieldFormatter.php'
➜ text_field_formatter git:(2.0.x) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml text_field_formatter
FILE: ...ext_field_formatter/src/Plugin/Field/FieldFormatter/TextFieldFormatter.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
95 | ERROR | [x] Multi-line function declarations must have a trailing comma
| | after the last parameter
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Time: 156ms; Memory: 12MB
➜ contrib git:(main) ✗ 🇵🇭Philippines clarkssquared
Hi
I applied MR !4 and I confirmed that it fixes all the PHPCS issues
➜ linkpurpose git:(1.0.x) curl https://git.drupalcode.org/project/linkpurpose/-/merge_requests/4.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 1523 0 1523 0 0 3180 0 --:--:-- --:--:-- --:--:-- 3219
patching file 'library/css/linkpurpose.css'
patching file linkpurpose.links.menu.yml
➜ linkpurpose git:(1.0.x) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml linkpurpose
➜ contrib git:(main) ✗