- Issue created by @alyaj2a
- 🇵🇭Philippines clarkssquared
Hi
I applied the MR !15 and I confirmed that it fixes all the PHPCS issues
➜ floating_block git:(2.0.x) curl https://git.drupalcode.org/project/floating_block/-/merge_requests/15.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 1113 0 1113 0 0 2227 0 --:--:-- --:--:-- --:--:-- 2248 patching file 'tests/modules/floating_block_test/css/floating_block_test.css' patching file 'tests/src/Unit/HelperTest.php' ➜ floating_block git:(2.0.x) ✗ .. ➜ contrib git:(2.1.x) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml floating_block ➜ contrib git:(2.1.x) ✗RTBC +1 from me
- 🇮🇹Italy apaderno Brescia, 🇮🇹
avpaderno → made their first commit to this issue’s fork.
- Merge request !16Created a new merge request to get the list of all the PHP_CodeSniffer errors/warnings to fix → (Open) created by apaderno
- 🇮🇹Italy apaderno Brescia, 🇮🇹
avpaderno → changed the visibility of the branch 3480257-gitlab-ci-reports to hidden.
- 🇳🇱Netherlands megachriz
I think that you need to update Coder module, because coding standard rules changed recently. The changes in the MR now introduce coding standard issues instead of fixing them.
See also the following commits:
https://git.drupalcode.org/project/floating_block/-/commit/e63b808c79208... (floating_block_test.css)
https://git.drupalcode.org/project/floating_block/-/commit/d10c07dacdef5... (HelperTest.php)