Contrib.social

Fix issues reported by PHPCS

Open on Drupal.org ā†’
Created on 2 January 2025, 4 months ago

Problem/Motivation

Here is a list of the phpcs issues to fix:

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml funnelback/

FILE: /var/www/web/modules/contrib/funnelback/tests/src/Unit/FunnelbackTest.php
--------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------
 12 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Tests\UnitTestCase.
--------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------


FILE: /var/www/web/modules/contrib/funnelback/funnelback.info.yml
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-------------------------------------------------------------------------------------------------------------


FILE: /var/www/web/modules/contrib/funnelback/src/FunnelbackClient.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------
 126 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 126 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/web/modules/contrib/funnelback/src/Form/FunnelbackSettingsForm.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------
 111 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------

Time: 780ms; Memory: 14MB

Steps to reproduce

Run the command,
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml funnelback/

Proposed resolution

Fix the phpcs issues.

šŸ“Œ Task
Status

Active

Version

2.0

Component

Code

Created by

šŸ‡®šŸ‡³India abhiyanshu

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @abhiyanshu
  • Comment 4 months ago ā†’
    šŸ‡¦šŸ‡ŗAustralia geoffreyr Sydney, AU / Gadigal country

    Very curious that these phpcs issues weren't picked up by the GitLab CI pipeline, which should cover that. I'll take a look.

  • First commit to issue fork.
  • Merge request !12Fixes issue #3496901: Fixed PHPCS issues ā†’ (Open) created by Unnamed author
  • Comment about 2 months ago ā†’
    šŸ‡®šŸ‡³India GGH
  • Pipeline finished with Success
    about 2 months ago
    Total: 149s
    #434884
  • Comment about 2 months ago ā†’
    šŸ‡µšŸ‡­Philippines clarkssquared

    I applied MR !12 in the module and there are no PHPCS issues found in the module

    āžœ  funnelback git:(2.0.0-beta4) curl https://git.drupalcode.org/project/funnelback/-/merge_requests/12.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  9877    0  9877    0     0  19630      0 --:--:-- --:--:-- --:--:-- 19913
patching file funnelback.info.yml
patching file 'src/Form/FunnelbackSettingsForm.php'
patching file 'src/FunnelbackClient.php'
āžœ  funnelback git:(2.0.0-beta4) āœ— ..
āžœ  contrib git:(main) āœ— phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml funnelback 
āžœ  contrib git:(main) āœ—

    RTBC +1

  • Status changed to Needs work about 1 month ago
  • Comment about 1 month ago ā†’
    šŸ‡¦šŸ‡ŗAustralia geoffreyr Sydney, AU / Gadigal country
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024