Contrib.social

Coding Standard Issues

Open on Drupal.org ā†’
Created on 1 November 2024, about 2 months ago

Problem/Motivation

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,css .

FILE: .../web/modules/custom/birthday_wish_mail/src/Form/BirthdayWishMailSettingsForm.php
---------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is
| | Drupal\Core\Database\Database.
---------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------

FILE: .../web/modules/custom/birthday_wish_mail/birthday_wish_mail.module
---------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------
10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is
| | Drupal\Core\Routing\RouteMatchInterface.
---------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------

Steps to reproduce

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,css .

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

šŸ“Œ Task
Status

Active

Version

2.0

Component

Code

Created by

šŸ‡µšŸ‡ŖPeru alyaj2a

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @alyaj2a
  • Merge request !3Coding Standard issues - #3485151 ā†’ (Open) created by alyaj2a
  • Comment about 2 months ago ā†’
    šŸ‡µšŸ‡ŖPeru alyaj2a
  • Comment about 2 months ago ā†’
    šŸ‡®šŸ‡³India rohitrajputsahab Uttam Nagar, Delhi

    Everything seems to be going well. Nothing found related to "phpcs --standard=Drupal,DrupalPractice".

    See screenshot.

  • Comment about 2 months ago ā†’
    šŸ‡µšŸ‡­Philippines clarkssquared

    I also applied MR !3 and I confirmed that the module has no PHPCS issues

    āžœ  birthday_wish_mail git:(2.0.x) curl https://git.drupalcode.org/project/birthday_wish_mail/-/merge_requests/3.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1128    0  1128    0     0   2209      0 --:--:-- --:--:-- --:--:--  2233
patching file birthday_wish_mail.module
patching file 'src/Form/BirthdayWishMailSettingsForm.php'
āžœ  birthday_wish_mail git:(2.0.x) āœ— ..
āžœ  contrib git:(main) āœ— phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml birthday_wish_mail 
āžœ  contrib git:(main) āœ—

    RTBC +1 from me

  • Comment about 1 month ago ā†’
    šŸ‡®šŸ‡³India rohitrajputsahab Uttam Nagar, Delhi

    No issue found. Closing this ticket

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024