Coding Standard issues

Open on Drupal.org →

Created on 26 September 2024, 7 months ago

Problem/Motivation

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml .

FILE: .../web/modules/custom/prevnext/prevnext.module
------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------
10 | WARNING | [x] Unused use statement
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------

FILE: .../web/modules/custom/prevnext/src/Form/PrevNextSettingsForm.php
------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is
| | Drupal\Core\Cache\Cache.
------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------

FILE: .../web/modules/custom/prevnext/src/Plugin/Block/PrevNextBlock.php
------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------
8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is
| | Drupal\prevnext\PrevNextServiceInterface.
------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------

FILE: .../web/modules/custom/prevnext/src/Plugin/views/field/PrevNextLinks.php
------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is
| | Drupal\prevnext\PrevNextServiceInterface.
65 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 4 spaces
------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------

FILE: .../web/modules/custom/prevnext/src/PrevNextService.php
--------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------------
49 | ERROR | [ ] Parameter $type is not described in comment
54 | ERROR | [x] Separate the @param and @return sections by a blank line.
57 | ERROR | [ ] Only 1 @return tag is allowed in a function comment
--------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------

Time: 165ms; Memory: 10MB

Steps to reproduce

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml .

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task

Status

Active

Version

2.0

Component

Code

Created by

🇵🇪Peru alyaj2a

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!36Coding Standard issues
Merged
🇵🇪Peru alyaj2a
updated 7 months ago

Comments & Activities

Issue created by @alyaj2a
Comment 7 months ago →
🇵🇪Peru alyaj2a
Merge request !36Coding standard issues - #3477141 → (Merged) created by alyaj2a
Comment 7 months ago →
🇵🇪Peru alyaj2a

Comment 7 months ago →

🇵🇭Philippines clarkssquared

Hi

I applied and checked MR !36 and I confirm that it fixes all the PHPCS issues

➜  prevnext git:(2.0.x) curl https://git.drupalcode.org/project/prevnext/-/merge_requests/36.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  4304    0  4304    0     0   7123      0 --:--:-- --:--:-- --:--:--  7185
patching file prevnext.module
patching file 'src/Form/PrevNextSettingsForm.php'
patching file 'src/Plugin/Block/PrevNextBlock.php'
patching file 'src/Plugin/views/field/PrevNextLinks.php'
patching file 'src/PrevNextService.php'
➜  prevnext git:(2.0.x) ✗ ..
➜  contrib git:(2.1.x) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml prevnext 
➜  contrib git:(2.1.x) ✗

Comment 7 months ago →
System Message

astonvictor → committed 95aba0bc on 2.0.x authored by alyaj2a →
Coding standard issues - #3477141
Comment 7 months ago →
🇺🇦Ukraine AstonVictor
thanks for the patch. fixed and merged
Comment 7 months ago →
🇺🇦Ukraine AstonVictor
Comment 6 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024