🇺🇦Ukraine @AstonVictor

astonvictor → made their first commit to this issue’s fork.

seems like the pipeline reported a few bugs related to the new changes
e.g. The @covers annotation requires a fully qualified name. (line 361) in the test or Variable $transaction in isset() always exists and is not nullable. (line 562)

seems not many changes :)
+1 RTBC

tested locally. works as expected
+1 RTBC

should work for views with eck entities now.

astonvictor → made their first commit to this issue’s fork.

ok, thanks for the reply

I just saw that almost all constructor methods in the core contain comments e.g. Constructs a {Class name} object..

So, it's like optional but recommended.

Hi there,

Implemented another MR to create group links. It tries to get the group from the route and validate if the group has an enabled plugin for the selected node bundle.

I also added a config to enable/disable regular/group links.

thanks in advance

I was able to reproduce the issue on my local and the MR fixes it. thnaks
+1 RTBC

seems like all methods were updated
+1 RTBC

I left one comment. Does it make sense?

Should it be updated in other places as well?

e.g. Url::fromRoute('user.pass') in user/src/AccountForm.php or
'Try again later or <a href=":url">request a new password</a>.', [':url' => Url::fromRoute('user.pass') here in user/src/Form/UserLofinForm.php

+1 RTBC

tested locally. pretty easy to reproduce
+1 RTBC

ok, thanks for the clarification

thanks for the MR. works for me
+1 RTBC

ok, thanks for the response

it works for me for all profiles
+1 RTBC

I checked and it was updated in all the required places
+1 RTBC

works for me. thanks for your work
+1 RTBC

seems like the pipeline has some errors to resolve

thanks for the fix
+1 RTBC

It works for me, but the only question: Should we use old names (HIDDEN, CLOSED, and OPEN - all uppercase)?

similar issue - 📌 Fix LongLineDeclaration in in several core/tests/Drupal directories Needs review

similar issue - 📌 Fix LongLineDeclaration in Tests/Component RTBC

it works for me. thanks
+1 RTBC

astonvictor → made their first commit to this issue’s fork.

provided a simple patch to revert changes for my project

Fixed the link in the description
+1 RTBC

+1 RTBC

the patch works for me
+1 RTBC

+1 RTBC

+1 RTBC

astonvictor → created an issue.

astonvictor → made their first commit to this issue’s fork.

Hi there,

Added a new 'Disable destination query parameter' checkbox to disable the destination.
thanks in advance

astonvictor → made their first commit to this issue’s fork.

Hi there,

Added a new entity type field with all possible options. So, now the editor can create a link to any entity type.
The feature with bundle and form mode is still present.

I guess we should create a new release for the feature because old configs won't match new configs. e.g. a new config should contain the 'type' value. as an alternative, we can try to create an update hook.

thanks in advance

Prepared a new MR to add default values for the class field.

astonvictor → made their first commit to this issue’s fork.

astonvictor → made their first commit to this issue’s fork.

Added a new 'Override reading time' text field for nodes. The value from the field will override the output for the reading_time extra field.
It should work for both the extra field and the view field plugin.

thanks for the report
fixed in the dev version

astonvictor → made their first commit to this issue’s fork.

thanks
fixed in the dev version

The module already contains a GitLab CI file.

thanks
fixed in the dev version

Hi there,

Please, use the MR in case you want to remove the system name column, but I guess it can be useful for other users. So, it won't be removed from the module for all.

thanks in advance.

thanks
fixed in the dev version

thanks
fixed in the dev version

thanks
fixed in the dev version

thanks. fixed

fixed in the dev version

updated the file

astonvictor → created an issue.

Hi there,

Added a new text field that will alter an output for the 'reading time' extra field and view field plugin.

thanks for the report. should be fixed on the dev version.

astonvictor → made their first commit to this issue’s fork.

thanks @nagy.balint

in that case, let's wait for @g089h515r806

Hi there,

I changed the permission and implemented an update hook to grant a new permission to all roles that had the old one.

thanks in advance

provided a simple MR to validate the value.

astonvictor → created an issue.

astonvictor → made their first commit to this issue’s fork.

thanks the MR.
fixed

astonvictor → made their first commit to this issue’s fork.

Hi there,

Updated the menu item and also changed the URL from admin/config/reading-time to admin/config/content/reading-time.

thanks a lot

astonvictor → made their first commit to this issue’s fork.

astonvictor → created an issue.

Hi there,

Created a similar field formatter for file types.

astonvictor → made their first commit to this issue’s fork.

Hi there,

Prepared a simple test to check base configurations.

astonvictor → created an issue.

HI there,

seems like it works in 2.0.x version.

Steps for testing:
1. install image_url_formatter 2.0.0 & image_widget_crop 3.0.0 modules.
2. create a new image style that uses the manual crop effect.
3. configure the image field to use the crop widget on the manage form display page.
4. configure the field to use the image URL formatter on the manage display page.
4. create a new node with an image (+ crop image) and go to the node overview page.

As a result, I can see the ...?h=d5171e05&itok=Vt7zgUHe suffix.

astonvictor → made their first commit to this issue’s fork.

Hi there,

Seems like you are using an incorrect formatter. The "Image Wrapped Within Link Field" formatter comes from the Image Link Formatter → module.

The current module only renders the plain text without any links. So, you cannot add e.g. target attribute to the plain text.

thanks in advance

Hi there,

I tried to reproduce it, but it works as expected. Moreover, the module template uses {{- var -}} filter to trim empty spaces.

I can only see empty spaces if Twig debug is enabled in the services.yml file. In that case, spaces will be added to all fields. So, it's not related to the current module.

thanks in advance

Hi there,

The config schema is used to validate config values. To check it, you can use the Configuration Inspector → module (attached a screenshot with check results).

thanks in advance

astonvictor → made their first commit to this issue’s fork.

astonvictor → created an issue.

Hi there,

I implemented a simple MR to hide the system name column and add the name after the description.
✨ Provide a simple/lightweight/clean mode that's primarily only the filter Active issue can be related. It helps to show/hide some sections on the page.

thanks in advance

Hi there,

It should be possible to configure sameSite parameter via the services.yml file. It has the 'Lax' value by default in the core.services.yml file.
You can add your own value e.g.

parameters:
  session.storage.options:
    cookie_samesite: Lax