Getting following error/warnings
FILE: /app/modules/contrib/vbo_export/src/Plugin/Action/VboExportBase.php
-----------------------------------------------------------------------------
FOUND 4 ERRORS AND 1 WARNING AFFECTING 5 LINES
-----------------------------------------------------------------------------
114 | ERROR | [x] Use null coalesce operator instead of ternary operator.
120 | ERROR | [x] Use null coalesce operator instead of ternary operator.
150 | ERROR | [x] Use null coalesce operator instead of ternary operator.
156 | ERROR | [x] Use null coalesce operator instead of ternary operator.
200 | WARNING | [ ] Unused variable $rand.
-----------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------
FILE: /app/modules/contrib/vbo_export/src/Plugin/Action/VboExportCsv.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
35 | ERROR | [x] Use null coalesce operator instead of ternary operator.
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
FILE: /app/modules/contrib/vbo_export/src/Plugin/Action/VboExportPdf.php
--------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------------------
15 | ERROR | [x] There must be one blank line after the last USE statement; 0 found;
31 | ERROR | [ ] Missing @var tag in member variable comment
81 | ERROR | [x] Use null coalesce operator instead of ternary operator.
90 | ERROR | [x] Use null coalesce operator instead of ternary operator.
--------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------
FILE: /app/modules/contrib/vbo_export/src/Plugin/Action/VboExportXlsx.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------
65 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------
Time: 4.47 secs; Memory: 12MB
Run following command
phpcs --standard="Drupal,DrupalPractice" --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml modules/contrib/vbo_export/
Above error/warnings need to be fixed
4.1
Code
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
Patch #2 applied cleanly, and all errors and warnings are fixed.
Thanks
I think everything is perfect now.
So moving it to RTBC.
Thanks
liam morland → made their first commit to this issue’s fork.