Pasting should update the clipboard content rather than inserting

Okay this works for LibreOffice, but am thinking maybe https://github.com/ckeditor/ckeditor5/issues/17309 is stopping it from working from Word itself. Will see, maybe some kind soul at ckeditor side will nudge me in the right direction (or maybe that itself is the underlying issue)....

Just an FYI if anyone is using ckeditor5_paste_filter - yes you found the reason it is not working. :)

What do you mean?

Sorry, should have been more clear... this defect in footnotes causes the ckeditor5_paste_filter not to work, this patch fixes the issue!

Thanks, updated title to help others find that. I think I cannot merge this as is though without an upstream fix in CKE as I believe this fixes some scenarios but Word continues to fail.

Current state of merge request.

Just hiding patch to avoid confusion, the recommended way now in Drupal docs is downloading locally from the diff and placing eg in private patches folder within your repo

Please give a thumbs up at https://github.com/ckeditor/ckeditor5/issues/17309 to upvote the feature in Cke5 blocking solving pasting conversion.

We just hit this, reverting to footnotes 4.0.0-beta5 is what we are going to do (for now).

Can you use git bisect to figure out which commit caused this issue?

Is someone able to describe the issue here in layman's terms? I don't understand. I also don't use the ckeditor5_paste_filter module on any current projects, which might be causing me some confusion.

The title "Pasting should update the clipboard content rather than inserting"... I though Copy is what updates the clipboard, and Pasting is supposed to insert...

Basically previously the clipboard content was pasted into the editor and so any other modules or tools wanting to modify the clipboard content would not be able to.

So instead the different CKE plugins are meant to modify the clipboard contents and then let it continue on until eventually CKE Core pastes it in.

They call this the clipboard pipeline. By it's similar to drupal alter hook: run an alter and let as many modules as desired alter one after the other. Then finally continue on with the original action.

The problem though is there are two clipboard pipelines rather than one it seems which is why that upstream issue in CKE mentioned in #13 is blocking this.

@scott_euser,
I probably should have openned a new issue instead of commenting above.

The issue I noticed is that upgrading from footnotes 4.0.0-beta5 to 4.0.0-beta6 completely breaks the functionality provided by the ckeditor5_paste_filter module.

In my defense however the title of this issue mentions ckeditor5_paste_filter compatibility.

I'm not sure what the rest is about so I'll probably go ahead and create a new issue titled:

footnotes 4.0.0-beta6 regression breaks the ckeditor5_paste_filter module

The merge request is correct and it doesn't just work with LibreOffice, it works with Word also.

I brought the merge request up-to-date with 4.0.x and recompiled the source javascript into the minified one.

Tested it, happy with this!

Thanks!

We'll all be long retired with great grandchildren before CKE5 gets fixed.

Please merge this immediately!

Thanks for testing, I need to do another test run myself, there has been plenty of Clipboard Pipeline activity lately in CKE https://github.com/ckeditor/ckeditor5/blob/stable/CHANGELOG.md - perhaps they have fixed the issue via some tother route. Ideally we also get more test coverage to ensure the pipeline continues to be modify-able but need to consider a bit more... my attention has been elsewhere, thanks for you patience.

+1 RTBTC

@astonvictor what is the difference between the old merge request and the one you just opened? Which one does your RTBC apply to?

scott_euser → changed the visibility of the branch 3486079-pasting_ to hidden.

I think its the same but with less debug output, so I'll review the previous MR and hid that one. @astonvictor otherwise let me know if I missed something

Okay I retested manually at least with LibreOffice and its successful. The test coverage pass (though these are only as close as I could get to a real paste scenario so are not 100% like real pasting). Still pasting from Office365 on a windows machine does not contain and footnote data. But in both the branch and in 4.0.x this is a problem so I will not let this block merging for compatibility with paste filter.

Merged thanks

just FYI

> @astonvictor what is the difference between the old merge request and the one you just opened? Which one does your RTBC apply to?

I was not able to apply MR#63 to my project because it conflicts with the patch from ✨ Make random strings optional, to allow linking to footnotes. Active
Both MRs update the FootnotesCkeditorPluginTest.php file

thanks

astonvictor → closed merge request !86

Aha makes sense thanks!

Automatically closed - issue fixed for 2 weeks with no activity.