🇨🇦Canada @joel_osc

Oh, and in block config I added col-sm-9, col-md-9, col-lg-10... not sure if that is correct, but it ended up looking ok.

I got it to work by removing the share widget. Agree, they really should not be adding those classes. Cheers!

Typically, Will asked that all wxt issues are raised against wxt and that is why there are components for wxt_library and wxt_bootstrap on that issue queue. Let people know if this is changing.

Cool, thanks @star-szr!

Yes! I was working on it during our previous project now another client has requested it so here it is!! lol. Thanks!! One thing is that i have hard-coded the 'theme' options selector. I am not sure if we should make those more dynamic, but I think the list is fairly static. Cheers!

Thanks for the fix to the tests!!! I am not sure we need to check if description is empty - I think the main fields are the search and replace. If someone has emptied both of those then I would say that we are sure they want the row gone. Cheers and thank-you!

Adding MR with block plugin code.

joel_osc → created an issue.

Sorry, should have been more clear... this defect in footnotes causes the ckeditor5_paste_filter not to work, this patch fixes the issue!

Not sure what is going with the tests, but I have tested the plain diff and it works as long as you drush updb to update sites with any existing filters configured.

joel_osc → made their first commit to this issue’s fork.

Here is a patch to get things going! Cheers.

joel_osc → created an issue.

Just an FYI if anyone is using ckeditor5_paste_filter - yes you found the reason it is not working. :)

Thanks for looking at this @quietone. The good news is that the problem as reported seems to be fixed! Closing this issue out.

@herved thank-you for finding and fixing this - we ran into this when displaying multiple node view modes on a panels page variant. The patch fixes it.

Hope I don't offend anyone for re-opening this... it seems there is a follow-up patch that is needed.

Looks good to me, just an FYI that this will help with the GCDS / WxT theme compatibility for hybrid sites.

joel_osc → created an issue.

The patch in 13 is still the incorrect approach...

joel_osc → created an issue.

Testing complete, works well. Thanks again!

Will test now, thanks @smulvih2 and @alan.wallac for the original solution.

Have added some code similar to comment #3 to incorporate a delay - which is configurable. Having trouble creating an MR for some reason, MR url gives me 404. Maybe it was the Xmas break or the Covid... here is the diff: https://git.drupalcode.org/issue/azure_cdn_purge-3351085/-/commit/0c3c9a...

We are seeing this as well with the Azure CDN. Reach out if you want more info.

joel_osc → created an issue.

Just noticed this issue (years later, sorry!), going to close it out as outdated. Still seeing some issues with multilingual content that is using content moderation. I will open up new issues as I characterize them... thank-you for your work on this module!

@anybody - thank-you for your comments, somehow I missed them. I will take another look at the patch and if I come up with something I will add an MR. @kuldeepbarot, happy to discuss your approach and thank-you for helping out on this!

I am not sure that will work for us, since our search urls are different for each language: en/search, fr/recherche. I don't think appending a language is enough.

joel_osc → created an issue.

Changing the component.

I have created a block that provides the correct markup as well as a theme selector. The theme selection is a bit odd since as a department you can request the principle publisher to add one for you, which then would not be available in the selector until we update DrupalWxt. I am open for suggestions on that.

joel_osc → created an issue.

Tested and works as expected now! Thank-you again.

Oh cool... thank-you very much for your help!!! I will grab the latest and continue testing. Cheers.

Here is a patch that adds this feature.

joel_osc → created an issue.

Just adding the workaround patch from #2 as a patch file for composer to apply until a solution is found. Thank-you @naushunaushad.

Awesome, thank-you!

joel_osc → created an issue. See original summary → .

Noticed the same problem, thankfully found this patch which fixed it . +1 for RBTC. Thank-you @j-barnes for the patch and thanks to the maintainer of this module for saving me quite a bit of work on a project!

Done and thank-you for your help!

Tested latest dev and it works great!

Oh cool, that is a nice approach! I will give a test. Thank-you!!!

Here is a patch that seems to fix the issue.

joel_osc → created an issue.

In NodeRevisionDelete.php:

**
* {@inheritdoc}
*/
public function getCandidatesRevisions(string $content_type, int $number = PHP_INT_MAX): array {
// @todo check if the method can be improved.

If you can find a way to configure / patch the node_revision_delete module to keep published revisions then we can shut down this module.

Cheers.

Awesome, thank-you kindly!

Here is a patch that fixes the issue.

joel_osc → created an issue.

Did you add and enable the module better_normalizers?

Great patch everyone! Necessary on my site in order to use this module. I noticed that some nodes could not be found by alias, in looking at it I found the queueing code was storing paths that it had already done and checking that before queueing. They key the code used did not have the langcode of the path so I was only getting each node in one of two languages. Small fix committed above.

joel_osc → made their first commit to this issue’s fork.

The node_revision_delete module is a really great module, this module applies a lot of the same logic. The difference is that this module is content moderation state aware, so you can do things like only delete non-published historical revisions. The node_revision_delete module has no concept of content moderation which could potentially make it dangerous for moderated sites where forward revisions could be drafts and an historical revision could be your current published revision (see in getCandidatesNodes in node_revision_delete).

Cheers!

Massive one line patch here. :)

joel_osc → created an issue.

Okay, sounds great. An example would be if a user wants to export nid's 10,15,23 and all of the taxonomy references, media references with them but not the node references because they don't want any other local node updates exported other than 10,15,23. In this case you would want the ability to export nodes, but not any referenced nodes. Does this make sense?

Hi and thank-you for your work on the module!!!

I think this patch is different than the --skip-entity-type option in that it is add the ability to skip referenced entities by type. Our business requirement is that no referenced nodes are exported. I think, but am not 100% sure, that if we use --skip_entity_type=node then we wouldn't get any nodes at all? Cheers!

Patch looks good, worked for us in an odd situation the $url->access() properly failed on the French version of a custom page so the fr key was properly removed from the $link array.

Ran into this exact issue and it was as a result of the message_subscribe module... grabbing the latest dev version of it fixed the problem. This line here: #9 /var/www/html/ehss_stage/web/modules/contrib/message_subscribe/message_subscribe_email/message_subscribe_email.module(24): Drupal\flag\FlagService->getAllEntityFlaggings() in the stack trace indicates this as well. Basically the message_subscribe_email code was not checking whether or not the $flagging entity was complete before trying to get all flaggings, so on a new node you would get this error. The maintainers has since added a check for $flagging->id() before getAllEntityFlaggings() now which prevents the issue.

++1, we have more than one client requesting this feature.

Here is a patch that fixes the issue.

joel_osc → created an issue.

Just ran into this problem, patch in 139 fixed it for me! Thank-you @budalokko and @TR!

Agreed, this is really complex. On sites that use moderation we started using this module: https://www.drupal.org/project/scheduled_transitions → which works well. Maybe best thing to do would be to put a note on this project stating it that content moderation is not supported? Then this issue can be closed off.

Here is a patch that just mimics what core RSS style does, not sure if this is correct but it does seem to fix the issue.

joel_osc → created an issue.

Fixed long comment line... thx!

Not sure what happened to the first patch, here is a properly formatted one.

Here is a patch that will invoke the filters prior to linkchecking.

joel_osc → created an issue.

Sad to see you go, I have been an admirer of your contributions and work in the Drupal community for many years. Best of luck and I am sure if things change for you the community will always welcome you back with open arms.

Here is a patch that adds this functionality.

joel_osc → created an issue.

Patch is confirmed working on multiple sites... rbtc.

Awesome, thank-you!

Here is a patch that implements the translatable configuration. Cheers!

joel_osc → created an issue.

Patch works perfectly, +1 RBTC. Thank-you all.

Thanks @joseph.olstad, appreciate you bringing this to our attention!

joel_osc → created an issue.

Withdrawing this issue, code is working as designed. In case anyone else sees this error in php8.1 you may want to look at your twig and add a check to see if the field value is empty before rendering a "Text (formatted, long)" field in this manner:

  {% if not node.field_my_textarea.value is empty %}
      {% set my_processed_text = {
        '#type':   'processed_text',
        '#text':    node.field_my_textarea.value,
        '#format': 'rich_text',
      } %}
      {{ my_processed_text }}
  {% endif %}

Cheers!

Withdrawing this issue, code is working as designed. In case anyone else sees this error in php8.1 you may want to look at your twig and add a check to see if the field value is empty before rendering a "Text (formatted, long)" field in this manner:

  {% if not node.field_my_textarea.value is empty %}
      {% set my_processed_text = {
        '#type':   'processed_text',
        '#text':    node.field_my_textarea.value,
        '#format': 'rich_text',
      } %}
      {{ my_processed_text }}
  {% endif %}

Here is a patch that fixes the issue.

joel_osc → created an issue. See original summary → .

Here is a patch that fixes the issue.

joel_osc → created an issue. See original summary → .