- Issue created by @joel_osc
- Status changed to Needs review
over 1 year ago 8:24pm 20 April 2023 - Open on Drupal.org →Core: 9.5.x + Environment: PHP 7 & MySQL 5.5last update
over 1 year ago Waiting for branch to pass - 🇨🇦Canada joel_osc
Here is a patch that implements the translatable configuration. Cheers!
- Status changed to Needs work
about 1 year ago 7:32am 31 October 2023 - 🇩🇪Germany Anybody Porta Westfalica
@joel_osc this is indeed important, thank you @joel_osc
I'm not sure, if the changes to the controller are really needed and if this is best-practice. Shouldn't a .config_translation.yml do the job for the translatable config values instead?
Would you mind providing a MR and having a look at the best practices?
Happy to review.
- Status changed to Needs review
29 days ago 6:11am 20 November 2024 - 🇮🇳India kuldeepbarot
I have tried a different approach here. Instead of making the configurations translatable, I have handled it by making changes to search404Goto() method by checking if language module is enabled then append language code to the custom path.
- 🇮🇳India kuldeepbarot
Filename was not correct in https://www.drupal.org/project/search404/issues/3355484#comment-15864755 ✨ Custom search path on a multilingual site Active , hence adding a new patch.
- 🇩🇪Germany Anybody Porta Westfalica
@kuldeepbarot please use a MR instead of patches.
- 🇨🇦Canada joel_osc
I am not sure that will work for us, since our search urls are different for each language: en/search, fr/recherche. I don't think appending a language is enough.
- 🇨🇦Canada joel_osc
@anybody - thank-you for your comments, somehow I missed them. I will take another look at the patch and if I come up with something I will add an MR. @kuldeepbarot, happy to discuss your approach and thank-you for helping out on this!
- 🇮🇳India Namisha Jadhav
Refined PR #5 to work on sites with single language as well.
- 🇮🇳India kuldeepbarot
Refined #11 patch, removed extra new line after use statements.