Difference with version 2.x of Node Revision Delete?

Created on 8 February 2024, 11 months ago
Updated 14 May 2024, 7 months ago

Could it be that this module has become obsolete with the introduction of version 2.x of the Node Revision Delete module?

It looks like that version is correctly tackling large amounts of revisions, content moderation and translations.

💬 Support request
Status

Closed: won't fix

Version

1.1

Component

Miscellaneous

Created by

🇧🇪Belgium rp7

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @rp7
  • 🇨🇦Canada joel_osc

    The node_revision_delete module is a really great module, this module applies a lot of the same logic. The difference is that this module is content moderation state aware, so you can do things like only delete non-published historical revisions. The node_revision_delete module has no concept of content moderation which could potentially make it dangerous for moderated sites where forward revisions could be drafts and an historical revision could be your current published revision (see in getCandidatesNodes in node_revision_delete).

    Cheers!

  • Status changed to Fixed 8 months ago
  • 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
  • Status changed to Closed: won't fix 7 months ago
  • 🇨🇦Canada smulvih2 Canada 🍁
  • Status changed to Active 7 months ago
  • 🇧🇪Belgium rp7

    The node_revision_delete module has no concept of content moderation which could potentially make it dangerous for moderated sites where forward revisions could be drafts and an historical revision could be your current published revision (see in getCandidatesNodes in node_revision_delete).

    Could it be that you are talking about the first version of the node_revision_delete module? Because the 2.x version certainly is content moderation aware.

    I can't find a getCandidatesNodes() method in the 2.x version of the module, so you are probably talking about the first version?

  • Status changed to Closed: won't fix 7 months ago
  • 🇨🇦Canada joel_osc

    In NodeRevisionDelete.php:

    **
    * {@inheritdoc}
    */
    public function getCandidatesRevisions(string $content_type, int $number = PHP_INT_MAX): array {
    // @todo check if the method can be improved.

    If you can find a way to configure / patch the node_revision_delete module to keep published revisions then we can shut down this module.

    Cheers.

Production build 0.71.5 2024