- Issue created by @joel_osc
- Status changed to Needs review
over 1 year ago 8:21pm 7 June 2023 - last update
over 1 year ago Patch Failed to Apply - 🇨🇦Canada joel_osc
Here is a patch that will invoke the filters prior to linkchecking.
- last update
over 1 year ago Build Successful - 🇨🇦Canada joel_osc
Not sure what happened to the first patch, here is a properly formatted one.
- 🇳🇴Norway eiriksm Norway
Thanks 🙏
For starters, do you mind fixing the coding standards in your patch? 🤓
- Status changed to Needs work
over 1 year ago 7:23pm 14 June 2023 - Status changed to Needs review
over 1 year ago 8:19pm 14 June 2023 - last update
over 1 year ago Build Successful - 🇩🇪Germany Anybody Porta Westfalica
I can sadly confirm this issue. All URLs made by linkit dynamically are unaliased and therefore cause 301 redirect detection.
As linkit is widely used and also the ckeditor integration, I'd say this is a bug.
- Status changed to Needs work
4 months ago 2:21pm 4 September 2024 - 🇩🇪Germany Anybody Porta Westfalica
------ ---------------------------------------------------------------------- Line src/LinkExtractorService.php ------ ---------------------------------------------------------------------- 168 \Drupal calls should be avoided in classes, use dependency injection instead ------ ----------------------------------------------------------------------
- 🇩🇪Germany Anybody Porta Westfalica
Okay I can tell that this at least still fixes the issue with linkit. Link checking now works as expected again and has correct results.
Still some things left to be done:
- Use dependency injection
- Check why tests fail, eventually fix implementation