- Issue created by @joel_osc
- Status changed to Needs review
almost 2 years ago 8:21pm 7 June 2023 - last update
almost 2 years ago Patch Failed to Apply - π¨π¦Canada joel_osc
Here is a patch that will invoke the filters prior to linkchecking.
- last update
almost 2 years ago Build Successful - π¨π¦Canada joel_osc
Not sure what happened to the first patch, here is a properly formatted one.
- π³π΄Norway eiriksm Norway
Thanks π
For starters, do you mind fixing the coding standards in your patch? π€
- Status changed to Needs work
almost 2 years ago 7:23pm 14 June 2023 - Status changed to Needs review
almost 2 years ago 8:19pm 14 June 2023 - last update
almost 2 years ago Build Successful - π©πͺGermany Anybody Porta Westfalica
I can sadly confirm this issue. All URLs made by linkit dynamically are unaliased and therefore cause 301 redirect detection.
As linkit is widely used and also the ckeditor integration, I'd say this is a bug.
- Status changed to Needs work
8 months ago 2:21pm 4 September 2024 - π©πͺGermany Anybody Porta Westfalica
------ ---------------------------------------------------------------------- Line src/LinkExtractorService.php ------ ---------------------------------------------------------------------- 168 \Drupal calls should be avoided in classes, use dependency injection instead ------ ----------------------------------------------------------------------
- π©πͺGermany Anybody Porta Westfalica
Okay I can tell that this at least still fixes the issue with linkit. Link checking now works as expected again and has correct results.
Still some things left to be done:
- Use dependency injection
- Check why tests fail, eventually fix implementation
- πΊπΈUnited States timwood Rockville, Maryland
Is this not related to the linkchecker settings under "Link Extraction" > Text formats for link extraction (side note, this should probably be labeled "Text filters")? If you check the following filter then the Linkit filter will not run and process your links during extraction.
Linkit URL converter
Updates links inserted by Linkit to point to entity URL aliases.