Fix the issues reported by phpcs

➜ contrib ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig layout_builder_paragraphs FILE: /Users/jetherparadero/Contributions/recommended-project/web/modules/contrib/layout_builder_paragraphs/layout_builder_paragraphs.api.php --------------------------------------------------------------------------------------------------------------------------------------------- FOUND 24 ERRORS AFFECTING 10 LINES --------------------------------------------------------------------------------------------------------------------------------------------- 10 | ERROR | [x] There must be exactly one blank line before the tags in a doc comment 12 | ERROR | [x] Separate the @param and @return sections by a blank line. 12 | ERROR | [ ] Description for the @return value is missing 16 | ERROR | [x] Expected 1 space after closing parenthesis; found "->hasPermission('some privilege permission') " 18 | ERROR | [x] Expected one space after the comma, 31 found 18 | ERROR | [x] Comments may not appear after statements 18 | ERROR | [x] Inline comments must start with a capital letter 18 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 19 | ERROR | [x] Expected one space after the comma, 24 found 19 | ERROR | [x] Comments may not appear after statements 19 | ERROR | [x] Inline comments must start with a capital letter 19 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 20 | ERROR | [x] Expected one space after the comma, 22 found 20 | ERROR | [x] Comments may not appear after statements 20 | ERROR | [x] Inline comments must start with a capital letter 20 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 27 | ERROR | [x] There must be exactly one blank line before the tags in a doc comment 29 | ERROR | [x] Separate the @param and @return sections by a blank line. 29 | ERROR | [ ] Description for the @return value is missing 34 | ERROR | [x] Expected one space after the comma, 24 found 34 | ERROR | [x] Comments may not appear after statements 34 | ERROR | [x] Inline comments must start with a capital letter 34 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 37 | ERROR | [x] Inline control structures are not allowed --------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 22 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Contributions/recommended-project/web/modules/contrib/layout_builder_paragraphs/layout_builder_paragraphs.module ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 72 ERRORS AND 5 WARNINGS AFFECTING 27 LINES ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 11 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Language\LanguageInterface. 18 | WARNING | [ ] All constants defined by a module must be prefixed with the module's name, expected "LAYOUT_BUILDER_PARAGRAPHS_PARAGRAPH_FIELD" but found "PARAGRAPH_FIELD" 18 | WARNING | [ ] Global constants should not be used, move it to a class or interface 30 | ERROR | [x] Expected one space after the comma, 26 found 30 | ERROR | [x] Comments may not appear after statements 30 | ERROR | [x] Inline comments must start with a capital letter 30 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 31 | ERROR | [x] Expected one space after the comma, 26 found 31 | ERROR | [x] Comments may not appear after statements 31 | ERROR | [x] Inline comments must start with a capital letter 31 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 32 | ERROR | [x] Expected one space after the comma, 22 found 32 | ERROR | [x] Comments may not appear after statements 32 | ERROR | [x] Inline comments must start with a capital letter 32 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 33 | ERROR | [x] Expected one space after the comma, 11 found 33 | ERROR | [x] Comments may not appear after statements 33 | ERROR | [x] Inline comments must start with a capital letter 33 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 34 | ERROR | [x] Expected one space after the comma, 12 found 34 | ERROR | [x] Comments may not appear after statements 34 | ERROR | [x] Inline comments must start with a capital letter 34 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 35 | ERROR | [x] Expected one space after the comma, 5 found 35 | ERROR | [x] Comments may not appear after statements 35 | ERROR | [x] Inline comments must start with a capital letter 35 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 36 | ERROR | [x] Expected one space after the comma, 10 found 36 | ERROR | [x] Comments may not appear after statements 36 | ERROR | [x] Inline comments must start with a capital letter 36 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 37 | ERROR | [x] Expected one space after the comma, 10 found 37 | ERROR | [x] Comments may not appear after statements 37 | ERROR | [x] Inline comments must start with a capital letter 37 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 38 | ERROR | [x] Expected one space after the comma, 33 found 38 | ERROR | [x] Comments may not appear after statements 38 | ERROR | [x] Inline comments must start with a capital letter 38 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 39 | ERROR | [x] Expected one space after the comma, 26 found 39 | ERROR | [x] Comments may not appear after statements 39 | ERROR | [x] Inline comments must start with a capital letter 39 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 40 | ERROR | [x] Expected one space after the comma, 24 found 40 | ERROR | [x] Comments may not appear after statements 40 | ERROR | [x] Inline comments must start with a capital letter 40 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 41 | ERROR | [x] Expected one space after the comma, 24 found 41 | ERROR | [x] Comments may not appear after statements 41 | ERROR | [x] Inline comments must start with a capital letter 41 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 42 | ERROR | [x] Expected one space after the comma, 12 found 42 | ERROR | [x] Comments may not appear after statements 42 | ERROR | [x] Inline comments must start with a capital letter 42 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 43 | ERROR | [x] Expected one space after the comma, 26 found 43 | ERROR | [x] Comments may not appear after statements 43 | ERROR | [x] Inline comments must start with a capital letter 43 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 44 | ERROR | [x] Expected one space after the comma, 11 found 44 | ERROR | [x] Comments may not appear after statements 44 | ERROR | [x] Inline comments must start with a capital letter 44 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 65 | ERROR | [x] Expected one space after the comma, 5 found 65 | ERROR | [x] Comments may not appear after statements 65 | ERROR | [x] Inline comments must start with a capital letter 65 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 86 | WARNING | [x] '@TODO: consider nulling this logic IF paragraphs_asymmetric_translation_widgets' should match the format '@todo Fix problem X here.' 88 | ERROR | [x] Inline control structures are not allowed 117 | ERROR | [x] Inline control structures are not allowed 154 | WARNING | [ ] Format should be "* Implements hook_foo().", "* Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements hook_foo_BAR_ID_bar() for | | xyz-bar.html.twig.", "* Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "* Implements hook_foo_BAR_ID_bar() for block templates." 155 | WARNING | [x] '@TODO: check if this is invalid. The code is taken from' should match the format '@todo Fix problem X here.' 155 | ERROR | [x] There must be exactly one blank line before the tags in a doc comment 183 | ERROR | [x] Inline control structures are not allowed 209 | ERROR | [x] Inline control structures are not allowed 212 | ERROR | [x] Inline control structures are not allowed 223 | ERROR | [x] Inline control structures are not allowed ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 74 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Contributions/recommended-project/web/modules/contrib/layout_builder_paragraphs/src/Form/AddParagraphForm.php ----------------------------------------------------------------------------------------------------------------------------------------- FOUND 6 ERRORS AND 11 WARNINGS AFFECTING 15 LINES ----------------------------------------------------------------------------------------------------------------------------------------- 6 | WARNING | [x] Unused use statement 10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\Entity\EntityFormDisplay. 20 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name 24 | WARNING | [ ] There must be no blank line following an inline comment 24 | ERROR | [x] Comments may not appear after statements 62 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 82 | WARNING | [ ] Unused variable $contexts. 95 | ERROR | [x] Inline control structures are not allowed 115 | WARNING | [x] '@TODO: find out if this is necessary?' should match the format '@todo Fix problem X here.' 153 | WARNING | [ ] Unused variable $key. 154 | WARNING | [x] '@TODO: Validate fields.' should match the format '@todo Fix problem X here.' 174 | WARNING | [x] '@TODO: don't hardcode the field as field_contents.' should match the format '@todo Fix problem X here.' 183 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters 188 | WARNING | [x] There must be no blank line following an inline comment 188 | WARNING | [ ] There must be no blank line following an inline comment 206 | ERROR | [x] Expected 1 blank line after function; 0 found 207 | ERROR | [x] The closing brace for the class must have an empty line before it ----------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 11 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Contributions/recommended-project/web/modules/contrib/layout_builder_paragraphs/src/Form/ModalMoveBlockForm.php ------------------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------- 13 | ERROR | [x] Expected 1 space after class name; 2 found 13 | ERROR | [x] Expected 1 space before extends keyword; 2 found ------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Contributions/recommended-project/web/modules/contrib/layout_builder_paragraphs/src/Element/ModalLayoutBuilder.php ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES ---------------------------------------------------------------------------------------------------------------------------------------------- 3 | ERROR | [x] Namespaced classes, interfaces and traits should not begin with a file doc comment 4 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters 5 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Contributions/recommended-project/web/modules/contrib/layout_builder_paragraphs/src/Controller/ChooseParagraphController.php ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 13 ERRORS AND 18 WARNINGS AFFECTING 26 LINES ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 6 | WARNING | [x] Unused use statement 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Ajax\AjaxHelperTrait. 7 | WARNING | [x] Unused use statement 8 | WARNING | [x] Unused use statement 9 | WARNING | [x] Unused use statement 10 | WARNING | [x] Unused use statement 11 | WARNING | [x] Unused use statement 13 | WARNING | [x] Unused use statement 14 | WARNING | [x] Unused use statement 16 | WARNING | [x] Unused use statement 17 | WARNING | [x] Unused use statement 31 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 38 | ERROR | [x] Inline control structures are not allowed 40 | WARNING | [x] '@TODO: make this more generic. E.g. check that that least there is' should match the format '@todo Fix problem X here.' 43 | ERROR | [x] Inline control structures are not allowed 46 | ERROR | [x] Inline control structures are not allowed 62 | WARNING | [x] '@TODO: make this more generic.' should match the format '@todo Fix problem X here.' 66 | ERROR | [x] Expected one space after the comma, 2 found 66 | ERROR | [x] Comments may not appear after statements 67 | WARNING | [ ] Line exceeds 80 characters; contains 93 characters 68 | WARNING | [x] '@TODO: make this more generic. E.g. check that the user has access' should match the format '@todo Fix problem X here.' 84 | ERROR | [x] Closing brace indented incorrectly; expected 3 spaces, found 2 100 | WARNING | [x] '@TODO: check the access to various paragraph types, refer to paragraphs_type_permissions module.' should match the format '@todo Fix problem X here.' 100 | WARNING | [x] There must be no blank line following an inline comment 100 | WARNING | [ ] There must be no blank line following an inline comment 113 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 124 | WARNING | [x] '@TODO: To use the paragraph form in modal, we need to solve the issue' should match the format '@todo Fix problem X here.' 167 | ERROR | [x] Expected one space after the comma, 2 found 167 | ERROR | [x] Comments may not appear after statements 185 | ERROR | [x] Expected 1 blank line after function; 0 found 186 | ERROR | [x] The closing brace for the class must have an empty line before it ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 29 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Contributions/recommended-project/web/modules/contrib/layout_builder_paragraphs/src/Controller/ModalLayoutRebuildTrait.php ------------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------------------------------------ 7 | WARNING | [x] Unused use statement 9 | WARNING | [x] Unused use statement ------------------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/jetherparadero/Contributions/recommended-project/web/modules/contrib/layout_builder_paragraphs/src/Routing/RouteSubscriber.php ------------------------------------------------------------------------------------------------------------------------------------------- FOUND 5 ERRORS AND 8 WARNINGS AFFECTING 8 LINES ------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Inline comments must start with a capital letter 9 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 30 | WARNING | [ ] Line exceeds 80 characters; contains 89 characters 30 | ERROR | [ ] Comment indentation error, expected only 1 spaces 31 | WARNING | [x] There must be no blank line following an inline comment 31 | WARNING | [ ] There must be no blank line following an inline comment 35 | WARNING | [ ] Line exceeds 80 characters; contains 92 characters 35 | ERROR | [ ] Comment indentation error, expected only 1 spaces 36 | WARNING | [x] There must be no blank line following an inline comment 36 | WARNING | [ ] There must be no blank line following an inline comment 40 | ERROR | [ ] Comment indentation error, expected only 1 spaces 41 | WARNING | [x] There must be no blank line following an inline comment 41 | WARNING | [ ] There must be no blank line following an inline comment ------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------- Time: 454ms; Memory: 10MB

Comments & Activities

Issue created by @paraderojether
Merge request !23469090: Fix the phpcs issues → (Open) created by paraderojether
Comment 8 months ago →
🇵🇭Philippines paraderojether
I fixed the issues reported by phpcs, please review.

Thank you.
Issue was unassigned.
Status changed to Needs review 8 months ago6:01am 20 August 2024
Comment 8 months ago →
🇵🇭Philippines paraderojether
Status changed to Needs work 5 months ago5:51am 6 November 2024

Comment 5 months ago →

🇮🇳India chandansha

I have tested MR 2. As i can see still some error and warning are not resolved.

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig .

FILE: /home/chandansha/docker/d10contro/web/modules/custom/layout_builder_paragraphs-3469090/layout_builder_paragraphs.module
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 18 | WARNING | All constants defined by a module must be prefixed with the module's name, expected "LAYOUT_BUILDER_PARAGRAPHS_PARAGRAPH_FIELD" but found "PARAGRAPH_FIELD"
 18 | WARNING | Global constants should not be used, move it to a class or interface
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/chandansha/docker/d10contro/web/modules/custom/layout_builder_paragraphs-3469090/src/Form/ModalRemoveBlockForm.php
------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------
 3 | ERROR | [x] Expected strict_types=1, found strict_types = 1.
------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------


FILE: /home/chandansha/docker/d10contro/web/modules/custom/layout_builder_paragraphs-3469090/src/Form/ModalAddBlockForm.php
---------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------
 3 | ERROR | [x] Expected strict_types=1, found strict_types = 1.
---------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------


FILE: /home/chandansha/docker/d10contro/web/modules/custom/layout_builder_paragraphs-3469090/src/Form/ModalMoveBlockForm.php
----------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------
 3 | ERROR | [x] Expected strict_types=1, found strict_types = 1.
----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------


FILE: /home/chandansha/docker/d10contro/web/modules/custom/layout_builder_paragraphs-3469090/src/Form/ModalUpdateBlockForm.php
------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------
 3 | ERROR | [x] Expected strict_types=1, found strict_types = 1.
------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------


FILE: /home/chandansha/docker/d10contro/web/modules/custom/layout_builder_paragraphs-3469090/src/Form/AddParagraphForm.php
--------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------------------
  19 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
 155 | WARNING | Unused variable $value.
--------------------------------------------------------------------------------------------------------------------------


FILE: /home/chandansha/docker/d10contro/web/modules/custom/layout_builder_paragraphs-3469090/src/Form/ModalRemoveSectionForm.php
--------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------
 3 | ERROR | [x] Expected strict_types=1, found strict_types = 1.
--------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------


FILE: /home/chandansha/docker/d10contro/web/modules/custom/layout_builder_paragraphs-3469090/src/Element/ModalLayoutBuilder.php
-------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------
 3 | ERROR | [x] Expected strict_types=1, found strict_types = 1.
-------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------


FILE: /home/chandansha/docker/d10contro/web/modules/custom/layout_builder_paragraphs-3469090/src/Controller/ModalMoveBlockController.php
----------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------
 3 | ERROR | [x] Expected strict_types=1, found strict_types = 1.
----------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/chandansha/docker/d10contro/web/modules/custom/layout_builder_paragraphs-3469090/src/Controller/ModalLayoutRebuildTrait.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------
 3 | ERROR | [x] Expected strict_types=1, found strict_types = 1.
---------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/chandansha/docker/d10contro/web/modules/custom/layout_builder_paragraphs-3469090/layout_builder_paragraphs.api.php
------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
------------------------------------------------------------------------------------------------------------------------------
 14 | ERROR | [ ] Description for the @return value is missing
 19 | ERROR | [x] Object operator not indented correctly; expected 4 spaces but found 6
 37 | ERROR | [ ] Description for the @return value is missing
------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------

Time: 175ms; Memory: 10MB

Comment 5 months ago →
dhruv.mittal
working on it
Comment 5 months ago →
dhruv.mittal

Comment 4 months ago →

🇵🇭Philippines clarkssquared

Hi dhruv

I applied the updated MR !2 and this is the remaining PHPCS issues that phpcs reported.

➜  layout_builder_paragraphs git:(1.0.x) curl https://git.drupalcode.org/project/layout_builder_paragraphs/-/merge_requests/2.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 26498    0 26498    0     0  45536      0 --:--:-- --:--:-- --:--:-- 46163
patching file layout_builder_paragraphs.api.php
patching file layout_builder_paragraphs.module
patching file 'src/Controller/ChooseParagraphController.php'
patching file 'src/Controller/ModalLayoutRebuildTrait.php'
patching file 'src/Controller/ModalMoveBlockController.php'
patching file 'src/Element/ModalLayoutBuilder.php'
patching file 'src/Form/AddParagraphForm.php'
patching file 'src/Form/ModalAddBlockForm.php'
patching file 'src/Form/ModalMoveBlockForm.php'
patching file 'src/Form/ModalRemoveBlockForm.php'
patching file 'src/Form/ModalRemoveSectionForm.php'
patching file 'src/Form/ModalUpdateBlockForm.php'
patching file 'src/Routing/RouteSubscriber.php'
➜  layout_builder_paragraphs git:(1.0.x) ✗ ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml layout_builder_paragraphs 

FILE: ...odules/contrib/layout_builder_paragraphs/layout_builder_paragraphs.api.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 20 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...modules/contrib/layout_builder_paragraphs/layout_builder_paragraphs.module
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------
 18 | WARNING | All constants defined by a module must be prefixed with the
    |         | module's name, expected
    |         | "LAYOUT_BUILDER_PARAGRAPHS_PARAGRAPH_FIELD" but found
    |         | "PARAGRAPH_FIELD"
 18 | WARNING | Global constants should not be used, move it to a class or
    |         | interface
--------------------------------------------------------------------------------


FILE: ...eb/modules/contrib/layout_builder_paragraphs/src/Form/AddParagraphForm.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 155 | WARNING | Unused variable $value.
--------------------------------------------------------------------------------

Time: 329ms; Memory: 10MB

➜  contrib git:(main) ✗

Comment 4 months ago →
🇨🇦Canada imustakim Canada
Comment 4 months ago →
🇨🇦Canada imustakim Canada
First commit to issue fork.
Comment 4 months ago →
shubham_pareek_19
As pipeline is failing so moving it to NW.

Fix the issues reported by phpcs

Merge Requests

!2Fix the issues reported by phpcs
Open

Comments & Activities

Fix the issues reported by phpcs

Merge Requests

!2Fix the issues reported by phpcsOpen

Comments & Activities

!2Fix the issues reported by phpcs
Open