I have try to apply patch but it will throw an error like "foreach() argument must be of type array|object, string given".
For reference i have attached Screen Shot.
Thanks!!
I tryed to fixed documents.Please review and let me if i am wrong to fixed it.
Thanks!!
chandansha → made their first commit to this issue’s fork.
I have tested MR 6. it look good.
i moved it to RTBC+1.
THANKS!!
Please have a look i have try to fix the issue.let me know if i am wrong to fix this issue.
Thanks!
Please have a look i try to fixed issue using above reference and let me know if you find any issue.
Thanks!!
chandansha → made their first commit to this issue’s fork.
chandansha → made their first commit to this issue’s fork.
I have tested MR 5. There is still some of error pending.
FILE: /home/chandansha/docker/d10contro/web/modules/custom/guest_suite-3485846/src/Form/SettingsForm.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------------------------
83 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
157 | ERROR | Missing parameter comment
------------------------------------------------------------------------------------------------------------------------------------------
FILE: /home/chandansha/docker/d10contro/web/modules/custom/guest_suite-3485846/src/Cron.php
---------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------
48 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
---------------------------------------------------------------------------------------------
Time: 396ms; Memory: 12MB
Thanks!!
I have tested MR 77. Now button are look good.
for reference i attached Screen Shots.
Thanks!
I have tested MR 2. As i can see still some error and warning are not resolved.
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig .
FILE: /home/chandansha/docker/d10contro/web/modules/custom/layout_builder_paragraphs-3469090/layout_builder_paragraphs.module
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
18 | WARNING | All constants defined by a module must be prefixed with the module's name, expected "LAYOUT_BUILDER_PARAGRAPHS_PARAGRAPH_FIELD" but found "PARAGRAPH_FIELD"
18 | WARNING | Global constants should not be used, move it to a class or interface
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /home/chandansha/docker/d10contro/web/modules/custom/layout_builder_paragraphs-3469090/src/Form/ModalRemoveBlockForm.php
------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------
3 | ERROR | [x] Expected strict_types=1, found strict_types = 1.
------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------
FILE: /home/chandansha/docker/d10contro/web/modules/custom/layout_builder_paragraphs-3469090/src/Form/ModalAddBlockForm.php
---------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------
3 | ERROR | [x] Expected strict_types=1, found strict_types = 1.
---------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------
FILE: /home/chandansha/docker/d10contro/web/modules/custom/layout_builder_paragraphs-3469090/src/Form/ModalMoveBlockForm.php
----------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------
3 | ERROR | [x] Expected strict_types=1, found strict_types = 1.
----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------
FILE: /home/chandansha/docker/d10contro/web/modules/custom/layout_builder_paragraphs-3469090/src/Form/ModalUpdateBlockForm.php
------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------
3 | ERROR | [x] Expected strict_types=1, found strict_types = 1.
------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------
FILE: /home/chandansha/docker/d10contro/web/modules/custom/layout_builder_paragraphs-3469090/src/Form/AddParagraphForm.php
--------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------------------
19 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
155 | WARNING | Unused variable $value.
--------------------------------------------------------------------------------------------------------------------------
FILE: /home/chandansha/docker/d10contro/web/modules/custom/layout_builder_paragraphs-3469090/src/Form/ModalRemoveSectionForm.php
--------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------
3 | ERROR | [x] Expected strict_types=1, found strict_types = 1.
--------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------
FILE: /home/chandansha/docker/d10contro/web/modules/custom/layout_builder_paragraphs-3469090/src/Element/ModalLayoutBuilder.php
-------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------
3 | ERROR | [x] Expected strict_types=1, found strict_types = 1.
-------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------
FILE: /home/chandansha/docker/d10contro/web/modules/custom/layout_builder_paragraphs-3469090/src/Controller/ModalMoveBlockController.php
----------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------
3 | ERROR | [x] Expected strict_types=1, found strict_types = 1.
----------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------
FILE: /home/chandansha/docker/d10contro/web/modules/custom/layout_builder_paragraphs-3469090/src/Controller/ModalLayoutRebuildTrait.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------
3 | ERROR | [x] Expected strict_types=1, found strict_types = 1.
---------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------
FILE: /home/chandansha/docker/d10contro/web/modules/custom/layout_builder_paragraphs-3469090/layout_builder_paragraphs.api.php
------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
------------------------------------------------------------------------------------------------------------------------------
14 | ERROR | [ ] Description for the @return value is missing
19 | ERROR | [x] Object operator not indented correctly; expected 4 spaces but found 6
37 | ERROR | [ ] Description for the @return value is missing
------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------
Time: 175ms; Memory: 10MB
I have tested MR 14. It is working well for reference i attached video.
Thanks!
I try to resolve issue please review.
Thanks!!
chandansha → made their first commit to this issue’s fork.
I have tested MR 17. Now page accessible.
I move it to RTBC.
THANKS!!
I have tested #2 patch and it's working well. I moved it to RTBC.
Thanks!!
I have tested #2 patch And it's working for reference i attached Screen shots.
Thanks!
Hello @monaw,
Could you please review once my steps. i followed below i did not get any kind of error.
1.Take pull above branch.
2. installed module.
3. created video content type and add new video field.
4. Change form settings and display settings.
5. Created new content and add video.
Thanks!!
chandansha → made their first commit to this issue’s fork.
chandansha → made their first commit to this issue’s fork.
I have created MR.
Please review once.
Thanks!!
chandansha → made their first commit to this issue’s fork.
I have created MR.
Please review once.
Thanks!!
chandansha → made their first commit to this issue’s fork.
I have checked #3 Pipeline job `phpunit` now all job passed successfully except phpunit (next major) it still throwing some error.
so if we want only phpunit job passed cleanly then we can move it to RTBC.
Thanks!!
i have checked MR 19. Now page is accesible.
Thanks!!
i have checked MR 9. Now pagination is styled.
Attached Screen shots for refference.
Hii realityloop,
I've tried to reproduce the issue but am unable to reproduce it.
Please share detailed steps to reproduce the issue
steps i followed
1. pull 3468825-deprecated-function-strpos branch in my local.
2. change it main branch which is 2.x
3. enabled module
4. check Recent log messages.
@ankitv18 i have checked pipeline it is fixed but in my local i found above issue.
i have tested MR 26 and run phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,js,info,txt,md,yml,twig . this command i found some phpcs issue.
also, pipeline failed test stage.
FILE: /home/chandansha/docker/testd10/web/modules/custom/ohdear_integration-3469661/README.md
---------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------
96 | WARNING | Line exceeds 80 characters; contains 88 characters
100 | WARNING | Line exceeds 80 characters; contains 84 characters
---------------------------------------------------------------------------------------------
FILE: /home/chandansha/docker/testd10/web/modules/custom/ohdear_integration-3469661/ohdear_integration.services.yml
-------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------
22 | ERROR | [x] Expected 1 newline at end of file; 2 found
-------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------
FILE: /home/chandansha/docker/testd10/web/modules/custom/ohdear_integration-3469661/ohdear_integration.routing.yml
------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------
7 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
------------------------------------------------------------------------------------------------------------------
Time: 276ms; Memory: 12MB
i have tested MR 17.Now module is compatible for Drupal 11.
i move it to RTBC.
thanks!!
i have fixed #11 listed issues. Find and resolve issues which is provided command in #11.
Chandansha → made their first commit to this issue’s fork.
i checked 3446259-resolve-php-issue branch and find theme drupal version 8. if i am not wrong. so, you are created 8 version branch and here you selected 2.0.1 version.
please pin me if i am wrong.
Thanks!!
I have tested MR 19. Now content image size is good according to page.
I move it to RTBC.
THANKS!!
I have tested MR 18 and check dependencies indentation missing one space now it is fixed as per needed indentation.
also eslint is green.
i moved it to RTBC.
THANKS!!
I have tested MR 19. Now link open correct page.
i move it to RTBC.
THANKS!!
i have tested 8.x-2.x and 3462773-lockstatus-is-deprecated branch i did not find any error in log page.
steps i followed
1. checkout 8.x-2.x branch and install module.
2. check Recent log messages page.
3. same as checkout 3462773-lockstatus-is-deprecated branch.
i attached Screenshot for refferece.
Thanks!!
@D34dMan,
Sorry, I just check this module is Install in drupal 11 or not.
I have tested Fixed Block Content version 8.x-1.3 in drupal version 10.3.2 but i could not get any error on edit page or Recent log page.
could you please guide steps if i am wrong. for refference i attached mp4 file.
Thanks!!
I have tested #3 Patch. Now module compatible for drupal 11.
I move it to RTBC.
THANKS!!
thejimbirch → credited Chandansha → .
I have tested MR 9. i could not get same error but issue is fixed now.
i have shared refferenced images.
RTBC+1
Thanks!!
I have tested MR 8. Now Button styled look good.
I moved it to RTBC.
i noticed one things which is your style text consider white color and once review my Screen shot it's consider blue color why this happening?
THANKS!!
I have fixed all coding standard issue using this command :-
phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,js,css,info
which is mention in notes.md file.
please review.
Thanks!!
I have fixed Drupal 11 compatibility issue.
please review i attached ScreenShots for refference.
Thanks!!
Chandansha → made their first commit to this issue’s fork.
Chandansha → made their first commit to this issue’s fork.
I have tested MR 3. Now Jquery/once issue resolve.
I move it to RTBC.
THANKS!!
I have created MR and fixed table style issue.
please review.
Chandansha → made their first commit to this issue’s fork.
I have fixed deprecated function error.
Please review.
Thanks!!
Chandansha → made their first commit to this issue’s fork.
Hello @mfb ,
i did not face same error like you can say. could please verify my step. if i am wrong please guide me to reproduced error.
1. setup project using 3466462-deprecated-function-explode this branch.
2. create file field in basic page and set file extension foobaz, mp3.
3. create node and upload mp3 file.
4. open node in front page. (i can't see error).
5. Again i try another way like create view for basic page and render file field and open that page still i can't see error.
Can you please provide proper steps to reproduced error
Thanks!!
Chandansha → made their first commit to this issue’s fork.
I have tested MR 10. Now twitter logo change to X.
I moved it to RTBC.
THANKS!!
I have tested MR 2. Now pagination aligned.
I moved it to RTBC.
THANKS!!
i have apply MR 3. Now button style is good.
I moved it to RTBC.
THANKS!!
i have tested MR 6. Now checkbox is looking well.
A suggestion from my side is that you can make all the above checkboxes like contact checkboxes?
THANKS!!
I have tested MR 3. IN Drupal 10.3.1.
Now link Pagespeed accessibility warning removed.
I moved it to RTBC.
THANKS!!
I have tested MR 39. in drupal 10.3.1.
Logo show properly.
I moved it to RTBC.
Chandansha → made their first commit to this issue’s fork.
I have tested MR 3 in Drupal 10.3.0 version.
Now Parent white color is coming.
I moved it to RTBC.
THANKS!!
I have tested MR 12 in Drupal 10.3.1 version.
Below steps i mention how did i reviewed.
1. Take pull of decorx-3464406 branch.
2. checkout 1.0.X to reproduced issue.
3. Review issue. Then
4. Checkout decorx-3464406 branch.
5. Review Bullet link.
i attached image for refference.
I moved it to RTBC.
THANKS!!
I have tested MR 11 in Drupal 8.9.20 version.
Below steps i mention how did i reviewed.
1. Take pull of style-submenu branch.
2. checkout 8.x-1.2 for reproduced issue.
3. Create testing menu.
4. Checkout style-submenu branch.
5. Review Menu.
i attached video for refferenced.
I moved it to RTBC.
THANKS!!
I've tested MR 8872 with the help of View live preview link.
i attached the video for refference.
I move it to RTBC.
THANKS!!
I have tested #2 patch. Now Page is open without error.
I moved it to RTBC.
One more thing i added when i apply the patch show Warning which i mention in patch-warning image.
Let me know it is normal or major.
THANKS.
I have tested MR 5. Now Error message visible well.
I moved it to RTBC.
THANKS!!
as per #9 i created new PR with small changes.
let me know now it is mergebal.
Thanks!!
i have tested ablecssfixed-3405257-2.patch. Now table styling is looking well.
i moved it to RTBC.
THANKS!!
i have reviewed MR 8869. Check comment now it will correct.
i moved it to RTBC.
THANKS!!
I have thoroughly reviewed MR !12 and can confirm that it resolves all the PHPCS issues.
i moved it to RTBC.
THANKS!!
Thank you @smustgrave for guidance.
I understand the concerns about credit farming tickets. Next time, I'll focus on mentoring newer users or tackling more complex tickets for more meaningful contributions.
Thanks!!
I have tested MR2. Now configure link available.
I moved it to RTBC.
THANKS!!
Chandansha → made their first commit to this issue’s fork.
I have fixed remaining errors.
Please review again.
Thanks.!!
I have fixed remaining errors.
Please review again.
Thanks.!!
Chandansha → made their first commit to this issue’s fork.
I HAVE fixed remaining warnings.
Kindly review again.
Thanks!!
i have tested MR 53. i FOUND SOME WARNING. i fixed all of warning using PHPCBF COMMAND.
Thanks!!
Chandansha → made their first commit to this issue’s fork.
I have tested MR 5.Now configure link is available.
I move it to RTBC.
THANKS!
I have tested MR 8816. Now unnecessary link tag removed.
I moved it to RTBC.
THANKS!!
Hello @sourojeetpaul,
When i pull it from 3412174-strpos_issue and check in my local i did not find any conflict changes that's why i created new Branch and created my changes in new branch.
i followed steps to resolve conflict.
1. Take pull from 3412174-strpos_issue.
2. Paste command which available in show command button.
3. Click on overview tab.
4. And click on Resolve locally link
5. i pasted all command which provide in this link.
Thanks!!
Hii @sarwan_verma,
I have tested MR 4. When i install module it will through below error.
Did you check Module after fixing all error and warnings.
Error: Call to undefined method Drupal\simple_currency_converter\CurrencyConverter::t() in Drupal\simple_currency_converter\CurrencyConverter->getSupplyCountryInfo() (line 69 of modules/custom/simple_currency_converter-3462250/src/CurrencyConverter.php).
Thanks!!