please review my small contribute if i am wrong please guide me.
Thanks!!
Chandansha → made their first commit to this issue’s fork.
Chandansha → created an issue.
I have tested MR 1 and cannot find any phpcs issue so I move forward to RTBC.
I have tested MR 12 and cannot find any phpcs issue so I move forward to RTBC.
In above phpcs command js extension was missing so found issues with js files kindly fix the issues.
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,js,info,txt,md,yml,twig .
FILE: /home/chandansha/docker/testd9/web/modules/custom/color-3443370/preview.js
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
41 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: /home/chandansha/docker/testd9/web/modules/custom/color-3443370/preview.es6.js
------------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 3 LINES
------------------------------------------------------------------------------------
68 | ERROR | [x] Expected 1 space before "-"; 0 found
68 | ERROR | [x] Expected 1 space after "-"; 0 found
68 | ERROR | [x] Expected 1 space before "="; 0 found
68 | ERROR | [x] Expected 1 space after "="; 0 found
75 | ERROR | [x] Expected 1 space before "-"; 0 found
75 | ERROR | [x] Expected 1 space after "-"; 0 found
75 | ERROR | [x] Expected 1 space before "="; 0 found
75 | ERROR | [x] Expected 1 space after "="; 0 found
88 | ERROR | [x] Expected 1 space before "-"; 0 found
88 | ERROR | [x] Expected 1 space after "-"; 0 found
------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 10 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------
FILE: /home/chandansha/docker/testd9/web/modules/custom/color-3443370/color.es6.js
----------------------------------------------------------------------------------------------
FOUND 44 ERRORS AFFECTING 16 LINES
----------------------------------------------------------------------------------------------
30 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
148 | ERROR | [x] Whitespace found before second semicolon of FOR loop
157 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
159 | ERROR | [x] Whitespace found before second semicolon of FOR loop
168 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
186 | ERROR | [x] Expected 1 space before "<"; 0 found
186 | ERROR | [x] Expected 1 space after "<"; 0 found
186 | ERROR | [x] Expected 1 space before "="; 0 found
186 | ERROR | [x] Expected 1 space after "="; 0 found
186 | ERROR | [x] Expected 1 space before ">"; 0 found
186 | ERROR | [x] Expected 1 space after ">"; 0 found
186 | ERROR | [x] Expected 1 space before "<"; 0 found
186 | ERROR | [x] Expected 1 space after "<"; 0 found
186 | ERROR | [x] Expected 1 space before "/"; 0 found
186 | ERROR | [x] Expected 1 space after "/"; 0 found
186 | ERROR | [x] Expected 1 space before ">"; 0 found
186 | ERROR | [x] Expected 1 space after ">"; 0 found
188 | ERROR | [x] Expected 1 space before "-"; 0 found
188 | ERROR | [x] Expected 1 space after "-"; 0 found
188 | ERROR | [x] Expected 1 space before "-"; 0 found
188 | ERROR | [x] Expected 1 space after "-"; 0 found
198 | ERROR | [x] Expected 1 space after first semicolon of FOR loop; newline found
202 | ERROR | [x] Expected 1 space after second semicolon of FOR loop; newline found
218 | ERROR | [x] Expected 1 space before "-"; 0 found
218 | ERROR | [x] Expected 1 space after "-"; 0 found
218 | ERROR | [x] Expected 1 space before "-"; 0 found
218 | ERROR | [x] Expected 1 space after "-"; 0 found
220 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
221 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
249 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
249 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
276 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
278 | ERROR | [x] Expected 1 space before "<"; 0 found
278 | ERROR | [x] Expected 1 space after "<"; 0 found
278 | ERROR | [x] Expected 1 space before "="; 0 found
278 | ERROR | [x] Expected 1 space after "="; 0 found
278 | ERROR | [x] Expected 1 space before ">"; 0 found
278 | ERROR | [x] Expected 1 space after ">"; 0 found
280 | ERROR | [x] Expected 1 space before "<"; 0 found
280 | ERROR | [x] Expected 1 space after "<"; 0 found
280 | ERROR | [x] Expected 1 space before "/"; 0 found
280 | ERROR | [x] Expected 1 space after "/"; 0 found
280 | ERROR | [x] Expected 1 space before ">"; 0 found
280 | ERROR | [x] Expected 1 space after ">"; 0 found
----------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 44 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------
FILE: /home/chandansha/docker/testd9/web/modules/custom/color-3443370/tests/modules/color_test/themes/color_test_theme/js/color_test_theme-fontsize.js
------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------------
10 | ERROR | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /home/chandansha/docker/testd9/web/modules/custom/color-3443370/color.js
----------------------------------------------------------------------------------------------
FOUND 9 ERRORS AFFECTING 7 LINES
----------------------------------------------------------------------------------------------
23 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
94 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
103 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
132 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
132 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
147 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
147 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
159 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
191 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 9 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------
Time: 386ms; Memory: 16MB
I have tested MR 14 and cannot find any phpcs issue so I move forward to RTBC.
Chandansha → created an issue.
I have tested and cannot find any phpcs issue so I move forward to RTBC.
Hii,
I applied #2 patch and I confirmed that it fixes most of the PHPCS issues but few issue remainig.
i fixed that remaining issue and created MR also.
FILE: /home/chandansha/docker/testd10/web/modules/fix-issue/keycdn-3437211/README.md
--------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------
4 | WARNING | Line exceeds 80 characters; contains 107 characters
16 | WARNING | Line exceeds 80 characters; contains 98 characters
--------------------
Time: 175ms; Memory: 12MB
Chandansha → made their first commit to this issue’s fork.
Chandansha → made their first commit to this issue’s fork.
Hi,
Reviewed the MR and no found any PHPCS errors and warnings.
Thank you!!
I checked module i could not find any phpcs issue.
below share image kindly check.
@all Thanks for Review.
Chandansha → created an issue.
Chandansha → created an issue.
Chandansha → made their first commit to this issue’s fork.
Chandansha → made their first commit to this issue’s fork.
fixed all issue. But still there are some issues left.
Please have a look
FILE: /home/chandansha/docker/testd10/web/modules/issue/variationcache-3432902/variationcache.module
------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------
19 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
------------------------------------------------------------------------------------------------------------------
FILE: /home/chandansha/docker/testd10/web/modules/issue/variationcache-3432902/src/Cache/VariationCacheInterface.php
--------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------
15 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
--------------------------------------------------------------------------------------------------------------------
FILE: /home/chandansha/docker/testd10/web/modules/issue/variationcache-3432902/src/Cache/CacheRedirect.php
------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------
15 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
------------------------------------------------------------------------------------------------------------------
FILE: /home/chandansha/docker/testd10/web/modules/issue/variationcache-3432902/src/Cache/VariationCacheFactory.php
------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------
15 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
------------------------------------------------------------------------------------------------------------------
FILE: /home/chandansha/docker/testd10/web/modules/issue/variationcache-3432902/src/Cache/VariationCache.php
------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------
15 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
------------------------------------------------------------------------------------------------------------------
FILE: /home/chandansha/docker/testd10/web/modules/issue/variationcache-3432902/src/Cache/VariationCacheFactoryInterface.php
---------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------
15 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
---------------------------------------------------------------------------------------------------------------------------
Time: 116ms; Memory: 10MB
Chandansha → created an issue.
Chandansha → made their first commit to this issue’s fork.
fixed all issue. But still there are some issues left.
Please have a look.
FILE: /home/chandansha/docker/testd10/web/modules/issue/config_pages-3424331/src/ConfigPagesTypeForm.php
--------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------
118 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
--------------------------------------------------------------------------------------------------------
FILE: /home/chandansha/docker/testd10/web/modules/issue/config_pages-3424331/src/Controller/ConfigPagesController.php
---------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------
169 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
---------------------------------------------------------------------------------------------------------------------
Time: 547ms; Memory: 12MB
Chandansha → created an issue.
Chandansha → created an issue.
Chandansha → created an issue.
Hii
i solved all phpcs issue like css and js also.
Thank @clarkssquared for your help
Let me know if you find any other issue regarding phpcs.
fixed Drupal 10 compatibility fixes
Chandansha → created an issue.
fix all phpcs issue.
Chandansha → created an issue.
fix issue.
Chandansha → created an issue.
now i fix configure issue.
Thanks.
i solve all issue.
Chandansha → created an issue.
i solve all issue. But still there are some issues left.
Please have a look.
FILE: /home/chandansha/docker/testd10/web/modules/contrib/search_tracking/src/Controller/SearchTrackingController.php
---------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
---------------------------------------------------------------------------------------------------------------------
20 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
24 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
25 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
37 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
40 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
---------------------------------------------------------------------------------------------------------------------
Time: 91ms; Memory: 10MB
Thanks.
Chandansha → created an issue.
fix the pop-up will close if you click on the overlay area.
i fixed all phpcs issues.
As Per The #13 issue list and CMD i solved the issues reported by PHPCS.
listed below issue is not resolved.
262 | WARNING | The use of function fnmatch() is discouraged
10 | WARNING | Class name must be prefixed with the project name "ConfigPolicy"
please review
Chandansha → changed the visibility of the branch 3337295-remove-remaining-uses to active.
Chandansha → changed the visibility of the branch 3337295-remove-remaining-uses to hidden.