Deprecations PHP 8.4

I believe this is the same issue I'm having, but with a slightly different message

Deprecated: Drupal\pathauto\Plugin\Action\UpdateAction::access(): Implicitly marking parameter $account as nullable is deprecated, the explicit nullable type must be used instead in ../web/modules/contrib/pathauto/src/Plugin/Action/UpdateAction.php on line 31

@niharika.s i have tested MR 92. there is still some issue remaining please find and resolve it thanks!!

PHP Deprecated:  Drupal\pathauto\Commands\PathautoCommands::generateAliases(): Implicitly marking parameter $types as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/web/modules/custom/pathauto-3495869/src/Commands/PathautoCommands.php on line 89

Deprecated: Drupal\pathauto\Commands\PathautoCommands::generateAliases(): Implicitly marking parameter $types as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/web/modules/custom/pathauto-3495869/src/Commands/PathautoCommands.php on line 89
PHP Deprecated:  Drupal\pathauto\Commands\PathautoCommands::deleteAliases(): Implicitly marking parameter $types as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/web/modules/custom/pathauto-3495869/src/Commands/PathautoCommands.php on line 135

Deprecated: Drupal\pathauto\Commands\PathautoCommands::deleteAliases(): Implicitly marking parameter $types as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/web/modules/custom/pathauto-3495869/src/Commands/PathautoCommands.php on line 135
PHP Deprecated:  Drupal\pathauto\AliasStorageHelper::__construct(): Implicitly marking parameter $entity_type_manager as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/web/modules/custom/pathauto-3495869/src/AliasStorageHelper.php on line 79

Deprecated: Drupal\pathauto\AliasStorageHelper::__construct(): Implicitly marking parameter $entity_type_manager as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/web/modules/custom/pathauto-3495869/src/AliasStorageHelper.php on line 79

Working on it.

We want to run tests against 8.4, at least temporarily:

Add this to .gitlab-ci.yml:

composer:
  extends: .composer-base
  variables:
    PHP_VERSION: '8.4'

we could also opt in to MAX_PHP, but that's still set to 8.3, I want to create an issue to update it to 8.4, didn't do that yet.

Nice. the tests still fail in (https://git.drupalcode.org/issue/pathauto-3495869/-/jobs/3824204) but they only fail on forum integration tests, so we need an issue in the forum contrib project to make the necessary changes.

I don't have the required knowledge for the failing tests. Please someone look into it.
Unassigning myself.

I have tested MR 92. Now all deprecation error are resolved.
I moved it to RTBC.
Thanks!!

I've added the issue to the Forum Contrib project for the PHP 8.4 fixes as per point #9.

Why are there two different issues here? Isn't this the same as this https://www.drupal.org/project/pathauto/issues/3489108 🐛 Fix PHP 8.4 implicit nullable deprecation Needs review ?

I went with this one, and it seems to have at least gotten rid of all deprecation messages I saw when running drush commands.

Closing this as duplicate of 🐛 Fix PHP 8.4 implicit nullable deprecation Needs review . Let's continue there!