🇮🇳India @Prem Suthar

Role-based access

Adds an access check based on a user's roles. This may be sufficient for sites where access is primarily granted or denied based on roles and permissions. For grants-based access checks on "Content" or "Comment" entities the "Content access" processor may be a suitable alternative.

can we include this processor information with more details. 

Prem Suthar → created an issue.

if possible, please create a Merge Request following the Drupal standard process.

The patch resolves all PHPCS issues once applied. Additionally, if possible, please create a Merge Request following the Drupal standard process.

yes right it is not working for autocomplete widget only its works fine in select list ..

For me its not working for two view only how we can reslove this for those two views its showing the error like "There is no display available. Please select another view or change the field settings." any solution ???

Prem Suthar → created an issue.

https://www.drupal.org/project/viewsreference/issues/3402036 🐛 Configuration schema for "Enable extra settings" (title,pagination,...) incorrect Fixed

Prem Suthar → created an issue.

Prem Suthar → created an issue.

#MR!4 is Working Fine As per the issue details so we can move this issue.

Updated The Patch as per latest code.

# 4 patch is Failed To Apply on the latest Code .

Checking patch src/Cache/PhpRedis.php...
Checking patch src/Cache/RedisCacheTagsChecksum.php...
error: while searching for:

    // We want to differentiate between PhpRedis and Redis clients.
    if ($this->clientType === 'PhpRedis') {
      $multi = $this->client->multi();
      foreach ($keys as $key) {
        $multi->incr($key);
      }

error: patch failed: src/Cache/RedisCacheTagsChecksum.php:58
error: src/Cache/RedisCacheTagsChecksum.php: patch does not apply
Checking patch src/Lock/PhpRedis.php...
Checking patch src/Queue/ReliablePhpRedis.php...

#MR!1 is Working Fine As per the issue details so we can move this issue.

fixed the 80% issue of phpcs but there is remaining issue they need to be done by modify the logic.

FILE: ...e/prem/Documents/drupal11/modules/custom/office_hours/src/OfficeHoursFormatterTrait.php
---------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------
 463 | WARNING | Only string literals should be passed to t() where possible
 477 | WARNING | Only string literals should be passed to t() where possible
---------------------------------------------------------------------------------------------


FILE: ...11/modules/custom/office_hours/src/Plugin/Field/FieldType/OfficeHoursExceptionsItem.php
---------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------
 50 | WARNING | Only string literals should be passed to t() where possible
---------------------------------------------------------------------------------------------


FILE: ...drupal11/modules/custom/office_hours/src/Plugin/Field/FieldType/OfficeHoursItemList.php
---------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------
 26 | WARNING | Possible useless method overriding detected
 83 | WARNING | Possible useless method overriding detected
---------------------------------------------------------------------------------------------


FILE: ...nts/drupal11/modules/custom/office_hours/src/Plugin/Field/FieldType/OfficeHoursItem.php
---------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
---------------------------------------------------------------------------------------------
 551 | ERROR | The text '@deprecated Deprecated in version 8.x-1.12 and is removed from
     |       | %removal-version%. %extra-info%.' does not match the standard format:
     |       | @deprecated in %deprecation-version% and is removed from %removal-version%.
     |       | %extra-info%.
 551 | ERROR | Each @deprecated tag must have a @see tag immediately following it
---------------------------------------------------------------------------------------------


FILE: ...odules/custom/office_hours/src/Plugin/Field/FieldWidget/OfficeHoursExceptionsWidget.php
---------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------
 175 | WARNING | Possible useless method overriding detected
 231 | WARNING | Possible useless method overriding detected
---------------------------------------------------------------------------------------------


FILE: ...odules/custom/office_hours/src/Plugin/Field/FieldFormatter/OfficeHoursFormatterBase.php
---------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
---------------------------------------------------------------------------------------------
 468 | WARNING | Only string literals should be passed to t() where possible
 469 | WARNING | Only string literals should be passed to t() where possible
 475 | WARNING | Only string literals should be passed to t() where possible
---------------------------------------------------------------------------------------------


FILE: ...ules/custom/office_hours/src/Plugin/Field/FieldFormatter/OfficeHoursFormatterStatus.php
---------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------
 62 | WARNING | Only string literals should be passed to t() where possible
 63 | WARNING | Only string literals should be passed to t() where possible
---------------------------------------------------------------------------------------------


FILE: ...om/office_hours/src/Plugin/Field/FieldFormatter/OfficeHoursFormatterTableSelectList.php
---------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------
 84 | WARNING | Only string literals should be passed to t() where possible
 90 | WARNING | Only string literals should be passed to t() where possible
---------------------------------------------------------------------------------------------


FILE: ...prem/Documents/drupal11/modules/custom/office_hours/src/Plugin/views/field/TimeSlot.php
---------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------
 69 | WARNING | Possible useless method overriding detected
---------------------------------------------------------------------------------------------


FILE: ...e/prem/Documents/drupal11/modules/custom/office_hours/src/Plugin/views/field/Season.php
---------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
---------------------------------------------------------------------------------------------
 20 | WARNING | Possible useless method overriding detected
 35 | WARNING | Possible useless method overriding detected
 43 | WARNING | Possible useless method overriding detected
---------------------------------------------------------------------------------------------


FILE: ...prem/Documents/drupal11/modules/custom/office_hours/src/Element/OfficeHoursBaseSlot.php
---------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------
 312 | WARNING | Only string literals should be passed to t() where possible
---------------------------------------------------------------------------------------------


FILE: .../Documents/drupal11/modules/custom/office_hours/src/Element/OfficeHoursSeasonHeader.php
---------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------
 253 | WARNING | Only string literals should be passed to t() where possible
---------------------------------------------------------------------------------------------

Prem Suthar → created an issue.

Prem Suthar → created an issue.

added the MR for phpcs issue fixed please review

Prem Suthar → changed the visibility of the branch 3423795-fix-the-issues to hidden.

Prem Suthar → made their first commit to this issue’s fork.

Prem Suthar → made their first commit to this issue’s fork.

its correct we need to add the media library as a dependency.
#3 working fine for me so we can move this issue ahed.

did not reproduce the error of #10 i got just one warning

FILE: /home/prem/Documents/drupal11/modules/custom/combined_image_style-3372208/src/Entity/CombinedImageStyle.php
-----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
 47 | WARNING | Possible useless method overriding detected
-----------------------------------------------------------------------------------------------------------------

Time: 181ms; Memory: 12MB

this warning of using __constructor without calling a any services if we remove it then it will show the error so we can skip this warning .

Fix the all reaming issues Please review and merge This Changes.

Created The mr as per issue suggestion and its working fine as per database config.

Prem Suthar → made their first commit to this issue’s fork.

updated the changes and created the mr.

Prem Suthar → made their first commit to this issue’s fork.

Please review The Mr Above Created

Prem Suthar → made their first commit to this issue’s fork.

Reviewed MR!1, is looks finne as its follows the template instruction mentioned here: https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... →

Create the Mr For Issue. Please Review

Prem Suthar → made their first commit to this issue’s fork.

i think so yo missed the check the credit option for this issue

Prem Suthar → created an issue.

testing

https://www.drupal.org/project/media_popup/issues/3423150 📌 Fix the issues reported by phpcs Needs review

Check this issue

Prem Suthar → created an issue.

Prem Suthar → made their first commit to this issue’s fork.

Fix The All phpcs issues please review it.

Prem Suthar → created an issue.

Testing123

Testing

i have fixed the phpcs issues please review it .

Prem Suthar → created an issue.

Testing

I have Fixed the all PHPCS error's And Warning Please review it.

Prem Suthar → created an issue.

I have Updated The code as per hrtime() api plz review it.

Prem Suthar → made their first commit to this issue’s fork.

Added the Mr For the #13 for re-roll the patch .

Prem Suthar → made their first commit to this issue’s fork.

Move the Patch Code To MR. As per #48

Re-Rolled The patch For #18 As per the #35 Suggestion .Also add the Inter Diff For The #18 to #37.

I have Fixed The Phpcs error of #6

remain part is warnings.

FILE: /home/prem/Documents/drupal11/modules/custom/social_media_links/src/IconsetFinderService.php
--------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------
 87 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
--------------------------------------------------------------------------------------------------


FILE: ...em/Documents/drupal11/modules/custom/social_media_links/modules/social_media_links_field/src/Plugin/Field/FieldFormatter/SocialMediaLinksFieldDefaultFormatter.php
------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 216 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 229 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
------------------------------------------------------------------------------------------------------------------------------------------------------------------------

test patch

Prem Suthar → created an issue.

testing

Here i have added the inter-diff for the 25# To 45#.

As Per the Issue tag i have re-rolled the patch again the #25 for Drupal version 11.x Dev

Not Reproduced any error while running the this cmd :- ./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/delete_entity_translations

Solved the all Phpcs error coming from 3.x version.
i use the cmd to show the error is : - ./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/inline_entity_form
attached the patch file plz review ..

Updated patch File ..

Fix The All PHPCS Issues generated by Drupal coding standard
I used The Following the CMD :- ./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/layout_builder_styles
Added The InterDiff File Between the #8 to #5.

As Per The #3 issue list and CMD i solved the issues reported by PHPCS.
just one issue is not resolved. listed below..

9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\config_policy\Result\ResultItem\ErrorResultItem.

@apaderno Not found any method DrupalMediaLibrary::isInternal() like this in media or media library module of core so we can close the issue.

i have Applied The Mr And Check The functionality Of user password Progress Bar is Working Fine as per the issue Scope. Here i Am Attaching the Video For Reference. After patch And Before Patch.

Prem Suthar → created an issue.