Try To Addressed the #8 point .
prem suthar → made their first commit to this issue’s fork.
I have re-based The MR Please Review.
prem suthar → made their first commit to this issue’s fork.
@heddn , I have Raised the MR as per #3 Point. Please Review.
prem suthar → made their first commit to this issue’s fork.
@mateb i have tested on the 11.2-dev and install the 2.0.3 version module after added the nofollow manually then pager is working fine and we can load more items.
@berdir Added the Mr From the #10. Please Review
As per the #155 re-rolled the patch #152 and created the Mr . also Addressed the #151 Points
Please review.
prem suthar → made their first commit to this issue’s fork.
prem suthar → made their first commit to this issue’s fork.
@voleger This Isse solution is already Done at this issue so i think so we can close this issue . https://www.drupal.org/project/filefield_paths/issues/3403246 ✨ Prevent crashing while file move, when file is not on the fileserver Needs review
prem suthar → made their first commit to this issue’s fork.
prem suthar → made their first commit to this issue’s fork.
prem suthar → made their first commit to this issue’s fork.
Please Review The Mr Re-Rolled From the #8.
prem suthar → made their first commit to this issue’s fork.
@heddn I have re-rolled the merge request as requested. Additionally, I made further updates to the information file to provide users with a clearer understanding of what this module offers. A screenshot has also been included for your review.
Please review The MR.
prem suthar → made their first commit to this issue’s fork.
@poker10 Please review The MR . i have added the default value for the new field.
added the MR Form the Patch and update code as per #8 suggestion.
prem suthar → made their first commit to this issue’s fork.
Update The MR As per #11 Suggestion please review .
prem suthar → made their first commit to this issue’s fork.
@sourabhsisodia_ can you fix the stylelint, eslint and phpcs fixces for raised mr.
Using Drupal Admin
-> Navigate to Configuration → Development → Configuration Synchronization → Single Import.
-> Export the current configuration containing update.settings.
-> Go to Export Configuration and download the configuration YAML file(s).
-> Edit the relevant YAML file (e.g., update.settings.yml) and remove the undesired configurations.
-> Import the edited configuration back to Drupal:
-> Go to Single Import, paste the updated YAML content, and click Import.
Also you can delete the configuration using code
$config_factory = \Drupal::service('config.factory');
// Delete the update.settings configuration.
$config_factory->getEditable('update.settings')->delete();
@romulasry Try to Run the command drush cdel update.settings
to delete the configuration settings. Afterward, try reinstalling the module. It seems the module's configuration isn't properly set up, and the settings might be stuck in your database. Clearing them should resolve the issue.
Issue: Hamburger Icons and Child Menu Arrow Icons Disappear on Hover for Mobile Responsive Devices
On all mobile responsive devices, when hovering over the hamburger menu or the arrow icons within the menu, the icons temporarily disappear and reappear once the hover state is removed. This behavior has been consistently observed across devices. A recorded video demonstrating the issue on the iPhone 14 Pro screen size is attached for reference.
Kindly investigate and address this issue.
@mylocaltrades i think so you select the wrong option https://www.drupal.org/project/add → in this page when you created the project so i think you need to select the Module project → .
@condor616 Right if we have content then table override the content and only display the table.
@condor616
I have used the csvfile_formatter to achieve the same functionality but that in a different way, as explained below.
The csvfile_formatter operates based on the content type. First, we need to create a field within the content type. Then, in the "Manage Display" section, we select the formatter. After that, we add the necessary classes as per our requirements and utilize DataTables, which offers various configuration options.
However, csvfile_formatter module has some limitations and functionality lack . The table generated does not provide a search functionality, and it cannot be used without creating a field.
prem suthar → made their first commit to this issue’s fork.
I have reviewed the MR !91 and its working fine after upgrade to the php 8.4 version.
@priti197 can you please raise the MR insted of Patch .
Patch is Working fine and resolved the issue just Raise the MR.
I have Done the phpcs fixes . Please review
Please assign one issue at a time so others can also pick the issues.
you have picked the issue
https://www.drupal.org/project/url_embed/issues/3488448
📌
Remove use of DeprecationHelper::backwardsCompatibleCall()
Active
this issue around 15 to 12 min ago and also assign this.
prem suthar → made their first commit to this issue’s fork.
Please review the changes.
prem suthar → made their first commit to this issue’s fork.
@astonvictor
i have Done the many changes for the PHPCS Fixes for DI and other all small fixes .
but still i have one warning
FILE: /home/prem/Documents/drupal-10-3-8/web/modules/custom/phpmailer-3133682/src/Form/SettingsForm.php
-------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------
375 | WARNING | Unused variable $ret_val.
-------------------------------------------------------------------------------------------------------
Time: 298ms; Memory: 12MB
This variable may be use for send the testing mail using the phpmailer so i remain as it is.
please review the changes and let me know other fixes .
prem suthar → made their first commit to this issue’s fork.
Please review the changes.
prem suthar → made their first commit to this issue’s fork.
Please Review The changes.
prem suthar → made their first commit to this issue’s fork.
I have Raised The MR!16 for the 2.0.x as well please review.
prem suthar → made their first commit to this issue’s fork.
prem suthar → made their first commit to this issue’s fork.
I have reviewed the MR ! 15 and its working fine as per the issue definition so i move the issue to RTBC.
I have reviewed the MR ! 14 and its working fine as per the issue so i move the issue to RTBC.
@debrup
navigation_extra_tools.plugin: this have -6 weight and navigation_extra_tools.db_update: also have same weight so as per the standards we cant use same weight for two links.
prem suthar → made their first commit to this issue’s fork.
prem suthar → made their first commit to this issue’s fork.
prem suthar → made their first commit to this issue’s fork.
prem suthar → made their first commit to this issue’s fork.
prem suthar → made their first commit to this issue’s fork.
prem suthar → made their first commit to this issue’s fork.
prem suthar → made their first commit to this issue’s fork.
Re-rolled The Patch #73 with The MR. Please review
prem suthar → made their first commit to this issue’s fork.
Re-rolled The Patch #2 with The MR. Please review.
prem suthar → made their first commit to this issue’s fork.
Re-rolled The Patch #3 with The MR. Please review.
prem suthar → made their first commit to this issue’s fork.
Re-rolled The Patch #11 with The MR. Please review.
Re-rolled The Patch #2 with The MR. Please review
prem suthar → made their first commit to this issue’s fork.
prem suthar → made their first commit to this issue’s fork.
prem suthar → made their first commit to this issue’s fork.
Re-rolled The Patch #5 with The MR. Please review
prem suthar → made their first commit to this issue’s fork.
prem suthar → made their first commit to this issue’s fork.
prem suthar → made their first commit to this issue’s fork.
@ windy-ux i have pushed the all fixed phpcs code in the 3478027-fix-phpcs-warnings
in this branch .
but i cant able to create the mr please review and Raise the MR and merge the MR.
Thanks
Prem Suthar
prem suthar → made their first commit to this issue’s fork.