Ahemdabad- Gujrat , Jodhpur - Rajsthan
Account created on 18 March 2020, about 5 years ago
#

Merge Requests

More

Recent comments

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

prem suthar created an issue.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan
🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

prem suthar made their first commit to this issue’s fork.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

@danrod This File already present in the
3.0.x-dev Branch .

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

prem suthar made their first commit to this issue’s fork.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan
🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

@Liam Morland, I have added the test. This is my first time writing a test, so please review it and let me know if any updates are needed.

As per my understanding, we also need to add a test for the "add row" functionality in this module. Additionally, we should create a folder for traits and move the trait tests inside it. Let me know if these changes need to be made.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

@liam morland yes i have reproduced this problem.
i will try to add test.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

@liam morland ohk i will try to add.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan
🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

prem suthar made their first commit to this issue’s fork.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

prem suthar made their first commit to this issue’s fork.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

prem suthar made their first commit to this issue’s fork.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

@liam morland i have added the 3.x branch in current issue fork .
can you change the target branch to 3.x of MR !10.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan
🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

prem suthar made their first commit to this issue’s fork.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

prem suthar changed the visibility of the branch PremSuthar-b40a75ab-patch-fff7 to hidden.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

prem suthar changed the visibility of the branch 8.x-2.x to hidden.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

prem suthar changed the visibility of the branch 3.0.x to hidden.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

prem suthar made their first commit to this issue’s fork.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

prem suthar made their first commit to this issue’s fork.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

prem suthar made their first commit to this issue’s fork.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

prem suthar made their first commit to this issue’s fork.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

prem suthar made their first commit to this issue’s fork.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

prem suthar made their first commit to this issue’s fork.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

prem suthar changed the visibility of the branch 1491584-sort-option-would to hidden.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

@Liam Morland, I can't see the 3.0.x branch in the current issue project "tablefield-3330779," which I need to rebase. Can you guide me on how to add it to the project?

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

prem suthar made their first commit to this issue’s fork.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

prem suthar made their first commit to this issue’s fork.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

@smustgrave please review the changes .

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

prem suthar made their first commit to this issue’s fork.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

prem suthar made their first commit to this issue’s fork.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

prem suthar made their first commit to this issue’s fork.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

prem suthar made their first commit to this issue’s fork.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

Please review the MR !11274 .

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

Re-rolled the patch As per #20 and as per the #19 updated the version from 10.3.1 to 10.3.0.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

prem suthar changed the visibility of the branch 3337900- to hidden.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

prem suthar made their first commit to this issue’s fork.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan
🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

prem suthar made their first commit to this issue’s fork.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

@kishan kumar can you change the target branch form 7.x-2.x to 8.x-1.x-dev.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

After applying the Merge Request (MR), I tested the patched code locally. When I navigated to the Moderated Blocks page (Content → Blocks → Moderated Blocks or "/admin/structure/block/block-content/moderated"), I encountered an error.

The website encountered an unexpected error. Try again later.

TypeError: Drupal\Core\Cache\CacheableMetadata::setCacheTags(): Argument #1 ($cache_tags) must be of type array, null given, called in /var/www/html/core/modules/views/src/Plugin/views/display/DisplayPluginBase.php on line 2416 in Drupal\Core\Cache\CacheableMetadata->setCacheTags() (line 29 of core/lib/Drupal/Core/Cache/CacheableMetadata.php).
Drupal\views\Plugin\views\display\DisplayPluginBase->getCacheMetadata() (Line: 228)
Drupal\views\Plugin\views\cache\CachePluginBase->generateResultsKey() (Line: 148)
Drupal\views\Plugin\views\cache\CachePluginBase->cacheGet() (Line: 1479)
Drupal\views\ViewExecutable->execute() (Line: 1514)
Drupal\views\ViewExecutable->render() (Line: 201)
Drupal\views\Plugin\views\display\Page->execute() (Line: 1690)
Drupal\views\ViewExecutable->executeDisplay() (Line: 80)
Drupal\views\Element\View::preRenderViewElement()
call_user_func_array() (Line: 107)
Drupal\Core\Render\Renderer->doTrustedCallback() (Line: 825)
Drupal\Core\Render\Renderer->doCallback() (Line: 387)
Drupal\Core\Render\Renderer->doRender() (Line: 203)
Drupal\Core\Render\Renderer->render() (Line: 241)
Drupal\Core\Render\MainContent\HtmlRenderer->Drupal\Core\Render\MainContent\{closure}() (Line: 593)
Drupal\Core\Render\Renderer->executeInRenderContext() (Line: 234)
Drupal\Core\Render\MainContent\HtmlRenderer->prepare() (Line: 131)
Drupal\Core\Render\MainContent\HtmlRenderer->renderResponse() (Line: 90)
Drupal\Core\EventSubscriber\MainContentViewSubscriber->onViewRenderArray() (Line: 246)
Symfony\Component\EventDispatcher\EventDispatcher::Symfony\Component\EventDispatcher\{closure}() (Line: 206)
Symfony\Component\EventDispatcher\EventDispatcher->callListeners() (Line: 56)
Symfony\Component\EventDispatcher\EventDispatcher->dispatch() (Line: 188)
Symfony\Component\HttpKernel\HttpKernel->handleRaw() (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle() (Line: 53)
Drupal\Core\StackMiddleware\Session->handle() (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle() (Line: 28)
Drupal\Core\StackMiddleware\ContentLength->handle() (Line: 32)
Drupal\big_pipe\StackMiddleware\ContentLength->handle() (Line: 116)
Drupal\page_cache\StackMiddleware\PageCache->pass() (Line: 90)
Drupal\page_cache\StackMiddleware\PageCache->handle() (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle() (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle() (Line: 53)
Drupal\Core\StackMiddleware\AjaxPageState->handle() (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle() (Line: 709)
Drupal\Core\DrupalKernel->handle() (Line: 19)
🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

prem suthar made their first commit to this issue’s fork.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

@pcambra
Here, I only need to add the t() function to static strings, correct?

so it should be like this $config->get('like_text', t('Likes));

am i right ? here

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

Can you please review and let me know for any other changes ?

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

@pcambra
Got it, I'll review the changes and make sure everything is on track.

Let me know if there's anything specific you'd like me to focus on .

🐛 | Poll | Empty vote
🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

prem suthar changed the visibility of the branch 3505480-empty-vote to hidden.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

prem suthar made their first commit to this issue’s fork.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

@dbielke1986
if possible then marked issue as as fixed

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan
🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan
🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan
🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

prem suthar made their first commit to this issue’s fork.

🐛 | Poll | Empty vote
🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

@chsdaiguil for me its showing only 0 vote .
see attachment

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

This issue Fixed in the 2.x branch but still is needed to fix in the 2.0.3 version

🐛 | Poll | Empty vote
🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

@chsdaiguil can you share any screen shot for reference where you see the 1 vote ?

🐛 | Poll | Empty vote
🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

@chsdaiguil

by default its showing only 0 votes after install 8.1.6 and 2.0 alpha 3 version but i cant reproduce the issue.

🐛 | Poll | Empty vote
🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

@arunsahijpal i think so issue is available in the 8.1.6 version .

🐛 | Poll | Empty vote
🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

prem suthar made their first commit to this issue’s fork.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

i have re-based the MR!12 .

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

@liam morland if you can access then can you change the target branch from 8.x-2.x To 3.0.x .

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

prem suthar made their first commit to this issue’s fork.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

@tr raised the mr as per the #15 so please review.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

prem suthar made their first commit to this issue’s fork.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

prem suthar changed the visibility of the branch 2873958-move-helper-function to active.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

prem suthar changed the visibility of the branch 2873958-move-helper-function to hidden.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

prem suthar made their first commit to this issue’s fork.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

prem suthar made their first commit to this issue’s fork.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

Please Review and Merge the Mr.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

prem suthar made their first commit to this issue’s fork.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

Please Review !14 Mr.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

prem suthar made their first commit to this issue’s fork.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan
🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

prem suthar made their first commit to this issue’s fork.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

I have reviewed the !226 Mr and its Working Fine as per the issue requirement.
i have attached the Screenshot For reference.

Suggestion :
i have one more suggestion can we include the Date selector for the range filter so we can easily filter the data.
also added the Screenshot For the what kind of popup we can add.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

prem suthar changed the visibility of the branch 3395585-validate-icon-base-uri-new to hidden.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

prem suthar made their first commit to this issue’s fork.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

prem suthar made their first commit to this issue’s fork.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

prem suthar made their first commit to this issue’s fork.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan
🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

prem suthar made their first commit to this issue’s fork.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan
🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

@dhavalpanchal Can you made the changes in MR insted Of patch.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

Added the Mr with the Drupal 11 version with the some code updates and Added Mr Form Patch #38 as per the suggestion of 40 .

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

prem suthar made their first commit to this issue’s fork.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

You're absolutely right. Having #2205027: VERSION in library declarations resolved and committed in core would significantly enhance our ability to cache assets effectively. It would also bring more consistency and reliability when handling contributed and custom modules. This improvement could save both development time and resources while improving site performance. Let’s hope it gets prioritized soon!

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan
🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

prem suthar created an issue.

🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

@dcam i have reviewed the MR!23 and its working fine as per the Issue requirement for reference i have added the screen shot. so i move this issue to RTBC.

Production build 0.71.5 2024