WYSIWYG support on each table cell for better content experience

Created on 21 August 2019, over 5 years ago
Updated 27 January 2023, almost 2 years ago

There is a related issue https://www.drupal.org/project/tablefield/issues/1833848 , but that one is for D 7.x branch. And I'm not sure if it's the same approach.

Anyway, by doing some changes, I think It's possible to enable the rich text editor for all cells. Even each one should be able to pick its own text format. This could allow to play nicely with several use cases. For example, imagine you need to build an easy product comparison page, by referencing existing nodes, with your desired view mode. To do this, it could be possible to make use of module "Entity embed" ( https://www.drupal.org/project/entity_embed ). So, by adding this feature, we could to build something like this:

And the output:

As you see, this way could allow to mix/build powerful rich-content tables. Providing patch...

Feature request
Status

Needs review

Version

2.0

Component

User interface

Created by

🇨🇴Colombia waspper

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇫🇷France egruel

    I just reroll the path to run with version 8.x-2.x-dev

  • 🇨🇭Switzerland vrancje Bern

    This works perfectly on 10.0.11! Thanks for the work.
    Are there any plans to reopen #3222990 now that allowed formats is in 10.1?

  • 🇺🇸United States superfluousapostrophe

    Something was updated in the 8.x-2.x-dev branch today and the patch in #32 is now broken. Any chance the patch can be re-rolled?

  • Status changed to Needs work 7 months ago
  • 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
  • First commit to issue fork.
  • 🇮🇳India immaculatexavier

    immaculatexavier changed the visibility of the branch 3076448- to hidden.

  • Status changed to Needs review 6 months ago
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 8
    last update 6 months ago
    3 pass
  • 🇮🇳India manish-31

    Added reroll patch for the patch from #32. Needs review.

    Shall we close the MR!4 and raise a new MR or push the changes in the same MR?

  • 🇺🇸United States superfluousapostrophe

    Thanks for the reroll! The #38 patch is now applying cleanly to the latest from the 2.x dev branch.

  • Status changed to RTBC 4 months ago
  • 🇮🇳India Tirupati_Singh

    Hi, I tried applying the MR !4 as a patch and got error while applying the patch.
    I applied the patch provided in comment #38 WYSIWYG support on each table cell for better content experience Needs review and it applied with no errors. After applying the patch <a href="https://www.drupal.org/files/issues/2024-05-23/wysiwyg-support-3076448-38.patch">wysiwyg-support-3076448-38.patch</a> the raise feature request functionality is working as expected. I am attaching the before and after screenshots for reference. As patch #38 resolves the issue hence, moving the issue status to RTBC.

    As mentioned in comment #38 the provided patch can be converted into MR for the issue.

  • 🇮🇳India gg24

    Re-rolled the patch with the latest stable module release. Please review.

  • In #41 patch not working for existing field, so fixed the issue by adding missing required code for existing field & uploaded the patch

  • 🇮🇩Indonesia awset

    Patch #38 works perfectly in my case with the version 2.5-rc1.
    DEV version dropped support for D10.2, where I still need it for now.

    However, I found a bug in #38 when doing an import via CSV, it is not populating the data.
    I have fix the issue here, I also added the interdiff to make it easier to review.

  • 🇮🇩Indonesia awset

    change the status to need review.

  • 🇮🇳India Tirupati_Singh

    Hi @awset, I've applied the provided wysiwyg-support-3076448-43.patch in #43 WYSIWYG support on each table cell for better content experience Needs review , it applied cleanly with no errors. After applying, each table cells have user input format option. Now user can change the input format for table cells. The changes are working fine while using the module. However, after applying the patch, export table data as CSV feature is impacted due to the new changes. Previously the table data was exported as the actual data/value but after applying the patch table data is being stored as simply 'Array' text instead of array. And when the table is being imported the table created is simply containing the text 'Array' instead of actual data due to the incorrect data present in the CSV file. Previously the import and export table data as CSV was working fine. I'm attaching the screenshots of the before and after fixes for your reference. As the module functionality is impacted due to the latest patch, hence moving back the issue status to Needs work.

    Thanks!

Production build 0.71.5 2024