WYSIWYG support on each table cell for better content experience

I just reroll the path to run with version 8.x-2.x-dev

This works perfectly on 10.0.11! Thanks for the work.
Are there any plans to reopen #3222990 → now that allowed formats is in 10.1?

Something was updated in the 8.x-2.x-dev branch today and the patch in #32 is now broken. Any chance the patch can be re-rolled?

immaculatexavier → changed the visibility of the branch 3076448- to hidden.

Added reroll patch for the patch from #32. Needs review.

Shall we close the MR!4 and raise a new MR or push the changes in the same MR?

Thanks for the reroll! The #38 patch is now applying cleanly to the latest from the 2.x dev branch.

Hi, I tried applying the MR !4 as a patch and got error while applying the patch.
I applied the patch provided in comment #38 ✨ WYSIWYG support on each table cell for better content experience Needs review and it applied with no errors. After applying the patch <a href="https://www.drupal.org/files/issues/2024-05-23/wysiwyg-support-3076448-38.patch">wysiwyg-support-3076448-38.patch</a> the raise feature request functionality is working as expected. I am attaching the before and after screenshots for reference. As patch #38 resolves the issue hence, moving the issue status to RTBC.

As mentioned in comment #38 the provided patch can be converted into MR for the issue.

Re-rolled the patch with the latest stable module release. Please review.

In #41 patch not working for existing field, so fixed the issue by adding missing required code for existing field & uploaded the patch

Patch #38 works perfectly in my case with the version 2.5-rc1.
DEV version dropped support for D10.2, where I still need it for now.

However, I found a bug in #38 when doing an import via CSV, it is not populating the data.
I have fix the issue here, I also added the interdiff to make it easier to review.

change the status to need review.

Hi @awset, I've applied the provided wysiwyg-support-3076448-43.patch → in #43 ✨ WYSIWYG support on each table cell for better content experience Needs review , it applied cleanly with no errors. After applying, each table cells have user input format option. Now user can change the input format for table cells. The changes are working fine while using the module. However, after applying the patch, export table data as CSV feature is impacted due to the new changes. Previously the table data was exported as the actual data/value but after applying the patch table data is being stored as simply 'Array' text instead of array. And when the table is being imported the table created is simply containing the text 'Array' instead of actual data due to the incorrect data present in the CSV file. Previously the import and export table data as CSV was working fine. I'm attaching the screenshots of the before and after fixes for your reference. As the module functionality is impacted due to the latest patch, hence moving back the issue status to Needs work.

Thanks!

lysenko → changed the visibility of the branch 3076448-wysiwyg-support-on to hidden.

lysenko → changed the visibility of the branch 3076448- to active.

lysenko → changed the visibility of the branch 3076448-wysiwyg-support-on to active.

Please rebase on 3.0.x.

prem suthar → made their first commit to this issue’s fork.

Hi,

I just tried to upgrade from 2.4.0 to 2.5.0 on Drupal 10.4.5 but patches 30 (the one I was using before) and 43 (seems to be the latest) worked. Could I get some guidance? Or is the patch not needed anymore?

Thanks,

The patch needs to be re-rolled.

lukasz.tyc → made their first commit to this issue’s fork.

I wanted to use the current MR with version 3.0.
The hook_update_n tablefield_update_8003 is not working with paragraphs.

The following error is thrown:
Base table or view not found: 1146 Table 'db.paragraph_field_data' doesn't exist

I tried to fix by setting the correct table name (should be paragraphs_item_field_data instead of paragraph_field_data), but it still gets stuck on non existing fields for the format (line 100 in the batch).

Sorry but I'm new to this...

liam morland said that "patch needs to be re-rolled". I did some digging and I believe I did it properly. So for version 2.5, this is what I ended up with (I've uploaded rerolled-patch-43.patch).

Can someone confirm that this is the correct way to proceed?

At the same time - and forgive me if I'm asking something stupid, but do we have a patch for 3.0.0? I believe I will need to upgrade to it before going to Drupal 11 and I'm guessing I would need a patch for that one too, right?

Thanks.