🇮🇩Indonesia @awset

change the status to need review.

Patch #38 works perfectly in my case with the version 2.5-rc1.
DEV version dropped support for D10.2, where I still need it for now.

However, I found a bug in #38 when doing an import via CSV, it is not populating the data.
I have fix the issue here, I also added the interdiff to make it easier to review.

I am able to replicate this issue with custom form, it is a combination of custom form and ajax.

The issue is due to https://git.drupalcode.org/project/simple_recaptcha/-/blob/8.x-1.x/js/si... it always false after ajax success or fail.

above lead to onclick on the button (line 42) is never executed.

my work around is by implementing CommandInterface class, the js of that class look like this.

Drupal.Ajax.prototype.beforeSubmit = function (form_values, element_settings, options) {
      const buttonElement = document.querySelector('.simple-recaptcha-submit');
      if (buttonElement.dataset.disabled === 'true') {
        this.ajaxing = false;
        return false;
      }

      return true;
    };

it took me hours to figure it out, for some reason webform is working just fine, so it was leading my investigation to other rabbit hole.

gargsuchi → credited awset → .

gargsuchi → credited awset → .

gargsuchi → credited awset → .