🇮🇳India @Tirupati_Singh

I'm looking into it.

Hi all, I've applied the provided MR as a patch and it applied cleanly without any errors. However, after applying the patch getting below error when configuring the mega menu.

The website encountered an unexpected error. Try again later.

Error: Call to undefined method Drupal\Core\Menu\MenuLinkDefault::getEntity() in Drupal\we_megamenu\WeMegaMenuBuilder::getMenuTree() (line 48 of modules/custom/we_megamenu/src/WeMegaMenuBuilder.php).

I've also tried applying the patch provided in the comment #4 ✨ Add translatable menu links to we_megamenu Active but getting below errors on applying:

Checking patch src/WeMegaMenuBuilder.php...
error: while searching for:
            }
          }
        }
      } 
    }
  }


error: patch failed: src/WeMegaMenuBuilder.php:448
error: src/WeMegaMenuBuilder.php: patch does not apply

I'm attaching the screenshots of before and after of the issue for reference. As the MR is not resolving the issue hence moving back the issue to NW.

Hi @anybody @xpersonas, I've applied the latest changes in the MR as a patch and it applied cleanly without any error. On applying the patch, the issue mentioned in the comment #31 ✨ Possibility to set words as reject pattern Needs review has been resolved. However, when the module is installed and then the patch has been applied, then on visiting the module configuration page i.e., /admin/config/content/protected_forms getting the below error:

The website encountered an unexpected error. Try again later.

InvalidArgumentException: "0" is an invalid render array key. Value should be an array but got a string. in Drupal\Core\Render\Element::children() (line 97 of core/lib/Drupal/Core/Render/Element.php).

But after reinstalling the module with the applied patch then the above issue has not been encountered.

After applying the patch, a new field Pattern matching has been added with options Check whole word instances and Check within strings. The newly added field provides the option to match the added pattern to match the whole or match only the pattern within the words. Both the provided field options are working fine with the forms and blocking the form submission as per the selected option in the field. I've attached the video clip for your reference and screenshots of before and after fixes as well.

As getting the mentioned error after applying the patch, hence keeping the issue to Need works.

Thanks!

Hi @megachriz @sourojeetpaul, I've reviewed the updated logo in the comment #21 📌 Create logo for Feeds Tamper for Project Browser Initiative Active and it looks good to me. The change in the tamper circle color now representing in the modification of the input and output data through the conversion on squre into circle indicating the module functionality well. As the latest proposed logo meets the requirement hence, moving the issue to RTBC.

Thanks!

Hi all, I replicated the issue and the issue persists. Upon adding any pattern in the Reject patterns field, the user is unable to submit the form due the any word containing the pattern added in the reject patterns field. I also applied the provided MR as a patch and it applied cleanly without any errors. However, after applying the patch getting below issue:

The website encountered an unexpected error. Try again later.

TypeError: Drupal\protected_forms\Form\ProtectedFormsForm::__construct(): Argument #1 ($module_handler) must be of type Drupal\Core\Extension\ModuleHandlerInterface, Drupal\Core\Config\ConfigFactory given, called in /app/web/core/lib/Drupal/Core/Form/ConfigFormBase.php on line 57 in Drupal\protected_forms\Form\ProtectedFormsForm->__construct() (line 28 of modules/custom/protected_forms/src/Form/ProtectedFormsForm.php).

Now on visiting the module configuration page getting the issue and also on submitting the form on which the protected form is enabled getting the issue shown in the screenshot. The provided MR still need works hence moving it to Needs work.

Thanks!

Hi @debrup, I've reviewed the proposed logo for the module as per the guidelines mentioned on the project browser. The logo meets the following requirements:

1. The logo dimension is 512x512px and it does not have any animation.
2. The proposed logo file size is within 10kb and the file format is png.

The logo image quality looks good however, the design at the top and bottom edged of the logo seems to be cutting at the edge "the square blue gear-box one at the top and bottom center". If there'll be some gap then it would be better. And also, as per the guidelines the proposed logo filename should be "logo.png" instead of Dubbot-fs8.png. Considering the above issues, I'm moving the issue status to needs work.

Thanks!

Hi all, I've also tried replicating the issue and the issue persists while using the 2.0.3 version of the module. However, the issue has been resolved in the development version 2.0.x in the issue #3395325 🐛 Deprecated function: Creation of dynamic property (with php 8.2) Fixed and the provided MR has been merged as well. It will get resolved once the maintainer published the new release of the module. As the related issue has been merged on the dev version hence, changing the issue status to duplicate.

Thanks!

Hi, I replicated the issue and can confirm that the issue persist. Currently, to visit/add any custom permissions to the Custom Permissions module configuration page no menu item has been provided. It is hard for a normal user to find the module configuration. To access the module configuration, the users have to visit the Extend page and then after the module configuration can be accessed which is not a good user experience.
I've applied the provided MR as a patch and it applied cleanly without any errors. After applying the patch, a new menu item named "Custom permissions" has been added under the "People" menu allowing user to access the module configuration page to enhance the user experience. I'm attaching the screenshots of before and after fixes for reference. As the MR is resolving the mentioned issue hence, moving it to RTBC. Hope to see this fixes in the new release of the module.

Thanks!

Hi all, I've tried replicating the issue, and it reproduced. I've applied the provided MR as a patch, and it applied cleanly without any errors. After applying the patch, the multivalued image field overlap issue got resolved successfully, along with the mentioned issues in the comment #17 🐛 Widget for multivalued file field overlap Active . Now, the multivalued image fields occupying the required space and are not blocking the usage of multivalued fields, as mentioned by @piridium.

Thanks to @mudasirweb and @sandip-poddar for resolving further designing issues while using this theme. Initially, the drag handler is center-aligned for the theme for all fields/tables, so it would be better if consistency is maintained for the theme. As changes made for the handler are not affecting the other functionality while using the theme, hence moving the issue to RTBC. I've attached the screenshots of before and after fixes for reference.

Thanks!

Hi @andy-blum, I've added the gap between the site logo and site title & slogan. Attaching the screenshot of the after fixes for your reference. Please review the changes.

Thanks!

Hi @shivam_tiwari, I can confirm that after applying the latest MR's changes as a patch the mentioned issues in the comment #19 has been fixed and it is working fine. I'm attaching the screenshot of after fixes for reference hence moving the issue status to RTBC. Thanks for the quick fixes.

Thanks!

Hi all, I've applied the provided MR as a patch and it applied cleanly without any errors. However, after applying the patch the issue does not get resolved as the menu attributes are not added to the menu item. Additionally, the added attributes value are being added to link attribute instead of being added to its individual attributes. I'm attaching screenshots of the before and after fixes along with the menu item configuration for the attributes. Hence, moving the issue to NW state.

Thanks!

Hi @rajat4u, I've applied the provided MR as a patch and it applied without any errors. After applying the patch, the new configuration has been provided to add rel attribute to the formatter for both Image and File type fields. On enabling the rel attribute for the field, the rel attribute is being added to the DOM for download link. The provided new rel attribute configuration is working fine. I'm attaching the screenshots of before and after fixes for the issues and moving it to RTBC.

Thanks!

Hi @sourojeetpaul, I've updated the MR. Please review the changes.
Thanks!

Hi @sourojeetpaul, I've added the configuration fields for social media icons. Additionally, I've added a field to Show/Hide social media title element. Please review the MR changes. Attaching the screenshots for your reference.

Thanks!

Working on it.

Hi, I've reviewed the proposed logos for the Module as per the provided review steps.
I liked the logo jQuery-UI-Resizable.png → provided in the comment #5 📌 Project Browser: Create a logo for jQuery UI Resizable Active as it designed as the proposed logo is representing the resizing icon instead of crop. The logo proposed by @AaronDeutsch seems that the module's functionality is to crop instead on resizing.

The proposed logo meets the following requirement:

• The logo dimension is 512x512px.
• The file format is PNG.
• No animation has been used in the logo.
• Better image quality.
• The logo file size is within the 10kb.
• Logo representing the module functionality.

As the proposed logo is meeting all the requirements hence moving it to RTBC.

Thanks!

Hi, I've resolved the pipeline issues for MR !16 only as it is resolving the issue, and it has been verified by @selfirian and @leducdubleuet. The sidebar can also be hidden by clicking outside the sidebar region. Please review the MR changes and verify whether the changes are working fine or not.

Thanks!

I'm looking into the issue.

Hi @raynaldmo, follow the instructions provided in the block configuration by visiting the URL /admin/structure/block to download the libraries. All the procedures have been mentioned there to use the other icon pack. I'm attaching the screenshot for your reference.

Thanks!

Hi, I'm also facing the same issue for tel link. The telephone link is also being shown as external link icon when Use Font Awesome icons instead of images config is enable. I've applied the provided MR as a patch and it applied cleanly without any errors. I can confirm that the MR is resolving the issue successfully. I'm attaching the screenshots of before and after fixes of the issue.

Thanks!

Hi all! I've also replicated the issue following the steps to reproduce and found that the problem was caused by the use of the spaceless filter in the Twig templates. I have removed the filter from the affected templates, please review the MR changes. I'm attaching the screenshots of the before and after fixes for reference.

@doxigo, I have only removed the filter from the templates associated with the address module. Would you recommend removing the filter from all template files, or should we limit the changes to these specific ones?

Thanks!

Hi, I've applied the provided MR as a patch and it applied cleanly without any errors. After applying the patch the logo bottom cut issue has been resolved successfully. However, the current logo dimension rendered is large as compared to the previous one. If the image dimension is not an issue then moving the issue to RTBC. I'm attaching the screenshots of the before and after fixes for reference.

Thanks!

Hi @nk, I've tested the mentioned issue on 2.0.x-dev and when the number of slide is less than 2 getting a warning message as shown in the attached screenshot when saving/updating the node. And confirm that the changes are working fine, did not get any console errors when the slider has only one slide. I'm attaching the screenshot for your reference. As the changes are working fine moving the issue to RTBC.

Thanks!

Hi @dhruv.mittal, I've applied the provided MR as a patch and it applied cleanly without any errors. After applying the patch, when the anonymous user tries to access the admin page getting Access Denied along with the login form as configured through the module configuration. After logging, the user is redirected to the hit URL only. I'm attaching the video clips of the before and after fixes for reference. Moving the issue status to RTBC as the MR is resolving the issue.

Thanks!

Hi, I was also able to replicate the issue for seven theme on Drupal 10.3.6 and confirm that the issue still persists. I've applied the provided MR !13 as a patch and it applied cleanly without any errors. After applying the patch the hover effect issue has been fixed and now there's no issue while hovering the action buttons.

I've also tried replicating the issue mentioned by @ehsa_kundu in the comment #27 🐛 In ui-dialog box at Views button hover effect is odd Active and confirm that the issue persists for the Delete action button visibility issue occurring after clicking anywhere except the Delete button. On applying the patch this issue has also been fixed.

As the provided MR !13 fixing all the issues hence, moving it to RTBC. I'm attaching the video clips of before and after fixes for reference.

Thanks!

Hi, I've applied the provided MR as a patch and it applied cleanly without any errors. After applying the patch, a new configuration field 'Enable for' has been provided to Enable/Disable the module functionality for the Admin Theme or Frontend Theme. When the Admin Theme option is unchecked then the messaging shown is unaltered. The provided new field functionality is working fine. I'm attaching the screenshots of the before and after fixes for reference and moving the issue to RTBC.

Thanks!

Hi, I've fixed the external link aria-label issue. Please review the changes.
Thanks!

Hi, I've reviewed the latest changes and now the Fediverse icon is being shown. I'm attaching the screenshot of the fixes for reference. Moving issue status to RTBC as the changes are working fine.

Thanks!

Hi, I've fixed the Trash icon not being shown in the navigation while using the Trash module. Please review the changes. I'm attaching screenshots of before and after fixes of the issue for reference.

Thanks!

Hello there, I've also tried replicating the issue and found that the Trash icon is displayed in the navigation. However, when using the Gin theme, the icon does not appear as mentioned by @dqd in the comment #6 🐛 Add navigation icon for Trash Active . I think the issue should be reported for Gin theme rather than the Trash module. Attaching the screenshots for reference.

Thanks!

Moving back to Needs Review as the mentioned error in the file 3188136-nr-bot.txt → has been fixed by @Bhanu951.

I'm working on it.

Hi @redseujac @alexpott, I've fixed the site slogan issue while using the Olivero theme. Now the site slogan is being shown for all the cases when the site slogan, site name and site logo have been enable on site-branding block configuration for the theme. I'm attaching the screenshots of the fixes for the issue. Please review the MR changes.

Thanks!

Hi @awset, I've applied the provided wysiwyg-support-3076448-43.patch → in #43 ✨ WYSIWYG support on each table cell for better content experience Needs review , it applied cleanly with no errors. After applying, each table cells have user input format option. Now user can change the input format for table cells. The changes are working fine while using the module. However, after applying the patch, export table data as CSV feature is impacted due to the new changes. Previously the table data was exported as the actual data/value but after applying the patch table data is being stored as simply 'Array' text instead of array. And when the table is being imported the table created is simply containing the text 'Array' instead of actual data due to the incorrect data present in the CSV file. Previously the import and export table data as CSV was working fine. I'm attaching the screenshots of the before and after fixes for your reference. As the module functionality is impacted due to the latest patch, hence moving back the issue status to Needs work.

Thanks!

Hi, I've applied the provided MR as a patch and it applied cleanly without any error. After applying the patch the view blocks pagination is now appearing as horizontal, in addition the styling has also been improved for the pagination. I'm attaching the screenshots of before and after fixes for reference. As the changes are working fine, moving it to RTBC.

Thanks!

Hi, I've fixed the alignment issue for the paragraph label while using the Modal as field widget config. I'm attaching the screenshots of the before and after fixes for reference. Please review the MR changes.

Added comment regarding the changes made. Please review the MR.

@manishvijay02, can we use any other icon library for fediverse icon? And I think it would be better if the font-awesome cdn can be added in a new library as the theme is adding all the cdn using the library. It should not be hard coded in the html.html.twig file.

Hi, I've applied the provided MR as a patch and it applied cleanly with no errors. After applying patch now social media link fields for Fediverse and Mastodon under the theme configuration. Now the Mastodon social link icon is being shown in the social icons. However, the Fediverse social icon is not being shown in the social icon footer after input the url in the Fediverse field. I'm attaching the screenshots of before and after fixes for reference. As the social icon is not being shown for Fediverse hence, moving back issue to Needs work.

Thanks!

Hi, I've applied the provided MR as a patch and it applied cleanly without any errors. After applying the patch the configuration page of the module is now accessible and the module functionality is working as expected, tested on Drupal 11.0.5. I'm attaching the screenshots of the before and after fixes for reference.

Thanks!

@saschaeggi, I've re-reviewed the recent changes. Everything is working fine and the MR can be merged.

Hi @esha_kundu, I've fixed the design issue of single item list for seven. I've attached the screenshot of after fixes. Please review the changes.

I've reviewed the MR!40 and found you have included the styling for gin, claro and seven theme in the newly created file select2.single-style.scss however separate scss files are present for these theme styling. IMO we could maintain the discrete structure of styling as present in the module.

The reason why I included the styling in one file and not the existing files is because a new library is being attached with the Single item style widget when this functionality is enabled. If the change was to be kept in the existing file, the CSS would load even if the Single item style option was disabled.

Hi @jurgenhaas, thanks for the quick fixes. I've reviewed the latest changes made for simple_sitemap and confirm that the sticky actions button is working fine while using the module on gin theme. The memory allocation issue has been resolved successfully. And the sticky actions button is working fine for node edit, views as well as simple_multistep module.

However, I didn't encounter the issue mentioned in the comment #35 🐛 Ensure sticky action buttons to work with modals and ajax refresh-calls Needs review . While using the simple_sitemap module, I'm not getting any gin more-trigger action buttons (three dots) on gin theme. I'm attaching the screenshots of before and after fixes for your reference.

As the mentioned issues have been resolved successfully and didn't get any issues while using the theme hence, moving the issue status to RTBC.

Thanks!

Hi @sourav_paul, I've resolved the merge conflicts. Please review the MR changes.

Thanks!

@saschaeggi, I've reviewed the latest changes for the typo fixes. Now the sticky actions button issue has been resolved successfully for node edit, views as well as for simple_multistep. The actions button is working fine when using the simple_multistep module and the node is now being save.

However, I'm also encountering the same issue Fatal error: Allowed memory size of 1073741824 bytes exhausted (tried to allocate 20480 bytes) in /app/web/core/lib/Drupal/Core/Theme/ThemeManager.php on line 204 as mentioned by @hmendes in the comment #32 🐛 Ensure sticky action buttons to work with modals and ajax refresh-calls Needs review for simple_sitemap module while using the gin theme. The issue has aroused after the typo fixes. Hence, I'm keeping the status to Needs work although the issues for node edit, views, simple_multistep has been resolved.

I'm attaching the screenshots of before and after fixes for your reference.

@saschaeggi, okay I'll review it.

Hi @deepak5423, I've fixed the eslint and cspell issues reported by gitlab-ci. Please review the changes.

Thanks!

Hi @sourojeetpaul, updated the admin toolbar search design as per the provided feedback. Uploading the updated patch. Attaching the screenshot of the fixes for the issue for your reference.

Hi @saschaeggi, I've tested the new changes made and after the new changes the actions button is not working for simple_multistep module. The Next button is not working for simple_multistep module, no action is being triggered on clicking the next button. Additionally, the actions button is also not being shown for node-edit form either when the Enable sticky action buttons is enabled or disabled. The recent changes has also affect other form-edit also, on enabling the Enable sticky action buttons the Save button is also not being shown on the theme setting page. Attaching the before and after screenshots for your reference.

Ok, I'll look into it again.

Hi @deepak5423, I've converted the patch into MR. Now the module is working fine on Drupal 11. Getting no issues while using the module on Drupal 11. Please review the changes.

Thanks!

Hi @sourojeetpaul, I've fixed the admin toolbar search styling issue and updated the previous patch for the same. I'm attaching the screenshots of the before and after fixes of the issue for your reference.

Thanks!

Hi, I've fixed the decimal value issue for the image tag width attribute while using the ratio_crop image style effect. I'm attaching the screenshots of the before and after fixes for reference. Please review the changes.

Thanks!

Hi all! I've updated the logo as per the suggested changes. I've increased the logo text and updated the module name text case as per the module page. Please review the changes.

Thanks!

Hi, I've removed the xs breakpoint for bootstrap 5 and added the xl, xxl for the carousel and grid. I'm attaching screenshots of the before and after fixes for reference. Please review the changes.

Thanks!

Hi, I've applied the provided MR as a patch and it applied cleanly with no errors. Additionally, applied the provided masquerade-drop-sessions-fix-2.x.patch → patch on 2.x branch and it also applied cleanly with no errors. Before applying the patch, having more than the allowed active sessions, all real sessions are logged out. After applying the patch, only the oldest real session logged out. I'm attaching the screenshot of configuration of the session limit for reference. Moving issue status to RTBC.

Hi all! I've reviewed the proposed logo for the module and it meets the following requirements:

1. The logo dimensions is 512x512px.
2. Image file format PNG
3. No animation has been used in the logo.
4. Image quality is fine.
5. The image file size is 9.9kb.
6. Provided logo is representing the module.

@sourojeetpaul, can the ball with the icon XML, JSON size be increase as these text will not be completely visible on the small size when the logo used on the project browser page? The XML text on ball is visible but the JSON text on the ball is not clearly visible in the logo on 512x512px.

@mandclu, the css porperty .add-to-calendar { display: inline-flex;} was being used for both Modal dialog and List of links formatter while using the module and due to this css the modal was always being opened. On using the css porperty .add-to-calendar[open], span.add-to-calendar { display: inline-flex; } the modal issue resolved successfully, additionally using the open attribute the css the icons in the modal also wrap as group for the narrow spaces.

To reproduce the issue for [open]: You just have to select Modal dialog in the Links display formatter and visit the node where the date field has been used. You'll notice that the modal is being open always and the icons on the modal for narrow spaces didn't wrap properly. This issue can be resolve for modal if we also use css display:inline-flex; only when the modal opens.

And the changes in the MR !25 is working fine for the List of links for date field.

Hi @sourojeetpaul, I've reviewed the updated logo and it meets the following requirements:

1. Logo dimensions: 512x512px
2. File format: png
3. No animation has been used in the logo.
4. Image quality is fine.
5. The proposed logo represents the module functionality.

As the logo file size 10kb is not a hard and fast requirement hence moving the issue status to RTBC.

Hi, I've tested the new changes made in the provided MR and confirm that the tags overflow design for mobile devices issue has been resolved successfully. Additionally, the hover effect for tags has also been implemented and its working fine. I'm attaching the after fixes screenshot for reference. Moving the issue status to RTBC as the changes are working fine.

Thanks!

Hi all! I've applied the provided MR as a patch and it applied cleanly with no errors. After applying the text Back to site has been replaced with the current active navigation text. However, I've noticed that the hyperlink for the Back to [active_navigation] always points to the last visited node as per the ginEscapeAdmin once in the gin/js/escape_admin.js file. I've attached screenshots for reference. So, I'm adding the needs maintainer review tag for the issue and moving to RTBC.

Hi @marcoliver, yes this issue may be occurring while using the Gin theme when the Enable sticky action buttons is enabled. However, most of the missing actions button issues have already been fixed in the Gin theme in the latest release. I've also checked for the issue in the Gin theme but didn't encounter the issue for layout_paragraphs as shown in the attached screenshots.

Hi @sclsweb, I've fixed the modal opening issue even when the calendar button has not been clicked for the Links Display: Modal dialog formatter configuration. Before fixes, the modals were opened without clicking on the button. Now, the modals are displayed only when the button has been clicked. I'm attaching screenshots of before and after fixes for your reference. Please review the changes.

Thanks!

Hi @everton137, I tried replicating the issue for the missing Save and Cancel actions button but it didn't replicate. I've followed the steps to reproduce the issue and while using the module for adding paragraphs, the actions button is being shown and getting no issue while using the module. I tried switching the admin theme also and checked on Gin theme but didn't encounter such issue. In addition, I've also tested the latest release of the module on D11 but got the same outcome. I've attached all the screenshots for your reference.

Tested on Drupal 9.5.11 and Drupal 11.

I've implemented the same structure for field_group as shown in the attached screenshots but I didn't encounter the spacing issue while using the module for group type HTML Element with configuration set to inline. I've also used the smart_title module for the name field. The space between the two fields is showing only when the space has been provided in the content. Could you share the screenshot of your node edit page and field configuration for Person name suffix with leading comma. I've attached the screenshots of with and without spaces along with configurations that I've used for your reference. Please have a look into it.

Hi!, I've tested the MR !479 and it's resolving most of the issue for sticky action buttons issues. After applying the MR as a patch the sticky action buttons for media_directory, views, simple_multistep, content forms. Below are my observations:

• Sticky actions button is working fine on field settings by increasing the cardinality: Allowed number of values configurations
• Now the action buttons are also being rendered in the views UI forms like field rearrange, relationships, contextual filters.
• While using the simple_multistep module the actions button is now being shown. However, I'm also encountering the same issue as mentioned by @jurgenhaas in #22 🐛 Ensure sticky action buttons to work with modals and ajax refresh-calls Needs review . Although the save button is present in the form but the Save button is not working as expected. Getting the error messages Warning: Undefined array key "#type" in gin_form_after_build() (line 65 of themes/custom/gin/includes/form.theme).
• When using the media_directories module the Save and select button is now being displayed and working fine. I'm not getting any issue while adding any media.

In addition, I've noticed that after applying the MR as a patch gin-sticky-form-actions class div is being added in DOM twice even though only single Sticky actions button is appearing as shown in the attached screenshots. There are two different id for the sticky actions button one with id #edit-gin-sticky-actions and other with #edit-actions. Before patch there was only single gin-sticky-form-actions div with two .form-actions class was there in the DOM. Not sure about the presence of the other gin-sticky-form-actions. However, this is not impacting any functionality and getting no issues while using the theme.

I've attached screenshots of before and after fixes for your reference.

Thanks!

Hi @trackleft2, I tried replicating the issue but the issue didn't replicate. I didn't encounter the extra spaces, new lines issues in the HTML tag for the field group using the collapsible option. Could you please provide more details about the issue and screenshots related to the issue? I've attached the screenshots of the configuration that I've used for the field groups.
Tested on Drupal 10.3.2 and Field group 4.0.0-alpha1.

Hi, I've applied the provided MR as a patch and it applied cleanly with no errors. Before applying the patch, on deleting any user with option Delete the account and make its content belong to the Anonymous user. This action cannot be undone. only information was being stored that the user has been deleted. No action taken was being stored. After applying the patch, a new column Cancellation Info has been added to the Entity Delete Log page table and a new column has been added to the module table in the database. And now the user cancellation information is being stored in the new column and also in the database entity_delete_log table. I'm attaching the before and after screenshots for reference.

Thanks!

Hi @giordy, it seems that the CSS property for the middle class is not being applied because you have added space just after the dot(.) class selector. Please use the below code and check if it works for you.

.middle {
vertical-align: middle;
}

Thanks!

Hi, I've reviewed all the proposed logos for the module and I liked the logo Feeds-edited12-fs8.png → personally as this logo representing that it's being feed but in case of the logo without bowl it's representing like the monster is doing some kind of processing the files (like thinking about the files). I've reviewed the logo as per the Review steps mentioned in the issue summary. The current logo meets the following requirement:

1. Image dimensions: 512x512px
2. File format: png
3. No animation has been used in the logo.
4. Image quality is fine.
5. Proposed logo represents the module functionality.

But considering the proposed logo file size as mentioned in the #41 📌 Project Browser: Create a logo for Feeds Needs review the file size 10kb isn't a hard requirement so I'm skipping this point for the logo.

Hi all! I've reviewed the proposed logos as per the Review Steps mentioned in the issue summary. I like the logo encrypt3.png → uploaded in the comment #21 📌 Project Browser: Create a logo for Encrypt Needs work . The logo meets the following requirements:

1. Logo dimensions: 512x512px
2. File format: png
3. No animation has been used in the logo.
4. Image quality is fine.
5. Logo represents the module functionality.

However, the logo doesn't meet the file size requirement as the encrypt3.png logo file size is 10.2kb. Hence, I'm moving the issue status to Needs work.

Attached the screenshot for the logo file size reference.

Hi @sourojeetpaul, I've reviewed the logo → uploaded in the comment #9 📌 Create logo for Feeds Tamper for Project Browser Initiative Active . The proposed logo meets the following requirements:

1. Logo dimensions: 512x512px
2. File format: png
3. No animation has been used in the logo.
4. Image quality is fine.

However, the logo file size is 10.2kb (as shown in the attached screenshot) which doesn't meet the logo requirement. The logo should be within 10kb. The logo represents the module functionality but I think it would be better if the feeds input and output for the tamper were shown in different colors like the shape conversion has been shown from circle to square. So that it can be distinguished for the conversion. In addition, the word tamper or t should be added in the tamper design as like #4 📌 Create logo for Feeds Tamper for Project Browser Initiative Active or the feeds-tamper-logo-attempt.png → shown by @megachriz.

As the proposed logo doesn't meet the logo requirements hence moving issue status to Needs work.

Thanks!

Hi @sourojeetpaul, I've reviewed the proposed logo as per the Review Steps mentioned in the issue summary. The proposed logo meets the requirements:

1. Logo size: 512x512px
2. Image format: png
3. File size: 6.7kb < 10kb
4. No animations have been used in the logo.
5. Image quality is fine.
6. Representing the module functionality as per the module use cases.

As the current logo aligns with the requirements, I'm moving it to RTBC+1.

Thanks!

Hi, I've applied the provided MR as a patch and it applied cleanly with no errors. After applying the patch the styling has been improved for the tags. However, the tags design is overflowing on mobile devices as shown in the attached screenshot. I've attached screenshots of the before and after fixes for reference. Since the issue persists for the mobile devices, I'm moving the issue status to Needs work.

@saschaeggi, fixed the pipeline phpcs issues. Please review the changes.

Thanks!

Hi @hatuhay, I've fixed the full-width layout region issue. Please review the changes. I'm attaching the after fixes screenshots for your reference.

Thanks!

@sirclickalot, the used MR link is incorrect here

4. Patch with 69 from https://git.drupalcode.org/project/frontend_editing/-/merge_requests/69/...

You'll have to use the MR link for the patch : https://git.drupalcode.org/project/frontend_editing/-/merge_requests/69.patch.

@sirclickalot, you can apply the patch using composer. If you want to apply the patch using the patch file downloaded locally then put the downloaded patch file in a directory named patches/ which will be in your root directory like drupal10/patches/frontend-editing-69.patch. Then you can add the patch details in the composer.json file as:

"extra": {
    ......
        "patches": {
            "drupal/frontend_editing": {
                "3440870 - floating links": "patches/frontend-editing-69.patch"
            },
           ......
        }
  .....
}

Hope this will resolve your issue.

Hi @a.dmitriiev, I've tested the new re-structured changes in the MR !69 and it looks good to me. I've also applied it as a patch and it's getting applied with no errors. And the new duplicate_links.js file is being added to the js directory of the frontend_editing module directory. Didn't encounter the issue mentioned by @sirclickalot in the comment #42 ✨ Float action links at bottom too Needs review . The new experimental duplicate action links button at the bottom functionality is working fine for all the entity bundles, also when using the entity reference field.

Thanks!

@riddhi.addweb, have you cleared the cache after applying the patch? I've applied the patch and it is getting applied with no errors and after clearing the cache the changes are visible. I'm not getting any issue after applying the patch. I've checked on Drupal 10.2 version also and didn't get the issue of advance search spacing after applying the patch. Moving back issue status to Needs review so that other devs can review this issue.

Hi @shelane, I've reviewed the latest changes and a new field has been provided in the view for the cards component. While choosing the Select by fields under Display configuration all the fields become required, and on selecting the None getting error "Please select an item in the list. This issue is due to the field marked as required. Due to this issue, it is not possible to leave any field empty the user will have to render all the card components like body, title and image. I think when the None option is being provided then fields should not be marked as required.

Hi @sergiur, I've fixed the double border being rendered for the horizontal tabs due to claro-details class. The claro-details class is being added due to the changes made in the feature request Add classes to JS rewriting in horizontal tabs ✨ Add classes to JS rewriting in horizontal tabs Fixed . I've attached the before and after fixes screenshots for your reference. Please review the changes.

Thanks!

Hi, I've applied the provided MR as a patch and it applied cleanly with no errors. I can confirm that the module functionality is working perfectly after applying the patch. I'm attaching the before and after fixes screenshots for reference. As the patch is resolving the issue and getting no errors while using the module hence moving the issue status to RTBC.

Thanks!

Hi @mandclu, now I can confirm that the styling issue for the duration has been fixed. I've tested the overlay duration for both 12h and 24h formatting and the overlay design is working perfectly. I'm attaching the screenshots for your reference. RTBC.

Thanks!

Hi @mandclu, I've applied the provided MR as a patch and it applied cleanly with no errors. After applying the patch Use an overlay to display duration options. - EXPERIMENTAL option is now being shown in smart_date field widget. When enabling the new overlay display duration, duration is shown between the time in the node edit page. However, there's a spacing/alignment issue in the overlay as shown in the attached screenshot. The extra spaces issue can be resolved if width: 3.75rem; is removed from the class .smart-date--duration-list--time. After removing the extra space is not visible and the time duration is displayed properly. I've attached screenshots of before and after fixes for your reference. As the design issue is present hence moving the issue status to Needs work.

Thanks!