- Issue created by @piridium
- First commit to issue fork.
- Merge request !548#3493765: Add a second selector to the css rule in order to properly override claro. โ (Open) created by Unnamed author
- ๐จ๐ญSwitzerland piridium
@christosgeorgiadis Thanks for the merge request. However, I think you have not implemented the original patch correctly. The 'table' itself has the class '.table-file-multiple-widget' and its child td should be set to 'height: auto'.
Your solution works, but only because the table in question is a child of another table. I can imagine that there may be situations in which this is not the case. - ๐ฌ๐ทGreece christosgeorgiadis
I don't know much scss so I can't proceed any further to address your requirements. Someone more experienced should make a commit to the MR so that the patch is implemented properly.
- First commit to issue fork.
- ๐ฌ๐ทGreece christosgeorgiadis
I've tested the MR and while it does fix what it was trying to, I feel like we should address that the Alternative Text textbox, description and remove button can overflow outside if the browser window gets too small. Or should this be another issue of its own?
- ๐ฉ๐ชGermany simonbitmade
Iยดve tested the
MR !548
and it fixes my Problem!Because of a nesting within a paragraph I was not able to click the button for further elements due to the bug.
Applying the patch makes the UI conform to my expectations, thank you very much. I would suggest the RTBC Status.
I think the drag button should be middle instead of top. I am working on it to fix.
- ๐ฆ๐ชUnited Arab Emirates mudasirweb
Noticed a couple of issues:
1. The layout breaks on mobile and iPad resolutions.
2. The "Remove" button is too close to the title and alt fields.
3. It would make more sense to display the image name below the image. - ๐ฆ๐ชUnited Arab Emirates mudasirweb
Fixed mobile and iPad resolutions. Also aligned remove button and image name.
Please review.Before:
After
HI @mudasirweb, Thanks for your work however, I have a couple of doubts that I would like to clarify
1. Here below i attached ss for Single image field. So in case for multiple image field we should also maintain this design why we are putting
the image title at the bottom.2. Could you please compile the SCSS file thoroughly? It seems to be causing a pipeline failure.
Hi @mudasirweb,
I noticed that the image title is still positioned at the bottom. As I mentioned in #21, it should maintain integrity with the single image field. If I am mistaken, could someone kindly verify it?
- Status changed to Needs review
about 1 month ago 11:43am 27 February 2025 - ๐ฆ๐ชUnited Arab Emirates mudasirweb
Moved image title to top in-order to maintain integrity with the single image field.
- ๐จ๐ญSwitzerland piridium
Thank you @mudasirweb and @sandip-poddar for taking care of further adjustments. However, I think it would be primarily important to get the original patch into a release, as the bug blocks the use of multivalued fields. We already have a confirmation for RTBC in #14. @saschaeggi could you please include this in a release?
Further adjustments like the centered drag handles and the title should imho be discussed in a separate issue. - ๐ฎ๐ณIndia Tirupati_Singh
Hi all, I've tried replicating the issue, and it reproduced. I've applied the provided MR as a patch, and it applied cleanly without any errors. After applying the patch, the multivalued image field overlap issue got resolved successfully, along with the mentioned issues in the comment #17 ๐ Widget for multivalued file field overlap Active . Now, the multivalued image fields occupying the required space and are not blocking the usage of multivalued fields, as mentioned by @piridium.
Thanks to @mudasirweb and @sandip-poddar for resolving further designing issues while using this theme. Initially, the drag handler is center-aligned for the theme for all fields/tables, so it would be better if consistency is maintained for the theme. As changes made for the handler are not affecting the other functionality while using the theme, hence moving the issue to RTBC. I've attached the screenshots of before and after fixes for reference.
Thanks!