Widget for multivalued file field overlap

Created on 13 December 2024, 4 months ago

Problem/Motivation

With the latest two releases (rc14 and rc15) thumbnail images from a multivalued image field inside a paragraph do overlap rendering the widgets unusable.

Steps to reproduce

Install the latest (rc15) version of gin and place a multivalued image field inside a paragraph.

Proposed resolution

My suspicion of what's going on: A style rule in is setting the height of the to some calculated value. tries to override it, but rule wins because of higher specificity.
Add a second selector to the css rule in gin.css in order to properly override claro.

Remaining tasks

I am not familiar with the build process of claros css files, so the attached patch just works on the css. Someone with more knowledge of the build process should please backport it to the scss code.

User interface changes

none

API changes

none

Data model changes

none

๐Ÿ› Bug report
Status

Active

Version

3.0

Component

Code

Created by

๐Ÿ‡จ๐Ÿ‡ญSwitzerland piridium

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @piridium
  • ๐Ÿ‡จ๐Ÿ‡ญSwitzerland piridium
  • ๐Ÿ‡จ๐Ÿ‡ญSwitzerland piridium
  • ๐Ÿ‡จ๐Ÿ‡ญSwitzerland piridium
  • First commit to issue fork.
  • Pipeline finished with Success
    4 months ago
    Total: 217s
    #367701
  • ๐Ÿ‡จ๐Ÿ‡ญSwitzerland piridium

    @christosgeorgiadis Thanks for the merge request. However, I think you have not implemented the original patch correctly. The 'table' itself has the class '.table-file-multiple-widget' and its child td should be set to 'height: auto'.
    Your solution works, but only because the table in question is a child of another table. I can imagine that there may be situations in which this is not the case.

  • ๐Ÿ‡ฌ๐Ÿ‡ทGreece christosgeorgiadis

    I don't know much scss so I can't proceed any further to address your requirements. Someone more experienced should make a commit to the MR so that the patch is implemented properly.

  • First commit to issue fork.
  • Pipeline finished with Success
    4 months ago
    Total: 204s
    #369518
  • ๐Ÿ‡จ๐Ÿ‡ญSwitzerland saschaeggi Zurich

    Waiting for an RTBC here. Thanks!

  • ๐Ÿ‡ฌ๐Ÿ‡ทGreece christosgeorgiadis

    I've tested the MR and while it does fix what it was trying to, I feel like we should address that the Alternative Text textbox, description and remove button can overflow outside if the browser window gets too small. Or should this be another issue of its own?

  • ๐Ÿ‡ฉ๐Ÿ‡ชGermany simonbitmade

    Iยดve tested the MR !548 and it fixes my Problem!

    Because of a nesting within a paragraph I was not able to click the button for further elements due to the bug.

    Applying the patch makes the UI conform to my expectations, thank you very much. I would suggest the RTBC Status.

  • I think the drag button should be middle instead of top. I am working on it to fix.

  • Pipeline finished with Success
    2 months ago
    Total: 253s
    #402409
  • Please review the changes.

    Before:

    After:

  • ๐Ÿ‡ฆ๐Ÿ‡ชUnited Arab Emirates mudasirweb

    Noticed a couple of issues:

    1. The layout breaks on mobile and iPad resolutions.
    2. The "Remove" button is too close to the title and alt fields.
    3. It would make more sense to display the image name below the image.

  • ๐Ÿ‡ฆ๐Ÿ‡ชUnited Arab Emirates mudasirweb
  • ๐Ÿ‡ฆ๐Ÿ‡ชUnited Arab Emirates mudasirweb

    Fixed mobile and iPad resolutions. Also aligned remove button and image name.
    Please review.

    Before:

    After

  • ๐Ÿ‡ฆ๐Ÿ‡ชUnited Arab Emirates mudasirweb
  • HI @mudasirweb, Thanks for your work however, I have a couple of doubts that I would like to clarify

    1. Here below i attached ss for Single image field. So in case for multiple image field we should also maintain this design why we are putting
    the image title at the bottom.

    2. Could you please compile the SCSS file thoroughly? It seems to be causing a pipeline failure.

  • Pipeline finished with Failed
    2 months ago
    Total: 364283s
    #403496
  • Pipeline finished with Failed
    2 months ago
    Total: 978s
    #407327
  • Pipeline finished with Success
    2 months ago
    Total: 284s
    #407391
  • ๐Ÿ‡ฆ๐Ÿ‡ชUnited Arab Emirates mudasirweb

    Fixed pipeline failure.

  • ๐Ÿ‡ฆ๐Ÿ‡ชUnited Arab Emirates mudasirweb
  • Hi @mudasirweb,

    I noticed that the image title is still positioned at the bottom. As I mentioned in #21, it should maintain integrity with the single image field. If I am mistaken, could someone kindly verify it?

  • Pipeline finished with Success
    about 1 month ago
    Total: 206s
    #435660
  • Status changed to Needs review about 1 month ago
  • ๐Ÿ‡ฆ๐Ÿ‡ชUnited Arab Emirates mudasirweb

    Moved image title to top in-order to maintain integrity with the single image field.

  • ๐Ÿ‡จ๐Ÿ‡ญSwitzerland piridium

    Thank you @mudasirweb and @sandip-poddar for taking care of further adjustments. However, I think it would be primarily important to get the original patch into a release, as the bug blocks the use of multivalued fields. We already have a confirmation for RTBC in #14. @saschaeggi could you please include this in a release?
    Further adjustments like the centered drag handles and the title should imho be discussed in a separate issue.

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia Tirupati_Singh

    Hi all, I've tried replicating the issue, and it reproduced. I've applied the provided MR as a patch, and it applied cleanly without any errors. After applying the patch, the multivalued image field overlap issue got resolved successfully, along with the mentioned issues in the comment #17 ๐Ÿ› Widget for multivalued file field overlap Active . Now, the multivalued image fields occupying the required space and are not blocking the usage of multivalued fields, as mentioned by @piridium.

    Thanks to @mudasirweb and @sandip-poddar for resolving further designing issues while using this theme. Initially, the drag handler is center-aligned for the theme for all fields/tables, so it would be better if consistency is maintained for the theme. As changes made for the handler are not affecting the other functionality while using the theme, hence moving the issue to RTBC. I've attached the screenshots of before and after fixes for reference.

    Thanks!

Production build 0.71.5 2024