Brussels
Account created on 22 March 2018, over 7 years ago
  • Backend Developer at Minsky 
#

Merge Requests

More

Recent comments

🇧🇪Belgium dieterholvoet Brussels

I re-rolled the patch for Drupal 11.1.x.

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet created an issue.

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet created an issue.

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet created an issue.

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet created an issue.

🇧🇪Belgium dieterholvoet Brussels

Hi @bojan_dev! Friendly reminder, seems like you forgot to update the credits in the contribution record.

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet created an issue.

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet created an issue.

🇧🇪Belgium dieterholvoet Brussels

Thanks for reporting! The issue is fixed in the 3.0.2 release.

🇧🇪Belgium dieterholvoet Brussels

You're right, I tested the new version and the problem is fixed.

🇧🇪Belgium dieterholvoet Brussels

I have been consistently getting this issue on sites when switching Config Splits that cause (un)installation of about 15 modules. The MR doesn't fix the issue for me, I'm still getting the following error after (un)installing the 8th module:

Fatal error: Allowed memory size of 536870912 bytes exhausted (tried to allocate 831488 bytes)

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet made their first commit to this issue’s fork.

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet created an issue.

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet changed the visibility of the branch 8.x-1.x to hidden.

🇧🇪Belgium dieterholvoet Brussels

Thanks for your contribution!

🇧🇪Belgium dieterholvoet Brussels

Here's a patch that fixes the issue. I know it's not ideal, but it's a sufficient workaround until we can upgrade to 3.x, where this issue might be fixed because of your refactorings.

🇧🇪Belgium dieterholvoet Brussels

I'm getting this issue using 2.0.0-beta7, but I'm not able to reproduce it reliably. I'm only getting the issue on production and I think on what's supposed to be an error page.

Symfony\Component\DependencyInjection\Exception\ServiceCircularReferenceException: Circular reference detected for service "router.route_provider", path: "options_request_listener -> router.route_provider -> path_processor_manager -> domain_source.path_processor -> Drupal\Core\Logger\LoggerChannelFactoryInterface -> logger.raven -> router -> router.no_access_checks". in Drupal\Component\DependencyInjection\Container->get() (line 149 of /var/web/vd28102/deploy/releases/20251030110737/web/core/lib/Drupal/Component/DependencyInjection/Container.php).

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet created an issue.

🇧🇪Belgium dieterholvoet Brussels

Here's part of the infinitely recursing stack trace:

token_tokens('site_setting_entity', Array, Array, Array, Object) (Line: 53)
Drupal\hook_event_dispatcher\HookEventDispatcherModuleHandler::Drupal\hook_event_dispatcher\{closure}('\token_tokens', 'token') (Line: 307)
Drupal\Core\Extension\ModuleHandler->invokeAllWith('tokens', Object) (Line: 68)
Drupal\hook_event_dispatcher\HookEventDispatcherModuleHandler->invokeAllWith('tokens', Object) (Line: 52)
Drupal\hook_event_dispatcher\HookEventDispatcherModuleHandler->invokeAll('tokens', Array) (Line: 359)
Drupal\Core\Utility\Token->generate('site_setting_entity', Array, Array, Array, Object) (Line: 191)
site_settings_tokens('site_settings_entity', Array, Array, Array, Object) (Line: 53)
Drupal\hook_event_dispatcher\HookEventDispatcherModuleHandler::Drupal\hook_event_dispatcher\{closure}('\site_settings_tokens', 'site_settings') (Line: 307)
Drupal\Core\Extension\ModuleHandler->invokeAllWith('tokens', Object) (Line: 68)
Drupal\hook_event_dispatcher\HookEventDispatcherModuleHandler->invokeAllWith('tokens', Object) (Line: 52)
Drupal\hook_event_dispatcher\HookEventDispatcherModuleHandler->invokeAll('tokens', Array) (Line: 359)
Drupal\Core\Utility\Token->generate('site_settings_entity', Array, Array, Array, Object) (Line: 241)
Drupal\Core\Utility\Token->doReplace(1, '[site_settings_entity:metadata:field_meta_description]', Array, Array, Object) (Line: 191)
Drupal\Core\Utility\Token->replace('[site_settings_entity:metadata:field_meta_description]', Array, Array, NULL) (Line: 66)
Drupal\metatag\MetatagToken->replace('[site_settings_entity:metadata:field_meta_description]', Array, Array) (Line: 783)
Drupal\metatag\MetatagManager->processTagValue(Object, Array, Array, , 'fr-BE') (Line: 626)
Drupal\metatag\MetatagManager->generateRawElements(Array, Object) (Line: 61)
Drupal\metatag\Plugin\Field\MetatagEntityFieldItemList::Drupal\metatag\Plugin\Field\{closure}() (Line: 593)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 48)
Drupal\metatag\Plugin\Field\MetatagEntityFieldItemList->computeValue() (Line: 32)
Drupal\metatag\Plugin\Field\MetatagEntityFieldItemList->ensureComputedValue() (Line: 43)
Drupal\metatag\Plugin\Field\MetatagEntityFieldItemList->getValue() (Line: 314)
Drupal\site_settings\Plugin\SiteSettingsLoader\FlattenedSiteSettingsLoader->getValue(Object) (Line: 265)
Drupal\site_settings\Plugin\SiteSettingsLoader\FlattenedSiteSettingsLoader->getValues(Object) (Line: 223)
Drupal\site_settings\Plugin\SiteSettingsLoader\FlattenedSiteSettingsLoader->buildSettings('fr-BE') (Line: 173)
Drupal\site_settings\Plugin\SiteSettingsLoader\FlattenedSiteSettingsLoader->rebuildCache('fr-BE') (Line: 164)
Drupal\site_settings\Plugin\SiteSettingsLoader\FlattenedSiteSettingsLoader->loadAll() (Line: 46)
site_settings_token_info() (Line: 53)
Drupal\hook_event_dispatcher\HookEventDispatcherModuleHandler::Drupal\hook_event_dispatcher\{closure}('\site_settings_token_info', 'site_settings') (Line: 307)
Drupal\Core\Extension\ModuleHandler->invokeAllWith('token_info', Object) (Line: 68)
Drupal\hook_event_dispatcher\HookEventDispatcherModuleHandler->invokeAllWith('token_info', Object) (Line: 52)
Drupal\hook_event_dispatcher\HookEventDispatcherModuleHandler->invokeAll('token_info') (Line: 40)
Drupal\token\Token->getInfo() (Line: 100)
Drupal\token\Token->getTokenInfo('site_setting_entity', 'field_meta_description') (Line: 57)
Drupal\token\TokenModuleProvider->resolveCacheMiss('site_setting_entity::field_meta_description') (Line: 148)
Drupal\Core\Cache\CacheCollector->get('site_setting_entity::field_meta_description') (Line: 49)
Drupal\token\TokenModuleProvider->getTokenModule('site_setting_entity', 'field_meta_description') (Line: 1754)
_field_tokens('entity', Array, Array, Array, Object) (Line: 503)
token_tokens('entity', Array, Array, Array, Object) (Line: 53)
Drupal\hook_event_dispatcher\HookEventDispatcherModuleHandler::Drupal\hook_event_dispatcher\{closure}('\token_tokens', 'token') (Line: 307)
Drupal\Core\Extension\ModuleHandler->invokeAllWith('tokens', Object) (Line: 68)
Drupal\hook_event_dispatcher\HookEventDispatcherModuleHandler->invokeAllWith('tokens', Object) (Line: 52)
Drupal\hook_event_dispatcher\HookEventDispatcherModuleHandler->invokeAll('tokens', Array) (Line: 359)
Drupal\Core\Utility\Token->generate('entity', Array, Array, Array, Object) (Line: 1097)
token_tokens('site_setting_entity', Array, Array, Array, Object) (Line: 53)
Drupal\hook_event_dispatcher\HookEventDispatcherModuleHandler::Drupal\hook_event_dispatcher\{closure}('\token_tokens', 'token') (Line: 307)
Drupal\Core\Extension\ModuleHandler->invokeAllWith('tokens', Object) (Line: 68)
Drupal\hook_event_dispatcher\HookEventDispatcherModuleHandler->invokeAllWith('tokens', Object) (Line: 52)
Drupal\hook_event_dispatcher\HookEventDispatcherModuleHandler->invokeAll('tokens', Array) (Line: 359)
Drupal\Core\Utility\Token->generate('site_setting_entity', Array, Array, Array, Object) (Line: 191)
site_settings_tokens('site_settings_entity', Array, Array, Array, Object) (Line: 53)
Drupal\hook_event_dispatcher\HookEventDispatcherModuleHandler::Drupal\hook_event_dispatcher\{closure}('\site_settings_tokens', 'site_settings') (Line: 307)
Drupal\Core\Extension\ModuleHandler->invokeAllWith('tokens', Object) (Line: 68)
Drupal\hook_event_dispatcher\HookEventDispatcherModuleHandler->invokeAllWith('tokens', Object) (Line: 52)
Drupal\hook_event_dispatcher\HookEventDispatcherModuleHandler->invokeAll('tokens', Array) (Line: 359)
Drupal\Core\Utility\Token->generate('site_settings_entity', Array, Array, Array, Object) (Line: 241)
Drupal\Core\Utility\Token->doReplace(1, '[site_settings_entity:metadata:field_meta_description]', Array, Array, Object) (Line: 191)
Drupal\Core\Utility\Token->replace('[site_settings_entity:metadata:field_meta_description]', Array, Array, NULL) (Line: 66)
Drupal\metatag\MetatagToken->replace('[site_settings_entity:metadata:field_meta_description]', Array, Array) (Line: 783)
Drupal\metatag\MetatagManager->processTagValue(Object, Array, Array, , 'fr-BE') (Line: 626)
Drupal\metatag\MetatagManager->generateRawElements(Array, Object) (Line: 61)
Drupal\metatag\Plugin\Field\MetatagEntityFieldItemList::Drupal\metatag\Plugin\Field\{closure}() (Line: 593)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 48)
Drupal\metatag\Plugin\Field\MetatagEntityFieldItemList->computeValue() (Line: 32)
Drupal\metatag\Plugin\Field\MetatagEntityFieldItemList->ensureComputedValue() (Line: 43)
Drupal\metatag\Plugin\Field\MetatagEntityFieldItemList->getValue() (Line: 314)
Drupal\site_settings\Plugin\SiteSettingsLoader\FlattenedSiteSettingsLoader->getValue(Object) (Line: 265)
Drupal\site_settings\Plugin\SiteSettingsLoader\FlattenedSiteSettingsLoader->getValues(Object) (Line: 223)
Drupal\site_settings\Plugin\SiteSettingsLoader\FlattenedSiteSettingsLoader->buildSettings('fr-BE') (Line: 173)
Drupal\site_settings\Plugin\SiteSettingsLoader\FlattenedSiteSettingsLoader->rebuildCache('fr-BE') (Line: 164)
Drupal\site_settings\Plugin\SiteSettingsLoader\FlattenedSiteSettingsLoader->loadAll() (Line: 46)
site_settings_token_info() (Line: 53)
Drupal\hook_event_dispatcher\HookEventDispatcherModuleHandler::Drupal\hook_event_dispatcher\{closure}('\site_settings_token_info', 'site_settings') (Line: 307)
Drupal\Core\Extension\ModuleHandler->invokeAllWith('token_info', Object) (Line: 68)
Drupal\hook_event_dispatcher\HookEventDispatcherModuleHandler->invokeAllWith('token_info', Object) (Line: 52)
Drupal\hook_event_dispatcher\HookEventDispatcherModuleHandler->invokeAll('token_info') (Line: 40)
Drupal\token\Token->getInfo() (Line: 100)
Drupal\token\Token->getTokenInfo('site_setting_entity', 'field_meta_description') (Line: 57)
Drupal\token\TokenModuleProvider->resolveCacheMiss('site_setting_entity::field_meta_description') (Line: 148)
Drupal\Core\Cache\CacheCollector->get('site_setting_entity::field_meta_description') (Line: 49)
Drupal\token\TokenModuleProvider->getTokenModule('site_setting_entity', 'field_meta_description') (Line: 1754)
_field_tokens('entity', Array, Array, Array, Object) (Line: 503)
token_tokens('entity', Array, Array, Array, Object) (Line: 53)
Drupal\hook_event_dispatcher\HookEventDispatcherModuleHandler::Drupal\hook_event_dispatcher\{closure}('\token_tokens', 'token') (Line: 307)
Drupal\Core\Extension\ModuleHandler->invokeAllWith('tokens', Object) (Line: 68)
Drupal\hook_event_dispatcher\HookEventDispatcherModuleHandler->invokeAllWith('tokens', Object) (Line: 52)
Drupal\hook_event_dispatcher\HookEventDispatcherModuleHandler->invokeAll('tokens', Array) (Line: 359)
Drupal\Core\Utility\Token->generate('entity', Array, Array, Array, Object) (Line: 1097)
token_tokens('site_setting_entity', Array, Array, Array, Object) (Line: 53)
Drupal\hook_event_dispatcher\HookEventDispatcherModuleHandler::Drupal\hook_event_dispatcher\{closure}('\token_tokens', 'token') (Line: 307)
Drupal\Core\Extension\ModuleHandler->invokeAllWith('tokens', Object) (Line: 68)
Drupal\hook_event_dispatcher\HookEventDispatcherModuleHandler->invokeAllWith('tokens', Object) (Line: 52)
Drupal\hook_event_dispatcher\HookEventDispatcherModuleHandler->invokeAll('tokens', Array) (Line: 359)
Drupal\Core\Utility\Token->generate('site_setting_entity', Array, Array, Array, Object) (Line: 191)
site_settings_tokens('site_settings_entity', Array, Array, Array, Object) (Line: 53)
Drupal\hook_event_dispatcher\HookEventDispatcherModuleHandler::Drupal\hook_event_dispatcher\{closure}('\site_settings_tokens', 'site_settings') (Line: 307)
Drupal\Core\Extension\ModuleHandler->invokeAllWith('tokens', Object) (Line: 68)
Drupal\hook_event_dispatcher\HookEventDispatcherModuleHandler->invokeAllWith('tokens', Object) (Line: 52)
Drupal\hook_event_dispatcher\HookEventDispatcherModuleHandler->invokeAll('tokens', Array) (Line: 359)
Drupal\Core\Utility\Token->generate('site_settings_entity', Array, Array, Array, Object) (Line: 241)
Drupal\Core\Utility\Token->doReplace(1, '[site_settings_entity:metadata:field_meta_description]', Array, Array, Object) (Line: 191)
Drupal\Core\Utility\Token->replace('[site_settings_entity:metadata:field_meta_description]', Array, Array, NULL) (Line: 66)
Drupal\metatag\MetatagToken->replace('[site_settings_entity:metadata:field_meta_description]', Array, Array) (Line: 783)
Drupal\metatag\MetatagManager->processTagValue(Object, Array, Array, , 'fr-BE') (Line: 626)
Drupal\metatag\MetatagManager->generateRawElements(Array, Object) (Line: 61)
Drupal\metatag\Plugin\Field\MetatagEntityFieldItemList::Drupal\metatag\Plugin\Field\{closure}() (Line: 593)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 48)
Drupal\metatag\Plugin\Field\MetatagEntityFieldItemList->computeValue() (Line: 32)
Drupal\metatag\Plugin\Field\MetatagEntityFieldItemList->ensureComputedValue() (Line: 43)
Drupal\metatag\Plugin\Field\MetatagEntityFieldItemList->getValue() (Line: 314)
Drupal\site_settings\Plugin\SiteSettingsLoader\FlattenedSiteSettingsLoader->getValue(Object) (Line: 265)
Drupal\site_settings\Plugin\SiteSettingsLoader\FlattenedSiteSettingsLoader->getValues(Object) (Line: 223)
Drupal\site_settings\Plugin\SiteSettingsLoader\FlattenedSiteSettingsLoader->buildSettings('fr-BE') (Line: 173)
Drupal\site_settings\Plugin\SiteSettingsLoader\FlattenedSiteSettingsLoader->rebuildCache('fr-BE') (Line: 164)
Drupal\site_settings\Plugin\SiteSettingsLoader\FlattenedSiteSettingsLoader->loadAll() (Line: 46)
site_settings_token_info() (Line: 53)
Drupal\hook_event_dispatcher\HookEventDispatcherModuleHandler::Drupal\hook_event_dispatcher\{closure}('\site_settings_token_info', 'site_settings') (Line: 307)
Drupal\Core\Extension\ModuleHandler->invokeAllWith('token_info', Object) (Line: 68)
Drupal\hook_event_dispatcher\HookEventDispatcherModuleHandler->invokeAllWith('token_info', Object) (Line: 52)
Drupal\hook_event_dispatcher\HookEventDispatcherModuleHandler->invokeAll('token_info') (Line: 40)
Drupal\token\Token->getInfo() (Line: 100)
Drupal\token\Token->getTokenInfo('site_setting_entity', 'field_meta_description') (Line: 57)
Drupal\token\TokenModuleProvider->resolveCacheMiss('site_setting_entity::field_meta_description') (Line: 148)
Drupal\Core\Cache\CacheCollector->get('site_setting_entity::field_meta_description') (Line: 49)
Drupal\token\TokenModuleProvider->getTokenModule('site_setting_entity', 'field_meta_description') (Line: 1754)
_field_tokens('entity', Array, Array, Array, Object) (Line: 503)
token_tokens('entity', Array, Array, Array, Object) (Line: 53)
Drupal\hook_event_dispatcher\HookEventDispatcherModuleHandler::Drupal\hook_event_dispatcher\{closure}('\token_tokens', 'token') (Line: 307)
Drupal\Core\Extension\ModuleHandler->invokeAllWith('tokens', Object) (Line: 68)
Drupal\hook_event_dispatcher\HookEventDispatcherModuleHandler->invokeAllWith('tokens', Object) (Line: 52)
Drupal\hook_event_dispatcher\HookEventDispatcherModuleHandler->invokeAll('tokens', Array) (Line: 359)
Drupal\Core\Utility\Token->generate('entity', Array, Array, Array, Object) (Line: 1097)
token_tokens('site_setting_entity', Array, Array, Array, Object) (Line: 53)
🇧🇪Belgium dieterholvoet Brussels

dieterholvoet created an issue.

🇧🇪Belgium dieterholvoet Brussels

Yeah, with 🐛 Mismatched entity and/or field definitions Active committed and released the original issue is back. Don't have time to investigate, so here's a rebased version of the original MR of this issue.

🇧🇪Belgium dieterholvoet Brussels

Removing the Postponed label since we already dropped support for Drupal 9.

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet made their first commit to this issue’s fork.

🇧🇪Belgium dieterholvoet Brussels

Good catch! I commented in the MR.

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet created an issue.

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet made their first commit to this issue’s fork.

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet made their first commit to this issue’s fork.

🇧🇪Belgium dieterholvoet Brussels

Thanks!

🇧🇪Belgium dieterholvoet Brussels

Good catch, thanks!

🇧🇪Belgium dieterholvoet Brussels

This has been causing issues in a lot of contrib and custom code, it would be nice to have this fixed. Linking some related contrib issues.

🇧🇪Belgium dieterholvoet Brussels

Looks good!

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet created an issue.

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet created an issue.

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet created an issue.

🇧🇪Belgium dieterholvoet Brussels

Could you test the MR from 🐛 RequiredApiRecursiveValidator discards violations triggered by regular constraints Active first? We have been discarding too many constraint violations and that issue aims to fix that, without handling Inline Entity Form specifically. If that were to fix your problem as well, that would be even better.

🇧🇪Belgium dieterholvoet Brussels

There's a button at the top of the page that should give you push rights, next to the MR information.

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet made their first commit to this issue’s fork.

🇧🇪Belgium dieterholvoet Brussels

Thanks for your contribution!

🇧🇪Belgium dieterholvoet Brussels

Thanks for your contributions! Seems like some more issues turned up in the pipeline though, so going to leave this open.

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet made their first commit to this issue’s fork.

🇧🇪Belgium dieterholvoet Brussels

I don't see why we should randomly drop support for core versions below 8.8. If you have a specific reason to do this, feel free to leave a comment.

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet made their first commit to this issue’s fork.

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet changed the visibility of the branch 8.x-2.x to hidden.

🇧🇪Belgium dieterholvoet Brussels

@defcon0 next time just add your changes to the existing MR. I just did, so I'm going to close your MR.

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet created an issue.

🇧🇪Belgium dieterholvoet Brussels

Thanks!

🇧🇪Belgium dieterholvoet Brussels

This is being fixed in 🐛 Fix lifecycle-link typo Needs review .

🇧🇪Belgium dieterholvoet Brussels

Thanks for your contribution!

🇧🇪Belgium dieterholvoet Brussels

@daniel_j you can get push access to any issue by clicking the button next to the MR information, below the issue description.

🇧🇪Belgium dieterholvoet Brussels

Thanks for your contribution! Had to fix the update hook, but apart from that everything seems fine.

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet made their first commit to this issue’s fork.

🇧🇪Belgium dieterholvoet Brussels

I'm going to mark this as Won't fix since the module is now obsolete.

🇧🇪Belgium dieterholvoet Brussels

Thanks for your contribution! I'll mark the Drupal project as obsolete as well.

🇧🇪Belgium dieterholvoet Brussels

I added some more information to the change record, changed the lifecycle link to the change record and bumped the minimum Devel version.

🇧🇪Belgium dieterholvoet Brussels

Thank you for your contribution!

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet made their first commit to this issue’s fork.

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet made their first commit to this issue’s fork.

🇧🇪Belgium dieterholvoet Brussels

I added the missing code mentioned in #175 to the MR and simplified it.

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet changed the visibility of the branch 9.3.x to hidden.

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet changed the visibility of the branch 2985168-edit-media-in-library to hidden.

Production build 0.71.5 2024