dieterholvoet → made their first commit to this issue’s fork.
dieterholvoet → made their first commit to this issue’s fork.
This has been causing issues in a lot of contrib and custom code, it would be nice to have this fixed. Linking some related contrib issues.
Could you test the MR from 🐛 RequiredApiRecursiveValidator discards violations triggered by regular constraints Active first? We have been discarding too many constraint violations and that issue aims to fix that, without handling Inline Entity Form specifically. If that were to fix your problem as well, that would be even better.
There's a button at the top of the page that should give you push rights, next to the MR information.
dieterholvoet → made their first commit to this issue’s fork.
Thanks for your contributions! Seems like some more issues turned up in the pipeline though, so going to leave this open.
dieterholvoet → made their first commit to this issue’s fork.
I don't see why we should randomly drop support for core versions below 8.8. If you have a specific reason to do this, feel free to leave a comment.
dieterholvoet → made their first commit to this issue’s fork.
dieterholvoet → changed the visibility of the branch 8.x-2.x to hidden.
@defcon0 next time just add your changes to the existing MR. I just did, so I'm going to close your MR.
This is being fixed in 🐛 Fix lifecycle-link typo Needs review .
@daniel_j you can get push access to any issue by clicking the button next to the MR information, below the issue description.
Thanks for your contribution! Had to fix the update hook, but apart from that everything seems fine.
dieterholvoet → made their first commit to this issue’s fork.
I'm going to mark this as Won't fix since the module is now obsolete.
Thanks for your contribution! I'll mark the Drupal project as obsolete as well.
I added some more information to the change record, changed the lifecycle link to the change record and bumped the minimum Devel version.
dieterholvoet → made their first commit to this issue’s fork.
dieterholvoet → made their first commit to this issue’s fork.
I added the missing code mentioned in #175 to the MR and simplified it.
dieterholvoet → changed the visibility of the branch 9.3.x to hidden.
dieterholvoet → changed the visibility of the branch 2985168-edit-media-in-library to hidden.
Geometry objects do have a checkValidity() method, but this depends on having the GEOS PHP extension installed so we probably shouldn't rely on that.
The module already contains hardcoded validation to check for out of bounds values (@title: @component_title is out of bounds (@bounds)), so might as well move that validation to a constraint, no? I don't think full WKT validation is realistic, so might as well have validation for certain common use cases.
I fixed this in context of ✨ Add support for updating submissions Active , could you try out the latest dev release and see if it fixes your issue?
Maybe there is an issue also with the format of the min and max values. In formkit and html the time input format seems to be hh:mm while it's returned hh:mm:ss.
That shouldn't be an issue according to the MDN docs:
The value is always a 24-hour HH:mm or HH:mm:ss formatted time, with leading zeros, regardless of the UI's input format.
This seems to have been working for more than a month in one of our projects so I'm going to go ahead and merge this. Any bugs or improvements can go in new tickets.
This module still supports Drupal 9.2. The PHPUnit attributes were only added in PHPUnit 10, which has only been supported since Drupal 11.2.0. Won't this cause issues?
That's a possibility, or ideally we would add a change record summarizing what was said/decided in the issue.
It should also be the time in seconds the Drush command should spend working on this specific queue in one run, but this is not enforced in this module.
Just realised this is not true. That's what the time-limit option is for, the lease-time only determines how long queue items are held.
dieterholvoet → made their first commit to this issue’s fork.
dieterholvoet → created an issue.
Thanks!
I think so, but not sure. It's been a while.
Pipeline is passing now, but still some phpstan & cspell warnings.
dieterholvoet → made their first commit to this issue’s fork.
Moving to the Drupal.org project ownership issue queue.
Setting to Needs work because more changes might be necessary, don't have time to do a deep dive right now.
dieterholvoet → created an issue.
I already tried a couple times but the new contribution record system has been acting up. I tried again.
I'm going to use this patch in a project for a week or two and if all is good, I'll merge.
Changes to this contribution record don't seem to be saving for me, once I refresh the page everything is unchecked again. I am noticing a lot of console errors in the likes of Uncaught TypeError: $(...).once is not a function
Tests are finally passing again. Thanks for the work everyone!
Maybe filter by only entries that were created by Tagify? Not sure if it could hurt to delete everything.