I spent the bigger part of the day on ECK, merging issues, fixing the automated test suite and fixing all code style issues in the codebase. The only other issue I want to merge before creating a release is 📌 EckEntityRouteProvider does not use link templates Needs review , but that one needs a rebase. After that, I’m going to do a last round of manual testing and create a new release.
I don't really see the value of maintaining this kind of code. Just use Views, or create a custom list builder for your project.
ECK entities are just regular entities. You can create a view for them and attach VBO. ✨ Add support for Views and override options for list builder pages Needs review is about providing views automatically, but I don't see ECK adding VBO automatically to those views.
This has been fixed in 📌 Fix eslint/phpcs/phpstan issues Active , I'll credit you there.
dieterholvoet → created an issue.
Please don't post new patches, work is being done in the MR. My comments there haven't been addressed yet, so setting back to Needs work.
dieterholvoet → changed the visibility of the branch 2.x to hidden.
Closing this one since 8.x-1.* versions aren't supported anymore. Continuing the work in ✨ Add revision support Closed: duplicate . I credited the people who worked on this issue there.
Crediting the people who worked on ✨ Add revision support Needs review .
dieterholvoet → created an issue.
There doesn't seem to be a good reason to drop support for Drupal 9.4, so I'm adding that back.
dieterholvoet → changed the visibility of the branch 3430042-automated-drupal-11 to hidden.
Getting the following error in the test results:
Unable to install modules: module 'eck' is incompatible with this version of Drupal core.
I think I'll merge 📌 Automated Drupal 11 compatibility fixes for eck Needs review first and fix the rest of the tests afterwards.
Hi @avpaderno, any update here? Thanks!
Not sure if anything else needs to happen here.
I created a MR with the latest patch and the suggestions of @devdits.
watchdog messages are translatable, they must not contain dynamic parts or every unique message will be its own separate translatable string. This could also be a security issue.
Looks like it was decided in
🐛
LogEntry causes erroneous records in "locales_source" table
Needs review
to not translate log messages, so using FormattableMarkup should be enough.
New PDF generation happens options on the content type Edit page. Very minimal, but maybe the wording needs to be updated here?
I changed the title, but I don't agree with the proposed changes to the options. 'Automatic, when the node is saved' is not proper English.
I followed the same steps for a node with multiple translations and noticed that saving translations does not add the job to the queue.
I added a hook that triggers when creating a new translation. Are you sure updating a translation doesn't work yet? Because there's no such thing as a translation update hook, normal update hooks should be triggered when updating a translation.
There are still classes and methods made final in the MR. Same with self/static. PHPStan also reports a syntax error.
The pipeline is not passing yet.
We should probably make sure automated tests are passing before committing/releasing this one: 🐛 Fix tests Active
Thanks for offering, but your account is a bit too new for me to trust you with access to this widely used module. Also, I think there are enough maintainers right now. About the D11 compatible release: I'll work on that soon.
Looks mostly okay. Adding final to classes/methods is not necessary though, nor is returning self instead of static in create methods. This makes it so these classes/methods can't be extended anymore.
No, this needs more work. The different places instantiating plugins need to either pass the config themselves or use the new factory method. Then, the code in the plugin needs to be changed to use $this->configuration. All this only if you agree with my proposal here though. It’s not super important, just adding the factory method without passing config to the plugin would also help with simplifying certain code.
Yes, but this one also needs a little more testing IMO. Not working today, but I’ll try to do that tomorrow or Friday.
I’m still interested!
Any feedback is welcome!
I created a branch from ✨ Add option to automatically generate PDFs after saving nodes in a queue Active because there's too much overlap, so the changes from that MR are also in this one. We should merge that one first and then rebase this one. The current implementation seems to work for my use case, but it still needs some more testing.
I also added the page_to_pdf_domain submodule that provides the integration with the domain/domain_access modules. For now it only creates queue items, it doesn't work yet with the batch way of doing things.
dieterholvoet → created an issue.
dieterholvoet → created an issue.
dieterholvoet → created an issue.
dieterholvoet → created an issue.
@scott_euser what do you think? I'm probably going to start implementing this on Monday.
dieterholvoet → created an issue.
dieterholvoet → created an issue.
In order to not create a dependency on the content_moderation module, I had to copy from code over to this module.
dieterholvoet → created an issue.
dieterholvoet → made their first commit to this issue’s fork.
The strange thing is, that the error then occured at the same time on the production site, although I haven't changed anything there!
That confirms my suspicion that this is about something outside the Drupal database, like PHP caches for example.
dieterholvoet → made their first commit to this issue’s fork.
I created a MR based on 6.0.x.
dieterholvoet → made their first commit to this issue’s fork.
Maybe you could create a D11 compatible release now? 🐛 Facets searches don't update results Needs review and ✨ Allow views AJAX history to be updated by (facet) checkboxes Needs review can still be dealt with in a next release, right? Thanks for your work on the module either way!
My bad, updated the link.
I went for the union type, up to you if you want to remove the type.
I just checked https://www.drupal.org/project/webform_email_confirmation_link/maintaine... → and that also only lists @stefan.butura. Moving back.
I sent the same message to shrop, deekayen and bdone through their Contact tabs. ms2011 doesn't have their Contact tab enabled.
Are you sure a method parameter type change is not a BC break? It wouldn't be for callers, but it would be for implementers. Not sure how big of a problem that would be in practice though, probably not (m)any other implementations out there.
dieterholvoet → created an issue.
Sounds good! Did a small change to the documentation you added.
Alright then, creating a release.
dieterholvoet → changed the visibility of the branch 3422332-1.0.x to hidden.
dieterholvoet → changed the visibility of the branch 1.0.x to hidden.
@leymannx inactivity is not a reason to raise the priority of issues, especially not when it's about a feature request. Please stop doing this.
I changed it to an early continue to decrease nesting levels.
dieterholvoet → made their first commit to this issue’s fork.
I left a comment in the MR.
I started a MR, let me know if it fixes your issue.
That's weird, the plugin options are supposed to be arrays. I don't see how they could be an integer. I'll change the update hook to discard any non-array plugin options, since they don't carry any meaning anyway.
dieterholvoet → changed the visibility of the branch 2.0.x to hidden.
dieterholvoet → made their first commit to this issue’s fork.
I fixed the test. The failing tests are also failing on the dev branch.
i rebased 3283018-7.patch onto 8.x-3.x and started a MR.
dieterholvoet → made their first commit to this issue’s fork.
dieterholvoet → changed the visibility of the branch project-update-bot-only to hidden.
@dpi this has been committed a couple months ago, could you create a new release with this included?
dieterholvoet → created an issue.
Not sure if you have gitlab comments enabled (I think off by default) so just adding that I replied to your reply. Thanks!
I have them enabled, no need to notify me here. Thanks
The changes in the MR fix the issue for me.
Looks like this has been done already in ✨ Consider replacing qr-code-bundle dependency with the base (non-Symfony) library Fixed .