Brussels
Account created on 22 March 2018, about 7 years ago
  • Backend Developer at Minsky 
#

Merge Requests

More

Recent comments

🇧🇪Belgium dieterholvoet Brussels

This MR contains the changes from Add support for choosing the enabled invalidation types Active , so that one should be merged first.

🇧🇪Belgium dieterholvoet Brussels

I rebased against 2.0.x and I fixed another case I encountered when the domain could not be negotiated.

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet made their first commit to this issue’s fork.

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet created an issue.

🇧🇪Belgium dieterholvoet Brussels

This issue has been committed, but never released. Any chance you could create a last 8.x-1.x patch release?

🇧🇪Belgium dieterholvoet Brussels

Not sure if it's a good idea for core, but in the HTTP Cache Control module we added an Expert mode toggle to the Performance config form that toggles maxage inputs between selects with readable presets and number inputs.

🇧🇪Belgium dieterholvoet Brussels

This handler doesn't prevent submissions as far as I know. Are you sure the 'Disable saving of submissions' option is not enabled on your webform? Are submissions being saved when you remove the handler?

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet changed the visibility of the branch 1.0.x to hidden.

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet made their first commit to this issue’s fork.

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet made their first commit to this issue’s fork.

🇧🇪Belgium dieterholvoet Brussels

Dflydev\DotAccessData\Exception\InvalidPathException is not related to the Symfony Dotenv component, so there's no point in catching it. Also, these files do not look like the one that this module provides. I'm guessing there already was a load.environment.php present before you ran the command. You can find the file that this module provides here.

🇧🇪Belgium dieterholvoet Brussels

I tested this with a <h2> and you're right. Without the patch, the id attribute isn't in the filtered HTML and with the patch it is.

🇧🇪Belgium dieterholvoet Brussels

The test failure is about the CKEditor plugin, seems unrelated.

🇧🇪Belgium dieterholvoet Brussels

You're right, I missed that. Created a new issue to fix the namespace: 🐛 The class namespace of the new Search API processor is wrong Active .

🇧🇪Belgium dieterholvoet Brussels

I think you're misunderstanding the purpose of this module, it's not about XSS filtering or stripping HTML. To refer to the project description:

This module provides a Webform handler that allows submission data of certain form elements to not be stored in the database. The submission data can still be used in other handlers preceding the Sanitize submission handler.

🇧🇪Belgium dieterholvoet Brussels

I tested this in Drupal 11.1.6 and Redirect 1.11.0 and I can't reproduce this either.

🇧🇪Belgium dieterholvoet Brussels

This indirectly fixes an issue for me where pages get stuck in an infinite loop when using the flattened site settings loader.

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet made their first commit to this issue’s fork.

🇧🇪Belgium dieterholvoet Brussels

Yes, it looks like negotiating the active domain this early in the request (during the loading of config overrides) is not supported. I started a MR with an approach where the active domain is loaded on demand. Having our own static cache is unnecessary since the active domain is also just a property on the DomainNegotiator service, so there isn't any performance gain.

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet made their first commit to this issue’s fork.

🇧🇪Belgium dieterholvoet Brussels

I also added a custom translation handler to actually make publishing of translations work. The code is mostly based on Drupal\node\NodeTranslationHandler and Drupal\eck\EckTranslationHandler.

🇧🇪Belgium dieterholvoet Brussels

I don't think it's necessary to add a custom setting to control the visibility of the status field. That's what the form display UI is for. I'll change it so the field is hidden by default and can be displayed by moving it in the form display. I also changed the default value of the publishing status to TRUE.

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet changed the visibility of the branch 3090261-setinlineblockdependency-override-might to hidden.

🇧🇪Belgium dieterholvoet Brussels

I started a new MR on an issue branch instead of the main 8.x-2.x branch.

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet changed the visibility of the branch 8.x-2.x to hidden.

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet made their first commit to this issue’s fork.

Production build 0.71.5 2024