Brussels
Account created on 22 March 2018, over 7 years ago
  • Backend Developer at Minsky 
#

Merge Requests

More

Recent comments

🇧🇪Belgium dieterholvoet Brussels
🇧🇪Belgium dieterholvoet Brussels
🇧🇪Belgium dieterholvoet Brussels

dieterholvoet made their first commit to this issue’s fork.

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet made their first commit to this issue’s fork.

🇧🇪Belgium dieterholvoet Brussels

Thanks!

🇧🇪Belgium dieterholvoet Brussels

Good catch, thanks!

🇧🇪Belgium dieterholvoet Brussels

This has been causing issues in a lot of contrib and custom code, it would be nice to have this fixed. Linking some related contrib issues.

🇧🇪Belgium dieterholvoet Brussels

Looks good!

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet created an issue.

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet created an issue.

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet created an issue.

🇧🇪Belgium dieterholvoet Brussels

Could you test the MR from 🐛 RequiredApiRecursiveValidator discards violations triggered by regular constraints Active first? We have been discarding too many constraint violations and that issue aims to fix that, without handling Inline Entity Form specifically. If that were to fix your problem as well, that would be even better.

🇧🇪Belgium dieterholvoet Brussels

There's a button at the top of the page that should give you push rights, next to the MR information.

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet made their first commit to this issue’s fork.

🇧🇪Belgium dieterholvoet Brussels

Thanks for your contribution!

🇧🇪Belgium dieterholvoet Brussels

Thanks for your contributions! Seems like some more issues turned up in the pipeline though, so going to leave this open.

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet made their first commit to this issue’s fork.

🇧🇪Belgium dieterholvoet Brussels

I don't see why we should randomly drop support for core versions below 8.8. If you have a specific reason to do this, feel free to leave a comment.

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet made their first commit to this issue’s fork.

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet changed the visibility of the branch 8.x-2.x to hidden.

🇧🇪Belgium dieterholvoet Brussels

@defcon0 next time just add your changes to the existing MR. I just did, so I'm going to close your MR.

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet created an issue.

🇧🇪Belgium dieterholvoet Brussels

Thanks!

🇧🇪Belgium dieterholvoet Brussels

This is being fixed in 🐛 Fix lifecycle-link typo Needs review .

🇧🇪Belgium dieterholvoet Brussels

Thanks for your contribution!

🇧🇪Belgium dieterholvoet Brussels

@daniel_j you can get push access to any issue by clicking the button next to the MR information, below the issue description.

🇧🇪Belgium dieterholvoet Brussels

Thanks for your contribution! Had to fix the update hook, but apart from that everything seems fine.

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet made their first commit to this issue’s fork.

🇧🇪Belgium dieterholvoet Brussels

I'm going to mark this as Won't fix since the module is now obsolete.

🇧🇪Belgium dieterholvoet Brussels

Thanks for your contribution! I'll mark the Drupal project as obsolete as well.

🇧🇪Belgium dieterholvoet Brussels

I added some more information to the change record, changed the lifecycle link to the change record and bumped the minimum Devel version.

🇧🇪Belgium dieterholvoet Brussels

Thank you for your contribution!

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet made their first commit to this issue’s fork.

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet made their first commit to this issue’s fork.

🇧🇪Belgium dieterholvoet Brussels

I added the missing code mentioned in #175 to the MR and simplified it.

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet changed the visibility of the branch 9.3.x to hidden.

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet changed the visibility of the branch 2985168-edit-media-in-library to hidden.

🇧🇪Belgium dieterholvoet Brussels

Fixed in 📌 Update gitlab-ci.yml Active .

🇧🇪Belgium dieterholvoet Brussels

Geometry objects do have a checkValidity() method, but this depends on having the GEOS PHP extension installed so we probably shouldn't rely on that.

🇧🇪Belgium dieterholvoet Brussels

The module already contains hardcoded validation to check for out of bounds values (@title: @component_title is out of bounds (@bounds)), so might as well move that validation to a constraint, no? I don't think full WKT validation is realistic, so might as well have validation for certain common use cases.

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet created an issue.

🇧🇪Belgium dieterholvoet Brussels

I fixed this in context of Add support for updating submissions Active , could you try out the latest dev release and see if it fixes your issue?

Maybe there is an issue also with the format of the min and max values. In formkit and html the time input format seems to be hh:mm while it's returned hh:mm:ss.

That shouldn't be an issue according to the MDN docs:

The value is always a 24-hour HH:mm or HH:mm:ss formatted time, with leading zeros, regardless of the UI's input format.

🇧🇪Belgium dieterholvoet Brussels

This seems to have been working for more than a month in one of our projects so I'm going to go ahead and merge this. Any bugs or improvements can go in new tickets.

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet created an issue.

🇧🇪Belgium dieterholvoet Brussels

This module still supports Drupal 9.2. The PHPUnit attributes were only added in PHPUnit 10, which has only been supported since Drupal 11.2.0. Won't this cause issues?

🇧🇪Belgium dieterholvoet Brussels

That's a possibility, or ideally we would add a change record summarizing what was said/decided in the issue.

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet created an issue.

🇧🇪Belgium dieterholvoet Brussels

Left some comments in the MR.

🇧🇪Belgium dieterholvoet Brussels

It should also be the time in seconds the Drush command should spend working on this specific queue in one run, but this is not enforced in this module.

Just realised this is not true. That's what the time-limit option is for, the lease-time only determines how long queue items are held.

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet made their first commit to this issue’s fork.

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet created an issue.

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet created an issue.

🇧🇪Belgium dieterholvoet Brussels

I think so, but not sure. It's been a while.

🇧🇪Belgium dieterholvoet Brussels

Pipeline is passing now, but still some phpstan & cspell warnings.

🇧🇪Belgium dieterholvoet Brussels

dieterholvoet made their first commit to this issue’s fork.

🇧🇪Belgium dieterholvoet Brussels

Moving to the Drupal.org project ownership issue queue.

🇧🇪Belgium dieterholvoet Brussels

Setting to Needs work because more changes might be necessary, don't have time to do a deep dive right now.

🇧🇪Belgium dieterholvoet Brussels

I already tried a couple times but the new contribution record system has been acting up. I tried again.

🇧🇪Belgium dieterholvoet Brussels

I'm going to use this patch in a project for a week or two and if all is good, I'll merge.

🇧🇪Belgium dieterholvoet Brussels

Changes to this contribution record don't seem to be saving for me, once I refresh the page everything is unchecked again. I am noticing a lot of console errors in the likes of Uncaught TypeError: $(...).once is not a function

🇧🇪Belgium dieterholvoet Brussels

Tests are finally passing again. Thanks for the work everyone!

🇧🇪Belgium dieterholvoet Brussels

Maybe filter by only entries that were created by Tagify? Not sure if it could hurt to delete everything.

Production build 0.71.5 2024