Outbound path processors miss the route name

Created on 8 March 2021, over 4 years ago
Updated 7 February 2023, over 2 years ago

Problem/Motivation

If an outbound path processor is configured to peform some path alterations based on the route then the route name needs to be known. However we pass only the route, but not the corresponding route name.

Steps to reproduce

Next to the route pass also the route name.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

πŸ› Bug report
Status

Needs work

Version

10.1 ✨

Component
RoutingΒ  β†’

Last updated about 3 hours ago

Created by

πŸ‡©πŸ‡ͺGermany hchonov πŸ‡ͺπŸ‡ΊπŸ‡©πŸ‡ͺπŸ‡§πŸ‡¬

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request β†’ as a guide.

    This could use a test case to show the issue.

  • First commit to issue fork.
  • πŸ‡§πŸ‡ͺBelgium dieterholvoet Brussels

    This change could mean a big performance improvement in the Domain module: πŸ“Œ Domain Config loading is resource intensive Needs work .

    I started a MR with the changes from the patch. I also added route_parameters to the $options array, we need that to extract entity information from the URL.

  • Pipeline finished with Success
    7 months ago
    Total: 407s
    #422405
  • First commit to issue fork.
  • Pipeline finished with Failed
    16 days ago
    Total: 137s
    #571917
  • Pipeline finished with Success
    16 days ago
    Total: 882s
    #571935
  • Added test coverage for adding route_name and route_parameters to the $options array in UrlGenerator::generateFromRoute() . Moving to NR.

  • πŸ‡«πŸ‡·France mably

    This is a must have.

    We are using Url::fromUserInput in the DomainSourcePathProcessor of the Domain module and it causes a significant performance issue (besides some annoying loops).

Production build 0.71.5 2024