- Issue created by @dieterholvoet
- 🇧🇪Belgium dieterholvoet Brussels
The minimum Drupal version is bumped to 9.2 because of the usage of the usage of the new field widget hook → . I also added back the Image module dependency since it was incorrectly removed in 💬 Support Drupal 10 Fixed . Setting to Needs work for the upgrade path implementation.
- Merge request !12Resolve #3472997 "Rewrite module to use default field storage" → (Merged) created by dieterholvoet
- Status changed to Needs work
11 months ago 9:33am 9 September 2024 - 🇫🇷France bachbach Le Havre
It's reinventing the wheel, since Drupal has a whole field storage system built in that automatically deals with things like translations and revisions.
exactly what i though after hours trying to make caption in nested parragraph translation to work :(
then i found your issue and your patch work like a charm!had to :
pmu the module (obviously delete all the caption contents)
composer require dev version of module
apply your patch
enable the module againthanks for your work !
- Assigned to Foxy-vikvik
- 🇧🇪Belgium dieterholvoet Brussels
@foxy-vik why did you make the caption a plain text field instead of a formatted text field in #e2e9925? In the current version of the module it's also a formatted text field, so I don't see why you would change that.
- 🇺🇦Ukraine Foxy-vikvik
@dieterholvoet It was a mistake. I found an issue and changed it. This merge request is still a work in progress. So it will be formatted text. I will change it when I have time.
- First commit to issue fork.
- Issue was unassigned.
- Status changed to Needs review
3 months ago 5:50pm 1 June 2025 -
foxy-vikvik →
committed 32882392 on 4.0.x authored by
dieterholvoet →
Issue #3472997 by kksandr, foxy-vikvik, dieterholvoet: Rewrite to use...
-
foxy-vikvik →
committed 32882392 on 4.0.x authored by
dieterholvoet →
- 🇧🇪Belgium dieterholvoet Brussels
Maybe it could be an idea to not drop the old tables just yet, just in case there are still issues with the migration? The dropping of the tables could be added once a stable release of the module is made.
kksandr → changed the visibility of the branch 3472997-rewrite-module-to to hidden.
- Merge request !22Resolve #3472997 "Kept legacy tables until stable release" → (Merged) created by Unnamed author
-
foxy-vikvik →
committed 0eec0608 on 4.0.x authored by
kksandr →
Issue #3472997 by kksandr, foxy-vikvik, dieterholvoet: Kept legacy...
-
foxy-vikvik →
committed 0eec0608 on 4.0.x authored by
kksandr →
kksandr → changed the visibility of the branch 3472997-fixes to hidden.
- Merge request !23Resolve #3472997 "Make image field config safe to use" → (Merged) created by Unnamed author
kksandr → changed the visibility of the branch 3472997-fixes-2 to hidden.
- Merge request !24Resolve #3472997 "Fix schema cleanup on uninstallation" → (Merged) created by Unnamed author
kksandr → changed the visibility of the branch 3472997-fixes-3 to hidden.