Rewrite module to use default field storage

Created on 9 September 2024, 7 months ago

Problem/Motivation

The biggest part of the issues this module has are caused by its custom field storage implementation. This also adds a lot of unnecessary complexity to the module. It's reinventing the wheel, since Drupal has a whole field storage system built in that automatically deals with things like translations.

Proposed resolution

Rewrite the module to stop using the custom storage service. Instead, make the caption a standard field property whose storage is handled like any other field property in Drupal.

Remaining tasks

Provide an upgrade path.

πŸ“Œ Task
Status

Active

Version

2.0

Component

Code

Created by

πŸ‡§πŸ‡ͺBelgium dieterholvoet Brussels

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @dieterholvoet
  • πŸ‡§πŸ‡ͺBelgium dieterholvoet Brussels

    The minimum Drupal version is bumped to 9.2 because of the usage of the usage of the new field widget hook β†’ . I also added back the Image module dependency since it was incorrectly removed in πŸ’¬ Support Drupal 10 Fixed . Setting to Needs work for the upgrade path implementation.

  • Status changed to Needs work 7 months ago
  • Pipeline finished with Success
    7 months ago
    Total: 233s
    #277927
  • Pipeline finished with Success
    7 months ago
    Total: 136s
    #277942
  • πŸ‡«πŸ‡·France bachbach Le Havre

    It's reinventing the wheel, since Drupal has a whole field storage system built in that automatically deals with things like translations and revisions.

    exactly what i though after hours trying to make caption in nested parragraph translation to work :(
    then i found your issue and your patch work like a charm!

    had to :
    pmu the module (obviously delete all the caption contents)
    composer require dev version of module
    apply your patch
    enable the module again

    thanks for your work !

  • πŸ‡«πŸ‡·France bachbach Le Havre
  • Assigned to Foxy-vikvik
  • πŸ‡§πŸ‡ͺBelgium dieterholvoet Brussels

    @foxy-vik why did you make the caption a plain text field instead of a formatted text field in #e2e9925? In the current version of the module it's also a formatted text field, so I don't see why you would change that.

  • πŸ‡ΊπŸ‡¦Ukraine Foxy-vikvik

    @dieterholvoet It was a mistake. I found an issue and changed it. This merge request is still a work in progress. So it will be formatted text. I will change it when I have time.

  • First commit to issue fork.
  • Pipeline finished with Success
    about 2 months ago
    Total: 148s
    #426891
  • Pipeline finished with Success
    about 2 months ago
    Total: 204s
    #426897
  • Pipeline finished with Success
    about 2 months ago
    Total: 138s
    #426934
  • Pipeline finished with Failed
    about 2 months ago
    Total: 216s
    #426973
  • Pipeline finished with Success
    about 2 months ago
    Total: 196s
    #426987
  • Pipeline finished with Failed
    about 2 months ago
    Total: 175s
    #426996
  • Pipeline finished with Success
    about 2 months ago
    Total: 147s
    #426999
  • Pipeline finished with Success
    about 2 months ago
    Total: 203s
    #427276
  • Pipeline finished with Failed
    about 1 month ago
    Total: 267s
    #434077
  • Pipeline finished with Success
    about 1 month ago
    Total: 147s
    #434087
  • Pipeline finished with Failed
    about 1 month ago
    Total: 147s
    #434439
  • Pipeline finished with Success
    about 1 month ago
    Total: 144s
    #434443
  • Pipeline finished with Success
    about 1 month ago
    Total: 151s
    #434450
  • Pipeline finished with Success
    about 1 month ago
    Total: 145s
    #434554
Production build 0.71.5 2024